From nobody Thu May 7 21:42:07 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18B98C433EF for ; Wed, 18 May 2022 01:34:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233659AbiERBem (ORCPT ); Tue, 17 May 2022 21:34:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57430 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230153AbiERBei (ORCPT ); Tue, 17 May 2022 21:34:38 -0400 Received: from out30-44.freemail.mail.aliyun.com (out30-44.freemail.mail.aliyun.com [115.124.30.44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D545738BD7 for ; Tue, 17 May 2022 18:34:36 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R161e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04423;MF=xianting.tian@linux.alibaba.com;NM=1;PH=DS;RN=21;SR=0;TI=SMTPD_---0VDYa6oI_1652837670; Received: from localhost(mailfrom:xianting.tian@linux.alibaba.com fp:SMTPD_---0VDYa6oI_1652837670) by smtp.aliyun-inc.com(127.0.0.1); Wed, 18 May 2022 09:34:31 +0800 From: Xianting Tian To: mick@ics.forth.gr, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, anup@brainfault.org, akpm@linux-foundation.org, wangkefeng.wang@huawei.com, rppt@kernel.org, david@redhat.com, wangborong@cdjrlc.com, twd2.me@gmail.com, seanjc@google.com, alex@ghiti.fr, petr.pavlu@suse.com, atishp@rivosinc.com Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, jianghuaming.jhm@alibaba-inc.com, guoren@kernel.org, heiko@sntech.de, Xianting Tian Subject: [PATCH v3] RISC-V: Mark IORESOURCE_EXCLUSIVE for reserved mem instead of IORESOURCE_BUSY Date: Wed, 18 May 2022 09:34:28 +0800 Message-Id: <20220518013428.1338983-1-xianting.tian@linux.alibaba.com> X-Mailer: git-send-email 2.17.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Commit 00ab027a3b82 ("RISC-V: Add kernel image sections to the resource tre= e") marked IORESOURCE_BUSY for reserved memory, which caused resource map failed in subsequent operations of related driver, so remove the IORESOURCE_BUSY flag. In order to prohibit userland mapping reserved memory, mark IORESOURCE_EXCLUSIVE for it. The code to reproduce the issue, dts: mem0: memory@a0000000 { reg =3D <0x0 0xa0000000 0 0x1000000>; no-map; }; &test { status =3D "okay"; memory-region =3D <&mem0>; }; code: np =3D of_parse_phandle(pdev->dev.of_node, "memory-region", 0); ret =3D of_address_to_resource(np, 0, &r); base =3D devm_ioremap_resource(&pdev->dev, &r); // base =3D -EBUSY Fixes: 00ab027a3b82 ("RISC-V: Add kernel image sections to the resource tre= e") Reported-by: Huaming Jiang Reviewed-by: Guo Ren Reviewed-by: Heiko Stuebner Tested-by: Heiko Stuebner Co-developed-by: Nick Kossifidis Signed-off-by: Xianting Tian --- Changes from v2: - Fix typo in commit message: casued -> caused - Remove Reviewed-by of Nick Kossifidis, who didn't give Reviewed-by actual= ly - Add Co-developed-by of Nick Changes from v1: - Mark reserved memory as IORESOURCE_EXCLUSIVE, suggested by Nick --- arch/riscv/kernel/setup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/riscv/kernel/setup.c b/arch/riscv/kernel/setup.c index 834eb652a7b9..e0a00739bd13 100644 --- a/arch/riscv/kernel/setup.c +++ b/arch/riscv/kernel/setup.c @@ -189,7 +189,7 @@ static void __init init_resources(void) res =3D &mem_res[res_idx--]; =20 res->name =3D "Reserved"; - res->flags =3D IORESOURCE_MEM | IORESOURCE_BUSY; + res->flags =3D IORESOURCE_MEM | IORESOURCE_EXCLUSIVE; res->start =3D __pfn_to_phys(memblock_region_reserved_base_pfn(region)); res->end =3D __pfn_to_phys(memblock_region_reserved_end_pfn(region)) - 1; =20 @@ -214,7 +214,7 @@ static void __init init_resources(void) =20 if (unlikely(memblock_is_nomap(region))) { res->name =3D "Reserved"; - res->flags =3D IORESOURCE_MEM | IORESOURCE_BUSY; + res->flags =3D IORESOURCE_MEM | IORESOURCE_EXCLUSIVE; } else { res->name =3D "System RAM"; res->flags =3D IORESOURCE_SYSTEM_RAM | IORESOURCE_BUSY; --=20 2.17.1