From nobody Fri May 8 00:09:38 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22DFFC433F5 for ; Mon, 16 May 2022 16:29:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343676AbiEPQ3c (ORCPT ); Mon, 16 May 2022 12:29:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343633AbiEPQ3N (ORCPT ); Mon, 16 May 2022 12:29:13 -0400 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8DCA3B02A; Mon, 16 May 2022 09:29:10 -0700 (PDT) Received: by mail-ej1-x631.google.com with SMTP id gh6so29837292ejb.0; Mon, 16 May 2022 09:29:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hJB5QWTkjOe+A3TmBJQWslNfP6ImokdCskIDq0K0JSM=; b=DnhHqyh6nEcagUBSwSL40ZweMeOpDzDwVizgwFmVcHjJ/CbyNvQe/YL0Q/Sm4VGTef snsNOJJGUmDBwBZmNxTZi/yeO28knuXU3t/9CaHyTMjnNfnA+TzcqyFqKjxsB9Y/ucmF K10r77Qx0BDVHbx/Qbc2sjxngOV2307zrtQNiPA3dNgys+L3hEaytD7diKMlFZoqZ+gH mxnrwG53b5Owa7VQ1Inessh3sUouGHbZEOLGjWEZ+vUC/vH9cRhFpaz4XhdzC+B9FsMz 4u2kjGEkmvPsnNVLbrePD09DJ2kODMtCttp9GHbTS2BuFJ4fysxycGxi/1+iRChtNXib 6Hag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hJB5QWTkjOe+A3TmBJQWslNfP6ImokdCskIDq0K0JSM=; b=g73rm4OkFmigJcBMg+CQBshDx9L3baQs0xRR9/uMvtZRunVkA30E4db6+REqDaKFBD 0ZuHIVrIAYcM7Vaq6T5Q0fRxprm1JNom/fnkM/jARuwcOLsS72fzuz+hhARNwx5078tt WqXPB2UlT0EetFr/pl7vOJc767xc6vhHIXEigtkIbhRziic0hUhj3Jr/NdNHKEU5tVrP rbL1Vj5Wp2TqkLZCEZzRfSMhHts38OvEA6Y01SwWC6/5DNfevxq+1qe2LCz3+HS6essn mPn7+PNm+c51o6BjNmpkY3gQVR4/oJDcDrhbNgpSgNZTrUztEbRQRQlPlkJs/Wm7zj4W pbww== X-Gm-Message-State: AOAM532Ipbkj1N17Xyxtl2IpVOzRI61//l1+JwdDxmSuHETu4SnoK6m5 r/cgxTT8Qp1KoAmo8iT4SLM= X-Google-Smtp-Source: ABdhPJyZcntD5axDOHiDmfr5EqB4Uv2Nmp/U52P8mLja7/bBTGWg/cytwgQKXKtLEFZNZBC9ymNpMw== X-Received: by 2002:a17:907:3e8f:b0:6f4:4f42:a75f with SMTP id hs15-20020a1709073e8f00b006f44f42a75fmr16158090ejc.695.1652718549038; Mon, 16 May 2022 09:29:09 -0700 (PDT) Received: from linuxdev2.toradex.int (31-10-206-125.static.upc.ch. [31.10.206.125]) by smtp.gmail.com with ESMTPSA id 9-20020a170906004900b006f3ef214e3bsm58819ejg.161.2022.05.16.09.29.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 May 2022 09:29:08 -0700 (PDT) From: Max Krummenacher To: max.krummenacher@toradex.com Cc: Christoph Niedermaier , Laurent Pinchart , Marek Vasut , Francesco Dolcini , Maxime Ripard , Dave Stevenson , Daniel Vetter , David Airlie , Krzysztof Kozlowski , Rob Herring , Sam Ravnborg , Thierry Reding , devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 1/2] dt-bindings: display: add new bus-format property for panel-dpi Date: Mon, 16 May 2022 18:28:25 +0200 Message-Id: <20220516162826.23025-2-max.oss.09@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220516162826.23025-1-max.oss.09@gmail.com> References: <20220516162826.23025-1-max.oss.09@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Max Krummenacher The property is used to set the enum bus_format and infer the bpc for a panel defined by 'panel-dpi'. This specifies how the panel is connected to the display interface. Signed-off-by: Max Krummenacher --- .../bindings/display/panel/panel-dpi.yaml | 11 +++++++++ .../dt-bindings/display/dt-media-bus-format.h | 23 +++++++++++++++++++ 2 files changed, 34 insertions(+) create mode 100644 include/dt-bindings/display/dt-media-bus-format.h diff --git a/Documentation/devicetree/bindings/display/panel/panel-dpi.yaml= b/Documentation/devicetree/bindings/display/panel/panel-dpi.yaml index dae0676b5c6e..ca44e96c3001 100644 --- a/Documentation/devicetree/bindings/display/panel/panel-dpi.yaml +++ b/Documentation/devicetree/bindings/display/panel/panel-dpi.yaml @@ -21,6 +21,14 @@ properties: - {} - const: panel-dpi =20 + bus-format: + $ref: /schemas/types.yaml#/definitions/uint32 + description: | + Describes how the display panel is connected to the display interfac= e. + Valid values are defined in . + The mapping between the color/significance of the panel lines to the + parallel data lines are defined in [1]. + [1] https://www.kernel.org/doc/html/v5.17/userspace-api/media/v4l/su= bdev-formats.html#packed-rgb-formats backlight: true enable-gpios: true height-mm: true @@ -39,11 +47,14 @@ additionalProperties: false =20 examples: - | + #include + ... panel { compatible =3D "startek,startek-kd050c", "panel-dpi"; label =3D "osddisplay"; power-supply =3D <&vcc_supply>; backlight =3D <&backlight>; + bus-format =3D "DT_MEDIA_BUS_FMT_RGB888_1X24"; =20 port { lcd_in: endpoint { diff --git a/include/dt-bindings/display/dt-media-bus-format.h b/include/dt= -bindings/display/dt-media-bus-format.h new file mode 100644 index 000000000000..c0f2a7b59aa1 --- /dev/null +++ b/include/dt-bindings/display/dt-media-bus-format.h @@ -0,0 +1,23 @@ +/* SPDX-License-Identifier: GPL-2.0-only OR MIT */ +/* + * Copyright 2022 Max Krummenacher + */ + +#ifndef __DT_BINDINGS_DT_MEDIA_BUS_FORMAT_H +#define __DT_BINDINGS_DT_MEDIA_BUS_FORMAT_H + +/* + * Attention: Keep these macro names in sync with + * include/uapi/linux/media-bus-format.h + */ + +#define DT_MEDIA_BUS_FMT_RGB565_1X16 1 +#define DT_MEDIA_BUS_FMT_RGB666_1X18 2 +#define DT_MEDIA_BUS_FMT_RBG888_1X24 3 +#define DT_MEDIA_BUS_FMT_RGB666_1X24_CPADHI 4 +#define DT_MEDIA_BUS_FMT_BGR888_1X24 5 +#define DT_MEDIA_BUS_FMT_GBR888_1X24 6 +#define DT_MEDIA_BUS_FMT_RGB888_1X24 7 +#define DT_MEDIA_BUS_FMT_RGB888_1X32_PADHI 8 + +#endif /* __DT_BINDINGS_DT_MEDIA_BUS_FORMAT_H */ --=20 2.20.1 From nobody Fri May 8 00:09:38 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E446C433F5 for ; Mon, 16 May 2022 16:29:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343668AbiEPQ3U (ORCPT ); Mon, 16 May 2022 12:29:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343645AbiEPQ3M (ORCPT ); Mon, 16 May 2022 12:29:12 -0400 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D6A8B3A5FC for ; Mon, 16 May 2022 09:29:11 -0700 (PDT) Received: by mail-ej1-x636.google.com with SMTP id i19so29696204eja.11 for ; Mon, 16 May 2022 09:29:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Y5Y01zEzcSsKU36y1NINY4WVk0Q8FiEw0n1MhQ5vAp8=; b=MzyxhcHxfpe4omR3oQIY9vDe3Ma0gJNH+l6vr8yMxzIcE7WLpzv3gQNngtko+7CHYK wnP0JeSPU3TtjfSYW/enDtVoXotkr2zQaxjJ4/noQLVUmKYH/Evyj3q+VW9NG0M+7/sb ytL/7GBUy8dZKftxMPUtkUWexMF7cLI54DvLkj9ENKp2ajx9lcLrjW/wH4upreuq5cYF qM0rYYi40WxtyS/YxBSmjDaGd6XUd6zhO6FYmPFSzl9krsIP29DwGB1BnX/jGT0qMgxM 5L27yb+KWA/IP1ElTWNYxoAkEazXi+bOENadZ9R133tfM5XSvTKGWI9l0NBcNVKqxbtX 5PbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Y5Y01zEzcSsKU36y1NINY4WVk0Q8FiEw0n1MhQ5vAp8=; b=BSr8VPh9H+hUL2ogMjCNaWtoFO7axQZ/m0Htn1N3SkHAcHeyTkz7rOolPUdKsLKvxu uIlEelDpbgJVCrSVzw1nsP/ivWj2S5qY+PIZ+4r2NpxM/of3GU5HZMs0aX8cbb9j8p/F Ms3p8cNI59QuT+JJJg2+1FTBHTeKXWxoupXHIFRLpFJ2uy8mBDNBO5iDjSIdLh9gfZXq 6037t/xrg+YvDwqbkKYQ+9G6lfMtncq8o6ky/B+1TFSgjoA1qdeZ7WVaZKEJstrIdikz K06omywJmdKMQcyR/Kw01HqP35roLD2ByynHqIpAILTkUbaN5DxbtPzv7gat4TKgDoVi I9WQ== X-Gm-Message-State: AOAM53242PeW6kLmPRk9p9oyVUFqFqSw5VXWouZRWKk0deSxBVkZGXqd 8JLPLFN77efTSJum517tS/c= X-Google-Smtp-Source: ABdhPJxCd+3OM7rVUlCJ415U5mos+W3z/pfP53EArLwIpkBM+GZj9NipDl9K9kC3z669g20z47imFg== X-Received: by 2002:a17:906:730e:b0:6f4:e9e7:4f4 with SMTP id di14-20020a170906730e00b006f4e9e704f4mr15402269ejc.509.1652718550402; Mon, 16 May 2022 09:29:10 -0700 (PDT) Received: from linuxdev2.toradex.int (31-10-206-125.static.upc.ch. [31.10.206.125]) by smtp.gmail.com with ESMTPSA id 9-20020a170906004900b006f3ef214e3bsm58819ejg.161.2022.05.16.09.29.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 May 2022 09:29:10 -0700 (PDT) From: Max Krummenacher To: max.krummenacher@toradex.com Cc: Christoph Niedermaier , Laurent Pinchart , Marek Vasut , Francesco Dolcini , Maxime Ripard , Dave Stevenson , Daniel Vetter , David Airlie , Sam Ravnborg , Thierry Reding , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 2/2] drm/panel: simple: add bus-format support for panel-dpi Date: Mon, 16 May 2022 18:28:26 +0200 Message-Id: <20220516162826.23025-3-max.oss.09@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220516162826.23025-1-max.oss.09@gmail.com> References: <20220516162826.23025-1-max.oss.09@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Max Krummenacher Evaluate the device tree bus-format property to set bus_format for a 'panel-dpi' panel. Additionally infer the bpc value from the given bus-format. Valid values for bus-format are found in: This completes the addition of panel-dpi to completely specify a panel-simple panel from the device tree. Signed-off-by: Max Krummenacher --- drivers/gpu/drm/panel/panel-simple.c | 43 ++++++++++++++++++++++++++++ 1 file changed, 43 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/p= anel-simple.c index a34f4198a534..090c60abb014 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -21,6 +21,7 @@ * DEALINGS IN THE SOFTWARE. */ =20 +#include #include #include #include @@ -453,6 +454,7 @@ static int panel_dpi_probe(struct device *dev, struct panel_desc *desc; unsigned int bus_flags; struct videomode vm; + u32 bus_format; int ret; =20 np =3D dev->of_node; @@ -477,6 +479,47 @@ static int panel_dpi_probe(struct device *dev, of_property_read_u32(np, "width-mm", &desc->size.width); of_property_read_u32(np, "height-mm", &desc->size.height); =20 + if (!of_property_read_u32(np, "bus-format", &bus_format)) { + /* infer bpc from bus-format */ + switch (bus_format) { + case DT_MEDIA_BUS_FMT_RGB565_1X16: + desc->bus_format =3D MEDIA_BUS_FMT_RGB565_1X16; + desc->bpc =3D 6; + break; + case DT_MEDIA_BUS_FMT_RGB666_1X18: + desc->bus_format =3D MEDIA_BUS_FMT_RGB666_1X18; + desc->bpc =3D 6; + break; + case DT_MEDIA_BUS_FMT_RGB666_1X24_CPADHI: + desc->bus_format =3D MEDIA_BUS_FMT_RGB666_1X24_CPADHI; + desc->bpc =3D 6; + break; + case DT_MEDIA_BUS_FMT_BGR888_1X24: + desc->bus_format =3D MEDIA_BUS_FMT_BGR888_1X24; + desc->bpc =3D 8; + break; + case DT_MEDIA_BUS_FMT_GBR888_1X24: + desc->bus_format =3D MEDIA_BUS_FMT_GBR888_1X24; + desc->bpc =3D 8; + break; + case DT_MEDIA_BUS_FMT_RBG888_1X24: + desc->bus_format =3D MEDIA_BUS_FMT_RBG888_1X24; + desc->bpc =3D 8; + break; + case DT_MEDIA_BUS_FMT_RGB888_1X24: + desc->bus_format =3D MEDIA_BUS_FMT_RGB888_1X24; + desc->bpc =3D 8; + break; + case DT_MEDIA_BUS_FMT_RGB888_1X32_PADHI: + desc->bus_format =3D MEDIA_BUS_FMT_RGB888_1X32_PADHI; + desc->bpc =3D 8; + break; + default: + dev_err(dev, "%pOF: unknown bus-format property\n", np); + return -EINVAL; + } + } + /* Extract bus_flags from display_timing */ bus_flags =3D 0; vm.flags =3D timing->flags; --=20 2.20.1