From nobody Sun Jun 14 16:28:38 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19B22C433F5 for ; Mon, 16 May 2022 08:22:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231195AbiEPIV4 (ORCPT ); Mon, 16 May 2022 04:21:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34012 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241645AbiEPIVw (ORCPT ); Mon, 16 May 2022 04:21:52 -0400 Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [IPv6:2607:f8b0:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1BAFF3701D; Mon, 16 May 2022 01:21:47 -0700 (PDT) Received: by mail-pf1-x42c.google.com with SMTP id i24so13382554pfa.7; Mon, 16 May 2022 01:21:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=O0TiBO73BII/MzrCAHzOpYtsDk7KXOAsa2LtIBAC5Gk=; b=IfOuW2vin7vUKjzYAtKuWx2/rWr6p3AXqn3rBg76roBvgX+1zBMK29EOlS1E3qiHpb xL5CL9VfcV5nWVMkLXSd881MjeEUjC41OB8vb8j9G8dmgaCoUpmb6V63mMs4v20nH/W0 xP/Y3ue7XdZd5U6fmdg+sAUQlaEj5ihJY6wlmyBpdJz1kzCbRS61nJLJy6Q9STyAmoml 0k+0rQrrKGC2M03sjPtB8Dz5z/WMgsWZ9pXHk235nsONG7EH25HcMEWis5XNTceZykXL Y23vqOH+xmahcOcset+zy28sJXNygyNKhD5wSdXCkk3Sxgm+1oyIUoWE4lKnNl5ux1Vx kwpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=O0TiBO73BII/MzrCAHzOpYtsDk7KXOAsa2LtIBAC5Gk=; b=l4ueP27tJyKDrhDWaEKLHfTG2eju5P6pvGR1/COmAASlY4qBL4IOBwM4r+j6FbTD4Z wPu33e6mYg12w8hd+ym567Lcre8S9gX3xw+JuaPqHfPDNxL0GDPdAwIiGWljJt1DSg5K EoJ1d4Ncn2+2LVW650eqxYQcINO0CtfAa+Vz3TrmsfQ3PtjALU9YAJeWiTUGRxX79nr+ fOs/WZmEOLBNVDaGrKweIagL/rZTY6WI66Uwl4ve3tA6UzIOlhkpv6XTg0zvG6Gun/mr FCuEsFiKGPWurnsNjh1xYjnvspmFJRgNA+Sgq1E2IDiEoUDwQv3MXGxilYOs+depNJIu PzFg== X-Gm-Message-State: AOAM530ar1NYokS9o5+SJRVwTFveI1OOqYkVDD2oINsDCGUKc9tzTAMz x0JVpuAs5l6dWvpCtMLvIiQ= X-Google-Smtp-Source: ABdhPJwCdHCi69vYPF4Tu88drOWDnyUagdmB6DmuUma7AAp9Sjw9bPvMfiVYx7G0Sp02lxVPuq4FiA== X-Received: by 2002:a05:6a00:1d8f:b0:510:9430:8021 with SMTP id z15-20020a056a001d8f00b0051094308021mr16421305pfw.55.1652689306559; Mon, 16 May 2022 01:21:46 -0700 (PDT) Received: from localhost.localdomain ([193.203.214.57]) by smtp.gmail.com with ESMTPSA id m9-20020a17090a7f8900b001cd4989fee6sm7858711pjl.50.2022.05.16.01.21.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 May 2022 01:21:46 -0700 (PDT) From: cgel.zte@gmail.com X-Google-Original-From: chi.minghao@zte.com.cn To: jdmason@kudzu.us Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Minghao Chi , Zeal Robot Subject: [PATCH] net: vxge: Remove unnecessary synchronize_irq() before free_irq() Date: Mon, 16 May 2022 08:19:14 +0000 Message-Id: <20220516081914.1651281-1-chi.minghao@zte.com.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Minghao Chi Calling synchronize_irq() right before free_irq() is quite useless. On one hand the IRQ can easily fire again before free_irq() is entered, on the other hand free_irq() itself calls synchronize_irq() internally (in a race condition free way), before any state associated with the IRQ is freed. Reported-by: Zeal Robot Signed-off-by: Minghao Chi --- drivers/net/ethernet/neterion/vxge/vxge-main.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/neterion/vxge/vxge-main.c b/drivers/net/e= thernet/neterion/vxge/vxge-main.c index d2de8ac44f72..fa5d4ddf429b 100644 --- a/drivers/net/ethernet/neterion/vxge/vxge-main.c +++ b/drivers/net/ethernet/neterion/vxge/vxge-main.c @@ -2405,7 +2405,6 @@ static void vxge_rem_msix_isr(struct vxgedev *vdev) for (intr_cnt =3D 0; intr_cnt < (vdev->no_of_vpath * 2 + 1); intr_cnt++) { if (vdev->vxge_entries[intr_cnt].in_use) { - synchronize_irq(vdev->entries[intr_cnt].vector); free_irq(vdev->entries[intr_cnt].vector, vdev->vxge_entries[intr_cnt].arg); vdev->vxge_entries[intr_cnt].in_use =3D 0; @@ -2427,7 +2426,6 @@ static void vxge_rem_isr(struct vxgedev *vdev) vdev->config.intr_type =3D=3D MSI_X) { vxge_rem_msix_isr(vdev); } else if (vdev->config.intr_type =3D=3D INTA) { - synchronize_irq(vdev->pdev->irq); free_irq(vdev->pdev->irq, vdev); } } --=20 2.25.1