From nobody Mon Feb 9 23:42:59 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6A7FC433F5 for ; Sat, 14 May 2022 16:48:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234530AbiENQsV (ORCPT ); Sat, 14 May 2022 12:48:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234384AbiENQry (ORCPT ); Sat, 14 May 2022 12:47:54 -0400 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0BE1B3207E for ; Sat, 14 May 2022 09:47:53 -0700 (PDT) Received: from dslb-188-097-047-153.188.097.pools.vodafone-ip.de ([188.97.47.153] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1npuvm-0003kw-3Q; Sat, 14 May 2022 18:47:50 +0200 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 5/7] staging: r8188eu: use BIT(tid) instead of manual shift Date: Sat, 14 May 2022 18:47:38 +0200 Message-Id: <20220514164740.282552-6-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220514164740.282552-1-martin@kaiser.cx> References: <20220514164740.282552-1-martin@kaiser.cx> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Use BIT(tid) instead of 1 << tid when we process an addba response. Signed-off-by: Martin Kaiser --- drivers/staging/r8188eu/core/rtw_mlme_ext.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/= r8188eu/core/rtw_mlme_ext.c index d5ea074c62f4..9aa6d09b2e74 100644 --- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c +++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c @@ -1510,7 +1510,7 @@ unsigned int OnAction_back(struct adapter *padapter, = struct recv_frame *precv_fr tid =3D u16_get_bits(le16_to_cpu(mgmt->u.action.u.addba_resp.capab), IEEE80211_ADDBA_PARAM_TID_MASK); if (mgmt->u.action.u.addba_resp.status =3D=3D 0) { /* successful */ - psta->htpriv.agg_enable_bitmap |=3D 1 << tid; + psta->htpriv.agg_enable_bitmap |=3D BIT(tid); psta->htpriv.candidate_tid_bitmap &=3D ~BIT(tid); } else { psta->htpriv.agg_enable_bitmap &=3D ~BIT(tid); --=20 2.30.2