From nobody Fri May 8 02:20:41 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D876DC433F5 for ; Fri, 13 May 2022 02:58:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376591AbiEMC6F (ORCPT ); Thu, 12 May 2022 22:58:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49314 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376599AbiEMC6C (ORCPT ); Thu, 12 May 2022 22:58:02 -0400 Received: from mail.nfschina.com (unknown [IPv6:2400:dd01:100f:2:72e2:84ff:fe10:5f45]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5B7025C84F for ; Thu, 12 May 2022 19:58:01 -0700 (PDT) Received: from localhost (unknown [127.0.0.1]) by mail.nfschina.com (Postfix) with ESMTP id 6C2B51E80C82; Fri, 13 May 2022 10:52:20 +0800 (CST) X-Virus-Scanned: amavisd-new at test.com Received: from mail.nfschina.com ([127.0.0.1]) by localhost (mail.nfschina.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PaVTrAFpiRlA; Fri, 13 May 2022 10:52:17 +0800 (CST) Received: from localhost.localdomain.localdomain (unknown [219.141.250.2]) (Authenticated sender: xupengfei@nfschina.com) by mail.nfschina.com (Postfix) with ESMTPA id A27F71E80C80; Fri, 13 May 2022 10:52:17 +0800 (CST) From: XU pengfei To: akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kernel@nfschina.com, Xu Pengfei Subject: [PATCH] mm: Optimize the statement to make it clearer Date: Fri, 13 May 2022 10:57:54 +0800 Message-Id: <20220513025754.9230-1-xupengfei@nfschina.com> X-Mailer: git-send-email 2.18.2 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Xu Pengfei Optimize the statement to make it clearer Signed-off-by: Xu Pengfei --- mm/filemap.c | 4 ++-- mm/mmap.c | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/mm/filemap.c b/mm/filemap.c index 9a1eef6c5d35..f6b2b915052a 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -1374,9 +1374,9 @@ static inline int folio_wait_bit_common(struct folio = *folio, int bit_nr, * waiter, but an exclusive one requires WQ_FLAG_DONE. */ if (behavior =3D=3D EXCLUSIVE) - return wait->flags & WQ_FLAG_DONE ? 0 : -EINTR; + return (wait->flags & WQ_FLAG_DONE) ? 0 : -EINTR; =20 - return wait->flags & WQ_FLAG_WOKEN ? 0 : -EINTR; + return (wait->flags & WQ_FLAG_WOKEN) ? 0 : -EINTR; } =20 #ifdef CONFIG_MIGRATION diff --git a/mm/mmap.c b/mm/mmap.c index 3aa839f81e63..28196b93515a 100644 --- a/mm/mmap.c +++ b/mm/mmap.c @@ -2975,9 +2975,9 @@ SYSCALL_DEFINE5(remap_file_pages, unsigned long, star= t, unsigned long, size, goto out; } =20 - prot |=3D vma->vm_flags & VM_READ ? PROT_READ : 0; - prot |=3D vma->vm_flags & VM_WRITE ? PROT_WRITE : 0; - prot |=3D vma->vm_flags & VM_EXEC ? PROT_EXEC : 0; + prot |=3D (vma->vm_flags & VM_READ) ? PROT_READ : 0; + prot |=3D (vma->vm_flags & VM_WRITE) ? PROT_WRITE : 0; + prot |=3D (vma->vm_flags & VM_EXEC) ? PROT_EXEC : 0; =20 flags &=3D MAP_NONBLOCK; flags |=3D MAP_SHARED | MAP_FIXED | MAP_POPULATE; --=20 2.18.2