From nobody Fri May 8 03:08:37 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 372F7C433F5 for ; Thu, 12 May 2022 07:48:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351188AbiELHsW (ORCPT ); Thu, 12 May 2022 03:48:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351163AbiELHsN (ORCPT ); Thu, 12 May 2022 03:48:13 -0400 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB1574CD4D for ; Thu, 12 May 2022 00:48:11 -0700 (PDT) Received: from kwepemi500005.china.huawei.com (unknown [172.30.72.53]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4KzP4J1JsJz1JBsZ; Thu, 12 May 2022 15:46:56 +0800 (CST) Received: from kwepemm600005.china.huawei.com (7.193.23.191) by kwepemi500005.china.huawei.com (7.221.188.179) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 12 May 2022 15:48:09 +0800 Received: from ubuntu1804.huawei.com (10.67.175.30) by kwepemm600005.china.huawei.com (7.193.23.191) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 12 May 2022 15:48:08 +0800 From: Hui Tang To: CC: , , , , , , , , Subject: [PATCH -next v2 1/2] ASoC: max98396: Fix build error for implicit function declaration Date: Thu, 12 May 2022 15:46:39 +0800 Message-ID: <20220512074640.75550-2-tanghui20@huawei.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220512074640.75550-1-tanghui20@huawei.com> References: <20220512074640.75550-1-tanghui20@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.67.175.30] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemm600005.china.huawei.com (7.193.23.191) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org sound/soc/codecs/max98396.c: In function =E2=80=98max98396_i2c_probe=E2=80= =99: sound/soc/codecs/max98396.c:1555:25: error: implicit declaration of functio= n =E2=80=98devm_gpiod_get_optional=E2=80=99; did you mean =E2=80=98devm_reg= ulator_get_optional=E2=80=99? [-Werror=3Dimplicit-function-declaration] max98396->reset_gpio =3D devm_gpiod_get_optional(&i2c->dev, ^~~~~~~~~~~~~~~~~~~~~~~ devm_regulator_get_optional sound/soc/codecs/max98396.c:1556:23: error: =E2=80=98GPIOD_OUT_HIGH=E2=80= =99 undeclared (first use in this function); did you mean =E2=80=98GPIOF_IN= IT_HIGH=E2=80=99? "reset", GPIOD_OUT_HIGH); ^~~~~~~~~~~~~~ GPIOF_INIT_HIGH sound/soc/codecs/max98396.c:1556:23: note: each undeclared identifier is re= ported only once for each function it appears in sound/soc/codecs/max98396.c:1565:3: error: implicit declaration of function= =E2=80=98gpiod_set_value_cansleep=E2=80=99; did you mean =E2=80=98gpio_set= _value_cansleep=E2=80=99? [-Werror=3Dimplicit-function-declaration] gpiod_set_value_cansleep(max98396->reset_gpio, 0); ^~~~~~~~~~~~~~~~~~~~~~~~ gpio_set_value_cansleep cc1: all warnings being treated as errors Include header file Fixes: b58581136770 ("ASoC: max98396: add amplifier driver") Signed-off-by: Hui Tang --- Changes in v2: * Add missing header files instead of adding dependencies sound/soc/codecs/max98396.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs/max98396.c b/sound/soc/codecs/max98396.c index 745d7e761680..56eb62bb041f 100644 --- a/sound/soc/codecs/max98396.c +++ b/sound/soc/codecs/max98396.c @@ -1,6 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 // Copyright (c) 2022, Analog Devices Inc. =20 +#include #include #include #include --=20 2.17.1 From nobody Fri May 8 03:08:37 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF0BFC433F5 for ; Thu, 12 May 2022 07:48:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351178AbiELHsQ (ORCPT ); Thu, 12 May 2022 03:48:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350850AbiELHsN (ORCPT ); Thu, 12 May 2022 03:48:13 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB0FE49693 for ; Thu, 12 May 2022 00:48:11 -0700 (PDT) Received: from kwepemi500004.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4KzP2S427TzGpbC; Thu, 12 May 2022 15:45:20 +0800 (CST) Received: from kwepemm600005.china.huawei.com (7.193.23.191) by kwepemi500004.china.huawei.com (7.221.188.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 12 May 2022 15:48:09 +0800 Received: from ubuntu1804.huawei.com (10.67.175.30) by kwepemm600005.china.huawei.com (7.193.23.191) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 12 May 2022 15:48:09 +0800 From: Hui Tang To: CC: , , , , , , , , Subject: [PATCH -next v2 2/2] ASoC: tlv320adc3xxx: Fix build error for implicit function declaration Date: Thu, 12 May 2022 15:46:40 +0800 Message-ID: <20220512074640.75550-3-tanghui20@huawei.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220512074640.75550-1-tanghui20@huawei.com> References: <20220512074640.75550-1-tanghui20@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.67.175.30] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemm600005.china.huawei.com (7.193.23.191) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org sound/soc/codecs/tlv320adc3xxx.c: In function =E2=80=98adc3xxx_i2c_probe=E2= =80=99: sound/soc/codecs/tlv320adc3xxx.c:1359:21: error: implicit declaration of fu= nction =E2=80=98devm_gpiod_get=E2=80=99; did you mean =E2=80=98devm_gpio_fr= ee=E2=80=99? [-Werror=3Dimplicit-function-declaration] adc3xxx->rst_pin =3D devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW); ^~~~~~~~~~~~~~ devm_gpio_free CC [M] drivers/gpu/drm/nouveau/nvkm/engine/disp/sorgt215.o LD [M] sound/soc/codecs/snd-soc-ak4671.o LD [M] sound/soc/codecs/snd-soc-arizona.o LD [M] sound/soc/codecs/snd-soc-cros-ec-codec.o LD [M] sound/soc/codecs/snd-soc-ak4641.o LD [M] sound/soc/codecs/snd-soc-alc5632.o sound/soc/codecs/tlv320adc3xxx.c:1359:50: error: =E2=80=98GPIOD_OUT_LOW=E2= =80=99 undeclared (first use in this function); did you mean =E2=80=98GPIOF= _INIT_LOW=E2=80=99? adc3xxx->rst_pin =3D devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW); ^~~~~~~~~~~~~ GPIOF_INIT_LOW sound/soc/codecs/tlv320adc3xxx.c:1359:50: note: each undeclared identifier = is reported only once for each function it appears in LD [M] sound/soc/codecs/snd-soc-cs35l32.o sound/soc/codecs/tlv320adc3xxx.c:1408:2: error: implicit declaration of fun= ction =E2=80=98gpiod_set_value_cansleep=E2=80=99; did you mean =E2=80=98gpi= o_set_value_cansleep=E2=80=99? [-Werror=3Dimplicit-function-declaration] gpiod_set_value_cansleep(adc3xxx->rst_pin, 1); ^~~~~~~~~~~~~~~~~~~~~~~~ gpio_set_value_cansleep LD [M] sound/soc/codecs/snd-soc-cs35l41-lib.o LD [M] sound/soc/codecs/snd-soc-cs35l36.o LD [M] sound/soc/codecs/snd-soc-cs35l34.o LD [M] sound/soc/codecs/snd-soc-cs35l41.o CC [M] drivers/gpu/drm/nouveau/nvkm/engine/disp/sormcp89.o cc1: all warnings being treated as errors Fixes: e9a3b57efd28 ("ASoC: codec: tlv320adc3xxx: New codec driver") Signed-off-by: Hui Tang --- Changes in v2: * Add missing header files instead of adding dependencies * Calling 'gpiochip_remove' depends on 'CONFIG_GPIOLIB' enabled sound/soc/codecs/tlv320adc3xxx.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/codecs/tlv320adc3xxx.c b/sound/soc/codecs/tlv320adc3= xxx.c index a5e9f80cfa32..80b8115e6053 100644 --- a/sound/soc/codecs/tlv320adc3xxx.c +++ b/sound/soc/codecs/tlv320adc3xxx.c @@ -14,6 +14,7 @@ =20 #include #include +#include #include #include #include @@ -1025,7 +1026,9 @@ static const struct gpio_chip adc3xxx_gpio_chip =3D { =20 static void adc3xxx_free_gpio(struct adc3xxx *adc3xxx) { +#ifdef CONFIG_GPIOLIB gpiochip_remove(&adc3xxx->gpio_chip); +#endif } =20 static void adc3xxx_init_gpio(struct adc3xxx *adc3xxx) --=20 2.17.1