From nobody Fri May 15 10:52:28 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70E12C433EF for ; Thu, 12 May 2022 01:39:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233152AbiELBjh (ORCPT ); Wed, 11 May 2022 21:39:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232208AbiELBj1 (ORCPT ); Wed, 11 May 2022 21:39:27 -0400 Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA1661BD730 for ; Wed, 11 May 2022 18:39:24 -0700 (PDT) Received: by mail-pj1-x102a.google.com with SMTP id gj17-20020a17090b109100b001d8b390f77bso6474951pjb.1 for ; Wed, 11 May 2022 18:39:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7JY5OzjYLJW7Rr2xhfmPsDoAWZorsrA3jl8llvrg60E=; b=CkbH1Acr8lJ87fJOrQbgEx6SXYUoJXQllKefeIvEIVc9ckF4mlXxwIg7sw5ZIFZlSe KPJjJIAqpwQbuH7l4JyD2iVzLh5bvZm9hjLt26yPw3vUAfgk2aLAZbY8wpy01RPQ/lEc F8tgykp8v+d9SqCWc7+78bNTntl3w3Fp5AdDE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7JY5OzjYLJW7Rr2xhfmPsDoAWZorsrA3jl8llvrg60E=; b=RT0KwGzCXmZBX7/zbid4ThS6BoYfMRT2ywBmf3bVFnnxL7QeCandL3PfiOeWEwI8ju D10MOCsInIIV7vln13g+x1kCpZ2PmFzHj3yi71nu6vF8rMfvmIcv+62D2VWmAitIr9cN vOWMDwyv1KcI79Q71l15eCY6qoHNgmHXmkUp86BpTMfqOJkrzCVRWGL6tjZbPvBVUrp9 40c+/EQ18yChTyRyEILGpkX5TYeZ7Pn+2yx5fQlK+mIiFjP7/7A/eAUwqcPYxvi0HYn0 8VrWQXP8V6vqSGplxznxemGESijXJ8dgC61pe84Iraqz4bjP7ZExIvY7rVtu7N3ct30b PSlA== X-Gm-Message-State: AOAM530vX4VNIP/Ug9g/FoYKDiEfaScr9euK/ZbVRDXMXLx/K0ej8BPK jORpgkTpXjiC88ygCDwn4NKopQ== X-Google-Smtp-Source: ABdhPJyMdRve7kEm91mSg9IVhIAWNGEF5IkkT0N0gEDCWsFRkKDNGC0YEfyDiZM6EpOoVX3qLxOpTA== X-Received: by 2002:a17:902:f68a:b0:15e:b12d:f4a1 with SMTP id l10-20020a170902f68a00b0015eb12df4a1mr27586276plg.166.1652319564440; Wed, 11 May 2022 18:39:24 -0700 (PDT) Received: from smtp.gmail.com ([2620:15c:202:201:193f:f17a:ab0d:1f83]) by smtp.gmail.com with ESMTPSA id b7-20020a170902d50700b0015e8d4eb2cfsm2614766plg.281.2022.05.11.18.39.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 May 2022 18:39:24 -0700 (PDT) From: Stephen Boyd To: Rob Herring Cc: linux-kernel@vger.kernel.org, patches@lists.linux.dev, devicetree@vger.kernel.org, Krzysztof Kozlowski , chrome-platform@lists.linux.dev, Guenter Roeck , Douglas Anderson , Craig Hesling , Tom Hughes , Alexandru M Stan , Tzung-Bi Shih , Matthias Kaehlcke , Benson Leung , Lee Jones Subject: [PATCH v5 1/3] dt-bindings: cros-ec: Fix a typo in description Date: Wed, 11 May 2022 18:39:19 -0700 Message-Id: <20220512013921.164637-2-swboyd@chromium.org> X-Mailer: git-send-email 2.36.0.512.ge40c2bad7a-goog In-Reply-To: <20220512013921.164637-1-swboyd@chromium.org> References: <20220512013921.164637-1-swboyd@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" A 's/pf/of/' on rpmsg-name description. Cc: Rob Herring Cc: Krzysztof Kozlowski Cc: Cc: Cc: Guenter Roeck Cc: Douglas Anderson Cc: Craig Hesling Cc: Tom Hughes Cc: Alexandru M Stan Cc: Tzung-Bi Shih Cc: Matthias Kaehlcke Cc: Benson Leung Cc: Lee Jones Signed-off-by: Stephen Boyd Acked-by: Rob Herring Reviewed-by: Guenter Roeck --- Documentation/devicetree/bindings/mfd/google,cros-ec.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml b/Do= cumentation/devicetree/bindings/mfd/google,cros-ec.yaml index d1f53bd449f7..99eda9ab0651 100644 --- a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml +++ b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml @@ -61,7 +61,7 @@ properties: mediatek,rpmsg-name: description: Must be defined if the cros-ec is a rpmsg device for a Mediatek - ARM Cortex M4 Co-processor. Contains the name pf the rpmsg + ARM Cortex M4 Co-processor. Contains the name of the rpmsg device. Used to match the subnode to the rpmsg device announced by the SCP. $ref: "/schemas/types.yaml#/definitions/string" --=20 https://chromeos.dev From nobody Fri May 15 10:52:28 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94C92C433F5 for ; Thu, 12 May 2022 01:39:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233151AbiELBjs (ORCPT ); Wed, 11 May 2022 21:39:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232428AbiELBj2 (ORCPT ); Wed, 11 May 2022 21:39:28 -0400 Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA5A11BDDAB for ; Wed, 11 May 2022 18:39:25 -0700 (PDT) Received: by mail-pg1-x530.google.com with SMTP id h186so634542pgc.3 for ; Wed, 11 May 2022 18:39:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8zSnMogrcWQWE/BuKkywg38wliZCVpEBThDjWjcPWOM=; b=VtUFbwwa5/ZVmUeo8CaGLWIcDdTY2xAxytCChncda0yPaC9e9mDt8yzSz+ehaOeQK0 hZGEVS9QRMY37sc00EMUzg6XHVfhP0S2QEqTzPV+KsmF/JV2YzXbNGjDORZDxsh/Qe+L Ja/impLhIi9fXS/4Lw9wrdFzuygfqeL/GFJ3A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8zSnMogrcWQWE/BuKkywg38wliZCVpEBThDjWjcPWOM=; b=fNSKHhv7uaESM0mHjOKdw4WnyfdRONE6+56rI+CNAsQ1Bqbmj8xV9tmVWKXTWfmA4G AA0nGHQcUQnxOx+3PGAlB2oDhVILRnZ6hTpINOBh/jFJBEq9WUAdNGdhBRACHGaFG02v wRX5s6Ntg7e7GKzTBV9sACaBCKFxEjl1vmvc/I3aeiEU+fDHynbnWqx7yqwEdHDhmtCd VGQO12fhRZY51UeCjn6o9aSGpqKTXnNIM4wJyBrAaJ+oN4d0Ah2bP8F6kbbncUwcIDgT oyOjZyjzJm3aby+I80OQj1xcq9Zxjs/+TXm7rKFP3su1gvlyhbgbyaonAoxf5WxCv5/n vvDQ== X-Gm-Message-State: AOAM5337RnvDqmp3Wm/21nXF87NPUMBxx7KUMLMRS8drj9U98p5LYnY6 lHtpE2wsbNypz8Y2YjPoBESFtw== X-Google-Smtp-Source: ABdhPJxtiZh2m0y02v4j2QxOoyQY+ZdeZXDWZV/CYYwyTocpEeBMbULAKws0Jzek6ic03DqmxVxQjQ== X-Received: by 2002:a65:4807:0:b0:3aa:3050:e24 with SMTP id h7-20020a654807000000b003aa30500e24mr23119709pgs.299.1652319565441; Wed, 11 May 2022 18:39:25 -0700 (PDT) Received: from smtp.gmail.com ([2620:15c:202:201:193f:f17a:ab0d:1f83]) by smtp.gmail.com with ESMTPSA id b7-20020a170902d50700b0015e8d4eb2cfsm2614766plg.281.2022.05.11.18.39.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 May 2022 18:39:25 -0700 (PDT) From: Stephen Boyd To: Rob Herring Cc: linux-kernel@vger.kernel.org, patches@lists.linux.dev, devicetree@vger.kernel.org, Krzysztof Kozlowski , chrome-platform@lists.linux.dev, Guenter Roeck , Douglas Anderson , Craig Hesling , Tom Hughes , Alexandru M Stan , Tzung-Bi Shih , Matthias Kaehlcke , Benson Leung , Lee Jones Subject: [PATCH v5 2/3] dt-bindings: cros-ec: Reorganize property availability Date: Wed, 11 May 2022 18:39:20 -0700 Message-Id: <20220512013921.164637-3-swboyd@chromium.org> X-Mailer: git-send-email 2.36.0.512.ge40c2bad7a-goog In-Reply-To: <20220512013921.164637-1-swboyd@chromium.org> References: <20220512013921.164637-1-swboyd@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Various properties in the cros-ec binding only apply to different compatible strings. For example, the interrupts and reg property are required for all cros-ec devices except for the rpmsg version. Add some conditions to update the availability of properties so that they can't be used with compatibles that don't support them. Cc: Rob Herring Cc: Krzysztof Kozlowski Cc: Cc: Cc: Guenter Roeck Cc: Douglas Anderson Cc: Craig Hesling Cc: Tom Hughes Cc: Alexandru M Stan Cc: Tzung-Bi Shih Cc: Matthias Kaehlcke Cc: Benson Leung Cc: Lee Jones Signed-off-by: Stephen Boyd Acked-by: Rob Herring Reviewed-by: Douglas Anderson --- .../bindings/mfd/google,cros-ec.yaml | 39 +++++++++++++------ 1 file changed, 27 insertions(+), 12 deletions(-) diff --git a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml b/Do= cumentation/devicetree/bindings/mfd/google,cros-ec.yaml index 99eda9ab0651..409ecef967ce 100644 --- a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml +++ b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml @@ -148,18 +148,33 @@ patternProperties: required: - compatible =20 -if: - properties: - compatible: - contains: - enum: - - google,cros-ec-i2c - - google,cros-ec-rpmsg -then: - properties: - google,cros-ec-spi-pre-delay: false - google,cros-ec-spi-msg-delay: false - spi-max-frequency: false +allOf: + - if: + properties: + compatible: + not: + contains: + const: google,cros-ec-spi + then: + properties: + controller-data: false + google,cros-ec-spi-pre-delay: false + google,cros-ec-spi-msg-delay: false + spi-max-frequency: false + + - if: + properties: + compatible: + not: + contains: + const: google,cros-ec-rpmsg + then: + properties: + mediatek,rpmsg-name: false + + required: + - reg + - interrupts =20 additionalProperties: false =20 --=20 https://chromeos.dev From nobody Fri May 15 10:52:28 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AC51C433EF for ; Thu, 12 May 2022 01:39:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233741AbiELBjo (ORCPT ); Wed, 11 May 2022 21:39:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232550AbiELBjb (ORCPT ); Wed, 11 May 2022 21:39:31 -0400 Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0BA31BE117 for ; Wed, 11 May 2022 18:39:26 -0700 (PDT) Received: by mail-pl1-x62a.google.com with SMTP id i17so3487176pla.10 for ; Wed, 11 May 2022 18:39:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=OKsiMTO05pP2YFIGQs4jSS3mDepImUu3DLLTqj1JC+E=; b=YsayhIWOka75EoI2fzwHCCftn/Bb9jwmP/Rkx1xwXG9vjaIK2W0w0dUR3AAOr6r2Oe XonHI7AKz/OGZFdSX/xhBM/WsB3QQR9homjoWpklpdW2aQ3t2N0JI7Qm44zoJcYE3r0d TLEHZusT57YAmYqkJuMTvRpsLVn6DR2UuXZlg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=OKsiMTO05pP2YFIGQs4jSS3mDepImUu3DLLTqj1JC+E=; b=1Ui0OSkRbN+tep4dDPwWu6+9xz+T9w08mgyqWmgCRFBnknrCbAh6WqcgVlXwzpI5oU Yh+QhcaL+vgE2+86/flKEMtr3rxP7cVSmMLhXYke7vseA8ickErnM7+VJCV2KLBVEgQW qg1nmxtcVLr4CwXcuUWyoOdp+aBlAGq9kvoiW7SmsJFAFrOac0+/1j4HqeiP80mJgc1q IU+hXnOyMhPnY1qs5UI9L7A+Cy0QhmdqOS4Bl/+FLnYE1wPoaOfpWJqCmeh+M5+j5r2r oI9kYrcqfpmwssFN3vtiWIvbNQoktCBpyd9ZxOdHB38xg1D8D7SeJkUr5RjWcuMwrB/H UkTw== X-Gm-Message-State: AOAM533hq8YMxktlbXLewLqsX2FPRmPL/BJXacyqwBynyHQ86lOjtZbV CWPXEkNs6WHuwRcRq9HPURotVA== X-Google-Smtp-Source: ABdhPJz5juvszW0WlRxr8OLPLsBo/MwprcIaMIxuhi+YYdwUVFMtA53XzJ8ap+j44qKXzkn75exLhQ== X-Received: by 2002:a17:902:e94e:b0:158:91e6:501 with SMTP id b14-20020a170902e94e00b0015891e60501mr28053817pll.29.1652319566414; Wed, 11 May 2022 18:39:26 -0700 (PDT) Received: from smtp.gmail.com ([2620:15c:202:201:193f:f17a:ab0d:1f83]) by smtp.gmail.com with ESMTPSA id b7-20020a170902d50700b0015e8d4eb2cfsm2614766plg.281.2022.05.11.18.39.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 May 2022 18:39:26 -0700 (PDT) From: Stephen Boyd To: Rob Herring Cc: linux-kernel@vger.kernel.org, patches@lists.linux.dev, devicetree@vger.kernel.org, Krzysztof Kozlowski , chrome-platform@lists.linux.dev, Guenter Roeck , Douglas Anderson , Craig Hesling , Tom Hughes , Alexandru M Stan , Tzung-Bi Shih , Matthias Kaehlcke , Benson Leung , Lee Jones Subject: [PATCH v5 3/3] dt-bindings: cros-ec: Add ChromeOS fingerprint binding Date: Wed, 11 May 2022 18:39:21 -0700 Message-Id: <20220512013921.164637-4-swboyd@chromium.org> X-Mailer: git-send-email 2.36.0.512.ge40c2bad7a-goog In-Reply-To: <20220512013921.164637-1-swboyd@chromium.org> References: <20220512013921.164637-1-swboyd@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add a binding to describe the fingerprint processor found on Chromebooks with a fingerprint sensor. Previously we've been describing this with the google,cros-ec-spi binding but it lacks gpio and regulator control used during firmware flashing. Cc: Rob Herring Cc: Krzysztof Kozlowski Cc: Cc: Cc: Guenter Roeck Cc: Douglas Anderson Cc: Craig Hesling Cc: Tom Hughes Cc: Alexandru M Stan Cc: Tzung-Bi Shih Cc: Matthias Kaehlcke Cc: Benson Leung Cc: Lee Jones Signed-off-by: Stephen Boyd Reviewed-by: Douglas Anderson --- .../bindings/mfd/google,cros-ec.yaml | 80 ++++++++++++++++--- 1 file changed, 71 insertions(+), 9 deletions(-) diff --git a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml b/Do= cumentation/devicetree/bindings/mfd/google,cros-ec.yaml index 409ecef967ce..e5fe60beb9fe 100644 --- a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml +++ b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml @@ -19,15 +19,19 @@ description: properties: compatible: oneOf: - - description: - For implementations of the EC is connected through I2C. - const: google,cros-ec-i2c - - description: - For implementations of the EC is connected through SPI. - const: google,cros-ec-spi - - description: - For implementations of the EC is connected through RPMSG. - const: google,cros-ec-rpmsg + # For implementations of the EC is connected through I2C. + - items: + - const: google,cros-ec-i2c + # For implementations of the FPMCU connected through SPI. + - items: + - const: google,cros-ec-fp + - const: google,cros-ec-spi + # For implementations of the EC is connected through SPI. + - items: + - const: google,cros-ec-spi + # For implementations of the EC is connected through RPMSG. + - items: + - const: google,cros-ec-rpmsg =20 controller-data: description: @@ -132,6 +136,15 @@ properties: =20 additionalProperties: false =20 + reset-gpios: + maxItems: 1 + + boot0-gpios: + maxItems: 1 + description: Assert for bootloader mode. + + vdd-supply: true + patternProperties: "^i2c-tunnel[0-9]*$": type: object @@ -176,6 +189,37 @@ allOf: - reg - interrupts =20 + - if: + properties: + compatible: + contains: + const: google,cros-ec-fp + then: + properties: + '#address-cells': false + '#size-cells': false + typec: false + ec-pwm: false + keyboard-controller: false + proximity: false + codecs: false + cbas: false + + patternProperties: + "^i2c-tunnel[0-9]*$": false + "^regulator@[0-9]+$": false + "^extcon[0-9]*$": false + + required: + - reset-gpios + - boot0-gpios + - vdd-supply + else: + properties: + reset-gpios: false + boot0-gpios: false + vdd-supply: false + additionalProperties: false =20 examples: @@ -231,4 +275,22 @@ examples: compatible =3D "google,cros-ec-rpmsg"; }; }; + + - | + #include + #include + spi { + #address-cells =3D <0x1>; + #size-cells =3D <0x0>; + ec@0 { + compatible =3D "google,cros-ec-fp", "google,cros-ec-spi"; + reg =3D <0>; + interrupt-parent =3D <&gpio_controller>; + interrupts =3D <4 IRQ_TYPE_LEVEL_LOW>; + spi-max-frequency =3D <3000000>; + reset-gpios =3D <&gpio_controller 5 GPIO_ACTIVE_LOW>; + boot0-gpios =3D <&gpio_controller 10 GPIO_ACTIVE_HIGH>; + vdd-supply =3D <&pp3300_fp_mcu>; + }; + }; ... --=20 https://chromeos.dev