From nobody Sun May 10 09:55:06 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C138BC433EF for ; Wed, 11 May 2022 21:17:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348148AbiEKVRR (ORCPT ); Wed, 11 May 2022 17:17:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244555AbiEKVQh (ORCPT ); Wed, 11 May 2022 17:16:37 -0400 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A0251FA4F for ; Wed, 11 May 2022 14:16:33 -0700 (PDT) Received: by mail-yb1-xb49.google.com with SMTP id o64-20020a257343000000b006483069a28aso3001549ybc.3 for ; Wed, 11 May 2022 14:16:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:message-id:mime-version:subject:from:to:cc; bh=RmwhTmtOKEfJCDjFlaEgB2jMmIYPJxSkJAhFJBeKz2I=; b=XkKSkM+v9S3PTc6l4ZTy49ewMfC2s4c5zMAg5UodUAo9tE3JjZGsHLiJZuutanSW/t 0PB1vzo+tXSImfHZPiGGWNQoWj/OsCpusTgXi9w15rSHH3t3+S2DZesoDXU52lamaqTv 6XL0EHRaDO6Ni1QV7CFRJ+DGgn9Mt2C7M4tGXW4u+r1NfQh+8CAeQMDlf18PXGERMkAG Ww/NLII6pTmYG3t6DW3HAaTr3EUgtVWawVHmCI8bfIFXwAU3LqjPLfhojmZ6OE6lLxLQ 9telHSSUmU10mBg86HgEinjHRAqd7vyCOxBDQ7uitqe351eEz46zqPyUVZ3DnD+jBMu3 hyGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=RmwhTmtOKEfJCDjFlaEgB2jMmIYPJxSkJAhFJBeKz2I=; b=1ByWmMJcQVuIwWO3Afj+S7KmsR5HX436AaaKglj4kmx39ElW4gEysycUipJpHHm4BL 4wPV4OdKmr3Nuy8PEJEb3I/9O7bd5cnjVUqukRFYvvlHxvX9A1ZsueULeChV9Hc2cNrF 3rtM8ob9uLBPJ8bRCcBL4azSvyUtZXzIO2147TWapyO1TlYIyX5UCbdYtArdUg7lyCQR FBSP3y3cArs5l19KrD83ERTNPJT5s/997DieqX6ASN2GGb6dOEu+LZ5rItaX5ZLfuLHS Ss9ELI8E9LT/RG3bgTll2ooGCtxACwHmFVTzwM8WOEPI6KtBFUg/pTq8AsiStlCjYtHp jTcw== X-Gm-Message-State: AOAM530yy0y9YYKAB2/sF2O2GwvSgN1BWTBvm5AqGhjRN/DV9adqQ2+9 3kMCxPQ27vPKOAul4nkNP/3tizhvFvMXgw== X-Google-Smtp-Source: ABdhPJxJscghYLknils0sPWTYiEWVf78KVRHjcnWmn2vXU7QMv4mIWF7u8hTkTvT9PIbzJ1Ow/LHJH9iF1/OvQ== X-Received: from dlatypov.svl.corp.google.com ([2620:15c:2cd:202:bd59:7b9f:6863:5402]) (user=dlatypov job=sendgmr) by 2002:a05:6902:704:b0:649:cadc:bcf0 with SMTP id k4-20020a056902070400b00649cadcbcf0mr25704910ybt.537.1652303793100; Wed, 11 May 2022 14:16:33 -0700 (PDT) Date: Wed, 11 May 2022 14:16:26 -0700 Message-Id: <20220511211626.3345036-1-dlatypov@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.36.0.512.ge40c2bad7a-goog Subject: [PATCH v2] kunit: bail out of test filtering logic quicker if OOM From: Daniel Latypov To: brendanhiggins@google.com, davidgow@google.com Cc: linux-kernel@vger.kernel.org, kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, skhan@linuxfoundation.org, Daniel Latypov , Zeal Robot , Lv Ruyi Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When filtering what tests to run (suites and/or cases) via kunit.filter_glob (e.g. kunit.py run ), we allocate copies of suites. These allocations can fail, and we largely don't handle that. Note: realistically, this probably doesn't matter much. We're not allocating much memory and this happens early in boot, so if we can't do that, then there's likely far bigger problems. This patch makes us immediately bail out from the top-level function (kunit_filter_suites) with -ENOMEM if any of the underlying kmalloc() calls return NULL. Implementation note: we used to return NULL pointers from some functions to indicate either that all suites/tests were filtered out or there was an error allocating the new array. We'll log a short error in this case and not run any tests or print a TAP header. From a kunit.py user's perspective, they'll get a message about missing/invalid TAP output and have to dig into the test.log to see it. Since hitting this error seems so unlikely, it's probably fine to not invent a way to plumb this error message more visibly. See also: https://lore.kernel.org/linux-kselftest/20220329103919.2376818-1-= lv.ruyi@zte.com.cn/ Signed-off-by: Daniel Latypov Reported-by: Zeal Robot Reported-by: Lv Ruyi Reviewed-by: Brendan Higgins --- v1 -> v2: no code changes. Fix Reported-by tag, add Brendan's Reviewed-by. --- lib/kunit/executor.c | 27 ++++++++++++++++++++++----- lib/kunit/executor_test.c | 4 +++- 2 files changed, 25 insertions(+), 6 deletions(-) diff --git a/lib/kunit/executor.c b/lib/kunit/executor.c index 22640c9ee819..2f73a6a35a7e 100644 --- a/lib/kunit/executor.c +++ b/lib/kunit/executor.c @@ -71,9 +71,13 @@ kunit_filter_tests(struct kunit_suite *const suite, cons= t char *test_glob) =20 /* Use memcpy to workaround copy->name being const. */ copy =3D kmalloc(sizeof(*copy), GFP_KERNEL); + if (!copy) + return ERR_PTR(-ENOMEM); memcpy(copy, suite, sizeof(*copy)); =20 filtered =3D kcalloc(n + 1, sizeof(*filtered), GFP_KERNEL); + if (!filtered) + return ERR_PTR(-ENOMEM); =20 n =3D 0; kunit_suite_for_each_test_case(suite, test_case) { @@ -106,14 +110,16 @@ kunit_filter_subsuite(struct kunit_suite * const * co= nst subsuite, =20 filtered =3D kmalloc_array(n + 1, sizeof(*filtered), GFP_KERNEL); if (!filtered) - return NULL; + return ERR_PTR(-ENOMEM); =20 n =3D 0; for (i =3D 0; subsuite[i] !=3D NULL; ++i) { if (!glob_match(filter->suite_glob, subsuite[i]->name)) continue; filtered_suite =3D kunit_filter_tests(subsuite[i], filter->test_glob); - if (filtered_suite) + if (IS_ERR(filtered_suite)) + return ERR_CAST(filtered_suite); + else if (filtered_suite) filtered[n++] =3D filtered_suite; } filtered[n] =3D NULL; @@ -146,7 +152,8 @@ static void kunit_free_suite_set(struct suite_set suite= _set) } =20 static struct suite_set kunit_filter_suites(const struct suite_set *suite_= set, - const char *filter_glob) + const char *filter_glob, + int *err) { int i; struct kunit_suite * const **copy, * const *filtered_subsuite; @@ -166,6 +173,10 @@ static struct suite_set kunit_filter_suites(const stru= ct suite_set *suite_set, =20 for (i =3D 0; i < max; ++i) { filtered_subsuite =3D kunit_filter_subsuite(suite_set->start[i], &filter= ); + if (IS_ERR(filtered_subsuite)) { + *err =3D PTR_ERR(filtered_subsuite); + return filtered; + } if (filtered_subsuite) *copy++ =3D filtered_subsuite; } @@ -236,9 +247,15 @@ int kunit_run_all_tests(void) .start =3D __kunit_suites_start, .end =3D __kunit_suites_end, }; + int err; =20 - if (filter_glob_param) - suite_set =3D kunit_filter_suites(&suite_set, filter_glob_param); + if (filter_glob_param) { + suite_set =3D kunit_filter_suites(&suite_set, filter_glob_param, &err); + if (err) { + pr_err("kunit executor: error filtering suites: %d\n", err); + return err; + } + } =20 if (!action_param) kunit_exec_run_tests(&suite_set); diff --git a/lib/kunit/executor_test.c b/lib/kunit/executor_test.c index 4ed57fd94e42..eac6ff480273 100644 --- a/lib/kunit/executor_test.c +++ b/lib/kunit/executor_test.c @@ -137,14 +137,16 @@ static void filter_suites_test(struct kunit *test) .end =3D suites + 2, }; struct suite_set filtered =3D {.start =3D NULL, .end =3D NULL}; + int err =3D 0; =20 /* Emulate two files, each having one suite */ subsuites[0][0] =3D alloc_fake_suite(test, "suite0", dummy_test_cases); subsuites[1][0] =3D alloc_fake_suite(test, "suite1", dummy_test_cases); =20 /* Filter out suite1 */ - filtered =3D kunit_filter_suites(&suite_set, "suite0"); + filtered =3D kunit_filter_suites(&suite_set, "suite0", &err); kfree_subsuites_at_end(test, &filtered); /* let us use ASSERTs without le= aking */ + KUNIT_EXPECT_EQ(test, err, 0); KUNIT_ASSERT_EQ(test, filtered.end - filtered.start, (ptrdiff_t)1); =20 KUNIT_ASSERT_NOT_ERR_OR_NULL(test, filtered.start); base-commit: 38289a26e1b8a37755f3e07056ca416c1ee2a2e8 --=20 2.36.0.512.ge40c2bad7a-goog