From nobody Fri May 8 05:17:28 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3575C433EF for ; Wed, 11 May 2022 01:25:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240334AbiEKBZa (ORCPT ); Tue, 10 May 2022 21:25:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240272AbiEKBZV (ORCPT ); Tue, 10 May 2022 21:25:21 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 277FCE15FC for ; Tue, 10 May 2022 18:25:19 -0700 (PDT) Received: from kwepemi500017.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Kycds2qvHzbmKr; Wed, 11 May 2022 09:24:49 +0800 (CST) Received: from kwepemm600005.china.huawei.com (7.193.23.191) by kwepemi500017.china.huawei.com (7.221.188.110) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 11 May 2022 09:25:17 +0800 Received: from ubuntu1804.huawei.com (10.67.175.30) by kwepemm600005.china.huawei.com (7.193.23.191) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 11 May 2022 09:25:16 +0800 From: Hui Tang To: CC: , , , , , , , , Subject: [PATCH -next 1/2] ASoC: max98396: Fix build error for implicit function declaration Date: Wed, 11 May 2022 09:23:47 +0800 Message-ID: <20220511012348.94288-2-tanghui20@huawei.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220511012348.94288-1-tanghui20@huawei.com> References: <20220511012348.94288-1-tanghui20@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.67.175.30] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemm600005.china.huawei.com (7.193.23.191) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org sound/soc/codecs/max98396.c: In function =E2=80=98max98396_i2c_probe=E2=80= =99: sound/soc/codecs/max98396.c:1555:25: error: implicit declaration of functio= n =E2=80=98devm_gpiod_get_optional=E2=80=99; did you mean =E2=80=98devm_reg= ulator_get_optional=E2=80=99? [-Werror=3Dimplicit-function-declaration] max98396->reset_gpio =3D devm_gpiod_get_optional(&i2c->dev, ^~~~~~~~~~~~~~~~~~~~~~~ devm_regulator_get_optional sound/soc/codecs/max98396.c:1556:23: error: =E2=80=98GPIOD_OUT_HIGH=E2=80= =99 undeclared (first use in this function); did you mean =E2=80=98GPIOF_IN= IT_HIGH=E2=80=99? "reset", GPIOD_OUT_HIGH); ^~~~~~~~~~~~~~ GPIOF_INIT_HIGH sound/soc/codecs/max98396.c:1556:23: note: each undeclared identifier is re= ported only once for each function it appears in sound/soc/codecs/max98396.c:1565:3: error: implicit declaration of function= =E2=80=98gpiod_set_value_cansleep=E2=80=99; did you mean =E2=80=98gpio_set= _value_cansleep=E2=80=99? [-Werror=3Dimplicit-function-declaration] gpiod_set_value_cansleep(max98396->reset_gpio, 0); ^~~~~~~~~~~~~~~~~~~~~~~~ gpio_set_value_cansleep cc1: all warnings being treated as errors Add depend on GPIOLIB for 'config SND_SOC_MAX98396' Fixes: b58581136770 ("ASoC: max98396: add amplifier driver") Signed-off-by: Hui Tang --- sound/soc/codecs/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index b106e5517090..71a7afedd0aa 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -1051,6 +1051,7 @@ config SND_SOC_MAX98390 config SND_SOC_MAX98396 tristate "Analog Devices MAX98396 Speaker Amplifier" depends on I2C + depends on GPIOLIB help Enable support for Analog Devices MAX98396 audio amplifier. The device provides a PCM interface for --=20 2.17.1 From nobody Fri May 8 05:17:28 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D8D6C433F5 for ; Wed, 11 May 2022 01:25:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240306AbiEKBZZ (ORCPT ); Tue, 10 May 2022 21:25:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47758 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234866AbiEKBZU (ORCPT ); Tue, 10 May 2022 21:25:20 -0400 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8732314ACA1 for ; Tue, 10 May 2022 18:25:19 -0700 (PDT) Received: from kwepemi500016.china.huawei.com (unknown [172.30.72.54]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4KycXt4CcfzCscn; Wed, 11 May 2022 09:20:30 +0800 (CST) Received: from kwepemm600005.china.huawei.com (7.193.23.191) by kwepemi500016.china.huawei.com (7.221.188.220) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 11 May 2022 09:25:17 +0800 Received: from ubuntu1804.huawei.com (10.67.175.30) by kwepemm600005.china.huawei.com (7.193.23.191) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 11 May 2022 09:25:17 +0800 From: Hui Tang To: CC: , , , , , , , , Subject: [PATCH -next 2/2] ASoC: tlv320adc3xxx: Fix build error for implicit function declaration Date: Wed, 11 May 2022 09:23:48 +0800 Message-ID: <20220511012348.94288-3-tanghui20@huawei.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220511012348.94288-1-tanghui20@huawei.com> References: <20220511012348.94288-1-tanghui20@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.67.175.30] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemm600005.china.huawei.com (7.193.23.191) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org sound/soc/codecs/tlv320adc3xxx.c: In function =E2=80=98adc3xxx_i2c_probe=E2= =80=99: sound/soc/codecs/tlv320adc3xxx.c:1359:21: error: implicit declaration of fu= nction =E2=80=98devm_gpiod_get=E2=80=99; did you mean =E2=80=98devm_gpio_fr= ee=E2=80=99? [-Werror=3Dimplicit-function-declaration] adc3xxx->rst_pin =3D devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW); ^~~~~~~~~~~~~~ devm_gpio_free CC [M] drivers/gpu/drm/nouveau/nvkm/engine/disp/sorgt215.o LD [M] sound/soc/codecs/snd-soc-ak4671.o LD [M] sound/soc/codecs/snd-soc-arizona.o LD [M] sound/soc/codecs/snd-soc-cros-ec-codec.o LD [M] sound/soc/codecs/snd-soc-ak4641.o LD [M] sound/soc/codecs/snd-soc-alc5632.o sound/soc/codecs/tlv320adc3xxx.c:1359:50: error: =E2=80=98GPIOD_OUT_LOW=E2= =80=99 undeclared (first use in this function); did you mean =E2=80=98GPIOF= _INIT_LOW=E2=80=99? adc3xxx->rst_pin =3D devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW); ^~~~~~~~~~~~~ GPIOF_INIT_LOW sound/soc/codecs/tlv320adc3xxx.c:1359:50: note: each undeclared identifier = is reported only once for each function it appears in LD [M] sound/soc/codecs/snd-soc-cs35l32.o sound/soc/codecs/tlv320adc3xxx.c:1408:2: error: implicit declaration of fun= ction =E2=80=98gpiod_set_value_cansleep=E2=80=99; did you mean =E2=80=98gpi= o_set_value_cansleep=E2=80=99? [-Werror=3Dimplicit-function-declaration] gpiod_set_value_cansleep(adc3xxx->rst_pin, 1); ^~~~~~~~~~~~~~~~~~~~~~~~ gpio_set_value_cansleep LD [M] sound/soc/codecs/snd-soc-cs35l41-lib.o LD [M] sound/soc/codecs/snd-soc-cs35l36.o LD [M] sound/soc/codecs/snd-soc-cs35l34.o LD [M] sound/soc/codecs/snd-soc-cs35l41.o CC [M] drivers/gpu/drm/nouveau/nvkm/engine/disp/sormcp89.o cc1: all warnings being treated as errors Add depend on GPIOLIB for 'config SND_SOC_TLV320ADC3XXX' Fixes: e9a3b57efd28 ("ASoC: codec: tlv320adc3xxx: New codec driver") Signed-off-by: Hui Tang --- sound/soc/codecs/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index 71a7afedd0aa..920486e01afb 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -1583,6 +1583,7 @@ config SND_SOC_TFA989X config SND_SOC_TLV320ADC3XXX tristate "Texas Instruments TLV320ADC3001/3101 audio ADC" depends on I2C + depends on GPIOLIB help Enable support for Texas Instruments TLV320ADC3001 and TLV320ADC3101 ADCs. --=20 2.17.1