From nobody Fri May 8 05:17:26 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AE64C433F5 for ; Tue, 10 May 2022 10:27:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239841AbiEJKba (ORCPT ); Tue, 10 May 2022 06:31:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239830AbiEJKb0 (ORCPT ); Tue, 10 May 2022 06:31:26 -0400 Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F26E5201337 for ; Tue, 10 May 2022 03:27:27 -0700 (PDT) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24AA83di031186; Tue, 10 May 2022 03:27:17 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=0Hl5ghIdZdkU4k6qCypCHdoG8Gw3tiISfSLVKrcPEf8=; b=S2Vgv/3Gcx2Vzvy8+SAhnxk/3gmlqLl9jkK7IEjz4y8iMSxnrw0aO9dAc4Oo1gYiLiRS Oj/clCnWBhXheRKybjiOOxT4a85w0beNKcEGrb4O9AgWUpmPvhzmZgsFayHABvR3ZQi7 EvBwR82CdvAA+AJjv/NMUbOCWoFonMdg1+YpcUgAQQoUJxFTLiFLBUy0anKCFSMtWiNE JuKzf9UAbZNmFiB08Z0LKAhdx2Wduv1CA06WP3MppFLarjajxztV9vpBRG/vTTl/A7ZW ixNCXNxfoCBpg5aSU2Er8IsUfMGtTkDVwsWUtYGLHhIdezUV7NYqdgkmaofWXgEdOshU Vw== Received: from dc5-exch01.marvell.com ([199.233.59.181]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3fyp1br1ta-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 10 May 2022 03:27:16 -0700 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 10 May 2022 03:27:15 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 10 May 2022 03:27:15 -0700 Received: from BG-SER530.marvell.com (BG-SER530.marvell.com [10.28.8.21]) by maili.marvell.com (Postfix) with ESMTP id E4D203F70A2; Tue, 10 May 2022 03:27:12 -0700 (PDT) From: Tanmay Jagdale To: , CC: , , , , , Tanmay Jagdale Subject: [PATCH] perf/marvell_cn10k: Fix tad_pmu_event_init() to check pmu type first Date: Tue, 10 May 2022 15:56:57 +0530 Message-ID: <20220510102657.487539-1-tanmay@marvell.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: jD1xn7UF0fqxBDyQrEgZmMuwCVBYL4gC X-Proofpoint-ORIG-GUID: jD1xn7UF0fqxBDyQrEgZmMuwCVBYL4gC X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-10_01,2022-05-10_01,2022-02-23_01 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Make sure to check the pmu type first and then check event->attr.disabled. Doing so would avoid reading the disabled attribute of an event that is not handled by TAD PMU. Signed-off-by: Tanmay Jagdale --- drivers/perf/marvell_cn10k_tad_pmu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/perf/marvell_cn10k_tad_pmu.c b/drivers/perf/marvell_cn= 10k_tad_pmu.c index ee67305f822d..282d3a071a67 100644 --- a/drivers/perf/marvell_cn10k_tad_pmu.c +++ b/drivers/perf/marvell_cn10k_tad_pmu.c @@ -146,12 +146,12 @@ static int tad_pmu_event_init(struct perf_event *even= t) { struct tad_pmu *tad_pmu =3D to_tad_pmu(event->pmu); =20 - if (!event->attr.disabled) - return -EINVAL; - if (event->attr.type !=3D event->pmu->type) return -ENOENT; =20 + if (!event->attr.disabled) + return -EINVAL; + if (event->state !=3D PERF_EVENT_STATE_OFF) return -EINVAL; =20 --=20 2.25.1