From nobody Sun Jun 14 23:30:03 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C3C8C433EF for ; Mon, 9 May 2022 23:19:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232366AbiEIXXX (ORCPT ); Mon, 9 May 2022 19:23:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46212 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232378AbiEIXXM (ORCPT ); Mon, 9 May 2022 19:23:12 -0400 Received: from mail-pl1-x649.google.com (mail-pl1-x649.google.com [IPv6:2607:f8b0:4864:20::649]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC63A21607E for ; Mon, 9 May 2022 16:19:16 -0700 (PDT) Received: by mail-pl1-x649.google.com with SMTP id v8-20020a170902b7c800b0015e927ee201so8942564plz.12 for ; Mon, 09 May 2022 16:19:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:message-id:mime-version:subject:from:to:cc; bh=BCsnd9wzln6SIBCaSSlJS6Bpvy5MKz7jpyqA0qGwjBw=; b=Kz+o6BXhKfBZQQe7+daPzx+o7K9hHTFAVH4QKtZF5Gn+nc/t1mzzKy3ZtfaNprrlqe jpNDJvzr22gN8RN42cTqfRcmgqt1s5UUN+PQ9jGk5qgxY8Xjry+cRnp4X+uuDS0eO9vI /fH6w+aoKuU6nVrJYNlzS8Mrj6nRmQvQ31qYPpd2KXij8CmNdoEjTMRz9ZoIVSSQOSQ8 UBZ2wc63dlv5XAGpoLeWsNP9bZsVNGnghPs3mScqP4fQ2WuApETk4/CIB7ZgbBWlwkNH NfFFt9w06quLYcuTwgnfMXzjLBnbqwlkQMHWXTs9grmvuKX2Mq8zIVIVnPwu4RrjLpTB vvNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=BCsnd9wzln6SIBCaSSlJS6Bpvy5MKz7jpyqA0qGwjBw=; b=dzvOiP/5L+dVI0JCM+0S9O8ejjcXlJv57ZOj2StvIppgEKpPbds6Nej2CkJQjMVk0T s3Nr8IAvxEXUJ35IMAxvA77nyjKrod9FnC8CyzyAL8L23tLxE+3xu4oEFwlEA5hvzgV+ Ym+QagP9w8M8wxAiwKqdxdNHBWkLjfq5mU7l/5tO3mlbXvcQnucyhm/kQSkLabZqLNKq wDSsSj0dV2W+XaBsuqlDmiRQAXhvP3qux5isErP3tvYWNJBMqBNlaZR65ivRIyki+mjq yale8zr6cP8LdmaK4f2gpA92WxHAa5Rh/lmYAaBno9Z7euYhM8sd6c8/MTVF43xrosRc snpg== X-Gm-Message-State: AOAM5313U/gKSjWEUul/tD3Pxp5Fe+GLdu2Gup/YJs2z/KroQYcLdSRE RiSv8DFFDsXJNBn+9MmlEM22lkU1qvsCWw== X-Google-Smtp-Source: ABdhPJyKu726ioJrlfuyldA9N5yHePRxj0NUUXS7H/3v/b0NYwSEZubjln+Ns5cqVF9CpRinoeiSBNsIirjYGA== X-Received: from zllamas.c.googlers.com ([fda3:e722:ac3:cc00:24:72f4:c0a8:4c]) (user=cmllamas job=sendgmr) by 2002:a17:902:b213:b0:158:d44d:cad4 with SMTP id t19-20020a170902b21300b00158d44dcad4mr18169199plr.45.1652138356306; Mon, 09 May 2022 16:19:16 -0700 (PDT) Date: Mon, 9 May 2022 23:19:01 +0000 Message-Id: <20220509231901.3852573-1-cmllamas@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.36.0.512.ge40c2bad7a-goog Subject: [PATCH] binder: fix printk format for commands From: Carlos Llamas To: Greg Kroah-Hartman , "=?UTF-8?q?Arve=20Hj=C3=B8nnev=C3=A5g?=" , Todd Kjos , Martijn Coenen , Christian Brauner Cc: Joel Fernandes , Hridya Valsaraju , Suren Baghdasaryan , kernel-team@android.com, linux-kernel@vger.kernel.org, Carlos Llamas Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make sure we use unsigned format specifier %u for binder commands as most of them are encoded above INT_MAX. This prevents negative values when logging them as in the following case: [ 211.895781] binder: 8668:8668 BR_REPLY 258949 0:0, cmd -2143260157 size = 0-0 ptr 0000006e766a8000-0000006e766a8000 Signed-off-by: Carlos Llamas Acked-by: Christian Brauner (Microsoft) Acked-by: Todd Kjos --- drivers/android/binder.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/android/binder.c b/drivers/android/binder.c index f3b639e89dd8..b4b0e4489bef 100644 --- a/drivers/android/binder.c +++ b/drivers/android/binder.c @@ -3984,7 +3984,7 @@ static int binder_thread_write(struct binder_proc *pr= oc, } break; =20 default: - pr_err("%d:%d unknown command %d\n", + pr_err("%d:%d unknown command %u\n", proc->pid, thread->pid, cmd); return -EINVAL; } @@ -4490,7 +4490,7 @@ static int binder_thread_read(struct binder_proc *pro= c, trace_binder_transaction_received(t); binder_stat_br(proc, thread, cmd); binder_debug(BINDER_DEBUG_TRANSACTION, - "%d:%d %s %d %d:%d, cmd %d size %zd-%zd ptr %016llx-%016llx\n", + "%d:%d %s %d %d:%d, cmd %u size %zd-%zd ptr %016llx-%016llx\n", proc->pid, thread->pid, (cmd =3D=3D BR_TRANSACTION) ? "BR_TRANSACTION" : (cmd =3D=3D BR_TRANSACTION_SEC_CTX) ? --=20 2.36.0.512.ge40c2bad7a-goog