From nobody Fri May 8 10:04:28 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD05DC433EF for ; Thu, 5 May 2022 09:25:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352699AbiEEJ3e (ORCPT ); Thu, 5 May 2022 05:29:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40260 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353176AbiEEJ3V (ORCPT ); Thu, 5 May 2022 05:29:21 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD08C1AF1B; Thu, 5 May 2022 02:25:41 -0700 (PDT) Received: from dggpemm500024.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Kv7b201PbzfYv7; Thu, 5 May 2022 17:25:18 +0800 (CST) Received: from dggpemm500007.china.huawei.com (7.185.36.183) by dggpemm500024.china.huawei.com (7.185.36.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 5 May 2022 17:25:37 +0800 Received: from huawei.com (10.175.103.91) by dggpemm500007.china.huawei.com (7.185.36.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 5 May 2022 17:25:36 +0800 From: Yang Yingliang To: , CC: , , Subject: [PATCH] soc/tegra: fuse: fix possible null-ptr-deref in tegra_fuse_probe() Date: Thu, 5 May 2022 17:37:20 +0800 Message-ID: <20220505093720.1283942-1-yangyingliang@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.103.91] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500007.china.huawei.com (7.185.36.183) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" It will cause null-ptr-deref when using 'res', if platform_get_resource() returns NULL, so move using 'res' after devm_ioremap_resource() that will check it to avoid null-ptr-deref. And use devm_platform_get_and_ioremap_resource() to simplify code. Fixes: 55a042b3f68f ("soc/tegra: fuse: Fix reading registers using DMA on T= egra20") Signed-off-by: Yang Yingliang --- drivers/soc/tegra/fuse/fuse-tegra.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/soc/tegra/fuse/fuse-tegra.c b/drivers/soc/tegra/fuse/f= use-tegra.c index aa94fda282f4..e85a78a80c48 100644 --- a/drivers/soc/tegra/fuse/fuse-tegra.c +++ b/drivers/soc/tegra/fuse/fuse-tegra.c @@ -218,13 +218,12 @@ static int tegra_fuse_probe(struct platform_device *p= dev) return err; =20 /* take over the memory region from the early initialization */ - res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); - fuse->phys =3D res->start; - fuse->base =3D devm_ioremap_resource(&pdev->dev, res); + fuse->base =3D devm_platform_get_and_ioremap_resource(pdev, 0, &res); if (IS_ERR(fuse->base)) { err =3D PTR_ERR(fuse->base); return err; } + fuse->phys =3D res->start; =20 fuse->clk =3D devm_clk_get(&pdev->dev, "fuse"); if (IS_ERR(fuse->clk)) { --=20 2.25.1