From nobody Fri May 8 11:25:52 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F3A8C433EF for ; Wed, 4 May 2022 12:52:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350043AbiEDM4O (ORCPT ); Wed, 4 May 2022 08:56:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41282 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237921AbiEDM4L (ORCPT ); Wed, 4 May 2022 08:56:11 -0400 X-Greylist: delayed 901 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Wed, 04 May 2022 05:52:35 PDT Received: from m12-18.163.com (m12-18.163.com [220.181.12.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 25F452AE12 for ; Wed, 4 May 2022 05:52:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=0j/hv WPupqrJGaOCk9faAVdYLcHHclCHbuBk/wL09eE=; b=XKXx2GJzfal9rxPRPgbfQ 1/robgERR1lNwK3ndSt6c+kbjEqn6m8tyRqe8yKVCAUPSu4wQ6drHUVyos7whsxy 3AFuhqCosXFTwzcqmjn1GnW0km6lUAiKXIe+nUNDrOcpD0reS/lfvJSmxaaMWmg7 kwyM6ZWcBsB0ThHHG8xkHs= Received: from localhost.localdomain (unknown [120.204.77.149]) by smtp14 (Coremail) with SMTP id EsCowABnJ_tKc3JikTI+Aw--.4038S4; Wed, 04 May 2022 20:37:05 +0800 (CST) From: lizhe To: bhe@redhat.com, vgoyal@redhat.com, dyoung@redhat.com, prudo@redhat.com Cc: kexec@lists.infradead.org, linux-kernel@vger.kernel.org, lizhe Subject: [PATCH] kernel/crash_core.c : Remove redundant checks for ck_cmdline is NULL Date: Wed, 4 May 2022 05:36:23 -0700 Message-Id: <20220504123623.36852-1-sensor1010@163.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: EsCowABnJ_tKc3JikTI+Aw--.4038S4 X-Coremail-Antispam: 1Uf129KBjvdXoW5Kr1rCw4xCrWxArWUXFW7CFg_yoWxXrX_W3 y7Krn2qr15Aw1j9r18ZayfWrWUKa10va9a9a43trW2va47trn5G343JFn0yrnxC397Cr17 Gws7Jrnrt3yakjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xR_sqWUUUUUU== X-Originating-IP: [120.204.77.149] X-CM-SenderInfo: 5vhq20jurqiii6rwjhhfrp/xtbBohH2q1aEEK-VzAAAsa Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" When ck_cmdline is NULL. The last three lines of this function(get_last_crashkernel()) are equivalent to : if (!NULL) return NULL; return NULL; This is obviously a redundant check Signed-off-by: lizhe Acked-by: Baoquan He --- kernel/crash_core.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/kernel/crash_core.c b/kernel/crash_core.c index 256cf6db573c..c232f01a2c54 100644 --- a/kernel/crash_core.c +++ b/kernel/crash_core.c @@ -222,9 +222,6 @@ static __init char *get_last_crashkernel(char *cmdline, p =3D strstr(p+1, name); } =20 - if (!ck_cmdline) - return NULL; - return ck_cmdline; } =20 --=20 2.25.1