From nobody Sun May 10 12:52:09 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 190F1C433F5 for ; Tue, 3 May 2022 19:39:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241985AbiECTnV (ORCPT ); Tue, 3 May 2022 15:43:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37130 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236024AbiECTnP (ORCPT ); Tue, 3 May 2022 15:43:15 -0400 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E6C32E6BB for ; Tue, 3 May 2022 12:39:42 -0700 (PDT) Received: by mail-pl1-x62d.google.com with SMTP id n18so15863449plg.5 for ; Tue, 03 May 2022 12:39:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Yb09R8V6T/hLKKorfQqqI/dYQ92aTPVCxYGvivN1WrQ=; b=nTnedbqZxvH3D4aoZhb8M4LN7yGE7oQAKVek4oFDpicjTEEuiiy1QnCB4CMj2ITh3r E35d1+bmNmbhlwRH6UBciyjGg3S/PzaInsbNHCmaq4LEz3tuoY082AAiyFKfvrkwXBeo JfIuom64Lrfu2J6c+jqE1UOZTnEjASjIOGqjM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Yb09R8V6T/hLKKorfQqqI/dYQ92aTPVCxYGvivN1WrQ=; b=4HhRi32mlQoOaNfc4Ov/RnP+2Aqz+L+8GyAuh/oF3bG8awrK++aHIKRdwL1wwaEMkR gCxzaXbqlpj3K/Xjc9MbqUnOseYEtElkTBY9KWmDBDP8pf2cFxzU4g+UCJpOwx4BLBGs 4afBlp5jLaQffQQ2TwYEqGRiT+7MlKdSqpDKqGmCHVTwW0cdtfghnIAeX7wFNgrmVTOj Rwkbh2hSSVubfhY5k+HH95mP7Ffieq3hqVs+zXXHiScFh4JNJtMy2+ZhXuKoY+aQbq6x pPuc7QUiMfzpH0i/BYqqrI1dnl+GJBm3iWjqPMmRKWArDtoj/fP3hadzU+zK3wwOGqGj 2k1g== X-Gm-Message-State: AOAM532/2MzphgiGetw/8SMbHLsWjIbguMs0Qvd65QZRTSFUeORw4exh fYO7Om9e7k+Cx0U//GDSvXjLCA== X-Google-Smtp-Source: ABdhPJzTCzLG6PohQNnCIuBLy07mZZOZm1WT+JhkbF402wdu6mru5FQFvmPnqMVpAfcfohVdTAjmFQ== X-Received: by 2002:a17:90b:4c09:b0:1dc:6c30:f230 with SMTP id na9-20020a17090b4c0900b001dc6c30f230mr6442474pjb.110.1651606781671; Tue, 03 May 2022 12:39:41 -0700 (PDT) Received: from smtp.gmail.com ([2620:15c:202:201:15e:c760:9a04:7fbe]) by smtp.gmail.com with ESMTPSA id e25-20020aa78c59000000b0050dc7628154sm6680804pfd.46.2022.05.03.12.39.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 May 2022 12:39:40 -0700 (PDT) From: Stephen Boyd To: Jonathan Cameron Cc: linux-kernel@vger.kernel.org, patches@lists.linux.dev, devicetree@vger.kernel.org, linux-iio@vger.kernel.org, Gwendal Grignou , Rob Herring , Krzysztof Kozlowski Subject: [PATCH v2 1/2] dt-bindings: iio: sx9324: Add CS idle/sleep mode Date: Tue, 3 May 2022 12:39:36 -0700 Message-Id: <20220503193937.3794477-2-swboyd@chromium.org> X-Mailer: git-send-email 2.36.0.464.gb9c8b46e94-goog In-Reply-To: <20220503193937.3794477-1-swboyd@chromium.org> References: <20220503193937.3794477-1-swboyd@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" We need to configure the sleep and idle mode of the CS pins for this device. Add a DT property to do this so pins are in a proper state during sleep (either hi-z, grounded, or pulled up to vdd). Reviewed-by: Gwendal Grignou Signed-off-by: Stephen Boyd Reviewed-by: Rob Herring --- .../bindings/iio/proximity/semtech,sx9324.yaml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/Documentation/devicetree/bindings/iio/proximity/semtech,sx9324= .yaml b/Documentation/devicetree/bindings/iio/proximity/semtech,sx9324.yaml index d265eb5258c8..b3aa2ebf9661 100644 --- a/Documentation/devicetree/bindings/iio/proximity/semtech,sx9324.yaml +++ b/Documentation/devicetree/bindings/iio/proximity/semtech,sx9324.yaml @@ -126,6 +126,14 @@ properties: UINT_MAX (4294967295) represents infinite. Other values represent 1-1/N. =20 + semtech,cs-idle-sleep: + description: + State of CS pins during sleep mode and idle time. + enum: + - hi-z + - gnd + - vdd + semtech,int-comp-resistor: description: Internal resistor setting for compensation. @@ -187,5 +195,6 @@ examples: semtech,avg-pos-strength =3D <64>; semtech,int-comp-resistor =3D "lowest"; semtech,input-precharge-resistor-ohms =3D <2000>; + semtech,cs-idle-sleep =3D "gnd"; }; }; --=20 https://chromeos.dev From nobody Sun May 10 12:52:09 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EA27C433EF for ; Tue, 3 May 2022 19:39:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241982AbiECTnX (ORCPT ); Tue, 3 May 2022 15:43:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241955AbiECTnQ (ORCPT ); Tue, 3 May 2022 15:43:16 -0400 Received: from mail-pg1-x536.google.com (mail-pg1-x536.google.com [IPv6:2607:f8b0:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 949532FE4E for ; Tue, 3 May 2022 12:39:43 -0700 (PDT) Received: by mail-pg1-x536.google.com with SMTP id t13so14779852pgn.8 for ; Tue, 03 May 2022 12:39:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=68lFLMzdFWYn9TeG84Yby4hphKM/OE0fXGXg6JYNJHo=; b=agSMD0mYwrZLWQyFktPHTmNxr53miZI5xh2A9CFUj0Az4lEqJsxLWnRfcf1ufjt+je Zucdf6ioUwE19NKX9ek1d7dHI8J5djCxnSjKovvFKd9LFWUGxd3shtjXIgIfyxSo3Iup ABMsV/xz75KORtZpf4o9dpjoIbuxouEpDtrKo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=68lFLMzdFWYn9TeG84Yby4hphKM/OE0fXGXg6JYNJHo=; b=E03wlEIw1BZHljnxwRVL/QlMscHu/kvs8HfFGbK+mJBIxeuf4xcWKJB83kLDkHkqFu Mn1tD3yjiW/LQkHHSyau/xdj1x3jRcA6pdLJaInM3rSUu7ikOE4zIBgBeqltHGM0PPnD +LKcy/maLEER1q/k2iBIci4NHxDRJXb1kFKkD4CT+iBbNGuV4saNgoI+j5TF03HsLa7n TKW+iD23PY5W0RN816sUeTyEBMt3q1agMQGz4+r4FtGwSpzOA5wFaD9LZp+lcIE4Mk34 SXDx6zFOQbTgde6WsCRDEs3wPzIF+6DJa5d7KS93pHYT4sbpLakVQ9LU7TM368JKt5Po 8hEQ== X-Gm-Message-State: AOAM530gV+JsXvn0rkVicRNMCPA6erCWWry5XrIu8LE9CoMT6iQtYPtg EeVXA5usbLjtJ+EXbKEoyASnfA== X-Google-Smtp-Source: ABdhPJwFb7VzKWz+rdPmAaYShya3oSzctVjAj8WRQ+y2WP3ynoKaRoLCqu7NRGV+8xoWFiqDNGLFPA== X-Received: by 2002:a63:5551:0:b0:3ab:84c3:1a0 with SMTP id f17-20020a635551000000b003ab84c301a0mr15295935pgm.604.1651606783136; Tue, 03 May 2022 12:39:43 -0700 (PDT) Received: from smtp.gmail.com ([2620:15c:202:201:15e:c760:9a04:7fbe]) by smtp.gmail.com with ESMTPSA id e25-20020aa78c59000000b0050dc7628154sm6680804pfd.46.2022.05.03.12.39.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 May 2022 12:39:42 -0700 (PDT) From: Stephen Boyd To: Jonathan Cameron Cc: linux-kernel@vger.kernel.org, patches@lists.linux.dev, devicetree@vger.kernel.org, linux-iio@vger.kernel.org, Gwendal Grignou , Rob Herring , Krzysztof Kozlowski Subject: [PATCH v2 2/2] iio: sx9324: Add setting for CS idle mode Date: Tue, 3 May 2022 12:39:37 -0700 Message-Id: <20220503193937.3794477-3-swboyd@chromium.org> X-Mailer: git-send-email 2.36.0.464.gb9c8b46e94-goog In-Reply-To: <20220503193937.3794477-1-swboyd@chromium.org> References: <20220503193937.3794477-1-swboyd@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Based on device tree setting, set the CS idle mode. Reviewed-by: Gwendal Grignou Signed-off-by: Stephen Boyd --- drivers/iio/proximity/sx9324.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/drivers/iio/proximity/sx9324.c b/drivers/iio/proximity/sx9324.c index 7f367f63e362..c7fc75f7badc 100644 --- a/drivers/iio/proximity/sx9324.c +++ b/drivers/iio/proximity/sx9324.c @@ -57,6 +57,11 @@ GENMASK(SX9324_REG_AFE_CTRL0_RINT_SHIFT + 1, \ SX9324_REG_AFE_CTRL0_RINT_SHIFT) #define SX9324_REG_AFE_CTRL0_RINT_LOWEST 0x00 +#define SX9324_REG_AFE_CTRL0_CSIDLE_SHIFT 4 +#define SX9324_REG_AFE_CTRL0_CSIDLE_MASK \ + GENMASK(SX9324_REG_AFE_CTRL0_CSIDLE_SHIFT + 1, \ + SX9324_REG_AFE_CTRL0_CSIDLE_SHIFT) +#define SX9324_REG_AFE_CTRL0_RINT_LOWEST 0x00 #define SX9324_REG_AFE_CTRL1 0x21 #define SX9324_REG_AFE_CTRL2 0x22 #define SX9324_REG_AFE_CTRL3 0x23 @@ -872,6 +877,8 @@ sx9324_get_default_reg(struct device *dev, int idx, { static const char * const sx9324_rints[] =3D { "lowest", "low", "high", "highest" }; + static const char * const sx9324_csidle[] =3D { "hi-z", "hi-z", "gnd", + "vdd" }; #define SX9324_PIN_DEF "semtech,ph0-pin" #define SX9324_RESOLUTION_DEF "semtech,ph01-resolution" #define SX9324_PROXRAW_DEF "semtech,ph01-proxraw-strength" @@ -901,6 +908,15 @@ sx9324_get_default_reg(struct device *dev, int idx, reg_def->def =3D raw; break; case SX9324_REG_AFE_CTRL0: + ret =3D device_property_read_string(dev, + "semtech,cs-idle-sleep", &res); + if (!ret) + ret =3D match_string(sx9324_csidle, ARRAY_SIZE(sx9324_csidle), res); + if (ret >=3D 0) { + reg_def->def &=3D ~SX9324_REG_AFE_CTRL0_CSIDLE_MASK; + reg_def->def |=3D ret << SX9324_REG_AFE_CTRL0_CSIDLE_SHIFT; + } + ret =3D device_property_read_string(dev, "semtech,int-comp-resistor", &res); if (ret) --=20 https://chromeos.dev