From nobody Sun May 10 15:06:42 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A457C433EF for ; Mon, 2 May 2022 08:34:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1383788AbiEBIhd (ORCPT ); Mon, 2 May 2022 04:37:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231486AbiEBIha (ORCPT ); Mon, 2 May 2022 04:37:30 -0400 Received: from mail.marcansoft.com (marcansoft.com [IPv6:2a01:298:fe:f::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0ED818386 for ; Mon, 2 May 2022 01:34:00 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: hector@marcansoft.com) by mail.marcansoft.com (Postfix) with ESMTPSA id 8828C41982; Mon, 2 May 2022 08:33:56 +0000 (UTC) From: Hector Martin To: Jassi Brar Cc: Alyssa Rosenzweig , Sven Peter , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Hector Martin Subject: [PATCH] mailbox: apple: Keep IRQs active in suspend Date: Mon, 2 May 2022 17:33:45 +0900 Message-Id: <20220502083345.22433-1-marcan@marcan.st> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Some consumers (notably SMC) need to be wakeup sources for s2idle, so the IRQs need to stay enabled during suspend. We expect consumers to properly suspend coprocessors such that no IRQs would be triggered where not necessary, so this can be done unconditionally. Signed-off-by: Hector Martin --- drivers/mailbox/apple-mailbox.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/mailbox/apple-mailbox.c b/drivers/mailbox/apple-mailbo= x.c index e0c2bf7c6338..ce54f72d8676 100644 --- a/drivers/mailbox/apple-mailbox.c +++ b/drivers/mailbox/apple-mailbox.c @@ -369,8 +369,8 @@ static int apple_mbox_probe(struct platform_device *pde= v) =20 ret =3D devm_request_threaded_irq(dev, mbox->irq_recv_not_empty, NULL, apple_mbox_recv_irq, - IRQF_NO_AUTOEN | IRQF_ONESHOT, irqname, - mbox); + IRQF_NO_AUTOEN | IRQF_ONESHOT | IRQF_NO_SUSPEND, + irqname, mbox); if (ret) return ret; =20 @@ -378,9 +378,8 @@ static int apple_mbox_probe(struct platform_device *pde= v) if (!irqname) return -ENOMEM; =20 - ret =3D devm_request_irq(dev, mbox->irq_send_empty, - apple_mbox_send_empty_irq, IRQF_NO_AUTOEN, - irqname, mbox); + ret =3D devm_request_irq(dev, mbox->irq_send_empty, apple_mbox_send_empty= _irq, + IRQF_NO_AUTOEN | IRQF_NO_SUSPEND, irqname, mbox); if (ret) return ret; =20 --=20 2.35.1