From nobody Sun May 10 16:27:02 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8AB2C433EF for ; Fri, 29 Apr 2022 08:14:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355467AbiD2IR6 (ORCPT ); Fri, 29 Apr 2022 04:17:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53914 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355455AbiD2IRx (ORCPT ); Fri, 29 Apr 2022 04:17:53 -0400 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2049.outbound.protection.outlook.com [40.107.244.49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D90AAC12D6; Fri, 29 Apr 2022 01:14:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LKvz4OKnNZK1d8nOe/XvVxSoIaA/D0qCUQoroUOJojwt4w0d9/JZr6Sqe0+kg91FBhX4ryAg7ELbKjl0Fav9O3SfVp/VjSSoD2HWzLHWpSUSmzwcdyexBUbK2DHDjPz6kJzAaRty1LjpRCtELtHlYQN72d1Kvpou0nXGEVQZ7qwWTMKfdHW4FiLzUho0xJC8/9aD8evfXW4TqUpRAYdC0g/c4NeMiicLnM4gDYHAty4501MGOb6Syx6LNyGTkwC+cTGUJjx6dBz5q69G2gjvYKwch53KxP+XQKb9QdgWmPXUoNcDm4m7gE9i32PDDHg+m0gCqi2wRx5DBpUo1q+wuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XQbeBOVIVK1PgYBlxHFsFLukyM/k7bxqNaQoFvP9Ggk=; b=GGV7+UORsz6tRPgvW1Cm7oxC7CPkRIOzKG9kKSv1hxcysSndwcY6cVioCrxNTpYtAgHeZ6xfoYHUjOXZ15w+QH1L/BXvOGjStYHlUkCSSX9whUoIO29ml/jB+ZPVmYv4f/rv0jnMKgIGJcof8zCfDsDDMtPnaFshq0SyA7SI1RF+tOSLFtOpsxq4Jg7VbPPKRk2/fjI52jKHBmfuaMDTG8IpJKeqAs5nK07j48enix4gzljAwtlox+iA+HnTT/ppkgCHAHxWnrvMt0Y5BWIWWTQ7yNElceK+AWrH2SrrZanEXRI9egvYY0hswR/QcM6moGZ45+c9RGNA2zdtxztmcQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XQbeBOVIVK1PgYBlxHFsFLukyM/k7bxqNaQoFvP9Ggk=; b=FyhaDIQGBkIJMpFFpHBcOTuutY9tBjUsyHjjJaAvtaOZs6DYGE4eFl/BA/ggFv+CBELlFQmkaxjscTZxTYjoaWMRrgZdT/zxLl3NEz+iK6Sl/H8jiVE6EyaAOcS5lhrvnUbkRAojm0lvrMh4/eEMHo39ZReTCVJTNATwk58IdUc= Received: from DS7PR03CA0299.namprd03.prod.outlook.com (2603:10b6:5:3ad::34) by BYAPR02MB4392.namprd02.prod.outlook.com (2603:10b6:a03:57::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Fri, 29 Apr 2022 08:14:32 +0000 Received: from DM3NAM02FT011.eop-nam02.prod.protection.outlook.com (2603:10b6:5:3ad:cafe::77) by DS7PR03CA0299.outlook.office365.com (2603:10b6:5:3ad::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15 via Frontend Transport; Fri, 29 Apr 2022 08:14:32 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com; Received: from xsj-pvapexch02.xlnx.xilinx.com (149.199.62.198) by DM3NAM02FT011.mail.protection.outlook.com (10.13.5.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5206.12 via Frontend Transport; Fri, 29 Apr 2022 08:14:32 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Fri, 29 Apr 2022 01:14:30 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Fri, 29 Apr 2022 01:14:30 -0700 Envelope-to: git@xilinx.com, linux-serial@vger.kernel.org, jirislaby@kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org Received: from [10.140.6.39] (port=57162 helo=xhdsgoud40.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1nkLll-0002va-RR; Fri, 29 Apr 2022 01:14:30 -0700 From: Shubhrajyoti Datta To: CC: , , , , , Shubhrajyoti Datta Subject: [PATCH 1/7] xilinx: Update copyright text to correct format Date: Fri, 29 Apr 2022 13:44:16 +0530 Message-ID: <20220429081422.3630070-2-shubhrajyoti.datta@xilinx.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220429081422.3630070-1-shubhrajyoti.datta@xilinx.com> References: <20220429081422.3630070-1-shubhrajyoti.datta@xilinx.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bb4243f8-caa2-43a1-782c-08da29b84a44 X-MS-TrafficTypeDiagnostic: BYAPR02MB4392:EE_ X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OtgDgrhpJs3tGdu+TnG5E7c40fSIeze4QnxIvMaC9c+AmIo9amBI8on/C88eFbvMqPEDXHHron6DahEwHk6a3/ZDDbFweWAXjidutPatIevnj0wEqaaGfGrLvEDBvIHtdNy+e1jv+beveB8dMmzJEFelAFpcud0/XvlV26Q2qX+ByDcBVAZYX+yznSkAerjo2GMjyWaAMCe4t2IvGCnOqAOSyLVWDiYOX4Vr/BZzBUoYNuxL+CF4AZPbJOr6BdCXi2CLBkdKnBxO92Nom+mXXlnwMVJJk5LTOZm+7GnUwCFwFiopEawg8ooFk5Vsa1DdYqNZ9HoB+7tq9jzaUc6hv72g/91j9C4v7okF+/ShCsb2MAb2ox66huK7qrTDGziZx8XRJVWC7iAFf6paYH+CM8ySrvprinwYvIBa4ew63ib+Ci9ZIkWdTmPbG7ChjyhobfsYW1exAE8KUXzHLmn2PBsIjEL6CHwG2zcLkMq+rpexANXTCCuDzLAc6pvAkzmx81DOZPfThRyiOv75BZGCFJ2PtHnlS1jDyRqYcUqvS0XTcXgj9S55LOP/feokuSE5vsdjuU8w7dPOI63gF0NpGPXfGRx55wQPkUhKDGObLzW6DrywEDPm3RxBTP8B2SblLpRh/3MZFDRpoBV/xiacMJl4/8EbJ+cPJNzofOOV86YT8lQVFlt8bpPFiIm14uXa+AsB9x0Fj7gUM6CMUjpcOA== X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch02.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(82310400005)(186003)(83380400001)(36860700001)(7696005)(6666004)(47076005)(426003)(2906002)(107886003)(336012)(1076003)(2616005)(6916009)(316002)(54906003)(36756003)(40460700003)(508600001)(44832011)(5660300002)(356005)(7636003)(4326008)(26005)(70206006)(70586007)(8936002)(9786002)(8676002)(4744005)(102446001);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2022 08:14:32.2131 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bb4243f8-caa2-43a1-782c-08da29b84a44 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT011.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR02MB4392 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Michal Simek Based on recommended guidance Copyright term should be also present in front of (c). That's why aligned drivers to match this pattern. It helps automated tools with source code scanning. Signed-off-by: Michal Simek Signed-off-by: Shubhrajyoti Datta --- drivers/tty/serial/xilinx_uartps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx= _uartps.c index 250a1d888eeb..fa82f88844a1 100644 --- a/drivers/tty/serial/xilinx_uartps.c +++ b/drivers/tty/serial/xilinx_uartps.c @@ -2,7 +2,7 @@ /* * Cadence UART driver (found in Xilinx Zynq) * - * 2011 - 2014 (C) Xilinx Inc. + * Copyright (c) 2011 - 2014 Xilinx, Inc. * * This driver has originally been pushed by Xilinx using a Zynq-branding.= This * still shows in the naming of this file, the kconfig symbols and some sy= mbols --=20 2.25.1 From nobody Sun May 10 16:27:02 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E3E4C433EF for ; Fri, 29 Apr 2022 08:14:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355470AbiD2ISJ (ORCPT ); Fri, 29 Apr 2022 04:18:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355459AbiD2IRz (ORCPT ); Fri, 29 Apr 2022 04:17:55 -0400 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2079.outbound.protection.outlook.com [40.107.93.79]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 03F63C12E9; Fri, 29 Apr 2022 01:14:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L8/Q6sFGg+Rx1ZM6KCE/3Ydrfr1blzJPeQnYwQIkUAjMgRml66oN1g3p4tjywiN4GDNVBbcZGMQKbwlkpYpQl3igsoIclDqu9H7DKRRun+u7M2B2Vsypo+8LTlGTHVbfOwlqK2aj4Ej319c8ao1CdOfRkmyq98rh2DGqpwmbUXAIUPKNwHdY/LWA6Np3oNFbLHDBOJ+H1w8dyXILhpTPHK7nFmjYqUBCjd66daeFt4OYhz2jUw67fi/EHrC18h3reYUiRnSJeY7q8Tgd7GrS5gsraQHnxvo/9HpTNQf0hCYJv9vVr07+NjFaj9+qlPk7Tggs1i14j+UNEfEAV7BN8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JwGj3OjMZPH4S1gPm8Fc+/KCvCdYA2jII1Zhg5OjxEA=; b=iyNZO8K84X+g+p7OGDyEsfAcXu4c5hrlNoaHk79mameIpVhtlgqFz87NslRBCxssGE9XlZtEk+JeSf47Ektc58MtipXr3yMwDdUQM2E5QgaDy+kpIoSjoSd9KE4WR434hs7mnkFe+2mX4+jMK/2aVFp+YoO2Uqo2APX/uWi8hWU0g3P71rguzwzhJTJMbDLCCf0YSDOx3gPHL1GH6lYh6HAP67OyN9gZXnVLi8fuPUdyQXYr7r4j4hxaN3me2TUTh9VSYE78cLT5RkHAr/okbZX7xPd9/Ls1KA1Ucw9DsXgKKwlgjPl7045tGdwbs+YQf4n/XFHfg+I76FUiAWmVJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JwGj3OjMZPH4S1gPm8Fc+/KCvCdYA2jII1Zhg5OjxEA=; b=K27AaHR0vFH277wfTVIk6H8pgJwCTDRdqB3GOUUBby+NM9XEa4Sc4E7fsTma8+OgsIrYD1mVAyKJ8k5cWSLVOrnR1J9ENXc7icyJpKkoyf/Puaio+WJaDc1JIoMYIgwNhf9mvWdEgv0kb1aBJp6GQw5Zw8r9Oje0WKW+QoQ+dIQ= Received: from SN7PR04CA0103.namprd04.prod.outlook.com (2603:10b6:806:122::18) by SA0PR02MB7322.namprd02.prod.outlook.com (2603:10b6:806:e8::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Fri, 29 Apr 2022 08:14:34 +0000 Received: from SN1NAM02FT0064.eop-nam02.prod.protection.outlook.com (2603:10b6:806:122:cafe::33) by SN7PR04CA0103.outlook.office365.com (2603:10b6:806:122::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13 via Frontend Transport; Fri, 29 Apr 2022 08:14:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch01.xlnx.xilinx.com; Received: from xsj-pvapexch01.xlnx.xilinx.com (149.199.62.198) by SN1NAM02FT0064.mail.protection.outlook.com (10.97.4.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5206.12 via Frontend Transport; Fri, 29 Apr 2022 08:14:34 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch01.xlnx.xilinx.com (172.19.86.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Fri, 29 Apr 2022 01:14:33 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Fri, 29 Apr 2022 01:14:33 -0700 Envelope-to: git@xilinx.com, linux-serial@vger.kernel.org, jirislaby@kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org Received: from [10.140.6.39] (port=57162 helo=xhdsgoud40.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1nkLlo-0002va-Ht; Fri, 29 Apr 2022 01:14:32 -0700 From: Shubhrajyoti Datta To: CC: , , , , , Shubhrajyoti Datta Subject: [PATCH 2/7] tty: xilinx_uartps: Check the clk_enable return value Date: Fri, 29 Apr 2022 13:44:17 +0530 Message-ID: <20220429081422.3630070-3-shubhrajyoti.datta@xilinx.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220429081422.3630070-1-shubhrajyoti.datta@xilinx.com> References: <20220429081422.3630070-1-shubhrajyoti.datta@xilinx.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c377b3f3-44eb-4d2e-5e27-08da29b84b95 X-MS-TrafficTypeDiagnostic: SA0PR02MB7322:EE_ X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lSJDj4UDPFJre8IBfjl4tlxPZXQVHxEUk/Uav6Lz9rQsnpojDBzfpNwXJ4GtmZKzW2VoYaXuhtgaPodZBt1RPvYisAPaLti+5p9vwb6jVZ0TLWhkErQWGqnGBK23BJLvEwOBY5VxUZOFlaigIShtCw+/UeWszY5tohpX7I8JtARj066LazTBjF2tIdjraUtSy5cv8nr2w4XUmYIVWwPHpLzsRDG7UFhkhZ3V5udQCubJiGQsrBKmKZlCfOskaGEDp58w75Pd/4PFFzDX592YztA+f2UMlHdCX5oQo1DMZ0hKnyoQ0Bxybr5vRfl5tY42HUtj6NUIQrLOu2QZRVz8xohz6SlwjMbv+pPmcDu/+AEfmiGyH7MP+1vkaeY5tNFc3J5hgV4dRWBVh8qZzbtztUXZwUvphDxJNVlt7ec+mWRILl6RLfblKkpffU8If2qiOwoECVRr/Lt0P31tsDpLrwsoulZpMij4d0UyN7IYbauSfOmSrso2yncdkTFH+pqQwcB2XWZsI4Br1TYuTr5bjrKRJHEMCeKOIQqkXdIh2AnV9JlGcy+ykp0YgcxCNxd1k98WUB9Kf5JmFvY/+uGqTmENWgVZEYYBQoOTXW7ml+9jItbHwhdlvjORQvfFjPgNW/xawR/HhFCUFRrNVHLxdgkWJYyMakotVkvionYSZtiyQuxFbq63QKKSOJiZEqqjRrC+V932YRAhJrd7cfL7Fg== X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch01.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(70586007)(4326008)(8676002)(70206006)(44832011)(40460700003)(2616005)(7636003)(26005)(186003)(82310400005)(5660300002)(83380400001)(356005)(2906002)(8936002)(107886003)(7696005)(54906003)(36860700001)(316002)(36756003)(47076005)(1076003)(4744005)(6666004)(6916009)(9786002)(508600001)(426003)(336012)(102446001);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2022 08:14:34.4366 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c377b3f3-44eb-4d2e-5e27-08da29b84b95 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT0064.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR02MB7322 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Check the clk_enable return value. Addresses-Coverity: Event check_return. Signed-off-by: Shubhrajyoti Datta --- drivers/tty/serial/xilinx_uartps.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx= _uartps.c index fa82f88844a1..8f15fe24a0eb 100644 --- a/drivers/tty/serial/xilinx_uartps.c +++ b/drivers/tty/serial/xilinx_uartps.c @@ -1397,9 +1397,17 @@ static int __maybe_unused cdns_runtime_resume(struct= device *dev) { struct uart_port *port =3D dev_get_drvdata(dev); struct cdns_uart *cdns_uart =3D port->private_data; + int ret; + + ret =3D clk_enable(cdns_uart->pclk); + if (ret) + return ret; =20 - clk_enable(cdns_uart->pclk); - clk_enable(cdns_uart->uartclk); + ret =3D clk_enable(cdns_uart->uartclk); + if (ret) { + clk_disable(cdns_uart->pclk); + return ret; + } return 0; }; =20 --=20 2.25.1 From nobody Sun May 10 16:27:02 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8EA4C433EF for ; Fri, 29 Apr 2022 08:14:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355478AbiD2ISD (ORCPT ); Fri, 29 Apr 2022 04:18:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239059AbiD2IRz (ORCPT ); Fri, 29 Apr 2022 04:17:55 -0400 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2089.outbound.protection.outlook.com [40.107.244.89]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 764ACC12F2; Fri, 29 Apr 2022 01:14:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=awntGVtucMdHkBKHQzVtmjCJAPJv743iN43cQVwWn+uki/5CSW75vTE2xVkzm8fczNnLeCaPyJ6Mth3lT4w3yHIbw4sjhrnVmo0p2KHbFjs4ZAvbLSNgXgtGD1O7BytEjyXxRx+TDpHAtkkZyz2qlfGMzwD8SuIKc/z1TjdZvL4Gg4n6Sob6b+l12AleFmwsGnjze3uVYQwsVacuSHVkbJjJPkO+k161PJ4nrF7pJsNvFL8Mt4/IiBTaj1xM1GzrAvwe6jAQNAo26I+nKMP9v93G4vNgWQzO99toQaITFupIlzT3JnZo+ECl/wczAjn1awS52gNaxuFPHMwex7rBuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VRcFkUezuEC4bQO7oaUQEFHFjhfH8x9QOrJR7mq/2SM=; b=CoujQXMa5BkR4iPPuMUHxhrIADMF+B5Q2uDD93dcmyCzu48gJmeppyeQNVbWpjst40taCwYh2t2oeFqCUky64OIOnBi+vcVTg6MAuVhJyGZ17NTMkxLHrwef0wUcGTQyAxul1t5785n1eWTUxYLoTQ7c6Vbh6ruwAt8FyKPSg77J1n0XKLNEd12x9k5qd99b3pGuxwuG9Y85YxsFplnsgEVhOUU8/9sNbZLwUu0RWeHSzpYv2DkumgUrz1oPGeX1uM5DGgu2mXAa9Kbnq1Wv7eNgh5bCLsYsfnayHLbMQ/lXEYpnQ1NttKz7p0Qg3VuaSbLbG7DpEAZjZLNjf5X6CA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VRcFkUezuEC4bQO7oaUQEFHFjhfH8x9QOrJR7mq/2SM=; b=AgdQ3wZgf8L8X8qLSC1u6eCVZ5rxKmksY5ymn8UDAuLQ6aB5M8TafKQ+1OKzm33SbiQaMN3jd8lLIybKIQu+9sLNEUp9BPA68s04wkYi5VDdu0XJYpJ9ZGU7FGtANu9pqzIs9rbxkLAd2NJk5FvZ3wIPCSC7311DuBm0CERyekQ= Received: from DS7PR05CA0092.namprd05.prod.outlook.com (2603:10b6:8:56::10) by BN6PR02MB2820.namprd02.prod.outlook.com (2603:10b6:404:fa::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Fri, 29 Apr 2022 08:14:37 +0000 Received: from DM3NAM02FT030.eop-nam02.prod.protection.outlook.com (2603:10b6:8:56:cafe::7d) by DS7PR05CA0092.outlook.office365.com (2603:10b6:8:56::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.6 via Frontend Transport; Fri, 29 Apr 2022 08:14:36 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com; Received: from xsj-pvapexch02.xlnx.xilinx.com (149.199.62.198) by DM3NAM02FT030.mail.protection.outlook.com (10.13.4.160) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5206.12 via Frontend Transport; Fri, 29 Apr 2022 08:14:36 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Fri, 29 Apr 2022 01:14:35 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Fri, 29 Apr 2022 01:14:35 -0700 Envelope-to: git@xilinx.com, linux-serial@vger.kernel.org, jirislaby@kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org Received: from [10.140.6.39] (port=57162 helo=xhdsgoud40.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1nkLlr-0002va-8O; Fri, 29 Apr 2022 01:14:35 -0700 From: Shubhrajyoti Datta To: CC: , , , , , Shubhrajyoti Datta Subject: [PATCH 3/7] tty: xilinx_uartps: Add check for runtime_get_sync calls Date: Fri, 29 Apr 2022 13:44:18 +0530 Message-ID: <20220429081422.3630070-4-shubhrajyoti.datta@xilinx.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220429081422.3630070-1-shubhrajyoti.datta@xilinx.com> References: <20220429081422.3630070-1-shubhrajyoti.datta@xilinx.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d66cefd8-777f-402d-5057-08da29b84d04 X-MS-TrafficTypeDiagnostic: BN6PR02MB2820:EE_ X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: j3AK1gWLoWQVtOVGmEqLzEUTs9BrwwsKaWgalwcZ2cYu9IRWVVHTlq1Ru+tCfv1aMRWi5AZluLl5UF2yWL0d5IT+YC1k0qbUDSfuYEq9FzHmLoGPjImuGFlMak62Srhuv7SIA0cDIS6SWzP4lQYt6BwLavwQjddRC8EVRkl0s0re+KMGLX49fufqMVVbNsJ2JzJm9KC0BkUfVvA8NyLQpJcnZuKkd0vIVrwMPtVnPBOYvU1uHkKozPur+fd0JqZeIvJABOhKwZ4CP6OE7pg/pYMsSJOh7i2LR54tl4I42FtximF6tvKNrtKOFaMTiTemoahnur5Lo9u6Im86z7dVEmSB7g78cg5/RHuRvN8TPwUIWBvNZl7pyg0yX7Vkc/ECgu7Nex9O/7tucCAx5fzvr6v29TDd4+X15gwUHYtf0kYMSkhCI2L7RQoVvco+rvuMDkPY3eROJ7uidldrTxFwFxraGGVtSGr+VE1c7eZ8/pGSBjqaq0j+iRMZV30IRlSaK2+SD6aO2likJJ9Gfv4HRtrlUchGU8tGVBas1A38iupSWSOpheCpv3Y6WWhNIE22Vut+6qTzWnZq58F7LJUmXyfJsCjU0Abb75j5oG2IxpSYB1ipvGRRz9ESehBDNVufAIv25hWbN5qmTj82Q+w+8EwDlvdUVmuNgk6OVqovg2NBElieA1tY9vdCtRl3cUkyXQ+3AomjWG7k2bNV8cL0yw== X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch02.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(4744005)(44832011)(54906003)(6916009)(5660300002)(9786002)(36756003)(2906002)(8936002)(356005)(508600001)(316002)(40460700003)(8676002)(70206006)(70586007)(4326008)(7636003)(6666004)(82310400005)(7696005)(83380400001)(36860700001)(26005)(186003)(2616005)(107886003)(1076003)(336012)(47076005)(426003)(102446001);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2022 08:14:36.8258 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d66cefd8-777f-402d-5057-08da29b84d04 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT030.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR02MB2820 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add a check for the return value of runtime get_sync calls. Addresses-Coverity: Event check_return. Signed-off-by: Shubhrajyoti Datta --- drivers/tty/serial/xilinx_uartps.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx= _uartps.c index 8f15fe24a0eb..868f4e587263 100644 --- a/drivers/tty/serial/xilinx_uartps.c +++ b/drivers/tty/serial/xilinx_uartps.c @@ -1100,13 +1100,17 @@ static void cdns_uart_poll_put_char(struct uart_por= t *port, unsigned char c) static void cdns_uart_pm(struct uart_port *port, unsigned int state, unsigned int oldstate) { + int ret; + switch (state) { case UART_PM_STATE_OFF: pm_runtime_mark_last_busy(port->dev); pm_runtime_put_autosuspend(port->dev); break; default: - pm_runtime_get_sync(port->dev); + ret =3D pm_runtime_get_sync(port->dev); + if (ret < 0) + dev_err(port->dev, "Failed to enable clocks\n"); break; } } --=20 2.25.1 From nobody Sun May 10 16:27:02 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A051C433EF for ; Fri, 29 Apr 2022 08:15:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355507AbiD2ISP (ORCPT ); Fri, 29 Apr 2022 04:18:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355472AbiD2ISB (ORCPT ); Fri, 29 Apr 2022 04:18:01 -0400 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam08on2063.outbound.protection.outlook.com [40.107.102.63]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12D48C0E56; Fri, 29 Apr 2022 01:14:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bougtOl+wDe5FB0ZZjeAxu2Asn/Edzz6lBdVMR96h4zU6JtaTT3ct3TDjUY4Y9EYVfH5mvM18WzoZgjM1bgm3CIFyOieLDrozFU/ioFao4cH6qN7ysHjaVicpe499eFgWjt5CAMfHStiBuMTbRT5Cn+96mLrCEvV6oLPVj/9K7/ACtnjV8OnGbQSAC8TcW/iP3WcDc+DcnaMsvZ2vs4vgyvVbEQDURaGuoCerMpY4BWNF1oPTepfcxKb1waizOQGIEvEzFiAmEJEHi9D657p05/qfpaJbdCv7Q/Idj4DnTOTtwa0FvDebgk3Wr9bMg/6q0I93/9O6Ke/J53mwYYLTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XNwHL25V79loRQlwOxLQEBNZTDVduKE5XoVza4jmxc8=; b=MlEi/+txmRYlTB6UmMRtMCDnVfUzLzAIt0q1iWcnhrHHnAkTOHgIQllKqP7EB9G8lklLRPoDq+KpwFqVnZswTDudqG5d+V/8Taj3DO6mqKCZkDLAoHcUys73YwFwRH6fUvDayPppEbz0nkpP2iQWG4NYmI4snVjOzrzh4J3xy6NRy50lKNOxnC6wYWP6SI+x4LGDZUGIM2tKbZYVTCmywH8lk/ANVQKxbGHXlegi3luhEA/Cq1/WHDkTe0XWJZPPeDT8bsQ9sRoHJdwEQtj3vUKeIMf6YvcGlPZEZk0PTWyrokWxgIDmzA/5s2RMevHalczg6cTIwUol3OYdFe80dQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XNwHL25V79loRQlwOxLQEBNZTDVduKE5XoVza4jmxc8=; b=GB07mMTUzonJQJZelAAGRBoMkyp9wLWyYxqreLz7fDzQo7WO1/4v5Wd1y+Eic7mWDKNOA8jp3pYG7+oZVMPCTM0vEMcI1MWhIvgsBALrBiZTeWOErzhatj6MDCKZFLU3Xzi5C7TOTU8UR606Yoq6ss5dsbX/5sIvN/SK71f/alA= Received: from DM6PR07CA0077.namprd07.prod.outlook.com (2603:10b6:5:337::10) by BY5PR02MB6115.namprd02.prod.outlook.com (2603:10b6:a03:1b2::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Fri, 29 Apr 2022 08:14:40 +0000 Received: from DM3NAM02FT051.eop-nam02.prod.protection.outlook.com (2603:10b6:5:337:cafe::c1) by DM6PR07CA0077.outlook.office365.com (2603:10b6:5:337::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14 via Frontend Transport; Fri, 29 Apr 2022 08:14:40 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com; Received: from xsj-pvapexch02.xlnx.xilinx.com (149.199.62.198) by DM3NAM02FT051.mail.protection.outlook.com (10.13.4.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5206.12 via Frontend Transport; Fri, 29 Apr 2022 08:14:40 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Fri, 29 Apr 2022 01:14:38 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Fri, 29 Apr 2022 01:14:38 -0700 Envelope-to: git@xilinx.com, linux-serial@vger.kernel.org, jirislaby@kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org Received: from [10.140.6.39] (port=57162 helo=xhdsgoud40.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1nkLlu-0002va-3h; Fri, 29 Apr 2022 01:14:38 -0700 From: Shubhrajyoti Datta To: CC: , , , , , Shubhrajyoti Datta Subject: [PATCH 4/7] tty: xilinx_uartps: Check clk_enable return value Date: Fri, 29 Apr 2022 13:44:19 +0530 Message-ID: <20220429081422.3630070-5-shubhrajyoti.datta@xilinx.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220429081422.3630070-1-shubhrajyoti.datta@xilinx.com> References: <20220429081422.3630070-1-shubhrajyoti.datta@xilinx.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3ea99b49-20c2-4d2c-d40d-08da29b84f20 X-MS-TrafficTypeDiagnostic: BY5PR02MB6115:EE_ X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1okMVk85lnN6QjOA4pfro5+z45i4LlZyDaseeiYU8462+j78DoU/3ku0sPbszdf5esDKrLGH+lutGqmMC2tsAC1ovPd2eTM3Ov6qA/NQAJKY+XwUvos84/JsexRkPjIL/aDvVR9jtZaGphudICecSUgpv9qMPW1SgbqzUkczD18ICitOhWUoXS8hMmS44qt5tVH9rZ02tBqYn4DU2FMeeDtr+BHUZV5wYPpr2DTVVc06qdATStnZfOkHpkEMjRtfWeCseBydohxcv8iXos+hSfvvdi23MucpWD00K9nmd1bgRP3iYYXOsbf7sySMnQElsgEtyMR34Ju/syNSm6908UOe3HKpmlp8nwf28Cg1Mcz/sDsy9btMTqz4GdmeCXZHfgGyB+BtHc0cpQOw6TzO2Ndog9Mz3SDsXD3BtDRJ7jNUGGv5vWGIDpCOBro6prjFeSUEfI5YCMojLPzDXam1cD63ow2xYfJ2UJItj+uUzN9DqXR347RpnmxwM9S7QIuSLt/Joe6lBzci1Z837AnMhjMhy57i2BRneLuhGAEFttIOAihs56gDV8L5wtsDizSGDOSPZKzFxqPXaYpjaeE+gIGSReh5d5+dEQhUUb78Ihy6Eoe98PNr68vbE9fOagrudNjoMlm99D3sX5xkhiWZij7EQJYNxhLBo6EVA8Yl8USijvJRIpu3uqirXaVPvqxKH5jKmodJoyX1PTdHa5XCWQ== X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch02.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(508600001)(336012)(54906003)(316002)(82310400005)(8676002)(7636003)(2616005)(9786002)(47076005)(6916009)(426003)(107886003)(186003)(1076003)(70586007)(70206006)(4326008)(83380400001)(36756003)(40460700003)(44832011)(26005)(356005)(4744005)(2906002)(36860700001)(8936002)(7696005)(6666004)(5660300002)(102446001);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2022 08:14:40.3838 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3ea99b49-20c2-4d2c-d40d-08da29b84f20 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT051.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR02MB6115 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Check for the clock enable return value. Addresses-Coverity: Event check_return. Signed-off-by: Shubhrajyoti Datta --- drivers/tty/serial/xilinx_uartps.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx= _uartps.c index 868f4e587263..bf0415f0a194 100644 --- a/drivers/tty/serial/xilinx_uartps.c +++ b/drivers/tty/serial/xilinx_uartps.c @@ -1347,12 +1347,18 @@ static int cdns_uart_resume(struct device *device) unsigned long flags; u32 ctrl_reg; int may_wake; + int ret; =20 may_wake =3D device_may_wakeup(device); =20 if (console_suspend_enabled && uart_console(port) && !may_wake) { - clk_enable(cdns_uart->pclk); - clk_enable(cdns_uart->uartclk); + ret =3D clk_enable(cdns_uart->pclk); + if (ret) + return ret; + + ret =3D clk_enable(cdns_uart->uartclk); + if (ret) + return ret; =20 spin_lock_irqsave(&port->lock, flags); =20 --=20 2.25.1 From nobody Sun May 10 16:27:02 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EC50C433EF for ; Fri, 29 Apr 2022 08:15:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355568AbiD2ISY (ORCPT ); Fri, 29 Apr 2022 04:18:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355492AbiD2ISO (ORCPT ); Fri, 29 Apr 2022 04:18:14 -0400 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2071.outbound.protection.outlook.com [40.107.223.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16EF4C12F8; Fri, 29 Apr 2022 01:14:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZlHIK2W/+wygmbeuvyyBXv2MLDScRmrseWvuNFMKytCb5x0a82dRa70WN6jtWQ4wOW9MY78vQ6C8S1YZp/mf+EExcgq5ze3ozSZnvK/aaOJvwbK7gYHm0Ux+v+syQdYHahKQG5AlOmK1a4ziHwxJymGXeq/fD0cgIx+jmDlr9KSw/+Jrwh5CO2RZabo/mMsXIQvrUP/2CU4UCsj1ORD9fWFU+LuRAZEdLtkGa4Tk0Q42J7jq6Ky83Z39sBWjHO86zcm3zNdGG1v3cmgz0wLfVzmsipOwy6bsySjEGIB5JzAAbwmxfC0PopbXrnpfDa3EH7m/1ARfOEMUJq4/jJaOUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IQDuRxH8m33avCNscVJb8jg0A2Q0IIxpabJvOg8s1xg=; b=HcG7s+p/HVQqKcKlFOtvPNgD4X0DvcULOTR6EZMDjy9s1cBaaPHmKn1QHXN9ZJfxNNOAVD5rdQ6Ol0lsIEQ+Il4+naeNu10e+nCR5SHnhMRIMhmVyKDKSbQhrCiJA0GITAGHaUfev5jJFh49eiLP+G1pLNCh1pnro4DZmTMLiHKmRzHMS68pSunZyoEuYwyonb8qhvDPGXD3eBVuFMcx03qgbBMnXCRJyqUOUabxiwlIML0lN+KN+fNwSTECIjebzqk0ooKIDdQxrpW40rGv7LjmYEPQwEbEBF2v6EBtI+aL0+uNmxq/YpdrrPpPYN5mAZLl3O5QOtsGu6tzprVqSQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IQDuRxH8m33avCNscVJb8jg0A2Q0IIxpabJvOg8s1xg=; b=Xpeg8CwoKH0klq/S4LIGskpUw3EJ0JsG7WhSLivmLo2wFueoPbqVY4DTOpaIRO40F6/8s6MbhVgHh2OBt/nIfgFBTijMTn75MgMlcx5bzfHwpqU2jfCZgpeaGHhjGh921+Sf4PtAoNmels/oTMcvkQlzN2CCVCr4QiqjdeQEwSM= Received: from DM6PR07CA0082.namprd07.prod.outlook.com (2603:10b6:5:337::15) by PH0PR02MB8616.namprd02.prod.outlook.com (2603:10b6:510:104::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Fri, 29 Apr 2022 08:14:44 +0000 Received: from DM3NAM02FT059.eop-nam02.prod.protection.outlook.com (2603:10b6:5:337:cafe::e6) by DM6PR07CA0082.outlook.office365.com (2603:10b6:5:337::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.23 via Frontend Transport; Fri, 29 Apr 2022 08:14:44 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com; Received: from xsj-pvapexch02.xlnx.xilinx.com (149.199.62.198) by DM3NAM02FT059.mail.protection.outlook.com (10.13.4.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5206.12 via Frontend Transport; Fri, 29 Apr 2022 08:14:44 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Fri, 29 Apr 2022 01:14:41 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Fri, 29 Apr 2022 01:14:41 -0700 Envelope-to: git@xilinx.com, linux-serial@vger.kernel.org, jirislaby@kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org Received: from [10.140.6.39] (port=57162 helo=xhdsgoud40.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1nkLlw-0002va-Pu; Fri, 29 Apr 2022 01:14:41 -0700 From: Shubhrajyoti Datta To: CC: , , , , , Shubhrajyoti Datta Subject: [PATCH 5/7] tty: xilinx_uartps: Make the timeout unsigned Date: Fri, 29 Apr 2022 13:44:20 +0530 Message-ID: <20220429081422.3630070-6-shubhrajyoti.datta@xilinx.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220429081422.3630070-1-shubhrajyoti.datta@xilinx.com> References: <20220429081422.3630070-1-shubhrajyoti.datta@xilinx.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 901afdaf-193a-4aa0-bc95-08da29b85159 X-MS-TrafficTypeDiagnostic: PH0PR02MB8616:EE_ X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PkeGGAG8l6fDr5enT2xXF3/TYCo5wpPaeYQlHvH4m6ECqaE6VfFQaraxcol7v0HbsAs55WdRu540sxPplRVNYuX0frKY793u1B9cs7BhGJhS/rxE5qZdCWaG3mwdJXDdgEyMuQZir27B3AVw4V/CPkxodCt4ry+ZLPPqqdx8a4TS82Rt3/fMyOFUfFgvJ+WURWi+upjeFfti4I9tkYwJLjkBEeMg/n+LCBrSMZeTQ7Nzbn13oQKCM9/9tWGuBzwwCgtKvIaE3yB7gPw5mMucfJ1lJiKdQVP1R++YMTM77lcNgoFDhVaZHwm9ekzqUGy/Y1rXk02nDEX82PcfUUNAD17MyJEpI/E82X2UA3tQxX/RX6yJO7/f3Y8zI67TCNbuN4ujkUxNATZTNWkzJqdABd8vpqerRgptS2vt2DkeRkyH6Vd0VUCY2uqO5iA09TZU4qZBF/c+4ZHAkHSaoBvnsr8Bx4Sk65MtPGLVumOFaVeK1aSC7ehTmUjtNODt5qpZ/gg8PQCmUpfJpqhCTOMbNQ6PQTK4CKyClN2mUyCndtBM16/VMA1Atbcmsrb6SwfFAtn9oAJwMgdxJjy66nrnHc7wLyPoeVT1AScMFpekpj4KZR8Yu+uFSjB9qWuPqm2WT0VZ3tjc71dZ8GuLcL/idKmRhyhd/dcuC0U65r0OW604pta9g4HUr3AvQRtFjTt9Etpr4AUJQZ44qTbUeSMogA== X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch02.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(47076005)(6916009)(316002)(83380400001)(36756003)(54906003)(36860700001)(426003)(336012)(2616005)(2906002)(70586007)(70206006)(1076003)(4326008)(186003)(8676002)(356005)(107886003)(6666004)(82310400005)(508600001)(7636003)(44832011)(40460700003)(8936002)(26005)(9786002)(5660300002)(4744005)(7696005)(102446001);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2022 08:14:44.0965 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 901afdaf-193a-4aa0-bc95-08da29b85159 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT059.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR02MB8616 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The timeout cannot be negative make it unsigned. Also the same for the trigger level. Addresses-Coverity: Event incompatible_param. Signed-off-by: Shubhrajyoti Datta --- drivers/tty/serial/xilinx_uartps.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx= _uartps.c index bf0415f0a194..289d70914956 100644 --- a/drivers/tty/serial/xilinx_uartps.c +++ b/drivers/tty/serial/xilinx_uartps.c @@ -34,12 +34,12 @@ #define TX_TIMEOUT 500000 =20 /* Rx Trigger level */ -static int rx_trigger_level =3D 56; +static uint rx_trigger_level =3D 56; module_param(rx_trigger_level, uint, 0444); MODULE_PARM_DESC(rx_trigger_level, "Rx trigger level, 1-63 bytes"); =20 /* Rx Timeout */ -static int rx_timeout =3D 10; +static uint rx_timeout =3D 10; module_param(rx_timeout, uint, 0444); MODULE_PARM_DESC(rx_timeout, "Rx timeout, 1-255"); =20 --=20 2.25.1 From nobody Sun May 10 16:27:02 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3FD2C433EF for ; Fri, 29 Apr 2022 08:15:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355540AbiD2ISU (ORCPT ); Fri, 29 Apr 2022 04:18:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355493AbiD2ISO (ORCPT ); Fri, 29 Apr 2022 04:18:14 -0400 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2061.outbound.protection.outlook.com [40.107.223.61]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB836C12FA; Fri, 29 Apr 2022 01:14:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GXxQ57hpEA0Cv6/9QljVs3qQbHQ9Qg60vSMPOmuozjM4VTIAAnGKN7LvCZ0rNrVepxtd+Dl+7kLi3HHQzuR+9NjaC4DssUOg6N9VZDOaIo/vnQdZV4xUD8uIB2mvHExnIMZyoueB82/fHq6aS36+TyHd4SNFL4AqKRapnYDM11swJvkmRz2KSv/hY6F97HLshL4AXK6hBuwbEvQhYcjsx2IVjBYEVFRD0tOdbwpdPi/uaXmy3013wH0hF+4J85WVnE4V6ogbnI9P7mguXUrIS0Dp655tfT4SiYQMhRIgi8bLOc/jTiUun+YIH/s7aQYKbEFJZ/M8nG/aCqdOEf9bfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ALpDvbk+lwlvTNbAlgghVYW+35HeBUF2Gv9Zh3WfU+Q=; b=OKLQTPsugKIawrcLXC7su1O/9IDD4q23TmWeaOmWYbegLDd+JTezhX+MEhsPHSiRjSBMa44XWTV69bhrMqQNj4Eq0ePP/7veOPJbSSaJ0Q9PIVlAtIcMNZP9gJy2CyvfEfTuW/X9tFv4ZJ5qbatNF7E/RJvn2I44uHSIB+EM8Lw8B3gwM9+Ki1f3VpDbvWvGwh4AICN3XT8A1yIVtL1YaucECDiZlmPRRMp8vC7bByeY2/wDEQLoWoaG4eNJkRLNKWrzPdPXA4AlIi/Z0tiBRf4TN2kDofWvAUmDwu79+8MpuZZNR6+bGXmIjmbmK8YCtC3dHd44Megx20X55zyh2Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ALpDvbk+lwlvTNbAlgghVYW+35HeBUF2Gv9Zh3WfU+Q=; b=ZTY49dX8F7rsILprR/bZ2jj3/fTQHKfWqQtsjGMlVof2sSezMKR1TTp7ezXUH0BoBj5aPKGQXXmV4UolCM0Z6COgdhFTMYrSwZVOq48UbhD2HH8ky/zDXt1o0zArqcE2yC3cR2omEKUgyC2h2fBE+oRJ8dqbN910HVcVDf8obks= Received: from DM6PR07CA0089.namprd07.prod.outlook.com (2603:10b6:5:337::22) by PH0PR02MB8859.namprd02.prod.outlook.com (2603:10b6:510:df::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.23; Fri, 29 Apr 2022 08:14:45 +0000 Received: from DM3NAM02FT059.eop-nam02.prod.protection.outlook.com (2603:10b6:5:337:cafe::8) by DM6PR07CA0089.outlook.office365.com (2603:10b6:5:337::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15 via Frontend Transport; Fri, 29 Apr 2022 08:14:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com; Received: from xsj-pvapexch02.xlnx.xilinx.com (149.199.62.198) by DM3NAM02FT059.mail.protection.outlook.com (10.13.4.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5206.12 via Frontend Transport; Fri, 29 Apr 2022 08:14:44 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Fri, 29 Apr 2022 01:14:44 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Fri, 29 Apr 2022 01:14:44 -0700 Envelope-to: git@xilinx.com, linux-serial@vger.kernel.org, jirislaby@kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org Received: from [10.140.6.39] (port=57162 helo=xhdsgoud40.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1nkLlz-0002va-If; Fri, 29 Apr 2022 01:14:44 -0700 From: Shubhrajyoti Datta To: CC: , , , , , Shubhrajyoti Datta Subject: [PATCH 6/7] serial: uartps: Fix the ignore_status Date: Fri, 29 Apr 2022 13:44:21 +0530 Message-ID: <20220429081422.3630070-7-shubhrajyoti.datta@xilinx.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220429081422.3630070-1-shubhrajyoti.datta@xilinx.com> References: <20220429081422.3630070-1-shubhrajyoti.datta@xilinx.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5b5e8425-caea-4a74-b414-08da29b851d5 X-MS-TrafficTypeDiagnostic: PH0PR02MB8859:EE_ X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gJifvjVU9I64qGovgnNNvmpXI/eAukGOklhM73RoW71X90SD4x+TkTZKnBBXGxYyGhbYY2Nadrlf1N/jvJXVWHUzDZ6V/k5n91RVQ3vKACHtulswTmol1BLMxnjCJwaiYZ5qpAr3r0ROmTQ39EzVdpx5PoYV248JhGd6H8WNMiFEvjTckE3Au9Ic4zYU7dr7Jc/Sw2dSoQq6VfGFwjOSjyXny8ZaxgScXXwrfd6/q0/mYo2ecet9wO8uD0H/mIzGEy3bhKVz6G2HmgZ+ID+oZ7R8rNDdAvtu/vS0myz0CTSmSkHZ7+qeyJBOm00TdIRJHHwhlZg4PNsErUlgAqG8d/1q9Dz61hEBYtBbtR8kw/sx1EdQSC9dmanU/6l9z4INaoD/hK9C2X3MZBJiB0kaG6FSPyMKLAm84lVqp4Qf4Df57ncQfi7Q6IVEF43oNNYfVWIN9KhhTdT3wDKmm47Avz9k8KlnIElZqtMBOPzyG37/V5ib94mmEilTMwyClvxDl3UhLQQj+zzGKzRJ375edho1UvlKzeqsEZkeOXxFSxCGvZ2R0zC4h0wtZ1cxBrzVHuLe/xOp/0qw3DvDGa6T5WKRdzsa3GzzuUELDK4oK6plm3gNaieIfD15aGjCE07QwBEvts9Y2vK+cLWBQ1Zpxwvo95IZJrj7DdcyRNR71aLuEIgABMBZTrb2bo1RAmTP0ytCxeZQLKbGSzTvzu2uqA== X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch02.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(426003)(1076003)(26005)(6666004)(70586007)(336012)(7696005)(82310400005)(47076005)(316002)(107886003)(186003)(70206006)(40460700003)(44832011)(8676002)(356005)(5660300002)(4326008)(2616005)(508600001)(83380400001)(7636003)(54906003)(2906002)(6916009)(36756003)(8936002)(9786002)(36860700001)(102446001);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2022 08:14:44.9246 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5b5e8425-caea-4a74-b414-08da29b851d5 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT059.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR02MB8859 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Currently the ignore_status is not considered in the isr. Also the ignore_status is not updated in the set_termios. Signed-off-by: Shubhrajyoti Datta --- drivers/tty/serial/xilinx_uartps.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx= _uartps.c index 289d70914956..81ba69c57716 100644 --- a/drivers/tty/serial/xilinx_uartps.c +++ b/drivers/tty/serial/xilinx_uartps.c @@ -375,6 +375,8 @@ static irqreturn_t cdns_uart_isr(int irq, void *dev_id) isrstatus &=3D ~CDNS_UART_IXR_TXEMPTY; } =20 + isrstatus &=3D port->read_status_mask; + isrstatus &=3D ~port->ignore_status_mask; /* * Skip RX processing if RX is disabled as RXEMPTY will never be set * as read bytes will not be removed from the FIFO. @@ -1583,6 +1585,8 @@ static int cdns_uart_probe(struct platform_device *pd= ev) port->dev =3D &pdev->dev; port->uartclk =3D clk_get_rate(cdns_uart_data->uartclk); port->private_data =3D cdns_uart_data; + port->read_status_mask =3D CDNS_UART_IXR_TXEMPTY | CDNS_UART_IXR_RXTRIG | + CDNS_UART_IXR_OVERRUN | CDNS_UART_IXR_TOUT; cdns_uart_data->port =3D port; platform_set_drvdata(pdev, port); =20 --=20 2.25.1 From nobody Sun May 10 16:27:02 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3DA8C433F5 for ; Fri, 29 Apr 2022 08:15:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355523AbiD2ISa (ORCPT ); Fri, 29 Apr 2022 04:18:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54368 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355511AbiD2ISR (ORCPT ); Fri, 29 Apr 2022 04:18:17 -0400 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2089.outbound.protection.outlook.com [40.107.237.89]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 348D7C1C93; Fri, 29 Apr 2022 01:14:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ixxGVJg7yC9xr85fXtNEHDUplI9e3n0uRk9PTFnToKo42j1+GknT2dlJ3JqrkZ2ASWNG4Uv551ZjQgYmMD2xX1RwY6k8VggIB/ia96U1HfnMqnRK7r9ofruuPz8GAVp3Rwrh+UpPlwioyOBd4VB+UzeyLkFziGSUWMXfrneRZmBFPTYSkAGvq7QpyO+QRlsQ89fZFZGFUpExFjqqWLzQ4cv2UUuY3IdQvTIeabitmfTmPMAyni6dIr9U96TY2pcQOf0Ge6kRo3PGy0ZJubv7AKiHp/xpsxoQKpBVWbX/8g+lbeJQMtksjTnl6nIUZfoDzUT6/LLxMacRQVQpoKAtKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h0JR+Ld875QtK7uCHk/VvJELmf4Jh3QYwyk3H6BEAxg=; b=eK9Z8V1KsMUx/Yw2GaEX8auedKc8Fb20dPTtdI85Bdb83cwii/jnBABcUn2bl9Kmk1TCRS++49uKbzkghM1n2qpz6lTVKKUpF35VDbrejvcKj6TB997wApKNia7aJJFOauTX/9iApvzW0fxp6RVbMKGdbDx82+YTuSx4wVbHzseeWoWfYBRDtz9LAhrlfdLBjQwlPUVRe5c08ZsSWLrrJXP77KMsgzrp9Zy1uz/wzfl6NjkqKDrUwiLUKZmrPtW9m9OJ4Cu9M8FOVkByBT5EUO6X+IRGhEWt0FYVeyZDB3yhWQVDb4qWoQCL/jxXSJXeXUPPSyeD81KUb32glE2Q9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h0JR+Ld875QtK7uCHk/VvJELmf4Jh3QYwyk3H6BEAxg=; b=g+nshG7BjJfPItRlthZDjb4BpMnpkMeYHxyvEHjhUQvHmO2J2dReQnkIGRxtwnH9LgCly39l55/Lpw8tyav301j7JR8quOwodxg3RKuqThXrGVN/f5Spb3gikj/ZGe+ishDB2KHGgFQlbvz8Ut9QqfOZImOszIjv6L6KvSjMinI= Received: from DM6PR06CA0045.namprd06.prod.outlook.com (2603:10b6:5:54::22) by DM6PR02MB6587.namprd02.prod.outlook.com (2603:10b6:5:220::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Fri, 29 Apr 2022 08:14:49 +0000 Received: from DM3NAM02FT028.eop-nam02.prod.protection.outlook.com (2603:10b6:5:54:cafe::c5) by DM6PR06CA0045.outlook.office365.com (2603:10b6:5:54::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14 via Frontend Transport; Fri, 29 Apr 2022 08:14:49 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com; Received: from xsj-pvapexch02.xlnx.xilinx.com (149.199.62.198) by DM3NAM02FT028.mail.protection.outlook.com (10.13.4.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5206.12 via Frontend Transport; Fri, 29 Apr 2022 08:14:49 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Fri, 29 Apr 2022 01:14:46 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Fri, 29 Apr 2022 01:14:46 -0700 Envelope-to: git@xilinx.com, linux-serial@vger.kernel.org, jirislaby@kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org Received: from [10.140.6.39] (port=57162 helo=xhdsgoud40.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1nkLm2-0002va-9f; Fri, 29 Apr 2022 01:14:46 -0700 From: Shubhrajyoti Datta To: CC: , , , , , Shubhrajyoti Datta Subject: [PATCH 7/7] serial: uartps: Prevent writes when the controller is disabled Date: Fri, 29 Apr 2022 13:44:22 +0530 Message-ID: <20220429081422.3630070-8-shubhrajyoti.datta@xilinx.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220429081422.3630070-1-shubhrajyoti.datta@xilinx.com> References: <20220429081422.3630070-1-shubhrajyoti.datta@xilinx.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b7fbfb7d-a8f9-4a53-5638-08da29b8546c X-MS-TrafficTypeDiagnostic: DM6PR02MB6587:EE_ X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FA4kICjiykfk0aX870u6q2sE+WGXc7GRfg6khnkKH+TVoMMe52ElFKb5ln1ilIPzZHUFIC3pFLF0PRNS5jyiQcLMssTswMmeSDZOHCwbDcIH8TUa57wZPigz3RarVLeXEz+5yaUzBIhIW8RJpzSA53txiINBAroBnx96+v34eZSOj61fG7B/W70+IWwjhnu0OmG11QtrFD6ui7RytqWqZP10ntkiHXwXgE9ivFW5mfAtWpEmPneQYY7MhJsF8VFtL/OnBTjjCxgDd2MxKSOt9Y4oQx13gc9OR+PFgynI6NEE46CoCKaA7Gz4yPlzk+LLQSD5gFzi3Yr1dpJhrbX/fys1UOy6/wyUqNFA3Ytlx/Fz3uh/Yf1JZcf0ETIfTEE96Gv+QArkBKqRQT77BE8YOs2g2UL6513ICzRMAmhVSoVwZQCmFCuFYej6V0zWAtLJDdYPf4vtBKWRzyXj3zCwMS2Oa9UjqOvsqAG1DuwAHDdWf6zTgEmwH/n07MpAZih8YO/63U5aMSmtrrwGmP/sHS9ldNTL8WbqiP+BbD+QwL8kZYx8OxlG3S0+1BTzSaxafo440/pmigPXN9UiklrA8uF0F6b1+kigFF5QKtCVaYRARCzhsT7bdwutyPaWJgvYg3811Fpgu4rXwRWaC1w4Szv5FM7e+Je3HwRwBTDQFZGsMlmTboi9uVR2A17lkNdtmRtq2q8PciOW2l93Uj2c6Q== X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch02.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(54906003)(82310400005)(6916009)(36860700001)(336012)(83380400001)(316002)(26005)(186003)(7636003)(36756003)(47076005)(426003)(44832011)(1076003)(40460700003)(508600001)(107886003)(8676002)(70206006)(2616005)(6666004)(2906002)(5660300002)(4744005)(4326008)(7696005)(9786002)(8936002)(356005)(70586007)(102446001);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2022 08:14:49.2516 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b7fbfb7d-a8f9-4a53-5638-08da29b8546c X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT028.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR02MB6587 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Prevent writing to the fifo if the controller is disabled. Signed-off-by: Shubhrajyoti Datta --- drivers/tty/serial/xilinx_uartps.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx= _uartps.c index 81ba69c57716..f629c4ca940f 100644 --- a/drivers/tty/serial/xilinx_uartps.c +++ b/drivers/tty/serial/xilinx_uartps.c @@ -1150,6 +1150,13 @@ static struct uart_driver cdns_uart_uart_driver; */ static void cdns_uart_console_putchar(struct uart_port *port, unsigned cha= r ch) { + unsigned int ctrl_reg; + + ctrl_reg =3D readl(port->membase + CDNS_UART_CR); + while (ctrl_reg & CDNS_UART_CR_TX_DIS) { + ctrl_reg =3D readl(port->membase + CDNS_UART_CR); + cpu_relax(); + } while (readl(port->membase + CDNS_UART_SR) & CDNS_UART_SR_TXFULL) cpu_relax(); writel(ch, port->membase + CDNS_UART_FIFO); --=20 2.25.1