From nobody Tue Jun 9 22:02:59 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FC06C4167B for ; Mon, 25 Apr 2022 21:07:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245664AbiDYVKZ (ORCPT ); Mon, 25 Apr 2022 17:10:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48246 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245534AbiDYVKU (ORCPT ); Mon, 25 Apr 2022 17:10:20 -0400 Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E6F7164738 for ; Mon, 25 Apr 2022 14:07:13 -0700 (PDT) Received: by mail-pj1-x102c.google.com with SMTP id t11-20020a17090ad50b00b001d95bf21996so462743pju.2 for ; Mon, 25 Apr 2022 14:07:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7pa6zrNLxEFTJIYew9I+MslyE/BqjUU2Vfh9xpblR54=; b=Shoz3tJtEfbeJHLbZbbAtm+y0n+qLrUd1IsVnLxx+HlgH0lU5Bzat9UjXBvtUxxkcZ fWVUxh4HAjy8+bLXQnIQG4pqK/T/ki1Ts5oXpNSWDKVq5nlj2zefrPxGz04zSJctnqww MdFeL7gkO8jwSYpuKBh4ELKQF7TnQPSYm6R2w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7pa6zrNLxEFTJIYew9I+MslyE/BqjUU2Vfh9xpblR54=; b=pbxoZ9PCTJtyKJTrMQcQePIJY/iJKQB/g0yvzUgWK7zEszRvEn6b8QdYMQqbO6Ely2 BeMhhmp4VfwMHOsC8HuU/y9Ca7iEM60HY2C1Wsa2MDuhRVsNawvK6CsKqGWITGoZ7Ec/ yOFsipU3flwmuVGrn4IDdG8JoYyNUeZdQAXj78iFl+dUdRJeihm64P/BpqhPQWCJmwtv nHMBRaeByqqFhNVoz4z6Jzt9z/AP2YNzMC7NYjUkzuGoQBN+86WJtJ/WZk9MuZsQUQqa O8PCakPrMT6vL+U+ABRySEPA4lUiL1/lA9JeGiaJtFoZ22SQnvUU9CWa+KqXnTseO6Rr Pd4A== X-Gm-Message-State: AOAM533R3EjbxZUSWBLni+6dBViV1YfFVioYK/rQxa2/4+TYhGlC8wjt BTGuLBAy6xxlzUpC6jcScoxV7w== X-Google-Smtp-Source: ABdhPJx+uxbkSaPe2+0BH9EheOMTgYzUOtVzJymppogmrFVLTMjQ1PWdb8ch86SegBtXfRZtKHInSQ== X-Received: by 2002:a17:902:cf0f:b0:15a:24e0:d9b0 with SMTP id i15-20020a170902cf0f00b0015a24e0d9b0mr19745380plg.42.1650920833478; Mon, 25 Apr 2022 14:07:13 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:201:b820:7f63:f3dd:3da]) by smtp.gmail.com with ESMTPSA id b20-20020a62a114000000b0050d231e08ffsm8523202pff.37.2022.04.25.14.07.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Apr 2022 14:07:13 -0700 (PDT) From: Douglas Anderson To: Bjorn Andersson , Vinod Koul , Rob Herring , Dmitry Baryshkov , Rob Clark Cc: Abhinav Kumar , linux-phy@lists.infradead.org, Stephen Boyd , dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Kishon Vijay Abraham I , Sankeerth Billakanti , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, quic_kalyant@quicinc.com, Kuogee Hsieh , Douglas Anderson , Daniel Vetter , David Airlie , Rob Clark , Sean Paul , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] dt-bindings: msm/dp: List supplies in the bindings Date: Mon, 25 Apr 2022 14:06:42 -0700 Message-Id: <20220425140619.1.Ibfde5a26a7182c4b478d570c23d2649823ac2cce@changeid> X-Mailer: git-send-email 2.36.0.rc2.479.g8af0fa9b8e-goog In-Reply-To: <20220425210643.2420919-1-dianders@chromium.org> References: <20220425210643.2420919-1-dianders@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" We're supposed to list the supplies in the dt bindings but there are none in the DP controller bindings. Looking at the Linux driver and existing device trees, we can see that two supplies are expected: - vdda-0p9-supply - vdda-1p2-supply Let's list them both in the bindings. Note that the datasheet for sc7280 doesn't describe these supplies very verbosely. For the 0p9 supply, for instance, it says "Power for eDP 0.9 V circuits". This this is obvious from the property name, we don't bother cluttering the bindings with a description. Signed-off-by: Douglas Anderson Reviewed-by: Sankeerth Billakanti --- .../devicetree/bindings/display/msm/dp-controller.yaml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.ya= ml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml index cd05cfd76536..dba31108db51 100644 --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml @@ -76,6 +76,9 @@ properties: "#sound-dai-cells": const: 0 =20 + vdda-0p9-supply: true + vdda-1p2-supply: true + ports: $ref: /schemas/graph.yaml#/properties/ports properties: @@ -137,6 +140,9 @@ examples: =20 power-domains =3D <&rpmhpd SC7180_CX>; =20 + vdda-0p9-supply =3D <&vdda_usb_ss_dp_core>; + vdda-1p2-supply =3D <&vdda_usb_ss_dp_1p2>; + ports { #address-cells =3D <1>; #size-cells =3D <0>; --=20 2.36.0.rc2.479.g8af0fa9b8e-goog From nobody Tue Jun 9 22:02:59 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69CDCC433EF for ; Mon, 25 Apr 2022 21:07:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245675AbiDYVKa (ORCPT ); Mon, 25 Apr 2022 17:10:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245583AbiDYVKU (ORCPT ); Mon, 25 Apr 2022 17:10:20 -0400 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01EF264BF8 for ; Mon, 25 Apr 2022 14:07:16 -0700 (PDT) Received: by mail-pl1-x636.google.com with SMTP id b12so13561754plg.4 for ; Mon, 25 Apr 2022 14:07:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fYD/F2OSbA7Q4eCV40OrtxHiQtAfyrFTFEIn6t3W6f8=; b=WvFR64qpnd4yCLm8ubU/W/DeKgWVe5sf1D05fbZmkSyTq8yGSG6v5hnDff1XSYazp6 83XXw1NiHbANd+TaAV+ZBDA2iYhNtL67l2+aocpmUGDCinB5/oxcsmHaIHzPCmL0lSdx g5TTDnxbPbEk7GACTTB9R3BKu9hJsSL5XH2GA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fYD/F2OSbA7Q4eCV40OrtxHiQtAfyrFTFEIn6t3W6f8=; b=noLkxmtk/RSYGdCL4kYnpZKIvlXIZwB2qwFl+OQAXXfWuYtc9/2jFFklkQazZtLeb0 W+5Pj/vAlMbnt9ByWYJyepqT8HEELwD8hY5Lk2qOw2GfbEUnsfDZMyl6ckeqC1X9bMCH n6x+G8EkFaDxa0lrzHChbrASAkxoWy83560RhFqhQS8Vr9RwxsNe2V8dVMAxN+Okhy2Q FGyTO829Zu1CgEcpyIY1LdbLj2R2QbGOTVWfatKu2CmO+ojTbAQJdx7HqpZSvCZP1Xop LO99CuqHjMxhsuCiQcIM7iX6QeP30BRhR4ZY7ZKnpHYaLQbNOVK0FiEMnluzmF+j/6EY LTuA== X-Gm-Message-State: AOAM533c4w1kGkKUJ4ayZgk1Q1nRFAay8N/QYA7LHzhlD9zh3Cr58LtA kfm4bK9H08OjyZ1Qt/m95k8N8Q== X-Google-Smtp-Source: ABdhPJyG9Xx7/t8cUKO2ub7bBhrSNggYmBrlKgygY827SF0gU8Mp7i0d+ErwAnNSiBQq7WdPpARN0w== X-Received: by 2002:a17:902:ed89:b0:15a:d3e:ada6 with SMTP id e9-20020a170902ed8900b0015a0d3eada6mr20094621plj.94.1650920835532; Mon, 25 Apr 2022 14:07:15 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:201:b820:7f63:f3dd:3da]) by smtp.gmail.com with ESMTPSA id b20-20020a62a114000000b0050d231e08ffsm8523202pff.37.2022.04.25.14.07.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Apr 2022 14:07:15 -0700 (PDT) From: Douglas Anderson To: Bjorn Andersson , Vinod Koul , Rob Herring , Dmitry Baryshkov , Rob Clark Cc: Abhinav Kumar , linux-phy@lists.infradead.org, Stephen Boyd , dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Kishon Vijay Abraham I , Sankeerth Billakanti , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, quic_kalyant@quicinc.com, Kuogee Hsieh , Douglas Anderson , Andy Gross , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] dt-bindings: phy: List supplies for qcom,edp-phy Date: Mon, 25 Apr 2022 14:06:43 -0700 Message-Id: <20220425140619.2.Iae013f0ff4599294189f3a6e91376fad137bbabf@changeid> X-Mailer: git-send-email 2.36.0.rc2.479.g8af0fa9b8e-goog In-Reply-To: <20220425210643.2420919-1-dianders@chromium.org> References: <20220425210643.2420919-1-dianders@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" We're supposed to list the supplies in the dt bindings but there are none in the eDP PHY bindings. Looking at the driver in Linux, I can see that there seem to be two relevant supplies: "vdda-phy" and "vdda-pll". Let's add those to the bindings. NOTE: from looking at the Qualcomm datasheet for sc7280, it's not immediately clear how to figure out how to fill in these supplies. The only two eDP related supplies are simply described as "power for eDP 0.9V circuits" and "power for eDP 1.2V circuits". From guessing and from comparing how a similar PHY is hooked up on other similar Qualcomm boards, I'll make the educated guess that the 1.2V supply goes to "vdda-phy" and the 0.9V supply goes to "vdda-pll" and I'll use that in the example here. Signed-off-by: Douglas Anderson Reviewed-by: Sankeerth Billakanti --- Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml b/Docu= mentation/devicetree/bindings/phy/qcom,edp-phy.yaml index a5850ff529f8..cf9e9b8011cb 100644 --- a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml @@ -41,6 +41,9 @@ properties: "#phy-cells": const: 0 =20 + vdda-phy-supply: true + vdda-pll-supply: true + required: - compatible - reg @@ -65,5 +68,8 @@ examples: =20 #clock-cells =3D <1>; #phy-cells =3D <0>; + + vdda-phy-supply =3D <&vdd_a_edp_0_1p2>; + vdda-pll-supply =3D <&vdd_a_edp_0_0p9>; }; ... --=20 2.36.0.rc2.479.g8af0fa9b8e-goog