From nobody Sun May 10 20:33:31 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E5C2C433EF for ; Mon, 25 Apr 2022 02:43:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240393AbiDYCqc (ORCPT ); Sun, 24 Apr 2022 22:46:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240266AbiDYCq2 (ORCPT ); Sun, 24 Apr 2022 22:46:28 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3AD5C68F84 for ; Sun, 24 Apr 2022 19:43:26 -0700 (PDT) Received: from dggpeml500020.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Kmq4w54xpzGpHX; Mon, 25 Apr 2022 10:40:48 +0800 (CST) Received: from dggpeml500008.china.huawei.com (7.185.36.147) by dggpeml500020.china.huawei.com (7.185.36.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 25 Apr 2022 10:43:23 +0800 Received: from huawei.com (10.67.175.34) by dggpeml500008.china.huawei.com (7.185.36.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 25 Apr 2022 10:43:23 +0800 From: Ren Zhijie To: , CC: , Ren Zhijie Subject: [PATCH -next] base: topology: fix unused variable compile error Date: Mon, 25 Apr 2022 10:41:49 +0800 Message-ID: <20220425024149.259189-1-renzhijie2@huawei.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.67.175.34] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpeml500008.china.huawei.com (7.185.36.147) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org compile error: drivers/base/topology.c: In function =E2=80=98topology_is_visible=E2=80=99: drivers/base/topology.c:158:17: error: unused variable =E2=80=98dev=E2=80= =99 [-Werror=3Dunused-variable] struct device *dev =3D kobj_to_dev(kobj); ^~~ cc1: all warnings being treated as errors If CONFIG_SMP is N, the macro 'topology_ppin()'expands as follows. "topology_ppin(dev->id) -> boot_cpu_data.ppin" This cause an unused variable warning for 'dev' which used in the topology_is_visible(). To fix build warning unused attribute added to the 'dev' variable. Reported-by: Hulk Robot Fixes:aa63a74d4535("topology/sysfs: Hide PPIN on systems that do not suppor= t it.") Signed-off-by: Ren Zhijie --- drivers/base/topology.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/base/topology.c b/drivers/base/topology.c index 706dbf8bf249..70962a4bcb1f 100644 --- a/drivers/base/topology.c +++ b/drivers/base/topology.c @@ -155,7 +155,8 @@ static struct attribute *default_attrs[] =3D { static umode_t topology_is_visible(struct kobject *kobj, struct attribute *attr, int unused) { - struct device *dev =3D kobj_to_dev(kobj); + struct device *dev __maybe_unused; + dev =3D kobj_to_dev(kobj); =20 if (attr =3D=3D &dev_attr_ppin.attr && !topology_ppin(dev->id)) return 0; --=20 2.17.1