From nobody Sun May 10 21:55:02 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A47FC433EF for ; Sat, 23 Apr 2022 13:02:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235603AbiDWNFK (ORCPT ); Sat, 23 Apr 2022 09:05:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229448AbiDWNFI (ORCPT ); Sat, 23 Apr 2022 09:05:08 -0400 Received: from mail-pg1-x536.google.com (mail-pg1-x536.google.com [IPv6:2607:f8b0:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 10AC81F037E for ; Sat, 23 Apr 2022 06:02:10 -0700 (PDT) Received: by mail-pg1-x536.google.com with SMTP id z21so1884617pgj.1 for ; Sat, 23 Apr 2022 06:02:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=np1VvhGsXveudaC3mg3HWoX7i37C0pM7mdB5fjxU4KQ=; b=goU7yWXzuueB/1fmAq5lrcoXVk9YtYy2CfEP9Rqid2PABQEcieOcFNJY2/Xrx3Ih6c q1td/X2fODGvpGB754FLsM0kaZdIumqZQsB2yEll/x1Z8EkXV30a/zQaeqi6kjrhPgdZ Qxk1734kzv2fjJLqHqMw29wuDOxfsHoBgdZTklP/bmH6qvrcKiQ7fgB/IN8BmtFL/AmJ pRDhQgBT0F9DwwAtazpe83HU7qIid4t9z6iVu3oE2bwCfb7x4hv0KeJUA9CTW/BFCoMw jAv4MT8J5nVcpYcnDm006wb+zLAXpbj6EyUxst/71wURP7Vvpummp/VSZk8PCKCr/219 z0ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=np1VvhGsXveudaC3mg3HWoX7i37C0pM7mdB5fjxU4KQ=; b=WCMtTrJMuc04T6OH+R30AkC5cApfSAYOaNhZsosHkM+eauVhkxczay+CHD89wS/8RR awRZ1Z3Vs9kk/a2qwsMfFM+71P2TFDP4GbgmgU8V5fpptMx32/s08Nz2rEBZ90uorHhd FSzlr5n45uNjsD9k8ZdHv9W/hthr8Z5q4VH4dZbeWRpcuK4IsOg3ZyfQ42PvvLfA0MiP gqDIXG5WhL23pbqFJQK4Xt4zuzHMFEmxbt4CFWxvEBHzNl4mdhW4uYdcjSNhdZmp5NQ6 mJ42R0ByY15G4Kly1nL7gXgOmHeHbMWcP6CBBMsI/QrcMpMNOWd1ZsOdk+odwRcmSLjO zSsg== X-Gm-Message-State: AOAM530kLxB0Px5XIsRNZ5eZMvupCQcdxaINxKpHnwrAwFXVU0ZepJ7S yQxK5JKDcEIrb7l/QNL1NexrFcxBHmUHxg== X-Google-Smtp-Source: ABdhPJwTx2+Ca+wGjC30X9mxFyzQeAUWP/zAaMHKpZDqef465+5acyngYnNmgsDoTd6btJufAn5Rgw== X-Received: by 2002:a05:6a00:218a:b0:505:aa03:ba57 with SMTP id h10-20020a056a00218a00b00505aa03ba57mr9996652pfi.84.1650718929480; Sat, 23 Apr 2022 06:02:09 -0700 (PDT) Received: from localhost.localdomain ([14.100.36.163]) by smtp.gmail.com with ESMTPSA id c139-20020a624e91000000b005060cdff4ffsm5808994pfb.129.2022.04.23.06.02.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Apr 2022 06:02:09 -0700 (PDT) From: Solomon Tan To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, dan.carpenter@oracle.com Subject: [PATCH 1/7] staging: rtl8192e: Remove unnecessary u8 assignment cast Date: Sat, 23 Apr 2022 21:01:44 +0800 Message-Id: <20220423130150.161903-2-wjsota@gmail.com> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220423130150.161903-1-wjsota@gmail.com> References: <20220423130150.161903-1-wjsota@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Remove the explicit casts in assignment statements for u8 variables. Because these variables are declared as u8, there is implicit conversion to u8 during the assignment, so an explicit cast is unnecessary. Signed-off-by: Solomon Tan --- .../rtl8192e/rtl8192e/r8190P_rtl8256.c | 8 ++--- .../staging/rtl8192e/rtl8192e/r8192E_dev.c | 32 +++++++++---------- .../staging/rtl8192e/rtl8192e/r8192E_phy.c | 16 +++++----- drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 18 +++++------ 4 files changed, 36 insertions(+), 38 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c b/drivers/s= taging/rtl8192e/rtl8192e/r8190P_rtl8256.c index 52eeb56c5c76..4abec7b42993 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c @@ -185,10 +185,10 @@ void rtl92e_set_ofdm_tx_power(struct net_device *dev,= u8 powerlevel) for (index =3D 0; index < 6; index++) { writeVal =3D (u32)(priv->MCSTxPowerLevelOriginalOffset[index] + ((index < 2) ? powerBase0 : powerBase1)); - byte0 =3D (u8)(writeVal & 0x7f); - byte1 =3D (u8)((writeVal & 0x7f00)>>8); - byte2 =3D (u8)((writeVal & 0x7f0000)>>16); - byte3 =3D (u8)((writeVal & 0x7f000000)>>24); + byte0 =3D writeVal & 0x7f; + byte1 =3D (writeVal & 0x7f00) >> 8; + byte2 =3D (writeVal & 0x7f0000) >> 16; + byte3 =3D (writeVal & 0x7f000000) >> 24; if (byte0 > 0x24) byte0 =3D 0x24; if (byte1 > 0x24) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_dev.c index a45ee95a8e6b..4b31fecde4e6 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c @@ -321,7 +321,7 @@ static void _rtl92e_read_eeprom_info(struct net_device = *dev) =20 usValue =3D rtl92e_eeprom_read(dev, (u16)(EEPROM_Customer_ID>>1)) >> 8; - priv->eeprom_CustomerID =3D (u8)(usValue & 0xff); + priv->eeprom_CustomerID =3D usValue & 0xff; usValue =3D rtl92e_eeprom_read(dev, EEPROM_ICVersion_ChannelPlan>>1); priv->eeprom_ChannelPlan =3D usValue&0xff; @@ -399,9 +399,9 @@ static void _rtl92e_read_eeprom_info(struct net_device = *dev) priv->EEPROMLegacyHTTxPowerDiff); =20 if (!priv->AutoloadFailFlag) - priv->EEPROMThermalMeter =3D (u8)(((rtl92e_eeprom_read(dev, + priv->EEPROMThermalMeter =3D ((rtl92e_eeprom_read(dev, (EEPROM_ThermalMeter>>1))) & - 0xff00)>>8); + 0xff00) >> 8; else priv->EEPROMThermalMeter =3D EEPROM_Default_ThermalMeter; RT_TRACE(COMP_INIT, "ThermalMeter =3D %d\n", @@ -413,8 +413,8 @@ static void _rtl92e_read_eeprom_info(struct net_device = *dev) usValue =3D rtl92e_eeprom_read(dev, EEPROM_TxPwDiff_CrystalCap >> 1); priv->EEPROMAntPwDiff =3D usValue & 0x0fff; - priv->EEPROMCrystalCap =3D (u8)((usValue & 0xf000) - >> 12); + priv->EEPROMCrystalCap =3D (usValue & 0xf000) + >> 12; } else { priv->EEPROMAntPwDiff =3D EEPROM_Default_AntTxPowerDiff; @@ -894,9 +894,8 @@ bool rtl92e_start_adapter(struct net_device *dev) =20 for (i =3D 0; i < TxBBGainTableLength; i++) { if (tmpRegA =3D=3D dm_tx_bb_gain[i]) { - priv->rfa_txpowertrackingindex =3D (u8)i; - priv->rfa_txpowertrackingindex_real =3D - (u8)i; + priv->rfa_txpowertrackingindex =3D i; + priv->rfa_txpowertrackingindex_real =3D i; priv->rfa_txpowertracking_default =3D priv->rfa_txpowertrackingindex; break; @@ -908,7 +907,7 @@ bool rtl92e_start_adapter(struct net_device *dev) =20 for (i =3D 0; i < CCKTxBBGainTableLength; i++) { if (TempCCk =3D=3D dm_cck_tx_bb_gain[i][0]) { - priv->CCKPresentAttentuation_20Mdefault =3D (u8)i; + priv->CCKPresentAttentuation_20Mdefault =3D i; break; } } @@ -1303,7 +1302,7 @@ void rtl92e_fill_tx_cmd_desc(struct net_device *dev,= struct tx_desc_cmd *entry, entry_tmp->Offset); entry_tmp->QueueSelect =3D QSLT_CMD; entry_tmp->TxFWInfoSize =3D 0x08; - entry_tmp->RATid =3D (u8)DESC_PACKET_TYPE_INIT; + entry_tmp->RATid =3D DESC_PACKET_TYPE_INIT; } entry->TxBufferSize =3D skb->len; entry->TxBuffAddr =3D mapping; @@ -1613,9 +1612,8 @@ static void _rtl92e_query_rxphystatus( total_rssi +=3D RSSI; =20 if (bpacket_match_bssid) { - pstats->RxMIMOSignalStrength[i] =3D (u8)RSSI; - precord_stats->RxMIMOSignalStrength[i] =3D - (u8)RSSI; + pstats->RxMIMOSignalStrength[i] =3D RSSI; + precord_stats->RxMIMOSignalStrength[i] =3D RSSI; } } =20 @@ -1661,14 +1659,14 @@ static void _rtl92e_query_rxphystatus( =20 if (is_cck_rate) { pstats->SignalStrength =3D precord_stats->SignalStrength =3D - (u8)(_rtl92e_signal_scale_mapping(priv, - (long)pwdb_all)); + _rtl92e_signal_scale_mapping(priv, + (long)pwdb_all); =20 } else { if (rf_rx_num !=3D 0) pstats->SignalStrength =3D precord_stats->SignalStrength =3D - (u8)(_rtl92e_signal_scale_mapping(priv, - (long)(total_rssi /=3D rf_rx_num))); + _rtl92e_signal_scale_mapping(priv, + (long)(total_rssi /=3D rf_rx_num)); } } =20 diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_phy.c index 411138102948..c7071e0997bc 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c @@ -1299,17 +1299,17 @@ void rtl92e_init_gain(struct net_device *dev, u8 Op= eration) DIG_ALGO_BY_FALSE_ALARM) rtl92e_set_bb_reg(dev, UFWP, bMaskByte1, 0x8); priv->initgain_backup.xaagccore1 =3D - (u8)rtl92e_get_bb_reg(dev, rOFDM0_XAAGCCore1, - BitMask); + rtl92e_get_bb_reg(dev, rOFDM0_XAAGCCore1, + BitMask); priv->initgain_backup.xbagccore1 =3D - (u8)rtl92e_get_bb_reg(dev, rOFDM0_XBAGCCore1, - BitMask); + rtl92e_get_bb_reg(dev, rOFDM0_XBAGCCore1, + BitMask); priv->initgain_backup.xcagccore1 =3D - (u8)rtl92e_get_bb_reg(dev, rOFDM0_XCAGCCore1, - BitMask); + rtl92e_get_bb_reg(dev, rOFDM0_XCAGCCore1, + BitMask); priv->initgain_backup.xdagccore1 =3D - (u8)rtl92e_get_bb_reg(dev, rOFDM0_XDAGCCore1, - BitMask); + rtl92e_get_bb_reg(dev, rOFDM0_XDAGCCore1, + BitMask); BitMask =3D bMaskByte2; priv->initgain_backup.cca =3D (u8)rtl92e_get_bb_reg(dev, rCCK0_CCA, BitMask); diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/r= tl8192e/rtl8192e/rtl_dm.c index aa942d915992..c85b23415772 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c @@ -633,7 +633,7 @@ static void _rtl92e_dm_tx_power_tracking_callback_tssi(= struct net_device *dev) rtl92e_writeb(dev, FW_Busy_Flag, 0); priv->rtllib->bdynamic_txpower_enable =3D false; =20 - powerlevelOFDM24G =3D (u8)(priv->Pwr_Track>>24); + powerlevelOFDM24G =3D priv->Pwr_Track >> 24; RF_Type =3D priv->rf_type; Value =3D (RF_Type<<8) | powerlevelOFDM24G; =20 @@ -833,7 +833,7 @@ static void _rtl92e_dm_tx_power_tracking_cb_thermal(str= uct net_device *dev) bMaskDWord); for (i =3D 0; i < OFDM_Table_Length; i++) { if (tmpRegA =3D=3D OFDMSwingTable[i]) { - priv->OFDM_index[0] =3D (u8)i; + priv->OFDM_index[0] =3D i; RT_TRACE(COMP_POWER_TRACKING, "Initial reg0x%x =3D 0x%x, OFDM_index =3D 0x%x\n", rOFDM0_XATxIQImbalance, tmpRegA, @@ -844,7 +844,7 @@ static void _rtl92e_dm_tx_power_tracking_cb_thermal(str= uct net_device *dev) TempCCk =3D rtl92e_get_bb_reg(dev, rCCK0_TxFilter1, bMaskByte2); for (i =3D 0; i < CCK_Table_length; i++) { if (TempCCk =3D=3D (u32)CCKSwingTable_Ch1_Ch13[i][0]) { - priv->CCK_index =3D (u8)i; + priv->CCK_index =3D i; RT_TRACE(COMP_POWER_TRACKING, "Initial reg0x%x =3D 0x%x, CCK_index =3D 0x%x\n", rCCK0_TxFilter1, TempCCk, @@ -1041,7 +1041,7 @@ static void _rtl92e_dm_cck_tx_power_adjust_tssi(struc= t net_device *dev, { u32 TempVal; struct r8192_priv *priv =3D rtllib_priv(dev); - u8 attenuation =3D (u8)priv->CCKPresentAttentuation; + u8 attenuation =3D priv->CCKPresentAttentuation; =20 TempVal =3D 0; if (!bInCH14) { @@ -1245,10 +1245,10 @@ void rtl92e_dm_backup_state(struct net_device *dev) return; =20 rtl92e_set_bb_reg(dev, UFWP, bMaskByte1, 0x8); - priv->initgain_backup.xaagccore1 =3D (u8)rtl92e_get_bb_reg(dev, rOFDM0_XA= AGCCore1, bit_mask); - priv->initgain_backup.xbagccore1 =3D (u8)rtl92e_get_bb_reg(dev, rOFDM0_XB= AGCCore1, bit_mask); - priv->initgain_backup.xcagccore1 =3D (u8)rtl92e_get_bb_reg(dev, rOFDM0_XC= AGCCore1, bit_mask); - priv->initgain_backup.xdagccore1 =3D (u8)rtl92e_get_bb_reg(dev, rOFDM0_XD= AGCCore1, bit_mask); + priv->initgain_backup.xaagccore1 =3D rtl92e_get_bb_reg(dev, rOFDM0_XAAGCC= ore1, bit_mask); + priv->initgain_backup.xbagccore1 =3D rtl92e_get_bb_reg(dev, rOFDM0_XBAGCC= ore1, bit_mask); + priv->initgain_backup.xcagccore1 =3D rtl92e_get_bb_reg(dev, rOFDM0_XCAGCC= ore1, bit_mask); + priv->initgain_backup.xdagccore1 =3D rtl92e_get_bb_reg(dev, rOFDM0_XDAGCC= ore1, bit_mask); bit_mask =3D bMaskByte2; priv->initgain_backup.cca =3D (u8)rtl92e_get_bb_reg(dev, rCCK0_CCA, bit_m= ask); =20 @@ -1535,7 +1535,7 @@ static void _rtl92e_dm_initial_gain(struct net_device= *dev) =20 if ((dm_digtable.pre_ig_value !=3D dm_digtable.cur_ig_value) || !initialized || force_write) { - initial_gain =3D (u8)dm_digtable.cur_ig_value; + initial_gain =3D dm_digtable.cur_ig_value; rtl92e_writeb(dev, rOFDM0_XAAGCCore1, initial_gain); rtl92e_writeb(dev, rOFDM0_XBAGCCore1, initial_gain); rtl92e_writeb(dev, rOFDM0_XCAGCCore1, initial_gain); --=20 2.36.0 From nobody Sun May 10 21:55:02 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4169C433F5 for ; Sat, 23 Apr 2022 13:02:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235621AbiDWNFO (ORCPT ); Sat, 23 Apr 2022 09:05:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41064 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235610AbiDWNFK (ORCPT ); Sat, 23 Apr 2022 09:05:10 -0400 Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3CB7C1F040A for ; Sat, 23 Apr 2022 06:02:14 -0700 (PDT) Received: by mail-pf1-x42e.google.com with SMTP id y14so9746077pfe.10 for ; Sat, 23 Apr 2022 06:02:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vM5RVFO6hnZxHJlh729g+B7vJJ65wYvCqP8gO/Xp2ro=; b=lgd9AJ3xV83rtBnLBU8P2J9R36SCBOyCEbLQ2iuuJcKcMYPcMWeG9oEhUpBiDld0QJ LD9vFOnSdr4UWN1ePf6i0irQilLHHJMkr0AENGUZREk5/bQcoAbYZUPRe6Hdcbt3uAcc gBRiH7tPPurHgunU8I5j1SKxPTPh0hu9rhhqAygLH6l/WeLloKQir3eAmYq1z8l3Dj4E QBR3390YsMPjuvu2zaXZ1hFwY1+6ss2zE1CXEMuD2386I9YhjZdzzO4bCyFxBM0yu8qu TiWkf9Hzqae26ugfIKq4V2qHHSrJxmNHBjb2wjlckqJI9YsCqBBlLJBDY0ixvAllIYle ddDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vM5RVFO6hnZxHJlh729g+B7vJJ65wYvCqP8gO/Xp2ro=; b=YvqqAEyplAWwvM+dh0n1oAUkRzjJaSQBSJvYiIxTr7jArehRBGO+DB3ASo7JsF6511 h4Zuhp56K9VB+l277RxAjPLPXtaM8UhmEE2vJDCtMwK0dh7wkelo1N549VsoFK2aIuyU Sv7i7Qp+tUywQS3sxcNklOfvRhdkzTNvE7atGWHFSpjIrPtNWFLqwSEEilSKpki8Upba icfmH92PzgsTPn49Z/ta+YpbSbX8/tA/ct/UEuBYSf3P3E/FehjviJbQo34vSaK7nRTE lftKCdTbwe3svvzdV/FR/eRZF7y1HZr2VEfgILFVonYvps0fpY2A5kD6zyXNjitFXo1b gDFQ== X-Gm-Message-State: AOAM53322FF75DMj5jtOhzg/irPDXNbWaUDXwjympLk0anQQ4cbKjT/G TPb7WRRRiKiIr21ePwadV18= X-Google-Smtp-Source: ABdhPJxrZpTSfajfKptQieeEDLFf4C5YXMwUJmLcw1HcMC8Y6cJLiI9R2mqPpyptpKj1iuvCYwoLhw== X-Received: by 2002:a05:6a00:4399:b0:50a:db62:e4fa with SMTP id bt25-20020a056a00439900b0050adb62e4famr10000551pfb.31.1650718933675; Sat, 23 Apr 2022 06:02:13 -0700 (PDT) Received: from localhost.localdomain ([14.100.36.163]) by smtp.gmail.com with ESMTPSA id c139-20020a624e91000000b005060cdff4ffsm5808994pfb.129.2022.04.23.06.02.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Apr 2022 06:02:13 -0700 (PDT) From: Solomon Tan To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, dan.carpenter@oracle.com Subject: [PATCH 2/7] staging: rtl8192e: Remove unnecessary u8 argument cast Date: Sat, 23 Apr 2022 21:01:45 +0800 Message-Id: <20220423130150.161903-3-wjsota@gmail.com> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220423130150.161903-1-wjsota@gmail.com> References: <20220423130150.161903-1-wjsota@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Remove the unnecessary explicit u8 casts for u8 arguments in function calls. These functions have declared their parameters to be of type u8, so the arguments given to those parameters will be automatically coerced to u8. Therefore, an explicit cast is unnecessary. Signed-off-by: Solomon Tan --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 9 ++++----- drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 3 +-- drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 2 +- drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 2 +- 4 files changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_dev.c index 4b31fecde4e6..4fe806eae5b7 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c @@ -1175,7 +1175,7 @@ void rtl92e_fill_tx_desc(struct net_device *dev, str= uct tx_desc *pdesc, pTxFwInfo =3D (struct tx_fwinfo_8190pci *)skb->data; memset(pTxFwInfo, 0, sizeof(struct tx_fwinfo_8190pci)); pTxFwInfo->TxHT =3D (cb_desc->data_rate & 0x80) ? 1 : 0; - pTxFwInfo->TxRate =3D _rtl92e_rate_mgn_to_hw((u8)cb_desc->data_rate); + pTxFwInfo->TxRate =3D _rtl92e_rate_mgn_to_hw(cb_desc->data_rate); pTxFwInfo->EnableCPUDur =3D cb_desc->bTxEnableFwCalcDur; pTxFwInfo->Short =3D _rtl92e_query_is_short(pTxFwInfo->TxHT, pTxFwInfo->TxRate, cb_desc); @@ -1194,7 +1194,7 @@ void rtl92e_fill_tx_desc(struct net_device *dev, str= uct tx_desc *pdesc, pTxFwInfo->CtsEnable =3D (cb_desc->bCTSEnable) ? 1 : 0; pTxFwInfo->RtsSTBC =3D (cb_desc->bRTSSTBC) ? 1 : 0; pTxFwInfo->RtsHT =3D (cb_desc->rts_rate&0x80) ? 1 : 0; - pTxFwInfo->RtsRate =3D _rtl92e_rate_mgn_to_hw((u8)cb_desc->rts_rate); + pTxFwInfo->RtsRate =3D _rtl92e_rate_mgn_to_hw(cb_desc->rts_rate); pTxFwInfo->RtsBandwidth =3D 0; pTxFwInfo->RtsSubcarrier =3D cb_desc->RTSSC; pTxFwInfo->RtsShort =3D (pTxFwInfo->RtsHT =3D=3D 0) ? @@ -1707,8 +1707,7 @@ static void _rtl92e_process_phyinfo(struct r8192_priv= *priv, u8 *buffer, slide_rssi_index =3D 0; =20 tmp_val =3D priv->stats.slide_rssi_total/slide_rssi_statistics; - priv->stats.signal_strength =3D rtl92e_translate_to_dbm(priv, - (u8)tmp_val); + priv->stats.signal_strength =3D rtl92e_translate_to_dbm(priv, tmp_val); curr_st->rssi =3D priv->stats.signal_strength; if (!prev_st->bPacketMatchBSSID) { if (!prev_st->bToSelfBA) @@ -2034,7 +2033,7 @@ bool rtl92e_get_rx_stats(struct net_device *dev, stru= ct rtllib_rx_stats *stats, pDrvInfo =3D (struct rx_fwinfo *)(skb->data + stats->RxBufShift); =20 stats->rate =3D _rtl92e_rate_hw_to_mgn((bool)pDrvInfo->RxHT, - (u8)pDrvInfo->RxRate); + pDrvInfo->RxRate); stats->bShortPreamble =3D pDrvInfo->SPLCP; =20 _rtl92e_update_received_rate_histogram_stats(dev, stats); diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/= staging/rtl8192e/rtl8192e/r8192E_firmware.c index 9b025b9fa7ab..38110fa4f36d 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c @@ -34,8 +34,7 @@ static bool _rtl92e_fw_boot_cpu(struct net_device *dev) netdev_dbg(dev, "Download Firmware: Put code ok!\n"); =20 CPU_status =3D rtl92e_readl(dev, CPU_GEN); - rtl92e_writeb(dev, CPU_GEN, - (u8)((CPU_status|CPU_GEN_PWR_STB_CPU)&0xff)); + rtl92e_writeb(dev, CPU_GEN, (CPU_status | CPU_GEN_PWR_STB_CPU) & 0xff); mdelay(1); =20 if (!_rtl92e_wait_for_fw(dev, CPU_GEN_BOOT_RDY, 200)) { diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_phy.c index c7071e0997bc..1b70c12be365 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c @@ -933,7 +933,7 @@ static u8 _rtl92e_phy_switch_channel_step(struct net_de= vice *dev, u8 channel, break; case CmdID_WritePortUchar: rtl92e_writeb(dev, CurrentCmd->Para1, - (u8)CurrentCmd->Para2); + CurrentCmd->Para2); break; case CmdID_RF_WriteReg: for (eRFPath =3D 0; eRFPath < diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/r= tl8192e/rtl8192e/rtl_dm.c index c85b23415772..d58800d06e8f 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c @@ -2513,5 +2513,5 @@ static void _rtl92e_dm_send_rssi_to_fw(struct net_dev= ice *dev) { struct r8192_priv *priv =3D rtllib_priv(dev); =20 - rtl92e_writeb(dev, DRIVER_RSSI, (u8)priv->undecorated_smoothed_pwdb); + rtl92e_writeb(dev, DRIVER_RSSI, priv->undecorated_smoothed_pwdb); } --=20 2.36.0 From nobody Sun May 10 21:55:02 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0582DC433EF for ; Sat, 23 Apr 2022 13:02:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235631AbiDWNFW (ORCPT ); Sat, 23 Apr 2022 09:05:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235626AbiDWNFP (ORCPT ); Sat, 23 Apr 2022 09:05:15 -0400 Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6AF2C1F0420 for ; Sat, 23 Apr 2022 06:02:18 -0700 (PDT) Received: by mail-pf1-x42d.google.com with SMTP id h1so10495234pfv.12 for ; Sat, 23 Apr 2022 06:02:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+3gUIKqgjIoqwfyRdl1gl0gu9sfmeEdgyuQbdCNe5BA=; b=LN46w5S3b44hmyqlW8bleygWumr9HpM35L/IWvTsW2aVpra7CrkWWp7so/GivC7wS4 K9iUcT4o8T+bZXihS+zOeHAmcmoTBKE0otsLwcElfTrewYuDDKDbNBRwLoutCrt/de0W 8We+i7z52FruY7VU3uCd5NXYM5sa2Qx4H+VCEDgkyMOfHOGoL4Ym1IbuNDbt0CuXOB2X DtlVR+fgZWKYWiNjmYrIECen7dFpfqG8zAEGwlktMSZP3W3WEVVKwMTOd1zlxK76TUzf S/xfImg2o2KaLtfuNhtAw8GjMahPILScWywueuVqyvYpbWABvLcZpNTYrnD1Cxt6NSVB L8OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+3gUIKqgjIoqwfyRdl1gl0gu9sfmeEdgyuQbdCNe5BA=; b=Im1IXjf4yO014QUig/eI5L1YQXgLpw2DjQub0b2/HO8CEspK2QBswqQ5D362ON1aCc 6YNgxTRyQ2vxHI2dfjV2+4yyUHQAkg2bmiAKNHZy8iMcU0cX5v2hp73k99Hvpg6539qa qA7cBqQCWka83nPkeg3CBveUOhLFBE6P2nigkGmrC3GK35KOZG0gH6A7snND4Q/07v2+ que2RXX+D3ytB4z4pXA+bBlBCI3MJ4xldpwB7xPJvv7dsekp/5glvsqjjXWONYDJHxvu Z+o8uUktXUqLzV7iB0nka3x6hGbCM3ZfzUAdbZcl0vHhyahf0ssvAWIyDmnurgg49Jub SVqg== X-Gm-Message-State: AOAM533n9WYSRnFgrtkWc/AoDMgiCvtX9tJikO2Cib5n2ZbsXjwWYnn9 MCjYN+gmdWyG4HMFe8NtW4xshDrG4Ew22Q== X-Google-Smtp-Source: ABdhPJzLZyrXSGRaOPPlqezEIm/raJzvDqC2gZAi8gNTlVurCBybd2ZOdD+ntz/RHhOcwoeeuMs3Tw== X-Received: by 2002:a05:6a00:2186:b0:4f7:5544:1cc9 with SMTP id h6-20020a056a00218600b004f755441cc9mr9719631pfi.62.1650718937763; Sat, 23 Apr 2022 06:02:17 -0700 (PDT) Received: from localhost.localdomain ([14.100.36.163]) by smtp.gmail.com with ESMTPSA id c139-20020a624e91000000b005060cdff4ffsm5808994pfb.129.2022.04.23.06.02.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Apr 2022 06:02:17 -0700 (PDT) From: Solomon Tan To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, dan.carpenter@oracle.com Subject: [PATCH 3/7] staging: rtl8192e: Remove unnecessary u8 cast in comparison Date: Sat, 23 Apr 2022 21:01:46 +0800 Message-Id: <20220423130150.161903-4-wjsota@gmail.com> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220423130150.161903-1-wjsota@gmail.com> References: <20220423130150.161903-1-wjsota@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Since the macro VERSION_8190_BD is defined to be 0x3, and the structure members card_8192_version and IC_Cut are both u8, an explicit u8 cast is unnecessary. Signed-off-by: Solomon Tan --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 2 +- drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_dev.c index 4fe806eae5b7..b608540c036c 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c @@ -811,7 +811,7 @@ bool rtl92e_start_adapter(struct net_device *dev) =20 rtl92e_config_mac(dev); =20 - if (priv->card_8192_version > (u8)VERSION_8190_BD) { + if (priv->card_8192_version > VERSION_8190_BD) { rtl92e_get_tx_power(dev); rtl92e_set_tx_power(dev, priv->chan); } diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_phy.c index 1b70c12be365..b7bdbd895e7b 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c @@ -919,7 +919,7 @@ static u8 _rtl92e_phy_switch_channel_step(struct net_de= vice *dev, u8 channel, continue; switch (CurrentCmd->CmdID) { case CmdID_SetTxPowerLevel: - if (priv->IC_Cut > (u8)VERSION_8190_BD) + if (priv->IC_Cut > VERSION_8190_BD) _rtl92e_set_tx_power_level(dev, channel); break; --=20 2.36.0 From nobody Sun May 10 21:55:02 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94F02C433F5 for ; Sat, 23 Apr 2022 13:02:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235646AbiDWNF3 (ORCPT ); Sat, 23 Apr 2022 09:05:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235633AbiDWNFT (ORCPT ); Sat, 23 Apr 2022 09:05:19 -0400 Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B73151F0419 for ; Sat, 23 Apr 2022 06:02:21 -0700 (PDT) Received: by mail-pf1-x436.google.com with SMTP id c1so3977594pfo.0 for ; Sat, 23 Apr 2022 06:02:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=idFLEuhhRBrIFoG+4fgFrk263hwBaKFKAvkJX1uSpV4=; b=CLTrwpUjDt+EKT+A/MFKftljZ9OzVlZE2pp2sby4IndormmslmJ5PLAJN0UOFDtsEM Npa1g78QMW3mZXiJPRcPffpGQ0b0kutjXFtRLwM1+aDJzN8IY0EcFeRHrm733GGxL9Lh /JrljX9pSLx0N6TYE9pvD64LrOH+nTRea4kah5f0wuBJ9yk5+sDmfGXOVW5ZVNrEtiBA icbEtpH+QSgeiUzPFdJz8WCXTGTsZ2dF9Q2jLqoSt5f7QmCtYfTVCRxz8UwVoVLtaSGi xYempN0Y0tFejWmxD69oF0aKJMcT8M0Bak9JPyLLr/xPiLPaFrQe2kIJz+rAaql98T+7 ztAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=idFLEuhhRBrIFoG+4fgFrk263hwBaKFKAvkJX1uSpV4=; b=AVvLjJXbDfbm8dG/TgJ2xGg4iNNVNqrKQnsUZghP35sWY9mLIXR1+zfCa/+k1RMEGY ie1Sf7QjgcchKC4j99yqQHDELLEuj6B3Zc7yxcC6dKoN4/EUQeeaJZHAVrn6gKaf/G1R TTD4bymNtmuMY40iApDP52GxA+arQlc4BW0TpYBmCIytjO4z+Pt6ajZhwcA/MH8EGn+6 hyUb87d2RJw83s7IPsQ0AnepfXdpLwP2yhJuf1GRXvBj87Ou7phLbrdz8y4egiyx/ylM 2bbsCtwX8U4Ohw98goY91f7Li2UY96lU/krqmXYlRfgH+6czSsh/qONp4UnBRECX3vtM 3sCQ== X-Gm-Message-State: AOAM533y1EtUgChD1ZG1qsP7qJVRoLo3ceN8ls8oMrejHNdi6PX+3Sug Mg+zcTJXu5hjKhLs/un+cH1MPS7cvmFv2w== X-Google-Smtp-Source: ABdhPJwTT7gagDiYTgzLspQB+d5xn7GjsnscQCajwVcnKJALZvPy3m2pmp1QV5tQ7VYSXk31mXQYFQ== X-Received: by 2002:a05:6a00:a0e:b0:4fd:fa6e:95fc with SMTP id p14-20020a056a000a0e00b004fdfa6e95fcmr10043915pfh.17.1650718941187; Sat, 23 Apr 2022 06:02:21 -0700 (PDT) Received: from localhost.localdomain ([14.100.36.163]) by smtp.gmail.com with ESMTPSA id c139-20020a624e91000000b005060cdff4ffsm5808994pfb.129.2022.04.23.06.02.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Apr 2022 06:02:20 -0700 (PDT) From: Solomon Tan To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, dan.carpenter@oracle.com Subject: [PATCH 4/7] staging: rtl8192e: Remove unnecessary u16 assignment cast Date: Sat, 23 Apr 2022 21:01:47 +0800 Message-Id: <20220423130150.161903-5-wjsota@gmail.com> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220423130150.161903-1-wjsota@gmail.com> References: <20220423130150.161903-1-wjsota@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Remove the explicit casts in assignment statements for u16 variables. Because these variables are declared as u16, there is implicit conversion to u16 during the assignment, so an explicit cast is unnecessary. Signed-off-by: Solomon Tan --- drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c | 2 +- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c b/drivers/st= aging/rtl8192e/rtl8192e/r8192E_cmdpkt.c index c5e44bbe997c..cd8bbc358d01 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c @@ -58,7 +58,7 @@ bool rtl92e_send_cmd_pkt(struct net_device *dev, u32 type= , const void *data, memset(pTxFwInfo, 0, sizeof(struct tx_fwinfo_8190pci)); memset(pTxFwInfo, 0x12, 8); } else { - tcb_desc->txbuf_size =3D (u16)frag_length; + tcb_desc->txbuf_size =3D frag_length; } =20 seg_ptr =3D skb_put(skb, frag_length); diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_dev.c index b608540c036c..feddb15bccbe 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c @@ -1225,7 +1225,7 @@ void rtl92e_fill_tx_desc(struct net_device *dev, str= uct tx_desc *pdesc, pdesc->LINIP =3D 0; pdesc->CmdInit =3D 1; pdesc->Offset =3D sizeof(struct tx_fwinfo_8190pci) + 8; - pdesc->PktSize =3D (u16)skb->len-sizeof(struct tx_fwinfo_8190pci); + pdesc->PktSize =3D skb->len - sizeof(struct tx_fwinfo_8190pci); =20 pdesc->SecCAMID =3D 0; pdesc->RATid =3D cb_desc->RATRIndex; @@ -1298,8 +1298,7 @@ void rtl92e_fill_tx_cmd_desc(struct net_device *dev,= struct tx_desc_cmd *entry, =20 entry_tmp->CmdInit =3D DESC_PACKET_TYPE_NORMAL; entry_tmp->Offset =3D sizeof(struct tx_fwinfo_8190pci) + 8; - entry_tmp->PktSize =3D (u16)(cb_desc->pkt_size + - entry_tmp->Offset); + entry_tmp->PktSize =3D cb_desc->pkt_size + entry_tmp->Offset; entry_tmp->QueueSelect =3D QSLT_CMD; entry_tmp->TxFWInfoSize =3D 0x08; entry_tmp->RATid =3D DESC_PACKET_TYPE_INIT; --=20 2.36.0 From nobody Sun May 10 21:55:02 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E73CC433EF for ; Sat, 23 Apr 2022 13:02:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235662AbiDWNFd (ORCPT ); Sat, 23 Apr 2022 09:05:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235634AbiDWNFW (ORCPT ); Sat, 23 Apr 2022 09:05:22 -0400 Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D5201F040A for ; Sat, 23 Apr 2022 06:02:25 -0700 (PDT) Received: by mail-pf1-x432.google.com with SMTP id i24so10505943pfa.7 for ; Sat, 23 Apr 2022 06:02:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Oyv6GRijgI6ZlQEYxlfZHmDpqpNucWtnXIaYxQpviek=; b=gpE6EbIka79YAOkWw/HkIZ4o/eLh5qUEEfeLWfx4F3l9r6mNubqOGbe4OHMTsYlUG5 kwdGKktCdxXTwJBgn0kXcbkm9QZJVYHZnnJe7sLGfqVgEZKykmPwjgQZbjt4YwK+SS5E cjt1C9smys6T2aErJJyQG6C2uEBVvmuEzBJml88xWcFCYEru3agIiVxoj5p8lXmBceWv 3mkbuiZ2Ou41Vu9McGHMOgI7Atrj6Yui8qxFsJcw8SogNA/hdSiiOvZyKY3NyIuIhDGb kmSyoNDq7jx1taFe58HH329FlIjILfM/lv3zjCT2V9spneUSlmFoBlmsc+TkBK+YBR9J C+vQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Oyv6GRijgI6ZlQEYxlfZHmDpqpNucWtnXIaYxQpviek=; b=iYUNjHdnttBfMBsixRhRsFxMjHEsqj73ZC6mKJCxUrq4lN9oBa6gsA0BOIsAqqodyd EUM3U2HrZgCwNjClYd+zQT3DjDL4SCgF1kN2B0urMHrsEzJzNaO0z+UmDFMw2+wMYvAA OfNtr274qMOFwtLAtZj+xzsitd8Jj0vKlEQl62IQKSJM11DmvFwO1YyvyqRyPsNNf9W/ 2tM6F5mwzc/XZFKInfgSjdH4LxYbGD04W3K6STo8/0NbEx0Jggu/H9f5xKI9pGgf2Xcl Lj6Z7746PYtirI/0eac/5pQqVeUzNXkopJQ3VBxy4CCPCqARiSJ3I10m9hY5N5q6TaPf Qbqw== X-Gm-Message-State: AOAM531YFEdS5TIJHqEsM22oilafemnAgCmdUT9ZX/+UZRnsHFedWKEw E+mVBh65Udr0d4CBmeKIICc= X-Google-Smtp-Source: ABdhPJyFcHs6ZfXij+Hc0XU13+ZgJuibRmhSOeNb5WawPnZnK/GODXcAy7louFq1siZa+3VxSDonpQ== X-Received: by 2002:a63:5648:0:b0:398:dfcf:c9c6 with SMTP id g8-20020a635648000000b00398dfcfc9c6mr7875249pgm.0.1650718944637; Sat, 23 Apr 2022 06:02:24 -0700 (PDT) Received: from localhost.localdomain ([14.100.36.163]) by smtp.gmail.com with ESMTPSA id c139-20020a624e91000000b005060cdff4ffsm5808994pfb.129.2022.04.23.06.02.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Apr 2022 06:02:24 -0700 (PDT) From: Solomon Tan To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, dan.carpenter@oracle.com Subject: [PATCH 5/7] staging: rtl8192e: Remove unnecessary u16 argument cast Date: Sat, 23 Apr 2022 21:01:48 +0800 Message-Id: <20220423130150.161903-6-wjsota@gmail.com> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220423130150.161903-1-wjsota@gmail.com> References: <20220423130150.161903-1-wjsota@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Remove the explicit u16 casts for u16 argument in the function call. This function has declared its parameter to be of type u16, so the argument given to that parameter will be automatically coerced to u16. Therefore, an explicit cast is unnecessary. Signed-off-by: Solomon Tan --- drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_phy.c index b7bdbd895e7b..f92551094738 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c @@ -929,7 +929,7 @@ static u8 _rtl92e_phy_switch_channel_step(struct net_de= vice *dev, u8 channel, break; case CmdID_WritePortUshort: rtl92e_writew(dev, CurrentCmd->Para1, - (u16)CurrentCmd->Para2); + CurrentCmd->Para2); break; case CmdID_WritePortUchar: rtl92e_writeb(dev, CurrentCmd->Para1, --=20 2.36.0 From nobody Sun May 10 21:55:02 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75247C433EF for ; Sat, 23 Apr 2022 13:02:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235683AbiDWNFi (ORCPT ); Sat, 23 Apr 2022 09:05:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42262 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235626AbiDWNFY (ORCPT ); Sat, 23 Apr 2022 09:05:24 -0400 Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D56F1F040A for ; Sat, 23 Apr 2022 06:02:28 -0700 (PDT) Received: by mail-pl1-x629.google.com with SMTP id c23so16766479plo.0 for ; Sat, 23 Apr 2022 06:02:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KrgVC3UPNzr2hlG0BxhLQFDCAl0tXFxgqHvP744zkDY=; b=hNsr/DD/bbhFB2+PqlTKJgoT+/OfTJgg+SQcqbSBWJsGPDvgnY67fsL83OXpsVJA6f MkJ0Z4bjqg8CV2hsyrcg1TM1xmGuMeMbKD18HVBNuNmbqxOWNjBXg4Cxcw8BFhUimiRV P9PB1dymobQnVePd7vIHBdcIVcj+4GiPQy4REzPH6tiO45Ckys+xLK3OCweuZ77YDAT8 TqrXKqACg77aUSdytJPfbK8Q7I5ByTOU3vQQF0l5qU1GcZpjDT3RgRs7dv8/8yv++7Un m+Lgu+YybF0gBkiyN3OOM4okbxtUvWir0VuDD6QcZ1tVhaJ/8aBHKR9r6CZABo+Bze+S ORPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KrgVC3UPNzr2hlG0BxhLQFDCAl0tXFxgqHvP744zkDY=; b=ivsc6shuKvxhFpK8aYpVoiPeUoUe9d7ZLdjO52KVUdlL0U1IuPqp5faTb2jDyBfJMX 4Pn6xpUPa8lMFxc4EvyEtbVe0Ka0SrQlqqIhGUZro02RWlk2rI2ybfan4CkhwMQd5F6i S48HVi9qa9VAuAZiabbHjDmc5GS5Gp5P7+Stp2ANGfWpRyWgBVbPJ2RolQBXtC6iG9yQ w3t4OFTtiinwsXc+Oo+finm+UrtDgMZFJAL1FRAPa7Z63mcyiQOC2elrQ+6dJKLeJmBt p+WqcpHJmx7oCNMlC8OQSgXs31vBaNeXniKFMIE/VBS7v9uDyjzdiD1NSYoNXwOuKHTC yvaA== X-Gm-Message-State: AOAM533PCFlp9ZppLjQ5wq57WlRLmUMNo30ywb1O/0tlLxmqm13XVxKi tPZUN7Z7vlNrQMUcWkTxngweMFNLbs9/jw== X-Google-Smtp-Source: ABdhPJyTbZVGl+TE0cMbfLiKFHFwn4cywT2egZi8doupH20ZPQrMCFEL4VGd59CUCEmD4DMGroZVLA== X-Received: by 2002:a17:90b:4a0f:b0:1d2:fe13:841e with SMTP id kk15-20020a17090b4a0f00b001d2fe13841emr10789827pjb.97.1650718947490; Sat, 23 Apr 2022 06:02:27 -0700 (PDT) Received: from localhost.localdomain ([14.100.36.163]) by smtp.gmail.com with ESMTPSA id c139-20020a624e91000000b005060cdff4ffsm5808994pfb.129.2022.04.23.06.02.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Apr 2022 06:02:27 -0700 (PDT) From: Solomon Tan To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, dan.carpenter@oracle.com Subject: [PATCH 6/7] staging: rtl8192e: Remove u16 cast for u32 parameter Date: Sat, 23 Apr 2022 21:01:49 +0800 Message-Id: <20220423130150.161903-7-wjsota@gmail.com> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220423130150.161903-1-wjsota@gmail.com> References: <20220423130150.161903-1-wjsota@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The explicit u16 cast is not necessary because rtl92e_eeprom_read's second parameter is defined to be u32. Signed-off-by: Solomon Tan --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_dev.c index feddb15bccbe..4b9249195b5a 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c @@ -320,7 +320,7 @@ static void _rtl92e_read_eeprom_info(struct net_device = *dev) priv->eeprom_did =3D rtl92e_eeprom_read(dev, EEPROM_DID >> 1); =20 usValue =3D rtl92e_eeprom_read(dev, - (u16)(EEPROM_Customer_ID>>1)) >> 8; + (EEPROM_Customer_ID >> 1)) >> 8; priv->eeprom_CustomerID =3D usValue & 0xff; usValue =3D rtl92e_eeprom_read(dev, EEPROM_ICVersion_ChannelPlan>>1); --=20 2.36.0 From nobody Sun May 10 21:55:02 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F04B8C433EF for ; Sat, 23 Apr 2022 13:02:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235700AbiDWNFl (ORCPT ); Sat, 23 Apr 2022 09:05:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235636AbiDWNF3 (ORCPT ); Sat, 23 Apr 2022 09:05:29 -0400 Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A00A1F0B88 for ; Sat, 23 Apr 2022 06:02:30 -0700 (PDT) Received: by mail-pl1-x630.google.com with SMTP id c23so16766693plo.0 for ; Sat, 23 Apr 2022 06:02:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=p8rAqTMQ2XWjal/ekmPzbpXL4sv2yzkmbXk/WYInG0Q=; b=J6Aeym90Qy7VvagYHJbWEoIg+d2WadfzFnKyUGz0cxZRSxhvpDAkZjUZ7Tz0RdjTe+ V2gHk2sQmmEJJc6KSe7SXmlQ5yjByo+Ts95qXsXhYzFwvBt4L/vPOdjb5LVKnLmcfK5x HcfNqM+4BTydL8FplyHJQfRopqpOr8xicBNxYtC/V3YBnrBA9zBDKPw3EDY8ePH2CJlP JFyZ3SNEJH338tHvdh21LKXbLDAim5DyDlcO8upRXgOiJa9wwhXLx8yy/5T9IbQFfoC7 nyE+L/9mAm8uodApvvqHxti+ZLS3wXdXJEWp8sSCJlqVINKpYgI8fTvMFRNZCU2ftZVc m2cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=p8rAqTMQ2XWjal/ekmPzbpXL4sv2yzkmbXk/WYInG0Q=; b=CZgM/nLPYFmHeYuzjw27f7B5PFxUZNO8Iq6fXTuhpRn3Rwe4517PX4oC+tkJVeiCc9 HKPYLDITTfwZ3VbsdBz18ZogvfyR3DqBn8bT3hE75795i5lCpNDZiFQNIN2wBxYgc4Se Ui0x1dslFtMIXQRpqFUpHCNjxKDKduPXryfa4WInWsTT7nlQrG/92zSlkjGbfPZCvIbA Uv2oX289LPa8MqwoZ8L6Tsj6dR6LJr7iLM6N78Vwu3Bc55oN32GF7LFTvM08JKEcS6Qo Xfc4bHKTjjpyfwjNTNn0M0cmS2nUahgJKp7g7SOzwMbU3PhI5xTHupppjaMgAg6SHfHC z+Lg== X-Gm-Message-State: AOAM533tXZEgeFoM7VFGLHV4YGhGiKOUfAngfaol0l2rcE5x09Bk6sse QGfye0VsnFIXqWVhMrn4ZueCTWY6L1c+Ww== X-Google-Smtp-Source: ABdhPJwAIIyfCLGQZTmPZl143X0zqHT/wc9wmMavCCX3LYvhAQteaMrULWE7fGph3+AgK9ezAIRCdA== X-Received: by 2002:a17:90b:3c51:b0:1d6:aabd:6a3b with SMTP id pm17-20020a17090b3c5100b001d6aabd6a3bmr10729005pjb.241.1650718950431; Sat, 23 Apr 2022 06:02:30 -0700 (PDT) Received: from localhost.localdomain ([14.100.36.163]) by smtp.gmail.com with ESMTPSA id c139-20020a624e91000000b005060cdff4ffsm5808994pfb.129.2022.04.23.06.02.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Apr 2022 06:02:30 -0700 (PDT) From: Solomon Tan To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, dan.carpenter@oracle.com Subject: [PATCH 7/7] staging: rtl8192e: Remove u16 cast for u16 return value Date: Sat, 23 Apr 2022 21:01:50 +0800 Message-Id: <20220423130150.161903-8-wjsota@gmail.com> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220423130150.161903-1-wjsota@gmail.com> References: <20220423130150.161903-1-wjsota@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Remove explicit u16 cast of the function Mk16 return value. The variable hi does not need to be casted explicitly to u16 as it will already be casted implicitly. Signed-off-by: Solomon Tan --- drivers/staging/rtl8192e/rtllib_crypt_tkip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192e/rtllib_crypt_tkip.c b/drivers/staging= /rtl8192e/rtllib_crypt_tkip.c index a305b79c53e7..8bc95651e384 100644 --- a/drivers/staging/rtl8192e/rtllib_crypt_tkip.c +++ b/drivers/staging/rtl8192e/rtllib_crypt_tkip.c @@ -136,7 +136,7 @@ static inline u16 Hi16(u32 val) =20 static inline u16 Mk16(u8 hi, u8 lo) { - return lo | (((u16)hi) << 8); + return lo | (hi << 8); } =20 =20 --=20 2.36.0