From nobody Sun May 10 21:55:05 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AA73C4321E for ; Fri, 22 Apr 2022 18:06:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232738AbiDVSIL (ORCPT ); Fri, 22 Apr 2022 14:08:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235893AbiDVSGM (ORCPT ); Fri, 22 Apr 2022 14:06:12 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 436621186C3 for ; Fri, 22 Apr 2022 11:03:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1650650421; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=k3HrrpfGqniKCURYCsUKg4ydRGoKS2ndx8X4LPtdmyI=; b=SxILixkjdMny4cgOI4WCjZ+aO4YZ1wUl+uEgL69XxbbYv0m22+GhNZBZbSxP1oLgEx0HM2 lfjCQDgQCaaGcIGayuRtFS41ARRMDaoz/5O/NQEky21sQzHIxUyW0eCqobMRjxTWO7JE0Q sD/mI4O6lBK5HtVrQJ8CvvKSaZshwJc= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-306-J2Ze-L6FOf-pHj4P0B5wOw-1; Fri, 22 Apr 2022 13:38:17 -0400 X-MC-Unique: J2Ze-L6FOf-pHj4P0B5wOw-1 Received: by mail-qt1-f199.google.com with SMTP id x10-20020ac8700a000000b002c3ef8fc44cso5448561qtm.8 for ; Fri, 22 Apr 2022 10:38:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=k3HrrpfGqniKCURYCsUKg4ydRGoKS2ndx8X4LPtdmyI=; b=cYUc8wjSZX/GLkU/JyandR9rMn5a8AGCHXt8O34SqedmiZKzwwqnD3YDP5rlSlrHNP tvVi/5QiGPq4/rxYLauLvoIngY7fcsQyVc3rgIl1Z8qoVs7DimDWtH6eEXaYHDOrHVLN dk6C3n/1vYsGbUOd9HhEE5AlFSqQ6deF1aP1kvF2Jan5sb6sXNjUEKq6o1qzx6SRrVr1 iTNz6Kc+uN4LrCjyL2nMm3uWksDZMTellyI0BKD8KJUPEbK43tsVuRV6BK/cYFJrhffA wJvHQMep4P9ugZoGQFpb2Q3hzoyhV/Kqk5ct/O6FUO13UiAgJhEMjCbKZ+MoO+8TYqk+ /CnQ== X-Gm-Message-State: AOAM531DJj6/AohE26/jRFC4A+8WokBmIW95YydnLYozToATxZuGOooE j46zsE6SEmQ8TYuE3bR0TyAGY8v7NFTDWEE81a4hmCrSv2zq9VY7yn6kbaTHd4lZoOPLfYCLmmI ZW2RVvZim2NYFCtGYAZezL7sz X-Received: by 2002:a37:98c4:0:b0:69a:e14:16a2 with SMTP id a187-20020a3798c4000000b0069a0e1416a2mr3413366qke.610.1650649096858; Fri, 22 Apr 2022 10:38:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxkRrCWTOZmr28sXJrcrAJhJH2aK2MQtPPCGY75e8P7o2eFbaxXJLJT6M4oqXObSBb/4+ejPw== X-Received: by 2002:a37:98c4:0:b0:69a:e14:16a2 with SMTP id a187-20020a3798c4000000b0069a0e1416a2mr3413353qke.610.1650649096641; Fri, 22 Apr 2022 10:38:16 -0700 (PDT) Received: from dell-per740-01.7a2m.lab.eng.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id g11-20020ac84b6b000000b002f35e802a55sm352570qts.1.2022.04.22.10.38.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Apr 2022 10:38:16 -0700 (PDT) From: Tom Rix To: agross@kernel.org, bjorn.andersson@linaro.org Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Tom Rix Subject: [PATCH] soc: qcom: pdr: use static for servreg_* variables Date: Fri, 22 Apr 2022 13:38:06 -0400 Message-Id: <20220422173806.21982-1-trix@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Sparse reports this repesentative issue pdr_internal.h:31:22: warning: symbol 'servreg_location_entry_ei' was not d= eclared. Should it be static? Similar for other servreg_* Global variables should not be defined in header files. This only works because pdr_internal.h is only included by pdr_interface.c. Single file use variables should be static so add static to their storage-class specifiers. Signed-off-by: Tom Rix --- drivers/soc/qcom/pdr_internal.h | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/soc/qcom/pdr_internal.h b/drivers/soc/qcom/pdr_interna= l.h index ab9ae8cdfa54..a30422214943 100644 --- a/drivers/soc/qcom/pdr_internal.h +++ b/drivers/soc/qcom/pdr_internal.h @@ -28,7 +28,7 @@ struct servreg_location_entry { u32 instance; }; =20 -struct qmi_elem_info servreg_location_entry_ei[] =3D { +static struct qmi_elem_info servreg_location_entry_ei[] =3D { { .data_type =3D QMI_STRING, .elem_len =3D SERVREG_NAME_LENGTH + 1, @@ -74,7 +74,7 @@ struct servreg_get_domain_list_req { u32 domain_offset; }; =20 -struct qmi_elem_info servreg_get_domain_list_req_ei[] =3D { +static struct qmi_elem_info servreg_get_domain_list_req_ei[] =3D { { .data_type =3D QMI_STRING, .elem_len =3D SERVREG_NAME_LENGTH + 1, @@ -116,7 +116,7 @@ struct servreg_get_domain_list_resp { struct servreg_location_entry domain_list[SERVREG_DOMAIN_LIST_LENGTH]; }; =20 -struct qmi_elem_info servreg_get_domain_list_resp_ei[] =3D { +static struct qmi_elem_info servreg_get_domain_list_resp_ei[] =3D { { .data_type =3D QMI_STRUCT, .elem_len =3D 1, @@ -199,7 +199,7 @@ struct servreg_register_listener_req { char service_path[SERVREG_NAME_LENGTH + 1]; }; =20 -struct qmi_elem_info servreg_register_listener_req_ei[] =3D { +static struct qmi_elem_info servreg_register_listener_req_ei[] =3D { { .data_type =3D QMI_UNSIGNED_1_BYTE, .elem_len =3D 1, @@ -227,7 +227,7 @@ struct servreg_register_listener_resp { enum servreg_service_state curr_state; }; =20 -struct qmi_elem_info servreg_register_listener_resp_ei[] =3D { +static struct qmi_elem_info servreg_register_listener_resp_ei[] =3D { { .data_type =3D QMI_STRUCT, .elem_len =3D 1, @@ -263,7 +263,7 @@ struct servreg_restart_pd_req { char service_path[SERVREG_NAME_LENGTH + 1]; }; =20 -struct qmi_elem_info servreg_restart_pd_req_ei[] =3D { +static struct qmi_elem_info servreg_restart_pd_req_ei[] =3D { { .data_type =3D QMI_STRING, .elem_len =3D SERVREG_NAME_LENGTH + 1, @@ -280,7 +280,7 @@ struct servreg_restart_pd_resp { struct qmi_response_type_v01 resp; }; =20 -struct qmi_elem_info servreg_restart_pd_resp_ei[] =3D { +static struct qmi_elem_info servreg_restart_pd_resp_ei[] =3D { { .data_type =3D QMI_STRUCT, .elem_len =3D 1, @@ -300,7 +300,7 @@ struct servreg_state_updated_ind { u16 transaction_id; }; =20 -struct qmi_elem_info servreg_state_updated_ind_ei[] =3D { +static struct qmi_elem_info servreg_state_updated_ind_ei[] =3D { { .data_type =3D QMI_SIGNED_4_BYTE_ENUM, .elem_len =3D 1, @@ -336,7 +336,7 @@ struct servreg_set_ack_req { u16 transaction_id; }; =20 -struct qmi_elem_info servreg_set_ack_req_ei[] =3D { +static struct qmi_elem_info servreg_set_ack_req_ei[] =3D { { .data_type =3D QMI_STRING, .elem_len =3D SERVREG_NAME_LENGTH + 1, @@ -362,7 +362,7 @@ struct servreg_set_ack_resp { struct qmi_response_type_v01 resp; }; =20 -struct qmi_elem_info servreg_set_ack_resp_ei[] =3D { +static struct qmi_elem_info servreg_set_ack_resp_ei[] =3D { { .data_type =3D QMI_STRUCT, .elem_len =3D 1, --=20 2.27.0