From nobody Sun May 10 22:40:20 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9982AC433EF for ; Thu, 21 Apr 2022 19:00:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1391712AbiDUTDd (ORCPT ); Thu, 21 Apr 2022 15:03:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1391694AbiDUTD0 (ORCPT ); Thu, 21 Apr 2022 15:03:26 -0400 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 527643A5D8 for ; Thu, 21 Apr 2022 12:00:34 -0700 (PDT) Received: by mail-ed1-x52c.google.com with SMTP id p18so2529341edr.7 for ; Thu, 21 Apr 2022 12:00:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TyZtZSd5cTSSlPOn3/pu61X0lFqS8ubq/VPK6S5b8ro=; b=KbJ8suT6akcFwDGZZ32/sv2cxbF45zgAuxPQdj0QfCAEmFFGuOSHqDPkEYVLLpv42J VTkFcGMp4k5nnelCelym6LrPoY+l3XZZ49/RQ3UrzxKHLL21LM2vUwulDGa9cBudRD/t 5z/JSupRQa2FRkazVocJUBr3XCLfI8bQvS3Zw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TyZtZSd5cTSSlPOn3/pu61X0lFqS8ubq/VPK6S5b8ro=; b=tF7PVs9NpIw47c/hXEabiZdI/TThlxZi/gv+wG22a9TfUs/8DzwucpO5j6AyDmJwGx Xcgob+ImTOuv+f99kt3GmgpZwnuOLlP30m4NMspiV94OJP7wrR/taQTzSaVmfV3z90h9 5R9CGjfZ8We3Bg1DjdiSODtSMZ3BnygyYtxGlbvUW7Jjw8OCJXZrKazjKr62V1J+NbKw 3xz3L5TEhg4sG/tkNtnHdOXHCXvarwO5fjLwc+1j9XsAiEQP6c1zjvZM8ZNOrADvuRHS DUcai/FuGV0UtX8zZCujrK/8jgDMWI1hOetwDjNlgytkQWNY5eeh8zkYEtIMKTkqpWtI an5A== X-Gm-Message-State: AOAM530kBH9hrXuzDjf/E/PuWL4+xvd8gE4w/0k78FUXzwfMfEwoxKOf yVxBGQkfu1idQlFVofEBO00lcByoz+4qjw== X-Google-Smtp-Source: ABdhPJzEgotpyjr8bxxnZGEw6QSFUz9Ctnbf2mCUqRiQErf3p7gK/T1Vy3eydjWyUgOQDWbl4g6mpg== X-Received: by 2002:aa7:de0e:0:b0:41d:6e55:24aa with SMTP id h14-20020aa7de0e000000b0041d6e5524aamr1026380edv.368.1650567632578; Thu, 21 Apr 2022 12:00:32 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.amarulasolutions.com (host-87-0-15-73.retail.telecomitalia.it. [87.0.15.73]) by smtp.gmail.com with ESMTPSA id s11-20020a170906284b00b006e108693850sm7975142ejc.28.2022.04.21.12.00.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Apr 2022 12:00:29 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Dario Binacchi , Michael Trimarchi , Rob Herring , Dmitry Torokhov , Krzysztof Kozlowski , Rob Herring , Stephan Gerhold , devicetree@vger.kernel.org, linux-input@vger.kernel.org Subject: [RESEND PATCH v4 1/6] dt-bindings: input: touchscreen: edt-ft5x06: add report-rate-hz Date: Thu, 21 Apr 2022 20:59:58 +0200 Message-Id: <20220421190003.3228699-2-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220421190003.3228699-1-dario.binacchi@amarulasolutions.com> References: <20220421190003.3228699-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" It allows to change the M06/M12 default scan rate. Co-developed-by: Michael Trimarchi Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi Acked-by: Rob Herring --- Changes in v4: - Add Rob Herring 'Acked-by' tag. Changes in v3: - Add hz unit suffix. - Add '|' to description. .../devicetree/bindings/input/touchscreen/edt-ft5x06.yaml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06= .yaml b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml index 2e8da7470513..46bc8c028fe6 100644 --- a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml +++ b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml @@ -85,6 +85,14 @@ properties: minimum: 0 maximum: 80 =20 + report-rate-hz: + description: | + Allows setting the scan rate in Hertz. + M06 supports range from 30 to 140 Hz. + M12 supports range from 1 to 255 Hz. + minimum: 1 + maximum: 255 + touchscreen-size-x: true touchscreen-size-y: true touchscreen-fuzz-x: true --=20 2.32.0 From nobody Sun May 10 22:40:20 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9BACC433EF for ; Thu, 21 Apr 2022 19:00:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1391710AbiDUTDk (ORCPT ); Thu, 21 Apr 2022 15:03:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1391693AbiDUTDf (ORCPT ); Thu, 21 Apr 2022 15:03:35 -0400 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 125CE4AE14 for ; Thu, 21 Apr 2022 12:00:42 -0700 (PDT) Received: by mail-ej1-x62a.google.com with SMTP id y20so11891755eju.7 for ; Thu, 21 Apr 2022 12:00:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5FXIG1Rp9D4NgAZ2oOx6JgdhKdrDvM+0LjdQT4OHOI8=; b=MaR3Nh0a44PUeP4GD3N3fQzpOlKuDClTPxLe42jw/eCBgTgd5mP96liXIDHRTXppE6 ixs8Ql1juGJM6TIDGV2+bJ9iYvfZ00PBMmh1w8O1yGdYwLdAzEODqrF9D0bSqvGeq50m sW/4spg0aTemVpI+udSkE8CjxlOk3WfAac4+4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5FXIG1Rp9D4NgAZ2oOx6JgdhKdrDvM+0LjdQT4OHOI8=; b=lih1HSkw+h/l3l+dZlHz2mDtv49A3xsyik3Dm4CaSEYaKc45BqIvmbaqpAIP7rV4YL MozFSBmDOZymCzWyi3YkzA9AFh+L7TRUyL5OKrZNCsboQycSXEemKGU6j4erUm4Bczgf v1B7kq8pu6d4Us+7NbmFmLQi9lRtgJdD6MozVD2Z8WbD5g+Z6umPQX65DOYPMr7g3DWj zRSMFeD3+OvvTDxW2fLUgug2/IdKBpdYEaG+/rTph/uOijuQYNEVGcuyU4VSM+QoxB7i 0CVkWNL3QbIw6fKrNi7N2ZL0SoWdFQUOQwTxeqobvXkD5Cxa6VUrQSWuA0RBT/efAxxR nq4w== X-Gm-Message-State: AOAM533+O/qQHjlA4ssUnUiDqhzOZf6BsCn4i+k4dI5sCtKjqlanBeYR r2zF9N2dw1E5tTytdEbS6wfauKmp97qg7Q== X-Google-Smtp-Source: ABdhPJxoL9Wtl1u17AlU4k2DNhoDrILAoq0+heR0L3nJccvzIFmIBYZJqw8kj58yiZXBbRQhzIKFIg== X-Received: by 2002:a17:907:1b19:b0:6f0:1022:1430 with SMTP id mp25-20020a1709071b1900b006f010221430mr843589ejc.13.1650567640396; Thu, 21 Apr 2022 12:00:40 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.amarulasolutions.com (host-87-0-15-73.retail.telecomitalia.it. [87.0.15.73]) by smtp.gmail.com with ESMTPSA id s11-20020a170906284b00b006e108693850sm7975142ejc.28.2022.04.21.12.00.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Apr 2022 12:00:34 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Dario Binacchi , Michael Trimarchi , Dmitry Torokhov , Marco Felsch , Oliver Graute , Stephan Gerhold , linux-input@vger.kernel.org Subject: [RESEND PATCH v4 2/6] Input: edt-ft5x06 - get/set M12 report rate by sysfs Date: Thu, 21 Apr 2022 20:59:59 +0200 Message-Id: <20220421190003.3228699-3-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220421190003.3228699-1-dario.binacchi@amarulasolutions.com> References: <20220421190003.3228699-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add support for reading/writing scan rate (SC) register for M12 by sysfs. The register value is equal to the SC (Hz), unlike M06, where instead it is equal to SC / 10. Co-developed-by: Michael Trimarchi Signed-off-by: Michael Trimarchi Tested-by: Dario Binacchi Signed-off-by: Dario Binacchi --- (no changes since v1) drivers/input/touchscreen/edt-ft5x06.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchsc= reen/edt-ft5x06.c index bb2e1cbffba7..77f061af5c61 100644 --- a/drivers/input/touchscreen/edt-ft5x06.c +++ b/drivers/input/touchscreen/edt-ft5x06.c @@ -47,6 +47,8 @@ #define M09_REGISTER_NUM_X 0x94 #define M09_REGISTER_NUM_Y 0x95 =20 +#define M12_REGISTER_REPORT_RATE 0x88 + #define EV_REGISTER_THRESHOLD 0x40 #define EV_REGISTER_GAIN 0x41 #define EV_REGISTER_OFFSET_Y 0x45 @@ -523,9 +525,9 @@ static EDT_ATTR(offset_y, S_IWUSR | S_IRUGO, NO_REGISTE= R, NO_REGISTER, /* m06: range 20 to 80, m09: range 0 to 30, m12: range 1 to 255... */ static EDT_ATTR(threshold, S_IWUSR | S_IRUGO, WORK_REGISTER_THRESHOLD, M09_REGISTER_THRESHOLD, EV_REGISTER_THRESHOLD, 0, 255); -/* m06: range 3 to 14, m12: (0x64: 100Hz) */ +/* m06: range 3 to 14, m12: range 1 to 255 */ static EDT_ATTR(report_rate, S_IWUSR | S_IRUGO, WORK_REGISTER_REPORT_RATE, - NO_REGISTER, NO_REGISTER, 0, 255); + M12_REGISTER_REPORT_RATE, NO_REGISTER, 0, 255); =20 static struct attribute *edt_ft5x06_attrs[] =3D { &edt_ft5x06_attr_gain.dattr.attr, @@ -1030,7 +1032,8 @@ static void edt_ft5x06_ts_set_regs(struct edt_ft5x06_= ts_data *tsdata) case EDT_M09: case EDT_M12: reg_addr->reg_threshold =3D M09_REGISTER_THRESHOLD; - reg_addr->reg_report_rate =3D NO_REGISTER; + reg_addr->reg_report_rate =3D tsdata->version =3D=3D EDT_M12 ? + M12_REGISTER_REPORT_RATE : NO_REGISTER; reg_addr->reg_gain =3D M09_REGISTER_GAIN; reg_addr->reg_offset =3D M09_REGISTER_OFFSET; reg_addr->reg_offset_x =3D NO_REGISTER; --=20 2.32.0 From nobody Sun May 10 22:40:20 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AD01C433EF for ; Thu, 21 Apr 2022 19:01:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1391692AbiDUTDs (ORCPT ); Thu, 21 Apr 2022 15:03:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46526 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1391693AbiDUTDl (ORCPT ); Thu, 21 Apr 2022 15:03:41 -0400 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD96142EC4 for ; Thu, 21 Apr 2022 12:00:50 -0700 (PDT) Received: by mail-ed1-x52d.google.com with SMTP id f17so7702389edt.4 for ; Thu, 21 Apr 2022 12:00:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NIUuHRgvgWCmYJCricL+FHDsiVQYgUJ0FjEwcnUqvHA=; b=m2IC8FNcMpgWptpAk5irJwhOTaeWH7pd1WYL0g/hEONSJ34jgGfLZtZiLIJJSCUJ0l JmrOJQSrFs2W7lnz/IKcWhRnBQx5ZYZPmiTjP+A+R8IusFP4rSZKWgtKgzQnaJy0lDR4 ovtzUi7Nyiz5PfyX9jbzD91/J6mi+3Ez71YjE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NIUuHRgvgWCmYJCricL+FHDsiVQYgUJ0FjEwcnUqvHA=; b=sw+mlQi7Lv+HPRx5g4lbR2MdDs+H9wdmqvm7kKKDUhOOHE2Si2ORpgv7lEw5P5cflw uxx6O2OLBhr1o8EM2mQJPQSRz2/e4/pCkuy8j971pIBD8iT1aIQXw4pSrrK1KFYR9a31 Q+Cs7tiYInV71fBzjp6w61GgNqUZ8FSKVVCA7XJXAa6Pl/N5Cq5VGl0TOTspMTAR+9Wm swjoxpv0AiTm808doD8ngkPR43jgeJDG9XlarmTkkBcykiaoJM2mr0Jp+0klwH7VRWuz fg9KLU4iwZhsJOJK0edvYblZNjRH597l6+HzSDxABkn++3cFPkxwQ6KN+DSRRf/tG1gh sBOA== X-Gm-Message-State: AOAM532ZB3ncnMUyDaSpfOGEex+3XcwzHvB5uuTRHEGJwTGonna0l9cH f0YKFlVpoz9QClSylpAaG0K9U5lTQdtiAQ== X-Google-Smtp-Source: ABdhPJxQiLhPFSbkfabOPaFiFv0NiEGVjipYprjVWUNCWZdLj48Nxc0yKpYdzzHF3PJT+UpVZvBAeQ== X-Received: by 2002:a05:6402:1707:b0:41d:9794:6421 with SMTP id y7-20020a056402170700b0041d97946421mr1047302edu.212.1650567649267; Thu, 21 Apr 2022 12:00:49 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.amarulasolutions.com (host-87-0-15-73.retail.telecomitalia.it. [87.0.15.73]) by smtp.gmail.com with ESMTPSA id s11-20020a170906284b00b006e108693850sm7975142ejc.28.2022.04.21.12.00.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Apr 2022 12:00:42 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Dario Binacchi , Michael Trimarchi , Dmitry Torokhov , Marco Felsch , Oliver Graute , Stephan Gerhold , linux-input@vger.kernel.org Subject: [RESEND PATCH v4 3/6] Input: edt-ft5x06 - set report rate by dts property Date: Thu, 21 Apr 2022 21:00:00 +0200 Message-Id: <20220421190003.3228699-4-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220421190003.3228699-1-dario.binacchi@amarulasolutions.com> References: <20220421190003.3228699-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" It allows to change the M06/M12 default scan rate on driver probing. Co-developed-by: Michael Trimarchi Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi --- (no changes since v3) Changes in v3: - Check the lower and upper limits of the report-rate-hz value - Convert the M06 report-rate-hz value drivers/input/touchscreen/edt-ft5x06.c | 30 ++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchsc= reen/edt-ft5x06.c index 77f061af5c61..843e8b0522f7 100644 --- a/drivers/input/touchscreen/edt-ft5x06.c +++ b/drivers/input/touchscreen/edt-ft5x06.c @@ -1084,6 +1084,7 @@ static int edt_ft5x06_ts_probe(struct i2c_client *cli= ent, struct input_dev *input; unsigned long irq_flags; int error; + u32 report_rate; char fw_version[EDT_NAME_LEN]; =20 dev_dbg(&client->dev, "probing for EDT FT5x06 I2C\n"); @@ -1213,6 +1214,35 @@ static int edt_ft5x06_ts_probe(struct i2c_client *cl= ient, edt_ft5x06_ts_get_defaults(&client->dev, tsdata); edt_ft5x06_ts_get_parameters(tsdata); =20 + if (tsdata->reg_addr.reg_report_rate !=3D NO_REGISTER && + !of_property_read_u32(client->dev.of_node, "report-rate-hz", + &report_rate)) { + tsdata->report_rate =3D report_rate; + if (tsdata->version =3D=3D EDT_M06) { + if (report_rate < 30) + report_rate =3D 30; + else if (report_rate > 140) + report_rate =3D 140; + } else if (report_rate < 1) { + report_rate =3D 1; + } else if (report_rate > 255) + report_rate =3D 255; + + if (report_rate !=3D tsdata->report_rate) + dev_warn(&client->dev, + "report-rate %dHz is unsupported, use %dHz\n", + tsdata->report_rate, report_rate); + + if (tsdata->version =3D=3D EDT_M06) + report_rate /=3D 10; + + tsdata->report_rate =3D report_rate; + + edt_ft5x06_register_write(tsdata, + tsdata->reg_addr.reg_report_rate, + tsdata->report_rate); + } + dev_dbg(&client->dev, "Model \"%s\", Rev. \"%s\", %dx%d sensors\n", tsdata->name, fw_version, tsdata->num_x, tsdata->num_y); --=20 2.32.0 From nobody Sun May 10 22:40:20 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B559C433FE for ; Thu, 21 Apr 2022 19:01:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1391699AbiDUTEh (ORCPT ); Thu, 21 Apr 2022 15:04:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1386191AbiDUTEf (ORCPT ); Thu, 21 Apr 2022 15:04:35 -0400 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2928C49924 for ; Thu, 21 Apr 2022 12:01:45 -0700 (PDT) Received: by mail-ej1-x634.google.com with SMTP id y10so11871466ejw.8 for ; Thu, 21 Apr 2022 12:01:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=b85JvDSGn8w4tr7JpVbjtxkbsu1O4D+F+hX3OsbfqCs=; b=ka0bSzqelK6lJUthcRpFwJgtlNk/odO7kgggb5rUBc+F9MxHrAiagKn17SvGC6jvkl BTE5CZ+DkTc2VSfuLv8wBIWTDffVF0jwMdBKR7zX4NT7PHstkijKl8PQtxkOShOghHUz bzl8LWmOaNwYy0ryHBX5rA1mezy5nnM/gyp+o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=b85JvDSGn8w4tr7JpVbjtxkbsu1O4D+F+hX3OsbfqCs=; b=ngX1GX89L4MKUD2nnuTe/Sb5OYrzI7Exfmw+xLW8P11fbNtn3hfS2S+M8Gax7ab/JV 3y7Q1/QKoMVgWDoSVpY1haM0HDTZdI1lnryBsiBmGo3YuweFvUNiul5NsE2QRKPThy2R RA63/Hlr8FSxLez9PF4UpVeQyRzzBqMjZNip3XttZ2ooZ8E1t8wwg/+lwSwzNf3nYj90 gWVjlwHpKjGgO+G0qh+QM7rvYlpAabSzIS8y+9HlfiqZFo9zEFec+idKvdTC3pjnvTua FJiPXuvgmAbBZBffeRO9KMB1vN/MyOWwL0zj3/jksxz1ltKC+mvjWw1ob5brP5cxXTqt GvYQ== X-Gm-Message-State: AOAM532/DpsFcZzZYu2uzOHhUuI9MYRH6K4Wpz78u5UmKWdfLpfrhwkp nW6uekjX+J+gueZg6uW/kvm7SnExieB7BQ== X-Google-Smtp-Source: ABdhPJxVGUh+88fza3C0hBCin08Pv3Ewf46UwISRqQuu2FYh8ryW+j/atM0tg7WYIEtPnpITj/krSA== X-Received: by 2002:a17:906:2bcb:b0:6e7:f655:3b96 with SMTP id n11-20020a1709062bcb00b006e7f6553b96mr801376ejg.175.1650567703496; Thu, 21 Apr 2022 12:01:43 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.amarulasolutions.com (host-87-0-15-73.retail.telecomitalia.it. [87.0.15.73]) by smtp.gmail.com with ESMTPSA id s11-20020a170906284b00b006e108693850sm7975142ejc.28.2022.04.21.12.00.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Apr 2022 12:01:04 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Dario Binacchi , Michael Trimarchi , Oliver Graute , Dmitry Torokhov , Stephan Gerhold , linux-input@vger.kernel.org Subject: [RESEND PATCH v4 4/6] Input: edt-ft5x06 - show model name by sysfs Date: Thu, 21 Apr 2022 21:00:01 +0200 Message-Id: <20220421190003.3228699-5-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220421190003.3228699-1-dario.binacchi@amarulasolutions.com> References: <20220421190003.3228699-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The model name was printed only if debug mode was enabled. Now you can always get it from sysfs. Co-developed-by: Michael Trimarchi Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi Acked-by: Oliver Graute --- (no changes since v1) drivers/input/touchscreen/edt-ft5x06.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchsc= reen/edt-ft5x06.c index 843e8b0522f7..89157deebfcb 100644 --- a/drivers/input/touchscreen/edt-ft5x06.c +++ b/drivers/input/touchscreen/edt-ft5x06.c @@ -529,6 +529,17 @@ static EDT_ATTR(threshold, S_IWUSR | S_IRUGO, WORK_REG= ISTER_THRESHOLD, static EDT_ATTR(report_rate, S_IWUSR | S_IRUGO, WORK_REGISTER_REPORT_RATE, M12_REGISTER_REPORT_RATE, NO_REGISTER, 0, 255); =20 +static ssize_t model_show(struct device *dev, struct device_attribute *att= r, + char *buf) +{ + struct i2c_client *client =3D to_i2c_client(dev); + struct edt_ft5x06_ts_data *tsdata =3D i2c_get_clientdata(client); + + return scnprintf(buf, PAGE_SIZE, "%s\n", tsdata->name); +} + +static DEVICE_ATTR_RO(model); + static struct attribute *edt_ft5x06_attrs[] =3D { &edt_ft5x06_attr_gain.dattr.attr, &edt_ft5x06_attr_offset.dattr.attr, @@ -536,6 +547,7 @@ static struct attribute *edt_ft5x06_attrs[] =3D { &edt_ft5x06_attr_offset_y.dattr.attr, &edt_ft5x06_attr_threshold.dattr.attr, &edt_ft5x06_attr_report_rate.dattr.attr, + &dev_attr_model.attr, NULL }; =20 --=20 2.32.0 From nobody Sun May 10 22:40:20 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D46FBC433EF for ; Thu, 21 Apr 2022 19:02:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1391722AbiDUTFG (ORCPT ); Thu, 21 Apr 2022 15:05:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1391709AbiDUTFE (ORCPT ); Thu, 21 Apr 2022 15:05:04 -0400 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB6DF49924 for ; Thu, 21 Apr 2022 12:02:13 -0700 (PDT) Received: by mail-ej1-x636.google.com with SMTP id u15so11850614ejf.11 for ; Thu, 21 Apr 2022 12:02:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YV+qTrBSZlEdVwvYGQdRpxUtm5BLonFPqiCggidUwTw=; b=B1H5ZgGpA63O5v5dDseCQC6tK+EJtNplHma4xWuSCMbmqOMxRoeqCVZLiBpjha9ied HJ0QtiOUImNuvD3lpJ8AOVNqvxXLzuO8WMkJNpKLVeGzPXvm9kem0R40B3e3G8TnVk28 lY31fw5J9GhwRn0P4mOlchEOVhna0sfWs7PKQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YV+qTrBSZlEdVwvYGQdRpxUtm5BLonFPqiCggidUwTw=; b=RcsBuVlX/FLisY7A5IdCYkhWEjIH0wFKMLNuagk8UAhctm24ooKAXxR2dI+QauLC4G D7C/D+xHHCjyIZ9/0PzrQw96n/+L7M+Pfn5RAanGbd69XxXhVJbnKIy8V/B9n1RgaNSZ QSoELY3DBLBvXm5oB5+FcWwedy6wIVBWvEfVJ2E7CNAeiRujDy08iQQUzMkU7RhcXJmE f0G7EMijCi1SL9dnqscuSkBIwZSyWvz+c5W7m+TXSSs2n64mXO5UxUCoKNHFMDt0bzlU LMCdtW1+PzjWDvRtHu9orkxj7R6jQ8e/4xalMzK5K+ui2UErJU9v4zmQkHsB0JzEsuDj 68xQ== X-Gm-Message-State: AOAM533eiiY4uo33MdPyPBTyB887PH7w5wfpxRVl299EjQ7vvMgK5b6F XdMcEbI8z1iqChErXx21zKvCbMOYN4fqFw== X-Google-Smtp-Source: ABdhPJwGnZ7s87UVdhDRJD6kiBB+YdmIaMSZceyr0LboNbbh6ou7VG2d0CGXpF4Nkk6oL49LbjBzEw== X-Received: by 2002:a17:907:7f09:b0:6f0:2991:9c76 with SMTP id qf9-20020a1709077f0900b006f029919c76mr853725ejc.170.1650567732081; Thu, 21 Apr 2022 12:02:12 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.amarulasolutions.com (host-87-0-15-73.retail.telecomitalia.it. [87.0.15.73]) by smtp.gmail.com with ESMTPSA id s11-20020a170906284b00b006e108693850sm7975142ejc.28.2022.04.21.12.01.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Apr 2022 12:01:48 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Dario Binacchi , Michael Trimarchi , Oliver Graute , Dmitry Torokhov , Stephan Gerhold , linux-input@vger.kernel.org Subject: [RESEND PATCH v4 5/6] Input: edt-ft5x06 - show firmware version by sysfs Date: Thu, 21 Apr 2022 21:00:02 +0200 Message-Id: <20220421190003.3228699-6-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220421190003.3228699-1-dario.binacchi@amarulasolutions.com> References: <20220421190003.3228699-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The firmware version was printed only if debug mode was enabled. Now you can always get it from sysfs. Co-developed-by: Michael Trimarchi Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi Acked-by: Oliver Graute --- (no changes since v1) drivers/input/touchscreen/edt-ft5x06.c | 22 +++++++++++++++++----- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchsc= reen/edt-ft5x06.c index 89157deebfcb..bab92344b2ea 100644 --- a/drivers/input/touchscreen/edt-ft5x06.c +++ b/drivers/input/touchscreen/edt-ft5x06.c @@ -129,6 +129,7 @@ struct edt_ft5x06_ts_data { int max_support_points; =20 char name[EDT_NAME_LEN]; + char fw_version[EDT_NAME_LEN]; =20 struct edt_reg_addr reg_addr; enum edt_ver version; @@ -540,6 +541,17 @@ static ssize_t model_show(struct device *dev, struct d= evice_attribute *attr, =20 static DEVICE_ATTR_RO(model); =20 +static ssize_t fw_version_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + struct i2c_client *client =3D to_i2c_client(dev); + struct edt_ft5x06_ts_data *tsdata =3D i2c_get_clientdata(client); + + return scnprintf(buf, PAGE_SIZE, "%s\n", tsdata->fw_version); +} + +static DEVICE_ATTR_RO(fw_version); + static struct attribute *edt_ft5x06_attrs[] =3D { &edt_ft5x06_attr_gain.dattr.attr, &edt_ft5x06_attr_offset.dattr.attr, @@ -548,6 +560,7 @@ static struct attribute *edt_ft5x06_attrs[] =3D { &edt_ft5x06_attr_threshold.dattr.attr, &edt_ft5x06_attr_report_rate.dattr.attr, &dev_attr_model.attr, + &dev_attr_fw_version.attr, NULL }; =20 @@ -834,13 +847,13 @@ static void edt_ft5x06_ts_teardown_debugfs(struct edt= _ft5x06_ts_data *tsdata) #endif /* CONFIG_DEBUGFS */ =20 static int edt_ft5x06_ts_identify(struct i2c_client *client, - struct edt_ft5x06_ts_data *tsdata, - char *fw_version) + struct edt_ft5x06_ts_data *tsdata) { u8 rdbuf[EDT_NAME_LEN]; char *p; int error; char *model_name =3D tsdata->name; + char *fw_version =3D tsdata->fw_version; =20 /* see what we find if we assume it is a M06 * * if we get less than EDT_NAME_LEN, we don't want @@ -1097,7 +1110,6 @@ static int edt_ft5x06_ts_probe(struct i2c_client *cli= ent, unsigned long irq_flags; int error; u32 report_rate; - char fw_version[EDT_NAME_LEN]; =20 dev_dbg(&client->dev, "probing for EDT FT5x06 I2C\n"); =20 @@ -1210,7 +1222,7 @@ static int edt_ft5x06_ts_probe(struct i2c_client *cli= ent, tsdata->input =3D input; tsdata->factory_mode =3D false; =20 - error =3D edt_ft5x06_ts_identify(client, tsdata, fw_version); + error =3D edt_ft5x06_ts_identify(client, tsdata); if (error) { dev_err(&client->dev, "touchscreen probe failed\n"); return error; @@ -1257,7 +1269,7 @@ static int edt_ft5x06_ts_probe(struct i2c_client *cli= ent, =20 dev_dbg(&client->dev, "Model \"%s\", Rev. \"%s\", %dx%d sensors\n", - tsdata->name, fw_version, tsdata->num_x, tsdata->num_y); + tsdata->name, tsdata->fw_version, tsdata->num_x, tsdata->num_y); =20 input->name =3D tsdata->name; input->id.bustype =3D BUS_I2C; --=20 2.32.0 From nobody Sun May 10 22:40:20 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CD32C433EF for ; Thu, 21 Apr 2022 19:02:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1391727AbiDUTFR (ORCPT ); Thu, 21 Apr 2022 15:05:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48126 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1391720AbiDUTFO (ORCPT ); Thu, 21 Apr 2022 15:05:14 -0400 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC82C4BFDE for ; Thu, 21 Apr 2022 12:02:23 -0700 (PDT) Received: by mail-ed1-x535.google.com with SMTP id f17so7707766edt.4 for ; Thu, 21 Apr 2022 12:02:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=V78a4T+XxMalGYKe1sIzEqFdtRWisjMfkHNLxFh+Xuk=; b=HHkEqxTxydBkOPTAWKKQG/XvT+4YPu7xQsaD3xEJkvmj/jeK3VMbwKQ98Hbg4RrxiH YELlCFmGs11cjfEKrDmGA95J5WqdeDTp8cqZivOwf0LvaC+Bw6LnM9/isAzazgkYZZhW GHhXNNhnP63fA/YlhvZ9WEMMZ1Lf61iZnKvKM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=V78a4T+XxMalGYKe1sIzEqFdtRWisjMfkHNLxFh+Xuk=; b=ZT7M24ji+Iqz49fCx3AsxC5KA3CgkORFj9toImmWmAA/33gdaLP5dDRlRSAsAUPe2N iWDKv3V/VSyT+j33nKBQsQfVPPU+Z3hlMVbCrvsoo6jdYRK7oQA1yEPIWRJOHmCTEYEb n3t7Jz/knNEiBzOdHude/B+j++eicGfk0TYY7Rl7sy1oGvnw5p0vKBnCXhZucM2UTY7A 5vUkWpStgPqrzCeyLpU6N6rSsXal/n/yWKSn2aI8AeLX0Y8gm4HU0j9iX9oUOBxn6ufR XsXwbNe9qHbvXDluF0tqhGN52dN8yOoEfVKPKLUitdsdz5z9eAvUDekK7ZBdzKhnb5+t 6l0g== X-Gm-Message-State: AOAM533UDa3eJHa3opiy7WKoBG6CXmlA3+EugRsk13tBqO0w8QwBdtVK +IyeZG34T4M68sPkp69PSPFH1Sua/U0WYg== X-Google-Smtp-Source: ABdhPJz0KGL6rSjm6EhATFv3ykGqeGZcALLvHUMKiYbjmdhG/nGMAxcs10My5jkMKrm9TOdaIQh09w== X-Received: by 2002:a05:6402:1a44:b0:41d:8969:e4c9 with SMTP id bf4-20020a0564021a4400b0041d8969e4c9mr997941edb.299.1650567741656; Thu, 21 Apr 2022 12:02:21 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.amarulasolutions.com (host-87-0-15-73.retail.telecomitalia.it. [87.0.15.73]) by smtp.gmail.com with ESMTPSA id s11-20020a170906284b00b006e108693850sm7975142ejc.28.2022.04.21.12.02.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Apr 2022 12:02:13 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Dario Binacchi , Michael Trimarchi , Dmitry Torokhov , Oliver Graute , Stephan Gerhold , linux-input@vger.kernel.org Subject: [RESEND PATCH v4 6/6] Input: edt-ft5x06 - show crc and header errors by sysfs Date: Thu, 21 Apr 2022 21:00:03 +0200 Message-Id: <20220421190003.3228699-7-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220421190003.3228699-1-dario.binacchi@amarulasolutions.com> References: <20220421190003.3228699-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" M06 sends packets with header and crc for data verification. Now you can check at runtime how many packets have been dropped. Co-developed-by: Michael Trimarchi Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi --- (no changes since v2) Changes in v2: - Add Oliver Graute's 'Acked-by' tag to: * Input: edt-ft5x06 - show model name by sysfs * Input: edt-ft5x06 - show firmware version by sysfs - Fix yaml file. Tested with `make DT_CHECKER_FLAGS=3D-m dt_binding_check'. drivers/input/touchscreen/edt-ft5x06.c | 30 ++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchsc= reen/edt-ft5x06.c index bab92344b2ea..3deb66d67469 100644 --- a/drivers/input/touchscreen/edt-ft5x06.c +++ b/drivers/input/touchscreen/edt-ft5x06.c @@ -133,6 +133,8 @@ struct edt_ft5x06_ts_data { =20 struct edt_reg_addr reg_addr; enum edt_ver version; + unsigned int crc_errors; + unsigned int header_errors; }; =20 struct edt_i2c_chip_data { @@ -181,6 +183,7 @@ static bool edt_ft5x06_ts_check_crc(struct edt_ft5x06_t= s_data *tsdata, crc ^=3D buf[i]; =20 if (crc !=3D buf[buflen-1]) { + tsdata->crc_errors++; dev_err_ratelimited(&tsdata->client->dev, "crc error: 0x%02x expected, got 0x%02x\n", crc, buf[buflen-1]); @@ -238,6 +241,7 @@ static irqreturn_t edt_ft5x06_ts_isr(int irq, void *dev= _id) if (tsdata->version =3D=3D EDT_M06) { if (rdbuf[0] !=3D 0xaa || rdbuf[1] !=3D 0xaa || rdbuf[2] !=3D datalen) { + tsdata->header_errors++; dev_err_ratelimited(dev, "Unexpected header: %02x%02x%02x!\n", rdbuf[0], rdbuf[1], rdbuf[2]); @@ -552,6 +556,30 @@ static ssize_t fw_version_show(struct device *dev, =20 static DEVICE_ATTR_RO(fw_version); =20 +/* m06 only */ +static ssize_t header_errors_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + struct i2c_client *client =3D to_i2c_client(dev); + struct edt_ft5x06_ts_data *tsdata =3D i2c_get_clientdata(client); + + return scnprintf(buf, PAGE_SIZE, "%d\n", tsdata->header_errors); +} + +static DEVICE_ATTR_RO(header_errors); + +/* m06 only */ +static ssize_t crc_errors_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + struct i2c_client *client =3D to_i2c_client(dev); + struct edt_ft5x06_ts_data *tsdata =3D i2c_get_clientdata(client); + + return scnprintf(buf, PAGE_SIZE, "%d\n", tsdata->crc_errors); +} + +static DEVICE_ATTR_RO(crc_errors); + static struct attribute *edt_ft5x06_attrs[] =3D { &edt_ft5x06_attr_gain.dattr.attr, &edt_ft5x06_attr_offset.dattr.attr, @@ -561,6 +589,8 @@ static struct attribute *edt_ft5x06_attrs[] =3D { &edt_ft5x06_attr_report_rate.dattr.attr, &dev_attr_model.attr, &dev_attr_fw_version.attr, + &dev_attr_header_errors.attr, + &dev_attr_crc_errors.attr, NULL }; =20 --=20 2.32.0