From nobody Mon May 11 00:10:12 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BEC9C433EF for ; Wed, 20 Apr 2022 21:41:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1382620AbiDTVoJ (ORCPT ); Wed, 20 Apr 2022 17:44:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1382624AbiDTVoH (ORCPT ); Wed, 20 Apr 2022 17:44:07 -0400 Received: from mail-4323.proton.ch (mail-4323.proton.ch [185.70.43.23]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06CF8427CD; Wed, 20 Apr 2022 14:41:16 -0700 (PDT) Date: Wed, 20 Apr 2022 21:41:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wujek.eu; s=protonmail2; t=1650490875; bh=KmMNR6faHtqUvs9lVAABz3wIvjkciGijqVJv/rEeN9I=; h=Date:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID; b=BQOGgQSpieFh8CzNHO1r9GsXm5vX25hwrxRQgpNc6JPeFNbfvuyQYPPXqk63USmoq 4wFe02/TalZU1zaSWcQwbJYXRBhRGrUJMARxkPReRzYl5wBG4kVcZwT4/ekUHsk+6L 4B0ImiqaYTAqHQcD0EQ/abedaoDN7/0YwuBHbXcq3/3GWHT0RVR89hw3dYlTUQDVQr uwxdYoAjZOdfjisuC+yRsvRF1u2tg6qt4wJ6t12TgnmPmBWoRP7RDcsvD04YcvhMH/ RirH6RldwGVSdf7ncjjo7pAjR5/hIuJuAdcEQoWNzaOAwcf9N9DSdpsibnFOADnX9d cQea3NZRgV+rA== From: Adam Wujek Cc: Adam Wujek , Guenter Roeck , Jean Delvare , linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Reply-To: Adam Wujek Subject: [v4 PATCH] hwmon: (pmbus) add MFR_* registers to debugfs Message-ID: <20220420214053.482902-1-dev_public@wujek.eu> In-Reply-To: <1b12cb3a-3d87-8254-b229-dcf83ad0bc0a@roeck-us.net> References: <20220419215326.309991-1-dev_public@wujek.eu> <20220420122128.411757-1-dev_public@wujek.eu> <6f697b2c-58aa-6ca4-966b-147bcc184dad@roeck-us.net> <1b12cb3a-3d87-8254-b229-dcf83ad0bc0a@roeck-us.net> Feedback-ID: 23425257:user:proton MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add registers to debugfs: PMBUS_MFR_ID PMBUS_MFR_MODEL PMBUS_MFR_REVISION PMBUS_MFR_LOCATION PMBUS_MFR_DATE PMBUS_MFR_SERIAL Signed-off-by: Adam Wujek --- Notes: Changes in v2: - Rebase to the latest kernel - Marked wrongly as a part of series of patches Changes in v3: - Submit as a single patch. V2 was wrongly submitted as a part of series of patches - Add justification for "rc +=3D 2;" - Increase allocated memory for debugfs entries Changes in v4: - Change "rc +=3D 2;" into "rc +=3D 1;". With "rc +=3D 2" an extra '\0'= is observed after '\n' at the end of debugfs file's output. drivers/hwmon/pmbus/pmbus_core.c | 89 +++++++++++++++++++++++++++++++- 1 file changed, 88 insertions(+), 1 deletion(-) diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_c= ore.c index d93574d6a1fb..a791e5f08fb2 100644 --- a/drivers/hwmon/pmbus/pmbus_core.c +++ b/drivers/hwmon/pmbus/pmbus_core.c @@ -2627,6 +2627,33 @@ static int pmbus_debugfs_get_status(void *data, u64 = *val) DEFINE_DEBUGFS_ATTRIBUTE(pmbus_debugfs_ops_status, pmbus_debugfs_get_statu= s, NULL, "0x%04llx\n"); +static ssize_t pmbus_debugfs_mfr_read(struct file *file, char __user *buf, + size_t count, loff_t *ppos) +{ + int rc; + struct pmbus_debugfs_entry *entry =3D file->private_data; + char data[I2C_SMBUS_BLOCK_MAX + 2] =3D { 0 }; + + rc =3D i2c_smbus_read_block_data(entry->client, entry->reg, data); + if (rc < 0) + return rc; + + /* Add newline at the end of a read data */ + data[rc] =3D '\n'; + + /* Include newline into the length */ + rc +=3D 1; + + return simple_read_from_buffer(buf, count, ppos, data, rc); +} + +static const struct file_operations pmbus_debugfs_ops_mfr =3D { + .llseek =3D noop_llseek, + .read =3D pmbus_debugfs_mfr_read, + .write =3D NULL, + .open =3D simple_open, +}; + static int pmbus_debugfs_get_pec(void *data, u64 *val) { struct i2c_client *client =3D data; @@ -2693,7 +2720,7 @@ static int pmbus_init_debugfs(struct i2c_client *clie= nt, /* Allocate the max possible entries we need. */ entries =3D devm_kcalloc(data->dev, - data->info->pages * 10, sizeof(*entries), + data->info->pages * 16, sizeof(*entries), GFP_KERNEL); if (!entries) return -ENOMEM; @@ -2803,6 +2830,66 @@ static int pmbus_init_debugfs(struct i2c_client *cli= ent, &entries[idx++], &pmbus_debugfs_ops); } + + if (pmbus_check_byte_register(client, i, PMBUS_MFR_ID)) { + entries[idx].client =3D client; + entries[idx].page =3D i; + entries[idx].reg =3D PMBUS_MFR_ID; + scnprintf(name, PMBUS_NAME_SIZE, "mfr%d_id", i); + debugfs_create_file(name, 0444, data->debugfs, + &entries[idx++], + &pmbus_debugfs_ops_mfr); + } + + if (pmbus_check_byte_register(client, i, PMBUS_MFR_MODEL)) { + entries[idx].client =3D client; + entries[idx].page =3D i; + entries[idx].reg =3D PMBUS_MFR_MODEL; + scnprintf(name, PMBUS_NAME_SIZE, "mfr%d_model", i); + debugfs_create_file(name, 0444, data->debugfs, + &entries[idx++], + &pmbus_debugfs_ops_mfr); + } + + if (pmbus_check_byte_register(client, i, PMBUS_MFR_REVISION)) { + entries[idx].client =3D client; + entries[idx].page =3D i; + entries[idx].reg =3D PMBUS_MFR_REVISION; + scnprintf(name, PMBUS_NAME_SIZE, "mfr%d_revision", i); + debugfs_create_file(name, 0444, data->debugfs, + &entries[idx++], + &pmbus_debugfs_ops_mfr); + } + + if (pmbus_check_byte_register(client, i, PMBUS_MFR_LOCATION)) { + entries[idx].client =3D client; + entries[idx].page =3D i; + entries[idx].reg =3D PMBUS_MFR_LOCATION; + scnprintf(name, PMBUS_NAME_SIZE, "mfr%d_location", i); + debugfs_create_file(name, 0444, data->debugfs, + &entries[idx++], + &pmbus_debugfs_ops_mfr); + } + + if (pmbus_check_byte_register(client, i, PMBUS_MFR_DATE)) { + entries[idx].client =3D client; + entries[idx].page =3D i; + entries[idx].reg =3D PMBUS_MFR_DATE; + scnprintf(name, PMBUS_NAME_SIZE, "mfr%d_date", i); + debugfs_create_file(name, 0444, data->debugfs, + &entries[idx++], + &pmbus_debugfs_ops_mfr); + } + + if (pmbus_check_byte_register(client, i, PMBUS_MFR_SERIAL)) { + entries[idx].client =3D client; + entries[idx].page =3D i; + entries[idx].reg =3D PMBUS_MFR_SERIAL; + scnprintf(name, PMBUS_NAME_SIZE, "mfr%d_serial", i); + debugfs_create_file(name, 0444, data->debugfs, + &entries[idx++], + &pmbus_debugfs_ops_mfr); + } } return devm_add_action_or_reset(data->dev, -- 2.25.1