From nobody Mon May 11 00:45:13 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44F2AC433F5 for ; Wed, 20 Apr 2022 01:17:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358700AbiDTBTm (ORCPT ); Tue, 19 Apr 2022 21:19:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54434 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1358701AbiDTBTi (ORCPT ); Tue, 19 Apr 2022 21:19:38 -0400 Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C8E72E6A9 for ; Tue, 19 Apr 2022 18:16:54 -0700 (PDT) Received: by mail-pf1-x432.google.com with SMTP id n22so505990pfa.0 for ; Tue, 19 Apr 2022 18:16:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id:in-reply-to:references; bh=awQ89Q2eVIn5YtdJtEsw9K0fnZEisfTylDK7brSxfAI=; b=ZvuY6hhlzcCFNr5CrpHawrlh8ladPMknFoA86rFmUlkTMZDJDbdfPhhew6+FHWnpCk +FDTGNRKSL6QIZ2xIqtNOC/sETeJGWJUe0bPBqKynQWjbQslUqxhDEmyp1BlOL5IRviC BWNZTni9zkFf4LKtey1D+xcV8Yfo0Bg3jcI13oyBC3+Lup3dxUHY38P9sSDTNrtrvrvv TWKtpwT3B9Ga+HRSAp1CTjrdePoEprxGUxWsPSfW21CHJtUO8AGG/w1ySQ4fwygBSRNv Ga2bIo0qevA5EnuVJd1qATgck/fPo1TUk+pgAOBC3bHMrXG1LsedU9JnXS4qFxK03Q89 5yng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=awQ89Q2eVIn5YtdJtEsw9K0fnZEisfTylDK7brSxfAI=; b=W6BSfJ9+exXNEehT+ZSvYkIn2mA3ZUim6TcIuGGy9Og/zU9wdVRItj1Y3YkZMTpVIU WBYS7BD3qPo2j5lRJOt9k5a9D5VQ2tu6uQYpSVTRBkyQyP1c1c5IfZ7a26nsghdUtqGf fdoD8HPAF/fBMyQfiazojjyycJ82DWl3CuDdiHjvLOVhYlunvuh6F3aq+ehX/CH5cZHR Bdyi0DOIh2MoPTjuBQu1RE8ZNh/lCJ8jDhG+YirkxmS9sfLvbDOMfPpPQh6Y2qobk8LM KIubhjFDY9Ljp6EP2agBmDzRkyYh/Htfy/d8m+kgpDgRjkJdt3pqNta1kChkIjGTxQX3 qYWw== X-Gm-Message-State: AOAM5333juZOH6c9td3Eh4pmBw8h6ndn895aSUEcstq9vUsmLSH22XSQ 44DlDchXAdY9A/U16ZZGDAU= X-Google-Smtp-Source: ABdhPJzjbFBIwom0FEvdj81aRBOLVKoduObhzayfRfK9ccXI226pDSUG4+046qvUgjNopJQGP1k6rQ== X-Received: by 2002:a65:6657:0:b0:381:1b99:3f04 with SMTP id z23-20020a656657000000b003811b993f04mr16771033pgv.512.1650417413525; Tue, 19 Apr 2022 18:16:53 -0700 (PDT) Received: from localhost.localdomain ([159.226.95.43]) by smtp.googlemail.com with ESMTPSA id f33-20020a631021000000b0039dbae3fce0sm17926598pgl.43.2022.04.19.18.16.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Apr 2022 18:16:53 -0700 (PDT) From: Miaoqian Lin To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , Dave Airlie , Tomi Valkeinen , Jyri Sarha , Miaoqian Lin , Lyude Paul , Maxime Ripard , Yakir Yang , Inki Dae , Heiko Stuebner , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] drm/bridge: Fix error handling in analogix_dp_probe Date: Wed, 20 Apr 2022 01:16:40 +0000 Message-Id: <20220420011644.25730-1-linmq006@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <202204031935.5SkYsM2M-lkp@intel.com> References: <202204031935.5SkYsM2M-lkp@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" In the error handling path, the clk_prepare_enable() function call should be balanced by a corresponding 'clk_disable_unprepare()' call , as already done in the remove function. Fixes: 3424e3a4f844 ("drm: bridge: analogix/dp: split exynos dp driver to b= ridge directory") Signed-off-by: Miaoqian Lin Reviewed-by: Robert Foss --- changes in v2: - remove the wrong return statement. --- .../gpu/drm/bridge/analogix/analogix_dp_core.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/g= pu/drm/bridge/analogix/analogix_dp_core.c index eb590fb8e8d0..474ef88015ae 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c @@ -1698,8 +1698,10 @@ analogix_dp_probe(struct device *dev, struct analogi= x_dp_plat_data *plat_data) res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); =20 dp->reg_base =3D devm_ioremap_resource(&pdev->dev, res); - if (IS_ERR(dp->reg_base)) - return ERR_CAST(dp->reg_base); + if (IS_ERR(dp->reg_base)) { + ret =3D PTR_ERR(dp->reg_base); + goto err_disable_clk; + } =20 dp->force_hpd =3D of_property_read_bool(dev->of_node, "force-hpd"); =20 @@ -1711,7 +1713,8 @@ analogix_dp_probe(struct device *dev, struct analogix= _dp_plat_data *plat_data) if (IS_ERR(dp->hpd_gpiod)) { dev_err(dev, "error getting HDP GPIO: %ld\n", PTR_ERR(dp->hpd_gpiod)); - return ERR_CAST(dp->hpd_gpiod); + ret =3D PTR_ERR(dp->hpd_gpiod); + goto err_disable_clk; } =20 if (dp->hpd_gpiod) { @@ -1731,7 +1734,8 @@ analogix_dp_probe(struct device *dev, struct analogix= _dp_plat_data *plat_data) =20 if (dp->irq =3D=3D -ENXIO) { dev_err(&pdev->dev, "failed to get irq\n"); - return ERR_PTR(-ENODEV); + ret =3D -ENODEV; + goto err_disable_clk; } =20 ret =3D devm_request_threaded_irq(&pdev->dev, dp->irq, @@ -1740,11 +1744,15 @@ analogix_dp_probe(struct device *dev, struct analog= ix_dp_plat_data *plat_data) irq_flags, "analogix-dp", dp); if (ret) { dev_err(&pdev->dev, "failed to request irq\n"); - return ERR_PTR(ret); + goto err_disable_clk; } disable_irq(dp->irq); =20 return dp; + +err_disable_clk: + clk_disable_unprepare(dp->clock); + return ERR_PTR(ret); } EXPORT_SYMBOL_GPL(analogix_dp_probe); =20 --=20 2.17.1