From nobody Mon May 11 00:45:13 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6233FC433F5 for ; Tue, 19 Apr 2022 21:57:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358117AbiDSV7w (ORCPT ); Tue, 19 Apr 2022 17:59:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235596AbiDSV7u (ORCPT ); Tue, 19 Apr 2022 17:59:50 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08C6F40A26 for ; Tue, 19 Apr 2022 14:57:07 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C6CDEB81C84 for ; Tue, 19 Apr 2022 21:57:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8239AC385A7; Tue, 19 Apr 2022 21:57:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650405424; bh=kvg9SXGdehN1yOUx+2cqBh0ZkhYF9DmxMqwB+3v5TRY=; h=From:To:Cc:Subject:Date:From; b=FhDIRLS2h0svfjr2wUFu6dKceIwBtTeYDlXfEG2hYER1g6bhyhUV0YwByzPI3HP1P ofvp4mrRiTMElQRuvcz3vGHMCbZ+l3mAasdHUELl6QKizFhvOj+nMfJdQrHEx4oVm3 x/AU2g++u/xAom9mU7ihOkN4+U+xTMnatk2/lNCFBfVp/VXajUh+kxNtf9g3w8ngXw tmdVHXeHtsmqyZRUkM4S/aHcECet9RxEt7Wjl/JBY87UccD/z8TftMJc2PVtMI6eNo 7DT6v+H8PRmaEdvlqrD7DAnFWvTjaW9XMQU2TqGXxpPfwJkHxyzslhxSbmfF3jPrGy NxKq+Zpzsd6vw== From: Jaegeuk Kim To: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Cc: Jaegeuk Kim Subject: [PATCH] f2fs: use flush command instead of FUA for zoned device Date: Tue, 19 Apr 2022 14:57:03 -0700 Message-Id: <20220419215703.1271395-1-jaegeuk@kernel.org> X-Mailer: git-send-email 2.36.0.rc0.470.gd361397f0d-goog MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The block layer for zoned disk can reorder the FUA'ed IOs. Let's use flush command to keep the write order. Signed-off-by: Jaegeuk Kim --- fs/f2fs/file.c | 4 +++- fs/f2fs/node.c | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index f08e6208e183..2aef0632f35b 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -372,7 +372,9 @@ static int f2fs_do_sync_file(struct file *file, loff_t = start, loff_t end, f2fs_remove_ino_entry(sbi, ino, APPEND_INO); clear_inode_flag(inode, FI_APPEND_WRITE); flush_out: - if (!atomic && F2FS_OPTION(sbi).fsync_mode !=3D FSYNC_MODE_NOBARRIER) + if ((!atomic && F2FS_OPTION(sbi).fsync_mode !=3D FSYNC_MODE_NOBARRIER) || + (atomic && !test_opt(sbi, NOBARRIER) && + f2fs_sb_has_blkzoned(sbi))) ret =3D f2fs_issue_flush(sbi, inode->i_ino); if (!ret) { f2fs_remove_ino_entry(sbi, ino, UPDATE_INO); diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c index c280f482c741..7224a980056f 100644 --- a/fs/f2fs/node.c +++ b/fs/f2fs/node.c @@ -1633,7 +1633,7 @@ static int __write_node_page(struct page *page, bool = atomic, bool *submitted, goto redirty_out; } =20 - if (atomic && !test_opt(sbi, NOBARRIER)) + if (atomic && !test_opt(sbi, NOBARRIER) && !f2fs_sb_has_blkzoned(sbi)) fio.op_flags |=3D REQ_PREFLUSH | REQ_FUA; =20 /* should add to global list before clearing PAGECACHE status */ --=20 2.36.0.rc0.470.gd361397f0d-goog