From nobody Mon May 11 00:45:31 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3467FC433F5 for ; Tue, 19 Apr 2022 21:54:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358100AbiDSV4n (ORCPT ); Tue, 19 Apr 2022 17:56:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357069AbiDSV4j (ORCPT ); Tue, 19 Apr 2022 17:56:39 -0400 Received: from mail-0201.mail-europe.com (mail-0201.mail-europe.com [51.77.79.158]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B2C23DA70 for ; Tue, 19 Apr 2022 14:53:54 -0700 (PDT) Date: Tue, 19 Apr 2022 21:53:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wujek.eu; s=protonmail2; t=1650405231; bh=YnTtRLrMceiJAjr17Kev+jb0+4PAI0gLw7VnQdS0VFg=; h=Date:From:Cc:Reply-To:Subject:Message-ID:Feedback-ID:From:To:Cc: Date:Subject:Reply-To:Feedback-ID:Message-ID; b=uKNog/vwKw8AViHsdwdMmnZm+dcneuEAc4WZ8cZqB+452RsA30FPlhL6vejhu8w6C ee35audlkd6ruIfzsoqizhKCIeKzPXg7JsN3g7jDjWgJYCDBXMwsuneJ9idD7R1VDB opmUEIS7cdYoUhYmFVyItWbmrHm58UfRAddaaWvioL5FuY1GIjILAaibDzxE/R5VHp nWqP9u+ZMOLZhLG95xyeBXXFIUkvhcZIDqmuotxXPAGQo14xkPqsWohjNGKLvVpmGK wL4+eY5kuEIG+kbz1N6gPdS9T1eZcDrHDV8VWHstFC35YjwgSN2tkJkD/FJp6kmvcG IGqA6nIVxECcA== From: Adam Wujek Cc: Adam Wujek , Guenter Roeck , Jean Delvare , linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Reply-To: Adam Wujek Subject: [PATCH] hwmon: (pmbus) add MFR_* registers to debugfs Message-ID: <20220419215326.309991-1-dev_public@wujek.eu> Feedback-ID: 23425257:user:proton MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add registers to debugfs: PMBUS_MFR_ID PMBUS_MFR_MODEL PMBUS_MFR_REVISION PMBUS_MFR_LOCATION PMBUS_MFR_DATE PMBUS_MFR_SERIAL Signed-off-by: Adam Wujek --- drivers/hwmon/pmbus/pmbus_core.c | 85 ++++++++++++++++++++++++++++++++ 1 file changed, 85 insertions(+) diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_c= ore.c index ef9989be8f89..6dc63f364ee6 100644 --- a/drivers/hwmon/pmbus/pmbus_core.c +++ b/drivers/hwmon/pmbus/pmbus_core.c @@ -2156,6 +2156,31 @@ static int pmbus_debugfs_get_status(void *data, u64 = *val) DEFINE_DEBUGFS_ATTRIBUTE(pmbus_debugfs_ops_status, pmbus_debugfs_get_statu= s, NULL, "0x%04llx\n"); + +static ssize_t pmbus_debugfs_mfr_read(struct file *file, char __user *buf, + size_t count, loff_t *ppos) +{ + int rc; + struct pmbus_debugfs_entry *entry =3D file->private_data; + char data[I2C_SMBUS_BLOCK_MAX + 2] =3D { 0 }; + + rc =3D i2c_smbus_read_block_data(entry->client, entry->reg, data); + if (rc < 0) + return rc; + + data[rc] =3D '\n'; + rc +=3D 2; + + return simple_read_from_buffer(buf, count, ppos, data, rc); +} + +static const struct file_operations pmbus_debugfs_ops_mfr =3D { + .llseek =3D noop_llseek, + .read =3D pmbus_debugfs_mfr_read, + .write =3D NULL, + .open =3D simple_open, +}; + static int pmbus_init_debugfs(struct i2c_client *client, struct pmbus_data *data) { @@ -2286,6 +2311,66 @@ static int pmbus_init_debugfs(struct i2c_client *cli= ent, &entries[idx++], &pmbus_debugfs_ops); } + + if (pmbus_check_byte_register(client, i, PMBUS_MFR_ID)) { + entries[idx].client =3D client; + entries[idx].page =3D i; + entries[idx].reg =3D PMBUS_MFR_ID; + scnprintf(name, PMBUS_NAME_SIZE, "mfr%d_id", i); + debugfs_create_file(name, 0444, data->debugfs, + &entries[idx++], + &pmbus_debugfs_ops_mfr); + } + + if (pmbus_check_byte_register(client, i, PMBUS_MFR_MODEL)) { + entries[idx].client =3D client; + entries[idx].page =3D i; + entries[idx].reg =3D PMBUS_MFR_MODEL; + scnprintf(name, PMBUS_NAME_SIZE, "mfr%d_model", i); + debugfs_create_file(name, 0444, data->debugfs, + &entries[idx++], + &pmbus_debugfs_ops_mfr); + } + + if (pmbus_check_byte_register(client, i, PMBUS_MFR_REVISION)) { + entries[idx].client =3D client; + entries[idx].page =3D i; + entries[idx].reg =3D PMBUS_MFR_REVISION; + scnprintf(name, PMBUS_NAME_SIZE, "mfr%d_revision", i); + debugfs_create_file(name, 0444, data->debugfs, + &entries[idx++], + &pmbus_debugfs_ops_mfr); + } + + if (pmbus_check_byte_register(client, i, PMBUS_MFR_LOCATION)) { + entries[idx].client =3D client; + entries[idx].page =3D i; + entries[idx].reg =3D PMBUS_MFR_LOCATION; + scnprintf(name, PMBUS_NAME_SIZE, "mfr%d_location", i); + debugfs_create_file(name, 0444, data->debugfs, + &entries[idx++], + &pmbus_debugfs_ops_mfr); + } + + if (pmbus_check_byte_register(client, i, PMBUS_MFR_DATE)) { + entries[idx].client =3D client; + entries[idx].page =3D i; + entries[idx].reg =3D PMBUS_MFR_DATE; + scnprintf(name, PMBUS_NAME_SIZE, "mfr%d_date", i); + debugfs_create_file(name, 0444, data->debugfs, + &entries[idx++], + &pmbus_debugfs_ops_mfr); + } + + if (pmbus_check_byte_register(client, i, PMBUS_MFR_SERIAL)) { + entries[idx].client =3D client; + entries[idx].page =3D i; + entries[idx].reg =3D PMBUS_MFR_SERIAL; + scnprintf(name, PMBUS_NAME_SIZE, "mfr%d_serial", i); + debugfs_create_file(name, 0444, data->debugfs, + &entries[idx++], + &pmbus_debugfs_ops_mfr); + } } return 0; -- 2.17.1