From nobody Thu Jun 18 17:04:22 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08351C433FE for ; Mon, 18 Apr 2022 16:28:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242435AbiDRQbe (ORCPT ); Mon, 18 Apr 2022 12:31:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59064 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346197AbiDRQbV (ORCPT ); Mon, 18 Apr 2022 12:31:21 -0400 Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A68842FFF6 for ; Mon, 18 Apr 2022 09:28:41 -0700 (PDT) Received: by mail-pj1-x1029.google.com with SMTP id i24-20020a17090adc1800b001cd5529465aso12959709pjv.0 for ; Mon, 18 Apr 2022 09:28:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pHmIfYdFlbEBfg1s7Ca3bU++BraBxET9LrYHIdIzDOw=; b=Gt4VzL3KTmWKfLKC7W25J/xX9fzpOGWcfANQQKWSw8ZY6PBC7ECL5WDiSRu61kFUXL Klgvra4BD/Sxpee4hC5tkrqL9LTGsU6tE1A09569yjOGlXZRSMwgZrN4jM7gME6rLGRX lwJr/N+1uGB9mtCSwCCOkBNqgltL3MiNyLDH3FhXVZDk1E34NyCJYmygtdju6pFmYRqF SpEgA+g9b8Wghl+MGkZavW6JV8NQqX7w+9sd/VBAL7iklYy3x3EFpj7nv4Eh+cZyYnkJ 0fLOtNohqHo5uY6TfflUaq+1G70rRypZWnQ3NRdR6KcSL3LGZizaeLc1Vb2wVVWCUGAC bfzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pHmIfYdFlbEBfg1s7Ca3bU++BraBxET9LrYHIdIzDOw=; b=w2qTEGc2UvceYLSmBxdqjzbG9vVVC4rESf5Szl7leI9NfRTFwqhkbBbBniWAmLPxLT PN+EFIFU0l60/yIzGtZAQN4YYvOIaOxtbyKbbR87bNRvFmH/v7Kih7GBikBc33B3Q/Lm /QRmOd+NoE4OdYxJ0P82NYzU2lVsANKZEcSEX5l4f73sXvIMtb+2+OcjO2tWfgl2wnLf EcrIKVSQhSmabQSDiSGEsiXTNz8lMNjmcrtJ/ktR82tFPvHerQmGrGBZFpsJ+AqQ9j9l JpRYR+PM1rYwalpi9c2YZD+5DzXSR2sep2iHbCW/DaivSJ58v3T1fSqDcsel0WavWgD5 /a0g== X-Gm-Message-State: AOAM530nn4/oNwQtHztZgrrBEsQ1bwF9bAO6tQIB58onN1J4nrD1sArp eyWGNMlMIn59oUhMT0NRIA8= X-Google-Smtp-Source: ABdhPJwa0etoZ3UYp1pfmXyyzdO+3SN5JsmGZJH9apOIyhcA7TVy4ZZD9uWEe1HhMAO++LdBOtht1Q== X-Received: by 2002:a17:902:7c01:b0:156:17a5:a68 with SMTP id x1-20020a1709027c0100b0015617a50a68mr11433631pll.166.1650299321045; Mon, 18 Apr 2022 09:28:41 -0700 (PDT) Received: from aliyar-HP-Laptop-15-da1xxx.domain.name ([14.139.241.88]) by smtp.gmail.com with ESMTPSA id h18-20020a63c012000000b0039cc3c323f7sm13295602pgg.33.2022.04.18.09.28.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Apr 2022 09:28:40 -0700 (PDT) From: Aliya Rahmani To: clabbe@baylibre.com Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, outreachy@lists.linux.dev, linux-kernel@vger.kernel.org, Aliya Rahmani Subject: [PATCH v2 1/3] staging: media: zoran: use seq_puts() instead of seq_printf() Date: Mon, 18 Apr 2022 21:52:44 +0530 Message-Id: <20220418162244.15346-2-aliyarahmani786@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220418162244.15346-1-aliyarahmani786@gmail.com> References: <20220418162244.15346-1-aliyarahmani786@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Replace seq_printf() with seq_puts() for a constant format without additional arguments, reported by checkpatch. Signed-off-by: Aliya Rahmani --- drivers/staging/media/zoran/videocodec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/zoran/videocodec.c b/drivers/staging/med= ia/zoran/videocodec.c index 3af7d02bd910..16a1f23a7f19 100644 --- a/drivers/staging/media/zoran/videocodec.c +++ b/drivers/staging/media/zoran/videocodec.c @@ -250,8 +250,8 @@ int videocodec_debugfs_show(struct seq_file *m) struct codec_list *h =3D codeclist_top; struct attached_list *a; =20 - seq_printf(m, "lave or attached aster name type flags magic = "); - seq_printf(m, "(connected as)\n"); + seq_puts(m, "lave or attached aster name type flags magic "); + seq_puts(m, "(connected as)\n"); =20 --=20 2.25.1 From nobody Thu Jun 18 17:04:22 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78AAFC4332F for ; Mon, 18 Apr 2022 16:31:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346233AbiDRQcp (ORCPT ); Mon, 18 Apr 2022 12:32:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346302AbiDRQc3 (ORCPT ); Mon, 18 Apr 2022 12:32:29 -0400 Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 301F53122A for ; Mon, 18 Apr 2022 09:29:42 -0700 (PDT) Received: by mail-pg1-x52c.google.com with SMTP id s137so19766848pgs.5 for ; Mon, 18 Apr 2022 09:29:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NnfylWN7MavTPT553g+jrwdoRsttSRF9ea+q5wroK2g=; b=FmFMoYGTefW+n/xauP+X3a81pJmhujkSpoC6XDS2NTi1wBUImQdjOqEfN6Nay2pmVa Q5fQR2dg3WNuUjHX539UdqZUfSlMEAJNGEhTU9UETcjtbMynbN+EqOJaQ6ENpO9S9hvM 9EeFHRcnfd+Q2kjD+POOiV8QX1j+qQZQ0kBMl8FeNh+YuQTqWQ7rL4fi986KE2zwcAnG cJTGUoKsXGVGybL0pnBBKuY+dJknC+2iDSTgixvXEVwb11dHlmP55ra87TkKVbohLZY8 CpvSQsgBn1lU/Q7PP91uJCscANYgHSy1AXQpJqUMMXF1I4i0ek6+Vvi5DGDRWh8m2AfF P+FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NnfylWN7MavTPT553g+jrwdoRsttSRF9ea+q5wroK2g=; b=5ibKL9mc9XsNPmr3G3MxcCW0AwKzV97X59/sVIPEPse0rw3soYaU7SOt/RdetBbdUG 66nBVjMaCukR0O4KpB/gncX0AnrpdokakMZP8Wh/MHMPr8g1uzGCrAgo8f91pGJbYog5 GzZMMFyYfixtOWGRLcp4PTuT/Xn4pGObM+gwji2xw1P+fUiQDIqYGw15etcCs+hKlQlJ 1lsSzOxyStwVkBQ/a6CXicXMT5iZdDHZ3IEIWEVT2VoU/rOrJAQVp7NtCSq7mSqEhmyy f5ZQJkadRXvvTrWzQABUZzCOcpcnrHaAqFVvIIBhuShHM0s40a5hkE2Hi6LPhZOcwJwU QCWA== X-Gm-Message-State: AOAM530fiU+SCY+KVCpC8Kci3k9wZokumx2lKCHN0nUjHygsVvEdouVy 07Aoe0engEJETQiIPBC4MlI= X-Google-Smtp-Source: ABdhPJxA2Go+r6mKW0OHbmQH7KoacX0ohuNjA2Mpy67TbAnVASS2Blt8F6TRSKoAqkCYwryj0oWRMg== X-Received: by 2002:a05:6a00:218d:b0:4fd:f7a4:d4ad with SMTP id h13-20020a056a00218d00b004fdf7a4d4admr12930534pfi.83.1650299381585; Mon, 18 Apr 2022 09:29:41 -0700 (PDT) Received: from aliyar-HP-Laptop-15-da1xxx.domain.name ([14.139.241.88]) by smtp.gmail.com with ESMTPSA id h18-20020a63c012000000b0039cc3c323f7sm13295602pgg.33.2022.04.18.09.29.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Apr 2022 09:29:41 -0700 (PDT) From: Aliya Rahmani To: clabbe@baylibre.com Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, outreachy@lists.linux.dev, linux-kernel@vger.kernel.org, Aliya Rahmani Subject: [PATCH v2 2/3] staging: media: zoran: else is not generally useful after a break or return Date: Mon, 18 Apr 2022 21:52:46 +0530 Message-Id: <20220418162244.15346-3-aliyarahmani786@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220418162244.15346-1-aliyarahmani786@gmail.com> References: <20220418162244.15346-1-aliyarahmani786@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Remove the else without affecting the logic. Fixes the checkpatch warning: = else is not generally useful after a break or return Signed-off-by: Aliya Rahmani --- drivers/staging/media/zoran/videocodec.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/media/zoran/videocodec.c b/drivers/staging/med= ia/zoran/videocodec.c index 16a1f23a7f19..19732a47c8bd 100644 --- a/drivers/staging/media/zoran/videocodec.c +++ b/drivers/staging/media/zoran/videocodec.c @@ -98,9 +98,8 @@ struct videocodec *videocodec_attach(struct videocodec_ma= ster *master) =20 h->attached +=3D 1; return codec; - } else { - kfree(codec); } + kfree(codec); } h =3D h->next; } --=20 2.25.1 From nobody Thu Jun 18 17:04:22 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADBE8C433EF for ; Mon, 18 Apr 2022 16:32:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346401AbiDRQey (ORCPT ); Mon, 18 Apr 2022 12:34:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35686 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234709AbiDRQeW (ORCPT ); Mon, 18 Apr 2022 12:34:22 -0400 Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00F965F50 for ; Mon, 18 Apr 2022 09:31:42 -0700 (PDT) Received: by mail-pg1-x530.google.com with SMTP id t13so19764416pgn.8 for ; Mon, 18 Apr 2022 09:31:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=J5XRVN0rYoKShdUkWHsZOX7pTFc2v1hH6PY/aOGhz2o=; b=opDlbbLXpfliyT0hxegO0lHHNJUhKN18viHaTHcXInOVtr00j2D8OJFj2gl2cJlr82 f29Iyvsxr7+Q9zFvxuyMO9eQsR30Xr7MVxSFP6w3KA9acvyoS+j3brCpMYzkTI2x1lKQ VtEloOT+ljzj32WU7UF+mVHgUTggpIEl9WhX6gBQqLyTCBW5PFTKDwJv53+zsuWPc9Ot Wl2fCmF04oy43KKL6oGBP0xwv7LM1xKPJmKHDrWnNsXnyC4WSeWN3+WMBmUJc+HyV9s6 wqtDbUp6BzP6OG0jFXWUEjZa/mgfOw7FBLEeSj0PoaqgIKC38IOmzaIR8fzRjP7v8Vbl cSCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=J5XRVN0rYoKShdUkWHsZOX7pTFc2v1hH6PY/aOGhz2o=; b=TDKBw+G9w2hHsf2l/JjC6lMXkko1gB5a2jojpxublO58cNgr/j99w2IfB5PzUrAehO laQexBOkYQBeObvp/OzYoHJuL/NL4FGhwfSNJEg/1QhrLVe+Qv/e5GDP5VfzrV3Ae6X7 RfStZs7aG0LEBsKqB7UZcF14nomo5PLllVWES5rllOkbYb7uBBKpO56LxbrwaYa8Gcv5 lAHtcYoeydCcARjZmL2JCiE4sWJ+V2JbN4TOaHQoRkQU6DXwXzNxJF9KGue+8ovgAeyx ttHR/VTK3+7GM+rZqM07SovDqNkKHTIrhZoAE30E05HJ7oqKO0jDTVzMiVMiVLPSrZVT u6Lg== X-Gm-Message-State: AOAM531PSo7YxyLNODWbeuxTLdS456rCT1XsJGsRN9HcrMYaWJYErIoq 0R2c7FaKzbRDbGZAJIfanoI= X-Google-Smtp-Source: ABdhPJxpEjB37dv3sT9B386rQBREHhLwteTv4M1Ps9RbqbppqC2G/I/1zlBh9L5z4QcXHZeRHi4kWA== X-Received: by 2002:a65:4c4e:0:b0:39d:21c4:2381 with SMTP id l14-20020a654c4e000000b0039d21c42381mr10912664pgr.566.1650299502320; Mon, 18 Apr 2022 09:31:42 -0700 (PDT) Received: from aliyar-HP-Laptop-15-da1xxx.domain.name ([14.139.241.88]) by smtp.gmail.com with ESMTPSA id h18-20020a63c012000000b0039cc3c323f7sm13295602pgg.33.2022.04.18.09.31.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Apr 2022 09:31:41 -0700 (PDT) From: Aliya Rahmani To: clabbe@baylibre.com Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, outreachy@lists.linux.dev, linux-kernel@vger.kernel.org, Aliya Rahmani Subject: [PATCH v2 3/3] staging: media: zoran: add parentheses on macro parameter Date: Mon, 18 Apr 2022 21:52:50 +0530 Message-Id: <20220418162244.15346-4-aliyarahmani786@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220418162244.15346-1-aliyarahmani786@gmail.com> References: <20220418162244.15346-1-aliyarahmani786@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" This patch fixes checkpatch warnings of precedence issues. Add parentheses around macro argument 'num'. Signed-off-by: Aliya Rahmani --- drivers/staging/media/zoran/videocodec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/zoran/videocodec.c b/drivers/staging/med= ia/zoran/videocodec.c index 19732a47c8bd..925f90fd5885 100644 --- a/drivers/staging/media/zoran/videocodec.c +++ b/drivers/staging/media/zoran/videocodec.c @@ -22,7 +22,7 @@ MODULE_PARM_DESC(videocodec_debug, "Debug level (0-4)"); =20 #define dprintk(num, format, args...) \ do { \ - if (videocodec_debug >=3D num) \ + if (videocodec_debug >=3D (num)) \ printk(format, ##args); \ } while (0) =20 --=20 2.25.1