From nobody Mon May 11 02:06:41 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39779C433F5 for ; Mon, 18 Apr 2022 12:02:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237960AbiDRMFb (ORCPT ); Mon, 18 Apr 2022 08:05:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231693AbiDRMF1 (ORCPT ); Mon, 18 Apr 2022 08:05:27 -0400 Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6CB913D3C for ; Mon, 18 Apr 2022 05:02:48 -0700 (PDT) Received: by mail-pj1-x1033.google.com with SMTP id h15-20020a17090a054f00b001cb7cd2b11dso13854035pjf.5 for ; Mon, 18 Apr 2022 05:02:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pHmIfYdFlbEBfg1s7Ca3bU++BraBxET9LrYHIdIzDOw=; b=QXDWG5IlrTI1SdTC2t0iJGNjYcOeHl6dU8afA0mPcO0Or+oRWHHlgJ1uRhLd4evU2I W5FnM/xeJ4CEyFyqIyGl6RPDQuIgBK8IX3vaQg+woyVXiRJLmLPzc/MMQxkCbDyp+J5C KzVgP0q4TD8uaq/vuJGd9gtT0/VjozlwEW52z2J6ISvZ+0eIGyGRpwpsp8lZ6wEEKhGE P93idKHTGXZ14lA6TBTim/g+AY/yJXmnroEE3sgC7icduU77CV+GjeB2nS2ueVgPToed S4yarTAJPnC3dx9LS3eNG/ZBES560RulN33Pu5aWLesongYn036mb1UpWexUM6xq2bPi UaOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pHmIfYdFlbEBfg1s7Ca3bU++BraBxET9LrYHIdIzDOw=; b=jgwW7zC14WRGkqZWyyhMAVk/IyDbQJGT+SNkHUyjJFO8AvSE4WmtqLyuiiUZq8dHEV 3koRPkOhzl5yXVOaT9BsKNsFnALSOLEldRPawF+q4ytvFFOlSVfHkDIVkf0AtXJ/SasT 5sBSk9zNhJA9h6BvQ6cj9np19ZhSJiURGo4ltTyMZvVTjwpCPipvAMGUQcEikpS4/U89 q6EQS+pDN/oUMp3PG7hzfWVgbouY5TDC12U9pTQPoe1hiEXan2zXJNo3MdumzcEN31AI KCn+JODjCV6ulQELYhCMvFOr9M4w6J8RAX+gw6JIfJgF7M2zHy+lyNpn3t3GtsnXahFf ydQQ== X-Gm-Message-State: AOAM530l8B5POa30qT2zTYEKPja8RW4dK7DPgAU6IArcs6yYnR2Bj8pQ zPpC0F7Iedze6dL8ZboJIkg= X-Google-Smtp-Source: ABdhPJyjaCRepIeQD49ER6XVhKfz5eniRdQHa7nbQuAOV/clAl/1UqGDDXpDHluB+6BttoCRcq5+Tg== X-Received: by 2002:a17:90b:1c88:b0:1b8:a77e:c9cb with SMTP id oo8-20020a17090b1c8800b001b8a77ec9cbmr17837755pjb.205.1650283368262; Mon, 18 Apr 2022 05:02:48 -0700 (PDT) Received: from aliyar-HP-Laptop-15-da1xxx.domain.name ([14.139.241.88]) by smtp.gmail.com with ESMTPSA id p1-20020a17090a680100b001d28905b214sm3840628pjj.39.2022.04.18.05.02.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Apr 2022 05:02:47 -0700 (PDT) From: Aliya Rahmani To: clabbe@baylibre.com Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, outreachy@lists.linux.dev, linux-kernel@vger.kernel.org, Aliya Rahmani Subject: [PATCH 1/3] staging: media: zoran: use seq_puts() instead of seq_printf() Date: Mon, 18 Apr 2022 17:29:48 +0530 Message-Id: <20220418115948.5456-2-aliyarahmani786@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220418115948.5456-1-aliyarahmani786@gmail.com> References: <20220418115948.5456-1-aliyarahmani786@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Replace seq_printf() with seq_puts() for a constant format without additional arguments, reported by checkpatch. Signed-off-by: Aliya Rahmani --- drivers/staging/media/zoran/videocodec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/zoran/videocodec.c b/drivers/staging/med= ia/zoran/videocodec.c index 3af7d02bd910..16a1f23a7f19 100644 --- a/drivers/staging/media/zoran/videocodec.c +++ b/drivers/staging/media/zoran/videocodec.c @@ -250,8 +250,8 @@ int videocodec_debugfs_show(struct seq_file *m) struct codec_list *h =3D codeclist_top; struct attached_list *a; =20 - seq_printf(m, "lave or attached aster name type flags magic = "); - seq_printf(m, "(connected as)\n"); + seq_puts(m, "lave or attached aster name type flags magic "); + seq_puts(m, "(connected as)\n"); --=20 2.25.1 From nobody Mon May 11 02:06:41 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82FA2C433EF for ; Mon, 18 Apr 2022 12:03:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237966AbiDRMGU (ORCPT ); Mon, 18 Apr 2022 08:06:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34210 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234686AbiDRMGS (ORCPT ); Mon, 18 Apr 2022 08:06:18 -0400 Received: from mail-pg1-x536.google.com (mail-pg1-x536.google.com [IPv6:2607:f8b0:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D8F9A17A88 for ; Mon, 18 Apr 2022 05:03:39 -0700 (PDT) Received: by mail-pg1-x536.google.com with SMTP id h5so18495728pgc.7 for ; Mon, 18 Apr 2022 05:03:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NnfylWN7MavTPT553g+jrwdoRsttSRF9ea+q5wroK2g=; b=SXVE+pR8devV3hO4tWlgoxCYNAdT0Ru6k53XSx5WS1V7guQJZqXF8ndR5M3UPGPryX preJK3/gW+63QwRNfoPx6ZtriC621Oq+FkCL6drTNIh/HRWLzHbUGf2IPoX7n5X4zmXX DOHLFuiRIigUu3TNkQw8E0AE09g6RMFWg2NuKJNlFvl9WHksO8vijte7fP0g2D2sIvW6 cjf/kHgxe3bUrrvBB1cpRYs6NnwocbAxBZ+d91sUaqoDCFnI2YmlkAmeOSVVFGgg+E5L FxhzYqayBHTPeyO4t2FIhCvufk0Wklhv0jvy7Bw7sgh4KWBIE4TrMpm74eEZ3RuR0IWn PXzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NnfylWN7MavTPT553g+jrwdoRsttSRF9ea+q5wroK2g=; b=WDO+hYhsPNpFfBFyfR44Yzrbqs73R+/A9Au8BKmWWxuDtuYDuQNDSwFPyB1DrAfle5 g+F7bI2SX+k20fOd4nYaywsmQre3/Jb/NoDm7kAx7BNishh0PpKTSb17HJCUdV7uvYEa ldCIG+a43A/AgtFSJ//7EmGLfOd9lke5FXSxFQE/088unIDFMRdyRn7/HlJyXRnnvuQz 4Z6wbFrNtt8yOg9n+S2r7bOJW+5CYLmxDrM86fRffr+eAdup1bC86s0r1YmuNBrXGxyE k67MWlfF4MkiVuyqC3UZLiN47cbfKnlztwqbCYDDEZ37OVyh2rKz18/S9GtyRVQmu+Gz 48YA== X-Gm-Message-State: AOAM5307FDINZ5ushJcHNkr7QdGC37Kf5hsdw2sjlQk0uAg5P0qsraqu j6dXts8E6v6ja/Pi9izeLpw= X-Google-Smtp-Source: ABdhPJxVYwRdke1zYGoWe8PpudWD0LJmyZsh75gb25UTnIp8YT9ms1lZ7EG2nblYE9sNVU+WooJIrQ== X-Received: by 2002:a63:1d5f:0:b0:39d:b5e4:ae24 with SMTP id d31-20020a631d5f000000b0039db5e4ae24mr9551819pgm.502.1650283419258; Mon, 18 Apr 2022 05:03:39 -0700 (PDT) Received: from aliyar-HP-Laptop-15-da1xxx.domain.name ([14.139.241.88]) by smtp.gmail.com with ESMTPSA id p1-20020a17090a680100b001d28905b214sm3840628pjj.39.2022.04.18.05.03.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Apr 2022 05:03:38 -0700 (PDT) From: Aliya Rahmani To: clabbe@baylibre.com Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, outreachy@lists.linux.dev, linux-kernel@vger.kernel.org, Aliya Rahmani Subject: [PATCH 2/3] staging: media: zoran: Code cleanup - else is not generally useful after a break or return Date: Mon, 18 Apr 2022 17:29:50 +0530 Message-Id: <20220418115948.5456-3-aliyarahmani786@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220418115948.5456-1-aliyarahmani786@gmail.com> References: <20220418115948.5456-1-aliyarahmani786@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Remove the else without affecting the logic. Fixes the checkpatch warning: = else is not generally useful after a break or return Signed-off-by: Aliya Rahmani --- drivers/staging/media/zoran/videocodec.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/media/zoran/videocodec.c b/drivers/staging/med= ia/zoran/videocodec.c index 16a1f23a7f19..19732a47c8bd 100644 --- a/drivers/staging/media/zoran/videocodec.c +++ b/drivers/staging/media/zoran/videocodec.c @@ -98,9 +98,8 @@ struct videocodec *videocodec_attach(struct videocodec_ma= ster *master) =20 h->attached +=3D 1; return codec; - } else { - kfree(codec); } + kfree(codec); } h =3D h->next; } --=20 2.25.1 From nobody Mon May 11 02:06:41 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFB3FC433EF for ; Mon, 18 Apr 2022 12:04:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237982AbiDRMHG (ORCPT ); Mon, 18 Apr 2022 08:07:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237980AbiDRMHB (ORCPT ); Mon, 18 Apr 2022 08:07:01 -0400 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4933B1A802 for ; Mon, 18 Apr 2022 05:04:23 -0700 (PDT) Received: by mail-pj1-x1034.google.com with SMTP id z6-20020a17090a398600b001cb9fca3210so13892960pjb.1 for ; Mon, 18 Apr 2022 05:04:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=l539e+cloHDtMJA9q+CEgCemouxdeXvEIx3a6xENmiw=; b=EME2rXuHZN/iDCQ2+/fD2SnBtcWDY/WxEDU7zV371DULgDSxAkHyqIHk2HsT9pzYwq X0jHxUfQBFj9UbfsPHqd5q6wAhE84cWLfeeR84Dp7k0+QIVeRMQY+B+Aiusixji2MZG2 ifwV6vhzgL5s5XDlv14p3JgMD+dfhdrtGG2ExdeaqSrKkXm5Ivd/5dMRW7F+tu/ZFwWL /WwRqSCNYjFeDgdsPPIuvc0L1BcoHGgxV/4uQAyt138812M31T3nP2qmLeor7vPaz7uH KnG4Stv+RmjZ8soo1W61p7OiNnozgmmTtN6ORA2jETC6mtk/2TsMF7NefT1qCxwcdhkp 6CYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=l539e+cloHDtMJA9q+CEgCemouxdeXvEIx3a6xENmiw=; b=sDDrBXQPRcR6CRge18hW+kKj+6H2c6RE9zSodTxgdhbI8iD4ekx0/0WxYuVFPf6bmP OBHCrgxSq0yUvQ9RaDhaeRZ5cZhE+khNhav8IkY9QRzlG2KVWChi8LYpnyIsnwl8Q9kH eKnssQK0OnrcLRy1DIEUkGZCEenPA6PwRKLIok97IiVUde8iBd9HBh/m7p1NU1GvlKj+ cZ7v3hbie0qCdXWGR8MUCtY7GZiYZpvOmkuRznHBFuLgMV9jN//9iPxW63crJtl6PGsg vohhE+MMtPB7YXQWrePGxUSuYWvGLb+zXxS2l3Vf+njg/7wr0j6fS9Gt/XohS7wtagwK ajkw== X-Gm-Message-State: AOAM533LIgU4s4Ra8PqVuxcGcf2xlVvAtuUAPS35oTnrRRyGra6xa/eW s2ZHdhENgetpqHw4nZTokdQ= X-Google-Smtp-Source: ABdhPJz5tpVjRVY7oW3rrsbG8qVY4KsncSBVc/mgVKR/4pTyMQpqlw0yWDuainxpF/jrj6yIKwpaMg== X-Received: by 2002:a17:90a:4403:b0:1ca:a4a3:6824 with SMTP id s3-20020a17090a440300b001caa4a36824mr12603150pjg.20.1650283462701; Mon, 18 Apr 2022 05:04:22 -0700 (PDT) Received: from aliyar-HP-Laptop-15-da1xxx.domain.name ([14.139.241.88]) by smtp.gmail.com with ESMTPSA id p1-20020a17090a680100b001d28905b214sm3840628pjj.39.2022.04.18.05.04.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Apr 2022 05:04:22 -0700 (PDT) From: Aliya Rahmani To: clabbe@baylibre.com Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, outreachy@lists.linux.dev, linux-kernel@vger.kernel.org, Aliya Rahmani Subject: [PATCH 3/3] staging: media: zoran: avoid macro argument precedence issues Date: Mon, 18 Apr 2022 17:29:52 +0530 Message-Id: <20220418115948.5456-4-aliyarahmani786@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220418115948.5456-1-aliyarahmani786@gmail.com> References: <20220418115948.5456-1-aliyarahmani786@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" This patch fixes checkpatch warnings of precedence issues. Added parentheses around macro argument 'num'. Signed-off-by: Aliya Rahmani --- drivers/staging/media/zoran/videocodec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/zoran/videocodec.c b/drivers/staging/med= ia/zoran/videocodec.c index 19732a47c8bd..925f90fd5885 100644 --- a/drivers/staging/media/zoran/videocodec.c +++ b/drivers/staging/media/zoran/videocodec.c @@ -22,7 +22,7 @@ MODULE_PARM_DESC(videocodec_debug, "Debug level (0-4)"); =20 #define dprintk(num, format, args...) \ do { \ - if (videocodec_debug >=3D num) \ + if (videocodec_debug >=3D (num)) \ printk(format, ##args); \ } while (0) =20 --=20 2.25.1