From nobody Mon May 11 02:56:32 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B150C4332F for ; Sun, 17 Apr 2022 10:22:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233932AbiDQKZT (ORCPT ); Sun, 17 Apr 2022 06:25:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232241AbiDQKZM (ORCPT ); Sun, 17 Apr 2022 06:25:12 -0400 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0887727FEA for ; Sun, 17 Apr 2022 03:22:34 -0700 (PDT) Received: from dslb-188-096-140-061.188.096.pools.vodafone-ip.de ([188.96.140.61] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1ng234-0002FP-VT; Sun, 17 Apr 2022 12:22:31 +0200 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 1/6] staging: r8188eu: check receiver address only once Date: Sun, 17 Apr 2022 12:22:16 +0200 Message-Id: <20220417102221.466524-2-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220417102221.466524-1-martin@kaiser.cx> References: <20220417102221.466524-1-martin@kaiser.cx> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Check only once in mgt_dispatcher that the receiver address is the local address or the broadcast address. The second identical check can be removed. Signed-off-by: Martin Kaiser --- drivers/staging/r8188eu/core/rtw_mlme_ext.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/= r8188eu/core/rtw_mlme_ext.c index b6ee6a24930a..3afd06120cb1 100644 --- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c +++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c @@ -431,13 +431,8 @@ void mgt_dispatcher(struct adapter *padapter, struct r= ecv_frame *precv_frame) ptable->func =3D &OnAuthClient; } =20 - if (ptable->func) { - /* receive the frames that ra(a1) is my address or ra(a1) is bc address. = */ - if (memcmp(hdr->addr1, myid(&padapter->eeprompriv), ETH_ALEN) && - !is_broadcast_ether_addr(hdr->addr1)) - return; + if (ptable->func) ptable->func(padapter, precv_frame); - } } =20 static u32 p2p_listen_state_process(struct adapter *padapter, unsigned cha= r *da) --=20 2.30.2 From nobody Mon May 11 02:56:32 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE57DC433EF for ; Sun, 17 Apr 2022 10:22:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233915AbiDQKZO (ORCPT ); Sun, 17 Apr 2022 06:25:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232133AbiDQKZM (ORCPT ); Sun, 17 Apr 2022 06:25:12 -0400 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75A9427FC0 for ; Sun, 17 Apr 2022 03:22:35 -0700 (PDT) Received: from dslb-188-096-140-061.188.096.pools.vodafone-ip.de ([188.96.140.61] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1ng236-0002FP-1U; Sun, 17 Apr 2022 12:22:32 +0200 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 2/6] staging: r8188eu: replace the GetFrameSubType call Date: Sun, 17 Apr 2022 12:22:17 +0200 Message-Id: <20220417102221.466524-3-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220417102221.466524-1-martin@kaiser.cx> References: <20220417102221.466524-1-martin@kaiser.cx> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The driver's local GetFrameSubType macro returns both frame type and subtype. Use the ieee80211 framework to extract the two fields. This shows more clearly that both type and subtype are read. Convert everything to host endianness before we use bit operations. Signed-off-by: Martin Kaiser --- drivers/staging/r8188eu/core/rtw_mlme_ext.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/= r8188eu/core/rtw_mlme_ext.c index 3afd06120cb1..be1afabe77d1 100644 --- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c +++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c @@ -395,7 +395,6 @@ void mgt_dispatcher(struct adapter *padapter, struct re= cv_frame *precv_frame) int index; struct mlme_handler *ptable; struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; - u8 *pframe =3D precv_frame->rx_data; struct ieee80211_hdr *hdr =3D (struct ieee80211_hdr *)precv_frame->rx_dat= a; struct sta_info *psta =3D rtw_get_stainfo(&padapter->stapriv, hdr->addr2); =20 @@ -409,8 +408,8 @@ void mgt_dispatcher(struct adapter *padapter, struct re= cv_frame *precv_frame) =20 ptable =3D mlme_sta_tbl; =20 - index =3D GetFrameSubType(pframe) >> 4; - + index =3D (le16_to_cpu(hdr->frame_control) & + (IEEE80211_FCTL_STYPE | IEEE80211_FCTL_FTYPE)) >> 4; if (index > 13) return; ptable +=3D index; --=20 2.30.2 From nobody Mon May 11 02:56:32 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06061C433EF for ; Sun, 17 Apr 2022 10:22:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233965AbiDQKZb (ORCPT ); Sun, 17 Apr 2022 06:25:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233917AbiDQKZO (ORCPT ); Sun, 17 Apr 2022 06:25:14 -0400 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9D6D27FCA for ; Sun, 17 Apr 2022 03:22:39 -0700 (PDT) Received: from dslb-188-096-140-061.188.096.pools.vodafone-ip.de ([188.96.140.61] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1ng236-0002FP-Rk; Sun, 17 Apr 2022 12:22:32 +0200 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 3/6] staging: r8188eu: the frame type is shifted out Date: Sun, 17 Apr 2022 12:22:18 +0200 Message-Id: <20220417102221.466524-4-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220417102221.466524-1-martin@kaiser.cx> References: <20220417102221.466524-1-martin@kaiser.cx> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The index calculation in mgt_dispatcher does not use the frame type. The 4-bit right shift ignores protocol version and frame type. Signed-off-by: Martin Kaiser --- drivers/staging/r8188eu/core/rtw_mlme_ext.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/= r8188eu/core/rtw_mlme_ext.c index be1afabe77d1..77a14f55b743 100644 --- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c +++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c @@ -408,8 +408,7 @@ void mgt_dispatcher(struct adapter *padapter, struct re= cv_frame *precv_frame) =20 ptable =3D mlme_sta_tbl; =20 - index =3D (le16_to_cpu(hdr->frame_control) & - (IEEE80211_FCTL_STYPE | IEEE80211_FCTL_FTYPE)) >> 4; + index =3D (le16_to_cpu(hdr->frame_control) & IEEE80211_FCTL_STYPE) >> 4; if (index > 13) return; ptable +=3D index; --=20 2.30.2 From nobody Mon May 11 02:56:32 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CF4BC433F5 for ; Sun, 17 Apr 2022 10:22:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233939AbiDQKZW (ORCPT ); Sun, 17 Apr 2022 06:25:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233907AbiDQKZM (ORCPT ); Sun, 17 Apr 2022 06:25:12 -0400 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB92C27FEF for ; Sun, 17 Apr 2022 03:22:37 -0700 (PDT) Received: from dslb-188-096-140-061.188.096.pools.vodafone-ip.de ([188.96.140.61] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1ng237-0002FP-Jp; Sun, 17 Apr 2022 12:22:33 +0200 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 4/6] staging: r8188eu: replace mlme_handler with function pointer Date: Sun, 17 Apr 2022 12:22:19 +0200 Message-Id: <20220417102221.466524-5-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220417102221.466524-1-martin@kaiser.cx> References: <20220417102221.466524-1-martin@kaiser.cx> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" mlme_sta_tbl is an array of struct mlme_handler. mlme_handler's num and str components are not used. The code in mgt_dispatcher uses the subtype number of the incoming frame to select the array entry for compiling the repsonse. We can remove struct mlme_handler and make mlme_sta_tbl an array of function pointers. Signed-off-by: Martin Kaiser --- drivers/staging/r8188eu/core/rtw_mlme_ext.c | 49 +++++++++---------- .../staging/r8188eu/include/rtw_mlme_ext.h | 6 +-- 2 files changed, 23 insertions(+), 32 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/= r8188eu/core/rtw_mlme_ext.c index 77a14f55b743..492f481b61ec 100644 --- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c +++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c @@ -14,25 +14,22 @@ #include "../include/rtl8188e_xmit.h" #include "../include/rtl8188e_dm.h" =20 -static struct mlme_handler mlme_sta_tbl[] =3D { - {WIFI_ASSOCREQ, "OnAssocReq", &OnAssocReq}, - {WIFI_ASSOCRSP, "OnAssocRsp", &OnAssocRsp}, - {WIFI_REASSOCREQ, "OnReAssocReq", &OnAssocReq}, - {WIFI_REASSOCRSP, "OnReAssocRsp", &OnAssocRsp}, - {WIFI_PROBEREQ, "OnProbeReq", &OnProbeReq}, - {WIFI_PROBERSP, "OnProbeRsp", &OnProbeRsp}, - - /*---------------------------------------------------------- - below 2 are reserved - -----------------------------------------------------------*/ - {0, "DoReserved", &DoReserved}, - {0, "DoReserved", &DoReserved}, - {WIFI_BEACON, "OnBeacon", &OnBeacon}, - {WIFI_ATIM, "OnATIM", &OnAtim}, - {WIFI_DISASSOC, "OnDisassoc", &OnDisassoc}, - {WIFI_AUTH, "OnAuth", &OnAuthClient}, - {WIFI_DEAUTH, "OnDeAuth", &OnDeAuth}, - {WIFI_ACTION, "OnAction", &OnAction}, +/* response function for each management frame subtype, do not reorder */ +static mlme_handler mlme_sta_tbl[] =3D { + OnAssocReq, + OnAssocRsp, + OnAssocReq, + OnAssocRsp, + OnProbeReq, + OnProbeRsp, + DoReserved, + DoReserved, + OnBeacon, + OnAtim, + OnDisassoc, + OnAuthClient, + OnDeAuth, + OnAction, }; =20 static struct action_handler OnAction_tbl[] =3D { @@ -393,7 +390,7 @@ void free_mlme_ext_priv(struct mlme_ext_priv *pmlmeext) void mgt_dispatcher(struct adapter *padapter, struct recv_frame *precv_fra= me) { int index; - struct mlme_handler *ptable; + mlme_handler fct; struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; struct ieee80211_hdr *hdr =3D (struct ieee80211_hdr *)precv_frame->rx_dat= a; struct sta_info *psta =3D rtw_get_stainfo(&padapter->stapriv, hdr->addr2); @@ -406,12 +403,10 @@ void mgt_dispatcher(struct adapter *padapter, struct = recv_frame *precv_frame) !is_broadcast_ether_addr(hdr->addr1)) return; =20 - ptable =3D mlme_sta_tbl; - index =3D (le16_to_cpu(hdr->frame_control) & IEEE80211_FCTL_STYPE) >> 4; if (index > 13) return; - ptable +=3D index; + fct =3D mlme_sta_tbl[index]; =20 if (psta) { if (ieee80211_has_retry(hdr->frame_control)) { @@ -424,13 +419,13 @@ void mgt_dispatcher(struct adapter *padapter, struct = recv_frame *precv_frame) =20 if (ieee80211_is_auth(hdr->frame_control)) { if (check_fwstate(pmlmepriv, WIFI_AP_STATE)) - ptable->func =3D &OnAuth; + fct =3D OnAuth; else - ptable->func =3D &OnAuthClient; + fct =3D OnAuthClient; } =20 - if (ptable->func) - ptable->func(padapter, precv_frame); + if (fct) + fct(padapter, precv_frame); } =20 static u32 p2p_listen_state_process(struct adapter *padapter, unsigned cha= r *da) diff --git a/drivers/staging/r8188eu/include/rtw_mlme_ext.h b/drivers/stagi= ng/r8188eu/include/rtw_mlme_ext.h index 0875472dbb72..dcf91e7894a5 100644 --- a/drivers/staging/r8188eu/include/rtw_mlme_ext.h +++ b/drivers/staging/r8188eu/include/rtw_mlme_ext.h @@ -184,11 +184,7 @@ enum SCAN_STATE { SCAN_STATE_MAX, }; =20 -struct mlme_handler { - unsigned int num; - char *str; - unsigned int (*func)(struct adapter *adapt, struct recv_frame *frame); -}; +typedef unsigned int (*mlme_handler)(struct adapter *adapt, struct recv_fr= ame *frame); =20 struct action_handler { unsigned int num; --=20 2.30.2 From nobody Mon May 11 02:56:32 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07DA5C433EF for ; Sun, 17 Apr 2022 10:22:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233947AbiDQKZY (ORCPT ); Sun, 17 Apr 2022 06:25:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233910AbiDQKZN (ORCPT ); Sun, 17 Apr 2022 06:25:13 -0400 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2EF0C27FCA for ; Sun, 17 Apr 2022 03:22:38 -0700 (PDT) Received: from dslb-188-096-140-061.188.096.pools.vodafone-ip.de ([188.96.140.61] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1ng238-0002FP-Be; Sun, 17 Apr 2022 12:22:34 +0200 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 5/6] staging: r8188eu: don't call empty DoReserved function Date: Sun, 17 Apr 2022 12:22:20 +0200 Message-Id: <20220417102221.466524-6-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220417102221.466524-1-martin@kaiser.cx> References: <20220417102221.466524-1-martin@kaiser.cx> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Replace the DoReserved function pointer with NULL in mlme_sta_tbl. We can skip the function call for reserved subtypes. Signed-off-by: Martin Kaiser --- drivers/staging/r8188eu/core/rtw_mlme_ext.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/= r8188eu/core/rtw_mlme_ext.c index 492f481b61ec..abb910f33c1c 100644 --- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c +++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c @@ -22,8 +22,8 @@ static mlme_handler mlme_sta_tbl[] =3D { OnAssocRsp, OnProbeReq, OnProbeRsp, - DoReserved, - DoReserved, + NULL, + NULL, OnBeacon, OnAtim, OnDisassoc, --=20 2.30.2 From nobody Mon May 11 02:56:32 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B38DAC433EF for ; Sun, 17 Apr 2022 10:22:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233975AbiDQKZ1 (ORCPT ); Sun, 17 Apr 2022 06:25:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233914AbiDQKZO (ORCPT ); Sun, 17 Apr 2022 06:25:14 -0400 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5657A27FC0 for ; Sun, 17 Apr 2022 03:22:39 -0700 (PDT) Received: from dslb-188-096-140-061.188.096.pools.vodafone-ip.de ([188.96.140.61] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1ng239-0002FP-6G; Sun, 17 Apr 2022 12:22:35 +0200 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 6/6] staging: r8188eu: use ARRAY_SIZE for mlme_sta_tbl Date: Sun, 17 Apr 2022 12:22:21 +0200 Message-Id: <20220417102221.466524-7-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220417102221.466524-1-martin@kaiser.cx> References: <20220417102221.466524-1-martin@kaiser.cx> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Use ARRAY_SIZE instead of hard-coding the number of entries in the mlme_sta_tbl array. Signed-off-by: Martin Kaiser --- drivers/staging/r8188eu/core/rtw_mlme_ext.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/= r8188eu/core/rtw_mlme_ext.c index abb910f33c1c..973adebdd69c 100644 --- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c +++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c @@ -404,7 +404,7 @@ void mgt_dispatcher(struct adapter *padapter, struct re= cv_frame *precv_frame) return; =20 index =3D (le16_to_cpu(hdr->frame_control) & IEEE80211_FCTL_STYPE) >> 4; - if (index > 13) + if (index > ARRAY_SIZE(mlme_sta_tbl)) return; fct =3D mlme_sta_tbl[index]; =20 --=20 2.30.2