From nobody Mon May 11 04:12:56 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9BF3C433F5 for ; Thu, 14 Apr 2022 17:03:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243952AbiDNRGV (ORCPT ); Thu, 14 Apr 2022 13:06:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244879AbiDNRFp (ORCPT ); Thu, 14 Apr 2022 13:05:45 -0400 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2089.outbound.protection.outlook.com [40.107.93.89]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F20125E0; Thu, 14 Apr 2022 09:48:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dRLPDJDDMGQR35P0GlZIj+jtowbamRysKVZWv5zFNE+IUJ1OH5SY+8xhmxT8WdtnCQRviF9E680AMV6m5XjVv2YO0m4n1j4FjbqETr/oas233zIAc2foW10urWUgdkQcSGJ8s3Z2o9zxLaZFfod4ZEwi1o75NS1F/AYwEtdBJuITM9Ra+KlAaaezT9IAdRBC04VqcaOVsT9wH1vPfqL+ME21Tmd29GqJYDA/lZVoA5nhJrRYwCyPb222QTXUDpghSNPi6moeUZ2SERd/7GSskUxuI3QqdBh10I7od4hSMRxhwwuqkoCVoQEH5XdjOBebYLvHUD+rfYYE//CNnM9hEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QsH9v9VH2C3CZrHYQj8mjGeSpGLVTuZ58YPEeXGvtjg=; b=DVHhVPzLuAE42nMIVahWvgco6H++2hJH1SAjF0pVdCRQjoI3+dUMqU6H05bX5U3NNchSaSlFMuj3v4kzkyGj3vbs+mlX/+1P22sf/i2SOO2ChU5t+PnDrwZ9l+Jn9W3hHNZOlYx1JNfOZlG9EuLrsg0dyMXdw2zbYGJvh0oL7EP/4Ym1jE+3Z94hLaRtTqnEDvjOu9dmzOjok4vjoG9aRy7mZUC5NtPwXvllXhcbdyigfG81WJN8TEggnPPhzZt0okksooF/GeUxMp8xajbYdcmsF/BKuRSPeOvtAT9ypBAvJIAyhRuBm3vCHyAztQm6DVNoE5Cq47LuceFhEaPkPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QsH9v9VH2C3CZrHYQj8mjGeSpGLVTuZ58YPEeXGvtjg=; b=AwQKvf1PuKsts2sBfBgYJ5blbTNb6c9XZo6d7YrjAugFS3lcyTTnDseMB47d/S47ZP7bk6/hP1hxd4LrXCQcbeoBILXZdHWmRmwvkVSk+c3TmV3hWa3pSEwTU0ADaZIVKQ7I+4hbwsjWW8GgnCRDc45m6yaC3ZbbPzAPSmI9/78= Received: from BN6PR2001CA0019.namprd20.prod.outlook.com (2603:10b6:404:b4::29) by BYAPR12MB2613.namprd12.prod.outlook.com (2603:10b6:a03:69::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Thu, 14 Apr 2022 16:48:13 +0000 Received: from BN8NAM11FT068.eop-nam11.prod.protection.outlook.com (2603:10b6:404:b4:cafe::84) by BN6PR2001CA0019.outlook.office365.com (2603:10b6:404:b4::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20 via Frontend Transport; Thu, 14 Apr 2022 16:48:13 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT068.mail.protection.outlook.com (10.13.177.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5164.19 via Frontend Transport; Thu, 14 Apr 2022 16:48:13 +0000 Received: from AUS-LX-MLIMONCI.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 14 Apr 2022 11:48:07 -0500 From: Mario Limonciello To: Rui Huang , "Rafael J . Wysocki" , Viresh Kumar CC: "open list:AMD PSTATE DRIVER" , Perry Yuan , open list , "Mario Limonciello" Subject: [PATCH v3 1/6] cpufreq: Export acpu_cpufreq_exit for other drivers to call Date: Thu, 14 Apr 2022 11:47:56 -0500 Message-ID: <20220414164801.1051-2-mario.limonciello@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220414164801.1051-1-mario.limonciello@amd.com> References: <20220414164801.1051-1-mario.limonciello@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 93a64e5b-59b8-44f4-c3c6-08da1e3690f3 X-MS-TrafficTypeDiagnostic: BYAPR12MB2613:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6XZpx5xkHH+VGlI5etn80u53SnSD5Mw+OsQcz+d8rDLwlg0hPOrL9RgDOU0N7mn1THnUiC3cwWV+Lql0qA46NAFExmbHwFfUsyxKG7T+PhlXnxUK8GzF1hXIuZx7ARZMYnTs8ZDaf3sLSqOORPzVrxYfNq3USOIAvAVNiGc+Mniaf3W2DlyL6/1I/b4O5ANCvUj1g2rJbOvqxNgLbFcuYTXWCat2j3X88QAfDlRo4kamx7JWcH3y8HPZkdQ+TsnGC8FkII5lQjqALiumWRFwvFnN5++YHsPzAAe2hyBeFp9Mx003wOktw9kqwhmkLjdzGMOmpzXkiw4Mipy26eBgTccfG0g90B/Mu2WDjLFfJzxQfg8k4L126wqb+dgQivmn2EjLpDmExpAwHmPzcOiMcdT3busC2t3PV2ZdfVUcDv6Ht93S8LyhcJ2O4QtI1Ixd+9C+4O1DSXfTFsHKndhjOxm3vpV0xHUzt4WueyTDj9MsvzrDP4a/7uDDylf4MrEJKr6YPnbZMaMEpiSKFvDMlvfuYSUctexsYrHXRlfO3T7s4WF8S1OHGd4uqNomvoIC5i4ZKOmKrJWbfMHdmjIJzVdMehAiYNfqWoVANQlX92yhb4weQEqMvu2YFlbUw+tyGtsb/cBUhYRNk2MA9NDBP8EyMOw8/jguBsloaZaqsNZwktLNJUlBwnI4uKLZmKC/kdj6WQ8HErHxJMBKUmEq5A== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(2906002)(40460700003)(508600001)(5660300002)(44832011)(8936002)(82310400005)(6666004)(1076003)(81166007)(186003)(26005)(16526019)(7696005)(2616005)(356005)(54906003)(110136005)(86362001)(83380400001)(36860700001)(426003)(316002)(70206006)(8676002)(47076005)(336012)(36756003)(4326008)(70586007)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2022 16:48:13.4683 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 93a64e5b-59b8-44f4-c3c6-08da1e3690f3 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT068.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB2613 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Currently, the only way to load an alternative cpufreq driver is to unload acpi-cpufreq first. Loosen that restriction to allow other kernel modules to unregister a registered driver. Signed-off-by: Mario Limonciello --- v2->v3: * Move to include header * Create a new symbol to prevent NX protected page fault calling exit function from other modules. v1->v2: * Export symbol instead of changing internals drivers/cpufreq/acpi-cpufreq.c | 10 ++++++++-- include/linux/cpufreq.h | 3 +++ 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c index 3d514b82d055..38358ed1f932 100644 --- a/drivers/cpufreq/acpi-cpufreq.c +++ b/drivers/cpufreq/acpi-cpufreq.c @@ -1033,7 +1033,7 @@ static int __init acpi_cpufreq_init(void) return ret; } =20 -static void __exit acpi_cpufreq_exit(void) +void acpi_cpufreq_exit(void) { pr_debug("%s\n", __func__); =20 @@ -1043,6 +1043,12 @@ static void __exit acpi_cpufreq_exit(void) =20 free_acpi_perf_data(); } +EXPORT_SYMBOL_GPL(acpi_cpufreq_exit); + +void __exit acpi_cpufreq_module_exit(void) +{ + acpi_cpufreq_exit(); +} =20 module_param(acpi_pstate_strict, uint, 0644); MODULE_PARM_DESC(acpi_pstate_strict, @@ -1050,7 +1056,7 @@ MODULE_PARM_DESC(acpi_pstate_strict, "performed during frequency changes."); =20 late_initcall(acpi_cpufreq_init); -module_exit(acpi_cpufreq_exit); +module_exit(acpi_cpufreq_module_exit); =20 static const struct x86_cpu_id __maybe_unused acpi_cpufreq_ids[] =3D { X86_MATCH_FEATURE(X86_FEATURE_ACPI, NULL), diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h index 35c7d6db4139..223bf9760117 100644 --- a/include/linux/cpufreq.h +++ b/include/linux/cpufreq.h @@ -273,6 +273,9 @@ static inline void cpufreq_stats_record_transition(stru= ct cpufreq_policy *policy unsigned int new_freq) { } #endif /* CONFIG_CPU_FREQ_STAT */ =20 +#if defined(CONFIG_X86_ACPI_CPUFREQ) || defined(CONFIG_X86_ACPI_CPUFREQ_MO= DULE) +void acpi_cpufreq_exit(void); +#endif /********************************************************************* * CPUFREQ DRIVER INTERFACE * *********************************************************************/ --=20 2.34.1 From nobody Mon May 11 04:12:56 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CD3FC433F5 for ; Thu, 14 Apr 2022 17:03:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240573AbiDNRGO (ORCPT ); Thu, 14 Apr 2022 13:06:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244615AbiDNRFp (ORCPT ); Thu, 14 Apr 2022 13:05:45 -0400 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2069.outbound.protection.outlook.com [40.107.94.69]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9375F49CAA; Thu, 14 Apr 2022 09:48:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lJG4ki+jhfEOqoMYzd8CkEyGPl2+ErAGuK7AaTQz8umzjRo1oDWMNGvM7soJb91hD3zF1drS2nwMuAeZJzANf3xRIhpWmHv/vqiAN5Sy/eqKjxfgmQz4UjFhzPUOAo4Aw4GeB+UCF57cc+lcGj/j/gQeuUIAD9lsRLWdLU8wLYCnueWdQJwSrZ/Y8ME7BTxItipslXGtyis45QVD4cScxqo469brE4P7qJImVp39dW6ywm9gqLCv5SxrCGcF0bpj7FHj6cuY7iV59PfM2paf2izXz8teACKcuZ8P183BiE0IuENKgi+Pu02dT/IC2dNENvZsI+yR8XcaPMzsM3sjcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pkgpigE1LvaXonsaJ8J779zuU+/p6eVI11s0hWA+n8Y=; b=nMJM1namw2FUWb2vJApbSir9inWyVTGPbwj9ATaE46m7UISvpuusvYMwKwP3Dd8VQL3J/UqAkVAoXZbInMsXf1mRcWQxip5+7z7uegFg7B/XuTypJMBzwylRmGPY7d/NqdkQkf4hHIyCDdSsSKLqRlhHWKZdxeCEDhQIkFeiXhkalBXhpnDPDeVl0hVLYC6e/IaxAgWOqZAtkKa3PxoeMgl5cu1YBaecFPZX955QZjRAd27EYxuX3rf1uBugTycuQCEUTN8qxnQKFV2yijDOX0zj1LlBZ7BljwQD2yMy71lFBXI8jgxMvfVZ7O9zQAjG7IjnFRBes8wk2KSTVvi4BQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pkgpigE1LvaXonsaJ8J779zuU+/p6eVI11s0hWA+n8Y=; b=znvlv7uXUdiBQ8JU9f3PA3YYZFBnMmuNuWh9ASrdqS+Q3QP5BemJQyR2b7Do9M+8kMPKAu8RRMsiLuvELVbz18Xc5XFa8woN3a8KgCWU9ewVmw46Vr+e9OMdXU9xi8z0mA5W+tTZglHdP409oqLnPVrR8DzVXRyT2w6UwN0HfKM= Received: from BN9PR03CA0780.namprd03.prod.outlook.com (2603:10b6:408:13a::35) by DM5PR12MB1371.namprd12.prod.outlook.com (2603:10b6:3:78::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Thu, 14 Apr 2022 16:48:14 +0000 Received: from BN8NAM11FT017.eop-nam11.prod.protection.outlook.com (2603:10b6:408:13a:cafe::51) by BN9PR03CA0780.outlook.office365.com (2603:10b6:408:13a::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.18 via Frontend Transport; Thu, 14 Apr 2022 16:48:14 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT017.mail.protection.outlook.com (10.13.177.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5164.19 via Frontend Transport; Thu, 14 Apr 2022 16:48:14 +0000 Received: from AUS-LX-MLIMONCI.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 14 Apr 2022 11:48:08 -0500 From: Mario Limonciello To: Rui Huang , "Rafael J . Wysocki" , Viresh Kumar CC: "open list:AMD PSTATE DRIVER" , Perry Yuan , open list , "Mario Limonciello" Subject: [PATCH v3 2/6] cpufreq: amd-pstate: Only show shared memory solution message once Date: Thu, 14 Apr 2022 11:47:57 -0500 Message-ID: <20220414164801.1051-3-mario.limonciello@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220414164801.1051-1-mario.limonciello@amd.com> References: <20220414164801.1051-1-mario.limonciello@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 070996c3-2ff2-4aa5-4e17-08da1e36916a X-MS-TrafficTypeDiagnostic: DM5PR12MB1371:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rAjzNGM7Q2uM0QZ9j4/t0W5cewILjusodtk2pKhE1mQ4JBedQnAfsNZl9o49f1NjRZkSprz6sa8AtGQng6urVHAF0nYub9zlBKQ/WlpwDWonX6QV/Dk2HPBWUIszCy1c84x5SIMllMfm8YGvwUFZTxD+/1Z6f/jgNpDGT7n4kQg4VIJqGe7EDrpi/NPKd8Jawp2gP967XRccWiFfcq8BPdcRViIjtXGaxFeTAXvkVxfGYBVmF+TK9OwzTr3WAecJMGSp31i4jQ8lcoz2ikYZ/hJPGd74Ja+hsE0TDHmo/peAtiJPlo6URIoYkbXYX9dsY7TGsFwp8GZwZKHdQ4N7BColgpEQPDWih2LsUG7TlSMZURmTKC7hgQQeFm8aFdPZcIBTtT3q5E/vcBiCcilGOtIFsEU0ZFYw1voEcf4WVykOXGhgZuEzAgcMaVLKb8PScjiJ6hqRAWhLhkLnrAbzmBr1k2fLux3N60q0b6POO9CgLrzRYLLkwQ5F2CA8pridaaMXFCsMraHbZEj9ZZ2YS5j5mZhDA6KxmRg0V6ecX63VspED8m4vuCCnmqM+It7iCRGtKvXBvqR9ygrwDtzfgvM6isq5SU6vBBDwbF9Qb1G75PsslEgdoKMssdOX7q7meI9UDTvfwCqY/y52pyncU3DmCPYvKGezpN5wHd+wJFqkR95ppr90hx15MjBuDBos9/kxFCJTOZ3lZlqflVypPQ== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(2616005)(8676002)(47076005)(54906003)(426003)(4326008)(6666004)(86362001)(508600001)(36756003)(1076003)(16526019)(5660300002)(44832011)(336012)(40460700003)(110136005)(316002)(8936002)(186003)(26005)(81166007)(7696005)(2906002)(83380400001)(82310400005)(356005)(70206006)(70586007)(36860700001)(15650500001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2022 16:48:14.2451 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 070996c3-2ff2-4aa5-4e17-08da1e36916a X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT017.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1371 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" A message is emitted to let users know they can enable shared memory, but it shows on all CPUs. As this parameter is system-wide not CPU specific, it doesn't make sense to show 8+ times. Modify it to print only once. Signed-off-by: Mario Limonciello Reviewed-by: Huang Rui --- v2->v3: * New patch drivers/cpufreq/amd-pstate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 7be38bc6a673..ecd1fd5e5b5a 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -666,7 +666,7 @@ static int __init amd_pstate_init(void) static_call_update(amd_pstate_init_perf, cppc_init_perf); static_call_update(amd_pstate_update_perf, cppc_update_perf); } else { - pr_info("This processor supports shared memory solution, you can enable = it with amd_pstate.shared_mem=3D1\n"); + pr_info_once("A processor on this system supports the shared memory solu= tion, you can enable it with amd_pstate.shared_mem=3D1\n"); return -ENODEV; } =20 --=20 2.34.1 From nobody Mon May 11 04:12:56 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C84A2C433EF for ; Thu, 14 Apr 2022 17:04:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244509AbiDNRG1 (ORCPT ); Thu, 14 Apr 2022 13:06:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244603AbiDNRFp (ORCPT ); Thu, 14 Apr 2022 13:05:45 -0400 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam07on2045.outbound.protection.outlook.com [40.107.95.45]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6427A49687; Thu, 14 Apr 2022 09:48:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F44kyiZ3nLO5CSxAOGS0Kkh+SgHUfcYQ8YlcyEJEK2+ITgPTwmsfh69VWz97NgGKovGPiaOKJrTKhl8kgbX6q1sT00QXvN+0f4dYUmq8rWRYRWxwyntI+arDIdM0hXDXrBnsKE6DIRya2EdXgtBdKJlkXsCbQxe5O7qhgbCZU12HZ4So03QSxvF62XOUfQoI6y5EezRe6WPbOzt9v/Ol4PrGIndW/LrbHnGm3DaCtRjczzDlkye68VuY/eIOcvZ1RXaoVho2pn7uU30aHML+cz5Lcp7lGnKFmSueCiMcpMj1rzStwjTJJQtuOUhXK4tvsKR88zHByPYVNzPlQigeiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iwGTwtCH0+YudosIEhG/8CiHFOI8FMbNpAfVkGHDIiA=; b=bgoQ0gxJKz7ouL8Y4njKODwNOk/ue59+F4t9i8cHBWfb1lG809rOHFik8jbc6AttYnvR9EVugn/lv3D4R57f7+Mp6mwsy2Y4ITS8jo73fL44C+mr6/L27COcUHCLpx6QehjkSHrNfDc+a0tTivTzvsaTg/CfeLcm+wCw4n7hq6MHQ0Zfj91o61hREO78fR4PpHamY+VUr5vKN1PhKTCne7mwcnpW7gfiSBMKCZHSOci4v/xfN4NcSXEZE/pBEELUKazA2hMsR8o2L6XIW4BRXFtq4lJ5CK0j8uwSK5mkR380aKJfkLDCieLlCn/tV+3lX4gk4q82DOXB1Zo3OCtc4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iwGTwtCH0+YudosIEhG/8CiHFOI8FMbNpAfVkGHDIiA=; b=OwhuzH+vwotDMgo16ZJa2xc27Fq9sQewGbynfJ7xCCFskA6a/aJ0he01CYgP0Qj2rgEHbeiS0A69wAYzBVcDb0QYbmoWJFqqPxlaep9dsYoM6q2J57w0M4KSAbPIh7hWCdBDYFYfJZXbk/eJh+dSeXRnVjrOla1mt9HOBsCxDrA= Received: from BN6PR2001CA0019.namprd20.prod.outlook.com (2603:10b6:404:b4::29) by BN6PR1201MB0034.namprd12.prod.outlook.com (2603:10b6:405:53::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.30; Thu, 14 Apr 2022 16:48:14 +0000 Received: from BN8NAM11FT068.eop-nam11.prod.protection.outlook.com (2603:10b6:404:b4:cafe::2b) by BN6PR2001CA0019.outlook.office365.com (2603:10b6:404:b4::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20 via Frontend Transport; Thu, 14 Apr 2022 16:48:14 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT068.mail.protection.outlook.com (10.13.177.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5164.19 via Frontend Transport; Thu, 14 Apr 2022 16:48:14 +0000 Received: from AUS-LX-MLIMONCI.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 14 Apr 2022 11:48:09 -0500 From: Mario Limonciello To: Rui Huang , "Rafael J . Wysocki" , Viresh Kumar CC: "open list:AMD PSTATE DRIVER" , Perry Yuan , open list , "Mario Limonciello" Subject: [PATCH v3 3/6] cpufreq: amd-pstate: Move cpufreq driver check later Date: Thu, 14 Apr 2022 11:47:58 -0500 Message-ID: <20220414164801.1051-4-mario.limonciello@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220414164801.1051-1-mario.limonciello@amd.com> References: <20220414164801.1051-1-mario.limonciello@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6deb2a6f-709b-4c16-1ed4-08da1e369172 X-MS-TrafficTypeDiagnostic: BN6PR1201MB0034:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MDu2nQUHZ+2V/8rvvGzysxEGVdzOFFUVW9J/zHlpMZ2zs6n31PgRED8UkXizGQkOZgxwGpp9WY6g0MgMWl8fqGIPPzkIOu++/0Ha14QgfMe3dY8HKgW3Ta2rlhKZVW1AlRo56aMA/5UgqYl3BVdJHezULzLO+q/+0NxzB8CvcqaHbC54LOZ+xmKRDEWtNOpH+qaxxQR64RlWxgtoEQYYVgu6Y9vqHZtUmMRKCQXdipK/5yms17bdrpAHHrlhNm9BJ30Hykn7BZF1voh6tYIH5VKJXFlqM1jlv36hP3T7gSTr1WjGDWXeD+V1B21lDAlHKe6Y10gwQDPxAs+/sy1/0tCkC5X6+64PZhAjEQZLcJ8sBx71w/x68CRhLB/VfdfoS3U43+do+LGImztn+xZ+L872uKRNHJEUz30RgKOB8NWJUV+hRP2BzyGS2GZNBR5kv1lSharJzmu9+dZVaE2JaJDz5sNjTA3Bp0naRATKmkGjfRFkK0k0HAnhaLAL9pQ0ZKxzQTJMiuFvRC3jTkHaTF4gcoTBHcWcryhay2TN+y1atDUWE8BqWlIxuqoOjxa0Loz25fj4s6wZ80MkBX+cVjH7y4UVCLaiQwg2xczBSpXy0TLcTuaq0MYTWMUa3xY5suw4C5B6HA7K0pborGEQ8FAGcg80C3+x0Ln6pdklgn5C0CtROTAH0PwlFBxvlLXSbvP/mENGr987q0D7qLug4w== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(40460700003)(5660300002)(8676002)(4326008)(36860700001)(81166007)(7696005)(110136005)(54906003)(70206006)(82310400005)(316002)(426003)(83380400001)(336012)(47076005)(6666004)(356005)(8936002)(70586007)(86362001)(508600001)(16526019)(26005)(186003)(1076003)(2616005)(36756003)(2906002)(44832011)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2022 16:48:14.2964 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6deb2a6f-709b-4c16-1ed4-08da1e369172 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT068.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1201MB0034 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The cpufreq driver check occurs before we verify if the CPU is supported. Depending upon module load order, this may mean that users are never notified they can enable the shared memory solution. Signed-off-by: Mario Limonciello Acked-by: Huang Rui --- v2->v3: * New patch drivers/cpufreq/amd-pstate.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index ecd1fd5e5b5a..d323f3e3888c 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -653,10 +653,6 @@ static int __init amd_pstate_init(void) return -ENODEV; } =20 - /* don't keep reloading if cpufreq_driver exists */ - if (cpufreq_get_current_driver()) - return -EEXIST; - /* capability check */ if (boot_cpu_has(X86_FEATURE_CPPC)) { pr_debug("AMD CPPC MSR based functionality is supported\n"); @@ -670,6 +666,10 @@ static int __init amd_pstate_init(void) return -ENODEV; } =20 + /* don't keep reloading if cpufreq_driver exists */ + if (cpufreq_get_current_driver()) + return -EEXIST; + /* enable amd pstate feature */ ret =3D amd_pstate_enable(true); if (ret) { --=20 2.34.1 From nobody Mon May 11 04:12:56 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4797C433F5 for ; Thu, 14 Apr 2022 17:04:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244202AbiDNRGl (ORCPT ); Thu, 14 Apr 2022 13:06:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244949AbiDNRFp (ORCPT ); Thu, 14 Apr 2022 13:05:45 -0400 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam08on2048.outbound.protection.outlook.com [40.107.101.48]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B32E449CB2; Thu, 14 Apr 2022 09:48:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZU0gBkRK4Inim/KM2M1Bhh5xck8Yfz5POfQrii7D9oXm+cyDEWywZjY5V2GbE8ANJV0R1r5zrulsDPK28u7pstUonQPZWUqKwdWULtlq/Yjr8dtYuaUzRd8MKWjCFUmVWKNE8luqvsLuHM/VIkAI17F8ZDJa335bd8gw1AMJBX3fmUPDFaWCqCftgr7rmkKNem3BT5c0uSoJ01ctFJ09/Bp7NAA6xXMzzFitaDeUqzpoydcUt2aPOBwHwiYEv3uhT6G5geMyQv7hvtyKpPAHOM1wi0c2CauonqHH8kIMvatl5pBCZO2nledRejS+gSWjQvsn5zW0JZIDhDbWOzJ1/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Dv46hVZhOh36hdtM/zKZRvRF3Pwxj0M6Wex6v4rRaEI=; b=bjJW3EvqcsaZrE7/3nixvlIjftT2pOicrn79Cc56nMFVeQMRKfS81SaDNeLwR23w0ei+HeuFf2MS/2LQ0PmGnSbk1E/RnvX3i6l515bNA6GdvsP9p/GakCAiwPR/oPs8WBRO1xwpzF0K5j0wsR/uLv8Nyl5bnOFXy3g1BphZsEl6r3V7qLypDJ7qz7PWqtGP8i/yp+0xxSpAbTOispj+wpAiZm3ZSg0RhLB81MIaCpI2O1/UydOjkbXLCn+H+V+/y4a/oZe+ShpfRZhiqep8Il6A1BSXn1SgSbzENtSVPiD5dbpWIU85dsoOtTkqg8BzFEpmq9qug58s2HpnEsfFSw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Dv46hVZhOh36hdtM/zKZRvRF3Pwxj0M6Wex6v4rRaEI=; b=ia5GOs1n5BCgotVeKhkZfbquRLtLzdTTCJ1jSOFBpD38hcmoMOGWPPGE71EMIac6i6y/8/eByEYQ/oQn54/o7tE4nRQLnURMwt+Gd4QyggYbahcsQS/TFZ+I4CWJzSzZz7qD2RRM8/Uu+9Yh5RaPYDNPaX6ePJtZcymFFNshPKI= Received: from BN6PR2001CA0013.namprd20.prod.outlook.com (2603:10b6:404:b4::23) by CY4PR12MB1671.namprd12.prod.outlook.com (2603:10b6:910:c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.18; Thu, 14 Apr 2022 16:48:15 +0000 Received: from BN8NAM11FT068.eop-nam11.prod.protection.outlook.com (2603:10b6:404:b4:cafe::90) by BN6PR2001CA0013.outlook.office365.com (2603:10b6:404:b4::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20 via Frontend Transport; Thu, 14 Apr 2022 16:48:14 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT068.mail.protection.outlook.com (10.13.177.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5164.19 via Frontend Transport; Thu, 14 Apr 2022 16:48:14 +0000 Received: from AUS-LX-MLIMONCI.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 14 Apr 2022 11:48:09 -0500 From: Mario Limonciello To: Rui Huang , "Rafael J . Wysocki" , Viresh Kumar CC: "open list:AMD PSTATE DRIVER" , Perry Yuan , open list , "Mario Limonciello" Subject: [PATCH v3 4/6] cpufreq: amd-pstate: Allow replacing acpi-cpufreq when loaded Date: Thu, 14 Apr 2022 11:47:59 -0500 Message-ID: <20220414164801.1051-5-mario.limonciello@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220414164801.1051-1-mario.limonciello@amd.com> References: <20220414164801.1051-1-mario.limonciello@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1160d358-80d6-470d-4230-08da1e3691b7 X-MS-TrafficTypeDiagnostic: CY4PR12MB1671:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: M0MBncQEM/yrcCun4yRsVanUUgBZVWmOMJqMRDCFWi3sH6m+Q+WdanGBomFBuPbyD+Aw6evkiBrz7BX67biNUjHhdBSmtIXQSt84cg8DIs6o9lBkbIR/JHzi4c4DJeck6QwnT9Uswd3kY68OT96LCSy3BDYVvnA4juGp4h6HFFas8S6oehPGh0GL8BA7KlcE4usFXTe10vLnQjYfDhsRgZtsn8BsKvZG5XvAc7WnH4bTC9cXbR/5IZmfkWY2SMXRbChl0UWZ1ThV5y0BxVjPYExXjW5JoCyE5n34m4s26xBkfqnAFRQ1vR6tisO7NFVbqHtLOWapu313aqk1B5RaE1Xcy4d+jl3OTH76dceAxyNYON5VqBUB5GFw94nJ9e0iVTV/KenD/2acWUmIkH6AFb1NmlUpgB4H+vG+ms00TD/bW4FhOhknEfn1XLGn7+z5qBd74vtr450WHhT98sm9pOmffS51oOx2B24By/g3upCq1TFUpuy/uEsc5Y0afeHiNDn5AKe4QStiOFPAj4y7x9Y6GSWdP4LFEPN8Oqz3T/2hi2buJRdQtJ3wLI0LvzrDorr8dczp7uBd4RT4sPEjtNSTeDTfO/zdrcsN2WDbCRROynIin+B0+g6ffHJYFlDII4gl1kWpPmzXorAiH7Lk//ETaS7UaJO93i3AEDrsUePVoW6Upco7/uYad6nt637TG8qJKpUmRNbRVYCWnkzuCg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(110136005)(54906003)(316002)(4326008)(70586007)(70206006)(8676002)(36756003)(426003)(16526019)(336012)(83380400001)(1076003)(186003)(26005)(40460700003)(47076005)(7696005)(6666004)(36860700001)(508600001)(356005)(81166007)(2616005)(86362001)(82310400005)(2906002)(5660300002)(44832011)(8936002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2022 16:48:14.7495 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1160d358-80d6-470d-4230-08da1e3691b7 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT068.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1671 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" `amd-pstate` can be compiled as a module. This however can be a deficiency because `acpi-cpufreq` will be loaded earlier when compiled into the kernel meaning `amd-pstate` doesn't get a chance. `acpi-cpufreq` is also unable to be unloaded in this circumstance. To better improve the usability of `amd-pstate` when compiled as a module, add an optional module parameter that will force it to replace other cpufreq drivers at startup. Signed-off-by: Mario Limonciello --- v2->v3: * Rebase on earlier patches * Use IS_REACHABLE * Only add replace parameter if acpu-cpufreq is enabled * Only show info message once v1->v2: * Update to changes from v1. * Verify the driver being matched is acpi-cpufreq. * Show a message letting users know they can use amd-pstate. drivers/cpufreq/amd-pstate.c | 22 ++++++++++++++++++++-- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index d323f3e3888c..8ae65a2072d6 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -63,6 +63,13 @@ module_param(shared_mem, bool, 0444); MODULE_PARM_DESC(shared_mem, "enable amd-pstate on processors with shared memory solution (false =3D= disabled (default), true =3D enabled)"); =20 +#if defined(CONFIG_X86_ACPI_CPUFREQ) || defined(CONFIG_X86_ACPI_CPUFREQ_MO= DULE) +static bool replace =3D false; +module_param(replace, bool, 0444); +MODULE_PARM_DESC(replace, + "replace acpi-cpufreq driver upon init if necessary"); +#endif + static struct cpufreq_driver amd_pstate_driver; =20 /** @@ -643,6 +650,7 @@ static struct cpufreq_driver amd_pstate_driver =3D { =20 static int __init amd_pstate_init(void) { + const char *current_driver; int ret; =20 if (boot_cpu_data.x86_vendor !=3D X86_VENDOR_AMD) @@ -666,9 +674,19 @@ static int __init amd_pstate_init(void) return -ENODEV; } =20 - /* don't keep reloading if cpufreq_driver exists */ - if (cpufreq_get_current_driver()) + current_driver =3D cpufreq_get_current_driver(); + if (current_driver) { +#if IS_REACHABLE(CONFIG_X86_ACPI_CPUFREQ) + if (replace && strcmp(current_driver, "acpi-cpufreq") =3D=3D 0) { + acpi_cpufreq_exit(); + } else { + pr_info_once("A processor on this system supports amd-pstate, you can e= nable it with amd_pstate.replace=3D1\n"); + return -EEXIST; + } +#else return -EEXIST; +#endif + } =20 /* enable amd pstate feature */ ret =3D amd_pstate_enable(true); --=20 2.34.1 From nobody Mon May 11 04:12:56 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E237CC433F5 for ; Thu, 14 Apr 2022 17:04:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245010AbiDNRG6 (ORCPT ); Thu, 14 Apr 2022 13:06:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244906AbiDNRFp (ORCPT ); Thu, 14 Apr 2022 13:05:45 -0400 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam08on2049.outbound.protection.outlook.com [40.107.102.49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9B5049CB3; Thu, 14 Apr 2022 09:48:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NBJ7Nx/xb/VQejZ2zpJnEZOc758IQUlGu6O6KpkbB4iNPwnn3tKQgQt4gpUROcHPEfKWJfrBGLvwa3U/3Zd/uE/2LATiZqeJnSFiq3mUxEYUAZCPXjW9+H0ekUXaa+rfrRWQ/WhgCyg7fNsWyddbnwBfbt4qcZhgSk+8KRb5iR5moFobl3rLYYC9Ogzf0l82H+Bc3a4/W3C2lfgVJ47KV4YDJDjLPBCQgbOBJcidP7bf1PlUUK+NpL1oRO7BRFRRp8JBSTIdPdDwwENr/TaSQG4NEWsCyhUcaaezb5JBIsJ2zK+kD//acVRhGeXxVdx54Wt2/5Ct2X6wFgTYwouPsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=l68433YVMq66wTCNnzwadv9YbsWeBaN8JOpghfEUYyM=; b=K/V4Ep3ceetRfE0RHF2VHRLx07d2276JGO3+kryZMggmQZAjF7FoezExJzT28WU6zUeaOHu0lhNyrnIPmQ7mh/X7qdUwAM8sDN3XxD5YB/ptAewdBoB8SftDrcIVE18neC/CIPCU6spczOhQ3R0mSxgSX5+gg5+CTNz+i/12C/4498X0cPW24fsPaOeigX5E5PyVeWw5aaOsBfs5OSZBCzEDWdle6BbGHwz6p4oGg82SrYX9pHzz+3lON1nYLYC8BsWSFXzN34nNtzlYK5eSL6WPZLSTfp+Ptn4KFZ390q8IhmqRpEGnasXjxNImYSCuq/n2xZeR538171Rq6aLJOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l68433YVMq66wTCNnzwadv9YbsWeBaN8JOpghfEUYyM=; b=l2cxLH+Ma80FAiFlelsm+JOHt7PeIn4Hmi5bTftcNDnliYYGEufKOV1ioTF3aeEeBUf6EKEb0NZ13SKjIPy1yFqoXkopqA+d+2rRccLij+0hVYqQSta+0BeB+2TPU+eAztY3lJ9OWxemBlsXVseQJjqvGjTiYNyMv7R3XSjtVts= Received: from BN9PR03CA0778.namprd03.prod.outlook.com (2603:10b6:408:13a::33) by PH0PR12MB5608.namprd12.prod.outlook.com (2603:10b6:510:143::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Thu, 14 Apr 2022 16:48:15 +0000 Received: from BN8NAM11FT017.eop-nam11.prod.protection.outlook.com (2603:10b6:408:13a:cafe::7f) by BN9PR03CA0778.outlook.office365.com (2603:10b6:408:13a::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.18 via Frontend Transport; Thu, 14 Apr 2022 16:48:15 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT017.mail.protection.outlook.com (10.13.177.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5164.19 via Frontend Transport; Thu, 14 Apr 2022 16:48:15 +0000 Received: from AUS-LX-MLIMONCI.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 14 Apr 2022 11:48:10 -0500 From: Mario Limonciello To: Rui Huang , "Rafael J . Wysocki" , Viresh Kumar CC: "open list:AMD PSTATE DRIVER" , Perry Yuan , open list , "Mario Limonciello" Subject: [PATCH v3 5/6] cpufreq: amd-pstate: Add a module device table Date: Thu, 14 Apr 2022 11:48:00 -0500 Message-ID: <20220414164801.1051-6-mario.limonciello@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220414164801.1051-1-mario.limonciello@amd.com> References: <20220414164801.1051-1-mario.limonciello@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8838f436-60e9-4766-1e44-08da1e3691df X-MS-TrafficTypeDiagnostic: PH0PR12MB5608:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DyxsT4ns4eis8pMyoxbIOs69nCRQx3ISPDmmbJyzVlUcE/XAVi/Ik/kTkmba6RLCWUNXH+SSapfWqKHs0b7Zf52ooRMLcmGdwEWyzqoNVhQ88fnrkEptOhBWEOBATcOl84hbATf3xZ9VrDNAR71tO/3TtmjfZVvm5qrsLp/CctTr+Rx2WMJv+Sg4rM6aRyISq0SOzCSLoR0WxR1xcJ3fpevKRhwmhOciFJ45izJpxHrRXl48AXqVYWP9PrQyVCA9v4sV6r+fl4RczECen7C05EObbxY+KsBz5LJIEKR0sOnRdCLIJyAPA3ozT/L2syvg21d6Sc8O/SHoRZBNf8XkrCh8jIt4X9dznrR9N7+WsPoccJv6gmKT2YIHo2avUb+cuBvNdiNHA/LWEemJsBc3pHBgS6REL3xa8G3E1Lh5vwMIHhHptU+MijshSDUnzoUQaTADkuEaLgk4pk3/qKwIXL9/Ya/mPMB3ItsrR0hEvRSx3coe+/WbvccgWps+FYCSYcb9um8OkgqFSianOEatYh1D0m9E2BYrVgrH2rGaUma4oYQ+MKwgoS7lfyd5nKOWKA3YVwCEwhb/K68HTvVHcdQFyLjzJQOS+QeqGvU7IKS/GSUSqLVxmuhYGm8oBl8WQk6fJHOxAK+QrtXJBF4zWB3dSyDYAzcP1Y7EbOaE+if91HeAsuMgMyw17dkVzqwOJjZCMK2pncCYm3vW4Dpg2A== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(36860700001)(81166007)(6666004)(7696005)(4326008)(508600001)(40460700003)(426003)(86362001)(83380400001)(26005)(36756003)(186003)(16526019)(1076003)(82310400005)(356005)(2616005)(336012)(5660300002)(44832011)(316002)(54906003)(8676002)(47076005)(110136005)(8936002)(70586007)(2906002)(70206006)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2022 16:48:15.0107 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8838f436-60e9-4766-1e44-08da1e3691df X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT017.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB5608 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" `amd-pstate` currently only loads automatically if compiled into the kernel. To improve the usability, add a module device table that will load when AMD CPUs that support CPPC are detected. Reviewed-by: Huang Rui Signed-off-by: Mario Limonciello --- v2->v3: * Add Ray's tag v1->v2: * Add comment to indicate need of SBIOS support. drivers/cpufreq/amd-pstate.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 8ae65a2072d6..3330504b7070 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -710,6 +710,17 @@ static void __exit amd_pstate_exit(void) amd_pstate_enable(false); } =20 +/* + * This will only match the HW feature, there still needs to be appropriate + * SBIOS support, so it's possible that in such cases this causes a module + * load with -ENODEV as the result. + */ +static const struct x86_cpu_id __maybe_unused amd_pstate_ids[] =3D { + X86_MATCH_VENDOR_FEATURE(AMD, X86_FEATURE_CPPC, NULL), + {} +}; +MODULE_DEVICE_TABLE(x86cpu, amd_pstate_ids); + module_init(amd_pstate_init); module_exit(amd_pstate_exit); =20 --=20 2.34.1 From nobody Mon May 11 04:12:56 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAA3DC433F5 for ; Thu, 14 Apr 2022 17:04:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243240AbiDNRGq (ORCPT ); Thu, 14 Apr 2022 13:06:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52184 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244930AbiDNRFp (ORCPT ); Thu, 14 Apr 2022 13:05:45 -0400 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2047.outbound.protection.outlook.com [40.107.237.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4AB89BC3; Thu, 14 Apr 2022 09:48:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K6BKK7rLq4mh7u1SCMoeIEQjyyniXHDZitC3suaL1IeHw9zqbBzN7bkpcWxuQL5KEHW0j/C4fkbDOFAaZ59bLWvJVa6lNy7mzny+WlwKwFjeyXvTNuhhBhkmWrLl3q2hHfu84Y5B6XZv8guLX81Y6IpRYYM/FD5jPH8pyoQ8diQw18r3hxTr/ivfRJz8hW5itJWah8LX4kEsv3JejQZfxr3DjEF1bZ404nPlkca8UGduDCv7X87EOu8MUe0cq3l8fDiQVYLNUp7gy/vkQSYUmxVGYHbL3Ibo92U/RDXJzyZHf96LOPu9t0O3rjc52tdO/vUr6IW5iqartUlO36UuNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Qmzr55cp2EbMngwaZIRCp1nStztnv1zdLphWXlYuvzI=; b=M2fY+94enRrIEndrIMwkiQ7N+drgsIqH4OnjhFjBcXGjfpyVIfVEGwRHC6CsYeFbtUiS15G5Y8vkMFloFZkkEIkNhR8/4MqTXwzFn5rZT15OJFYSuVj1Ef/oQ3r3S2LNFgj5PuxIZBXkmOB+prQR/F3T5h1rXsdrILxweaRAjcn2HOz3/kngEtVFMlD36ZQe8RUAPIjjaSgrYu0V53krXMwVECTR/3mjib+xaX2sh9zhoLFXWfl8sHeBpSw6bDhKnyNCLvV63V12lCRNWV2U4s/xwn/H71m/e5XU/ufIrFdulR0L2RNiMBygmcWiDNYi6nAmi6HXzM0/3EhDdm6ojA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Qmzr55cp2EbMngwaZIRCp1nStztnv1zdLphWXlYuvzI=; b=seYSED5YodXkmoJXI1O+eBTXqXliHICKNpmmy+l+w5IiZt/waTCf2TgVjSQX5MYMP1F14V2BsNXq6KnR19mXXO+ND0F86L2bP0apIUendcMhlDqoqgMZqxxwOFIh6UwqRfSyPleiA/9xvbVQ0QqxoMq8euj93Yg5fO/FT/e3I1c= Received: from BN6PR2001CA0023.namprd20.prod.outlook.com (2603:10b6:404:b4::33) by BN6PR12MB1938.namprd12.prod.outlook.com (2603:10b6:404:fe::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Thu, 14 Apr 2022 16:48:15 +0000 Received: from BN8NAM11FT068.eop-nam11.prod.protection.outlook.com (2603:10b6:404:b4:cafe::ed) by BN6PR2001CA0023.outlook.office365.com (2603:10b6:404:b4::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20 via Frontend Transport; Thu, 14 Apr 2022 16:48:15 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT068.mail.protection.outlook.com (10.13.177.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5164.19 via Frontend Transport; Thu, 14 Apr 2022 16:48:15 +0000 Received: from AUS-LX-MLIMONCI.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 14 Apr 2022 11:48:10 -0500 From: Mario Limonciello To: Rui Huang , "Rafael J . Wysocki" , Viresh Kumar CC: "open list:AMD PSTATE DRIVER" , Perry Yuan , open list , "Mario Limonciello" Subject: [PATCH v3 6/6] cpufreq: amd-pstate: Default to replace acpi-cpufreq Date: Thu, 14 Apr 2022 11:48:01 -0500 Message-ID: <20220414164801.1051-7-mario.limonciello@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220414164801.1051-1-mario.limonciello@amd.com> References: <20220414164801.1051-1-mario.limonciello@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a4d56c98-443a-4523-15cc-08da1e36920d X-MS-TrafficTypeDiagnostic: BN6PR12MB1938:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PXOZXpnwRI0LBEi2kXcjCzDUCbkXmJrdnEdYVVHJXad2LJhjlqCZieNbCUpOvjToZ41Zn7efqqLrXRkaD6cxAKTSbPtXSiYqd+xaN+n6umiM86ICLO1DzybxsfKg7jMJgInhojo/iODyx0H1mu4mHzEpsrKXTs6SulUhIbOVoYUiREGfZZkscv5z7aIlRHBuFoZ2OaO8mL0JY/1e542KONLcyiRhbFONi9pv2C0jIVe+CuUp5N802UICDSFN6qomukulepoE6lRP0v7LKfb5P7DCrqVoyvP2nhYDDjP66FtEnVHxqMhyAFMYfhmlClCNF22vKBWzVIASHXDMKSKxoD/NDj7c94by+sEVwxIlDf/9kj4VtlVpQ8GAgcTnJdjQfKrQE++ED1H9njDH9cONbQbAptNaRxgqp/kYgxw4RguLO4TF6o6YL8hvNK7zqSyOqiR5AhxcTwcjHa10ewOwbsfq7/UE+2pCGfheigfqHmADBjFN/d7ZeJaghRloG0oL4rXRxyz0HGnWUUnajZKB6LkxVxR8H28egDQwNN5MjOCs5SAdh94VcK/75Qj5QzSCCDkX6IqKUbPQR+UwIwLrpMFcFVrckMHX2GnryXcEkKzMbmBZtmbqHZe+TEiWggwtXQAyCSZIRLGz9i2EMCt6h3a2sfOoJf6mUUbML3tdO7eeqyjlnnTab1K//C1oqpM/9c3I86nNj/4kNabJ4TfhSw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(44832011)(83380400001)(82310400005)(47076005)(2616005)(186003)(16526019)(1076003)(426003)(336012)(110136005)(54906003)(5660300002)(316002)(8936002)(81166007)(86362001)(356005)(2906002)(4326008)(36756003)(6666004)(7696005)(40460700003)(26005)(508600001)(70586007)(70206006)(8676002)(36860700001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2022 16:48:15.3119 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a4d56c98-443a-4523-15cc-08da1e36920d X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT068.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1938 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" As a side effect of using the symbol `acpi_cpufreq_exit` attempting to `modprobe amd-pstate` loads the acpi-cpufreq driver if it's compiled as a module. This means that module load order can't work anymore from those changes. To make this a more obvious default behavior set the "replace" module parameter for amd-pstate to true. Expected outcome is that no matter what configuration for module or compiled in, amd-pstate will take precedence. If a user prefers to use acpi_cpufreq, they can set `amd_pstate.replace=3D0` and then the following outcomes will happen when attempting to load amd-pstate: * acpi_cpufreq module & amd_pstate module -> acpi_cpufreq * acpi_cpufreq builtin & amd_pstate module -> acpi_cpufreq * acpi_cpufreq builtin & amd_pstate builtin -> amd_pstate * acpi_cpufreq module & amd_pstate builtin -> amd_pstate Signed-off-by: Mario Limonciello --- v2->v3: * New patch, added since worse experience from patch 4. drivers/cpufreq/amd-pstate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 3330504b7070..538c9c4cea6d 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -64,7 +64,7 @@ MODULE_PARM_DESC(shared_mem, "enable amd-pstate on processors with shared memory solution (false =3D= disabled (default), true =3D enabled)"); =20 #if defined(CONFIG_X86_ACPI_CPUFREQ) || defined(CONFIG_X86_ACPI_CPUFREQ_MO= DULE) -static bool replace =3D false; +static bool replace =3D true; module_param(replace, bool, 0444); MODULE_PARM_DESC(replace, "replace acpi-cpufreq driver upon init if necessary"); --=20 2.34.1