From nobody Mon May 11 04:11:53 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2E61C433EF for ; Thu, 14 Apr 2022 15:49:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245501AbiDNPva (ORCPT ); Thu, 14 Apr 2022 11:51:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1358350AbiDNPlg (ORCPT ); Thu, 14 Apr 2022 11:41:36 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 107BDECC73 for ; Thu, 14 Apr 2022 08:23:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649949836; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IGRJLz7z/3jGasxkIFljjT/M7YCjB3xjYdcrHt5JsPY=; b=R6F46RRSoVmJ5TxbsSSECf0FPaYBKNSX1pSMHSwwfkqQ58M4RFcvU0fIGssO1qfcSOpKjD HqtfPS9KGBI13SP/wAzyH2Wffa8rjfSYYgyzSSPsLS4kNkNK+vOvUq4BQncX0RU+fVYbbD 8w+Na2hMm1eGJqgOOVCLdufUTWkpCmI= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-536-f-lfp3HlNhyHZPEo0TjWEg-1; Thu, 14 Apr 2022 11:23:55 -0400 X-MC-Unique: f-lfp3HlNhyHZPEo0TjWEg-1 Received: by mail-qv1-f69.google.com with SMTP id jz4-20020a0562140e6400b004461f104a7cso2693773qvb.6 for ; Thu, 14 Apr 2022 08:23:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IGRJLz7z/3jGasxkIFljjT/M7YCjB3xjYdcrHt5JsPY=; b=w+6ZlI6Zs6E4bfEZvfFN4Qcn8S9WGf8z6QRmxtrUQ9JzEUWDtCnXLCL1PUAJOZ+LFx ubsT/tOZFtbCT7sMIWNqZz2ZLnkUbaaaIXYSZ2gIlepS2UlKHIfj3C/9WGRYx8acCDyy 5YwRT02oJ98UMTUU4aj3sQwBXHj2f/kEerwtde3U1tahe2P+69uxNJfaLs2ahX1nKFz2 QaUFrQZ6JuCwheBOS0HFCK9sN8pu6A0sui00l9dXkafMzw5uRQlIktsYM9IX7OPcYWoT N4GmQbE89Q7R7oRKwcOIFpWLov45jaeKPLVbncgCOBXWxDPBB2nwIAbQ1HPmAuMwh713 K8Vw== X-Gm-Message-State: AOAM533hiAamZWIkT5mVElv2SXXUdhZ8IbbEqwldHtjGg7P1xGDW1Sf1 Mp930Eaqkg0UD1U2kfUMLUdREwYlpS5UBSVR4tP+8p4oXvYaQDOMMOEB9suEPiGVADY+zJkq1vx j7ZJR1+FaFq/I+yukhohVyavU X-Received: by 2002:ad4:5dc7:0:b0:443:6f15:fe32 with SMTP id m7-20020ad45dc7000000b004436f15fe32mr3852121qvh.6.1649949834657; Thu, 14 Apr 2022 08:23:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxDIMnHIaFBi6EAQ93deNI9TIf/lTnkCTwd5RkyfWbj4eTfNhDjJwcfrcjQzxV8pE0w7SpAiw== X-Received: by 2002:ad4:5dc7:0:b0:443:6f15:fe32 with SMTP id m7-20020ad45dc7000000b004436f15fe32mr3852106qvh.6.1649949834481; Thu, 14 Apr 2022 08:23:54 -0700 (PDT) Received: from fedora.redhat.com (modemcable200.11-22-96.mc.videotron.ca. [96.22.11.200]) by smtp.gmail.com with ESMTPSA id p5-20020a378d05000000b0069beaffd5b3sm1166038qkd.4.2022.04.14.08.23.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Apr 2022 08:23:54 -0700 (PDT) From: Adrien Thierry To: Greg Kroah-Hartman , Nicolas Saenz Julienne , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Maxime Ripard , Takashi Iwai Cc: linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Adrien Thierry Subject: [PATCH 1/2] staging: bcm2835-audio: fully describe config symbol Date: Thu, 14 Apr 2022 11:23:39 -0400 Message-Id: <20220414152340.68932-2-athierry@redhat.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220414152340.68932-1-athierry@redhat.com> References: <20220414152340.68932-1-athierry@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Explain SND_BCM2835 config option in more detail, especially the implications of using the bcm2835-audio driver in conjunction with vc4 for HDMI audio. Reported by checkpatch: WARNING: please write a help paragraph that fully describes the config symbol FILE: drivers/staging/vc04_services/bcm2835-audio/Kconfig:2 Signed-off-by: Adrien Thierry --- drivers/staging/vc04_services/bcm2835-audio/Kconfig | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/vc04_services/bcm2835-audio/Kconfig b/drivers/= staging/vc04_services/bcm2835-audio/Kconfig index d32ea348e846..7cd0b3c0cae4 100644 --- a/drivers/staging/vc04_services/bcm2835-audio/Kconfig +++ b/drivers/staging/vc04_services/bcm2835-audio/Kconfig @@ -5,5 +5,8 @@ config SND_BCM2835 select SND_PCM select BCM2835_VCHIQ help - Say Y or M if you want to support BCM2835 built in audio + Say Y or M if you want to support BCM2835 built in audio. + This driver handles both 3.5mm and HDMI audio. However, please + note that when HDMI audio is enabled with this driver, the vc4 + driver cannot be used simultaneously, otherwise HDMI will break. =20 --=20 2.35.1 From nobody Mon May 11 04:11:53 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CAF1C4332F for ; Thu, 14 Apr 2022 15:59:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232439AbiDNQBr (ORCPT ); Thu, 14 Apr 2022 12:01:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59182 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1358363AbiDNPlj (ORCPT ); Thu, 14 Apr 2022 11:41:39 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 6E9D9ECC7E for ; Thu, 14 Apr 2022 08:23:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649949838; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ymoHjSbTJfTWENDrZAMakMAu3NTQlX8fnQuTkXZ1c+0=; b=NjM4/oM453w+Y3ZL2zQHem4spfK/U+l1r/IXAii8ukpXAHjIgsjwt7B96Ij/U1ddA9WkDw YjMiEpHphTq1kHEwSdLXnoFf1eV6h9fICqLT1tBq97/Lcs9Gqy82FygLLTDhmLCLze0xPU DCVy2ZRxsOosIxqGpm8VDVf0MRSWgY0= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-77-NFF5WRSIMtWYdd1dkAKzXw-1; Thu, 14 Apr 2022 11:23:57 -0400 X-MC-Unique: NFF5WRSIMtWYdd1dkAKzXw-1 Received: by mail-qv1-f72.google.com with SMTP id o1-20020a0c9001000000b00440e415a3a2so4621963qvo.13 for ; Thu, 14 Apr 2022 08:23:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ymoHjSbTJfTWENDrZAMakMAu3NTQlX8fnQuTkXZ1c+0=; b=vg9gG2Vv+c2fyP3V6WwWAr/+3I9KgEnE34eksK0RRzuqS1QUU4Jhx7cLCLufgjBVUA sNoOxKgtF0xoltE9ZmXQAOEteq1oLCDV4UaK2LuRL3QjaPQHvJvuO316fzB3HIdzMcCx COIlSYF3lV9aq8BVScqXp6+q+PkZaE6WcMYz1D3Yt5SlvM2rlSNjeJEgwtEUY5RyMryB Uz115/m3h12BXfX7bZyenmhIjLd2H6lcKThptKYNtYEgOQIo7f6c6QPff8Jl2cJHItam k+mLwFrxDOpXZurCB7HkmFyLYbn1VTSQ8nvu7106rLBHuADz1BCWSGXh5quatI2ggdmB yznw== X-Gm-Message-State: AOAM5313jhigNVLrPfDoKV0fXCl861mJ69abTWTEJkwpIgOKdgYP0sqQ xCBqBw7gjPvpYu4QQK4VtH5rHh9oC27TJFupiTu7RfNVQ1h7MfaatEhsc1TTnbRiBO5u0V96ub8 F9FGprlyUHD000gd7oNYKVNtw X-Received: by 2002:a05:622a:1793:b0:2e1:ba41:ed2 with SMTP id s19-20020a05622a179300b002e1ba410ed2mr2180116qtk.238.1649949836596; Thu, 14 Apr 2022 08:23:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzs3AjMBWvnaeFFepMGw6xBfV7UrXSMsLV3Nf+VF6QIpa+RPOmd63l8E4yiuw2decacPo8cmQ== X-Received: by 2002:a05:622a:1793:b0:2e1:ba41:ed2 with SMTP id s19-20020a05622a179300b002e1ba410ed2mr2180095qtk.238.1649949836406; Thu, 14 Apr 2022 08:23:56 -0700 (PDT) Received: from fedora.redhat.com (modemcable200.11-22-96.mc.videotron.ca. [96.22.11.200]) by smtp.gmail.com with ESMTPSA id p5-20020a378d05000000b0069beaffd5b3sm1166038qkd.4.2022.04.14.08.23.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Apr 2022 08:23:56 -0700 (PDT) From: Adrien Thierry To: Greg Kroah-Hartman , Nicolas Saenz Julienne , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Maxime Ripard , Takashi Iwai Cc: linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Adrien Thierry Subject: [PATCH 2/2] staging: bcm2835-audio: clean code style warnings Date: Thu, 14 Apr 2022 11:23:40 -0400 Message-Id: <20220414152340.68932-3-athierry@redhat.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220414152340.68932-1-athierry@redhat.com> References: <20220414152340.68932-1-athierry@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Clean a few minor code style warnings. Reported by checkpatch: CHECK: Lines should not end with a '(' FILE: drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c:85: CHECK: No space is necessary after a cast FILE: drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c:240: CHECK: struct mutex definition without comment FILE: drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c:14: CHECK: struct mutex definition without comment FILE: drivers/staging/vc04_services/bcm2835-audio/bcm2835.h:64: Signed-off-by: Adrien Thierry --- drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c | 5 ++--- drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c | 2 +- drivers/staging/vc04_services/bcm2835-audio/bcm2835.h | 2 +- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c b/dr= ivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c index f2ef1d641e70..68e8d491a7ec 100644 --- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c +++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c @@ -82,8 +82,7 @@ void bcm2835_playback_fifo(struct bcm2835_alsa_stream *al= sa_stream, } =20 /* open callback */ -static int snd_bcm2835_playback_open_generic( - struct snd_pcm_substream *substream, int spdif) +static int snd_bcm2835_playback_open_generic(struct snd_pcm_substream *sub= stream, int spdif) { struct bcm2835_chip *chip =3D snd_pcm_substream_chip(substream); struct snd_pcm_runtime *runtime =3D substream->runtime; @@ -237,7 +236,7 @@ static void snd_bcm2835_pcm_transfer(struct snd_pcm_sub= stream *substream, { struct snd_pcm_runtime *runtime =3D substream->runtime; struct bcm2835_alsa_stream *alsa_stream =3D runtime->private_data; - void *src =3D (void *) (substream->runtime->dma_area + rec->sw_data); + void *src =3D (void *)(substream->runtime->dma_area + rec->sw_data); =20 bcm2835_audio_write(alsa_stream, bytes, src); } diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c b/= drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c index d567a2e3f70c..e429b33b4d39 100644 --- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c +++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c @@ -11,7 +11,7 @@ struct bcm2835_audio_instance { struct device *dev; unsigned int service_handle; struct completion msg_avail_comp; - struct mutex vchi_mutex; + struct mutex vchi_mutex; /* Serialize vchiq access */ struct bcm2835_alsa_stream *alsa_stream; int result; unsigned int max_packet; diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835.h b/driver= s/staging/vc04_services/bcm2835-audio/bcm2835.h index 51066ac8eea5..38b7451d77b2 100644 --- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835.h +++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835.h @@ -61,7 +61,7 @@ struct bcm2835_chip { =20 unsigned int opened; unsigned int spdif_status; - struct mutex audio_mutex; + struct mutex audio_mutex; /* Serialize chip data access */ =20 struct bcm2835_vchi_ctx *vchi_ctx; }; --=20 2.35.1