From nobody Mon May 11 04:53:34 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AF37C433EF for ; Thu, 14 Apr 2022 09:28:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241773AbiDNJbL (ORCPT ); Thu, 14 Apr 2022 05:31:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241263AbiDNJbA (ORCPT ); Thu, 14 Apr 2022 05:31:00 -0400 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC9476D1B9 for ; Thu, 14 Apr 2022 02:28:35 -0700 (PDT) Received: by mail-wr1-x433.google.com with SMTP id k22so6089895wrd.2 for ; Thu, 14 Apr 2022 02:28:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Av8EzP8d6KVoQi/yXwkBOAZabP9Xc8kXclRu9dT4+Lw=; b=XW/DvwVmRs0u+HPVCBNJh0m4E34d8hn5teI5p4MFlw1AwT0QGpyDrvDYKeFL04RmRK jvJG4o7qAJeCTCf9MHamgs4HLvZ9Sp1qgwjYT6HwHxwOr7ayhQgJeTOVefciIbCRRfcN kAIWOaIp3+4P5k1D8vWT9Ug6Fw28yDxDjq/go= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Av8EzP8d6KVoQi/yXwkBOAZabP9Xc8kXclRu9dT4+Lw=; b=bhOdWFh4F8WcP2/XZLfAmnsANb8Q95ench58YM1lr6a4etd8YSZg7N78p07CKfzYei EbisCgVmdKQh3XiE8pr3x0Hoz+SUUQ6jgoR6JK91Gpu1xRj5g7DTj88v3+TjJniHqUIU rKaLyNcvz6gG/gjXPfJjV6h+dl/uO+Fu6PFjmMOnsllSnePzmmQ2c085kEEkyLlS2Lmy CSXH4W7nF5jK0eo4+U2hcLXs1lIvHCMlZqm9ESfeZdrcUAJ1Hfsa8gpoXJ7CB5HKhyxr PHmINomDCS7HhOk35NmWbnBtOvCIizXsQoftl+6vDnpa1iWoDl/JGMCD2mfM5M7u3xl4 9sig== X-Gm-Message-State: AOAM532CNUW4tKO2oHkYh4AS7lf0HPebvVdNNudg/rSKJUNJ0XYTt/eG PZ3nsKx/kW7kpqdKfkZnmfXtKw== X-Google-Smtp-Source: ABdhPJwICPNoTiCyXovM+uFrLY1cRUMc9NSi0tZTBQi5obLIMnAkksH5rZ/OUVje2hYRLnI13kqUcw== X-Received: by 2002:adf:d1c7:0:b0:205:dc0e:383a with SMTP id b7-20020adfd1c7000000b00205dc0e383amr1370718wrd.335.1649928514435; Thu, 14 Apr 2022 02:28:34 -0700 (PDT) Received: from fabiobaltieri-linux.lan ([37.228.205.1]) by smtp.gmail.com with ESMTPSA id bg8-20020a05600c3c8800b0038e4c5967besm1698099wmb.3.2022.04.14.02.28.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Apr 2022 02:28:34 -0700 (PDT) From: Fabio Baltieri To: Benson Leung , Guenter Roeck Cc: Thierry Reding , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Lee Jones , Rob Herring , chrome-platform@lists.linux.dev, linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Fabio Baltieri Subject: [PATCH v4 1/4] dt-bindings: add mfd/cros_ec definitions Date: Thu, 14 Apr 2022 09:28:28 +0000 Message-Id: <20220414092831.3717684-2-fabiobaltieri@chromium.org> X-Mailer: git-send-email 2.36.0.rc0.470.gd361397f0d-goog In-Reply-To: <20220414092831.3717684-1-fabiobaltieri@chromium.org> References: <20220414092831.3717684-1-fabiobaltieri@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add a dt-bindings include file for cros_ec devicetree definition, define a pair of special purpose PWM channels in it. Signed-off-by: Fabio Baltieri Acked-by: Rob Herring --- include/dt-bindings/mfd/cros_ec.h | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) create mode 100644 include/dt-bindings/mfd/cros_ec.h diff --git a/include/dt-bindings/mfd/cros_ec.h b/include/dt-bindings/mfd/cr= os_ec.h new file mode 100644 index 000000000000..3b29cd049578 --- /dev/null +++ b/include/dt-bindings/mfd/cros_ec.h @@ -0,0 +1,18 @@ +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ +/* + * DTS binding definitions used for the Chromium OS Embedded Controller. + * + * Copyright (c) 2022 The Chromium OS Authors. All rights reserved. + */ + +#ifndef _DT_BINDINGS_MFD_CROS_EC_H +#define _DT_BINDINGS_MFD_CROS_EC_H + +/* Typed channel for keyboard backlight. */ +#define CROS_EC_PWM_DT_KB_LIGHT 0 +/* Typed channel for display backlight. */ +#define CROS_EC_PWM_DT_DISPLAY_LIGHT 1 +/* Number of typed channels. */ +#define CROS_EC_PWM_DT_COUNT 2 + +#endif --=20 2.35.1.1178.g4f1659d476-goog From nobody Mon May 11 04:53:34 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F08DAC433F5 for ; Thu, 14 Apr 2022 09:29:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241775AbiDNJbX (ORCPT ); Thu, 14 Apr 2022 05:31:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56526 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241750AbiDNJbB (ORCPT ); Thu, 14 Apr 2022 05:31:01 -0400 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B67C96EC61 for ; Thu, 14 Apr 2022 02:28:36 -0700 (PDT) Received: by mail-wr1-x430.google.com with SMTP id i20so6039830wrb.13 for ; Thu, 14 Apr 2022 02:28:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EI3aTLR3kZ/7o/ypPML1uz1j1gkp6fUYT50vDoeqrt8=; b=MCUjT0/lXL5lIjMWgZu0d8wayePTcccWJTZoE7NfAJuSSfDH8EBY7hH0Sf2jXnCfTF oxnWjsCwp43x0K3TOs4kCnYnJsrzymPc0UAN+WwI2brDlmDylUkxVv0YYH94MNr3ljgP lSJQvppPewdLqC3GbQ0t8HbsfOyEZb+YQwjiQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EI3aTLR3kZ/7o/ypPML1uz1j1gkp6fUYT50vDoeqrt8=; b=nf/MaTB3/FYKBv/26XCTioesTaA35h7T77RTxyiuxHYnyPEbsJCZRPLXcdiKM6LN4Q 164I5N+5hpVkKn1VNJ36A24I+vTC8mnnl7Qx17n0ZKF19DNNyg+2qqzWA4HYt0szC3FV r6bOT16OusgAfrfYJLRDq18jPU8yLPSaL9SjMBU0WG/XDJFUDqRQ5pDOE+39eHrQgbDG EpgRfmsRTlRUsfoqLaclu+N61uOFbcqnRQVMh5G4Sih/IZXBgo2Kk489Dt18x0SCddU+ oAGiFcO9hcwyaM4t69+pc6NEWLa8l1/0h7PE3+sAwN1vdW/FLkgQR6JjnsRyFK4r4lZ6 yzow== X-Gm-Message-State: AOAM530Rww4IHV7TZ15LpK8Zc+EVk6dOr8IEvKc1DtMAeHugefVAv78K j1/e1xPEuArNOSuxjsgys76Hug== X-Google-Smtp-Source: ABdhPJxKT8AeK9HaPvUrB7RHjH335zMFPNbVP4pvTRWtdYfo2RjwG+KhFSRBarDuueoZrX8Cy0OvYw== X-Received: by 2002:a05:6000:2ac:b0:20a:7732:4bb6 with SMTP id l12-20020a05600002ac00b0020a77324bb6mr198482wry.538.1649928515280; Thu, 14 Apr 2022 02:28:35 -0700 (PDT) Received: from fabiobaltieri-linux.lan ([37.228.205.1]) by smtp.gmail.com with ESMTPSA id bg8-20020a05600c3c8800b0038e4c5967besm1698099wmb.3.2022.04.14.02.28.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Apr 2022 02:28:34 -0700 (PDT) From: Fabio Baltieri To: Benson Leung , Guenter Roeck Cc: Thierry Reding , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Lee Jones , Rob Herring , chrome-platform@lists.linux.dev, linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Fabio Baltieri Subject: [PATCH v4 2/4] pwm: pwm-cros-ec: add channel type support Date: Thu, 14 Apr 2022 09:28:29 +0000 Message-Id: <20220414092831.3717684-3-fabiobaltieri@chromium.org> X-Mailer: git-send-email 2.36.0.rc0.470.gd361397f0d-goog In-Reply-To: <20220414092831.3717684-1-fabiobaltieri@chromium.org> References: <20220414092831.3717684-1-fabiobaltieri@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add support for EC_PWM_TYPE_DISPLAY_LIGHT and EC_PWM_TYPE_KB_LIGHT pwm types to the PWM cros_ec_pwm driver. This allows specifying one of these PWM channel by functionality, and let the EC firmware pick the correct channel, thus abstracting the hardware implementation from the kernel driver. To use it, define the node with the "google,cros-ec-pwm-type" compatible. Signed-off-by: Fabio Baltieri Reviewed-by: Tzung-Bi Shih --- drivers/pwm/pwm-cros-ec.c | 82 ++++++++++++++++++++++++++++++++------- 1 file changed, 67 insertions(+), 15 deletions(-) diff --git a/drivers/pwm/pwm-cros-ec.c b/drivers/pwm/pwm-cros-ec.c index 5e29d9c682c3..7f10f56c3eb6 100644 --- a/drivers/pwm/pwm-cros-ec.c +++ b/drivers/pwm/pwm-cros-ec.c @@ -12,17 +12,21 @@ #include #include =20 +#include + /** * struct cros_ec_pwm_device - Driver data for EC PWM * * @dev: Device node * @ec: Pointer to EC device * @chip: PWM controller chip + * @use_pwm_type: Use PWM types instead of generic channels */ struct cros_ec_pwm_device { struct device *dev; struct cros_ec_device *ec; struct pwm_chip chip; + bool use_pwm_type; }; =20 /** @@ -58,14 +62,31 @@ static void cros_ec_pwm_free(struct pwm_chip *chip, str= uct pwm_device *pwm) kfree(channel); } =20 -static int cros_ec_pwm_set_duty(struct cros_ec_device *ec, u8 index, u16 d= uty) +static int cros_ec_dt_type_to_pwm_type(u8 dt_index, u8 *pwm_type) { + switch (dt_index) { + case CROS_EC_PWM_DT_KB_LIGHT: + *pwm_type =3D EC_PWM_TYPE_KB_LIGHT; + return 0; + case CROS_EC_PWM_DT_DISPLAY_LIGHT: + *pwm_type =3D EC_PWM_TYPE_DISPLAY_LIGHT; + return 0; + default: + return -EINVAL; + } +} + +static int cros_ec_pwm_set_duty(struct cros_ec_pwm_device *ec_pwm, u8 inde= x, + u16 duty) +{ + struct cros_ec_device *ec =3D ec_pwm->ec; struct { struct cros_ec_command msg; struct ec_params_pwm_set_duty params; } __packed buf; struct ec_params_pwm_set_duty *params =3D &buf.params; struct cros_ec_command *msg =3D &buf.msg; + int ret; =20 memset(&buf, 0, sizeof(buf)); =20 @@ -75,14 +96,25 @@ static int cros_ec_pwm_set_duty(struct cros_ec_device *= ec, u8 index, u16 duty) msg->outsize =3D sizeof(*params); =20 params->duty =3D duty; - params->pwm_type =3D EC_PWM_TYPE_GENERIC; - params->index =3D index; + + if (ec_pwm->use_pwm_type) { + ret =3D cros_ec_dt_type_to_pwm_type(index, ¶ms->pwm_type); + if (ret) { + dev_err(ec->dev, "Invalid PWM type index: %d\n", index); + return ret; + } + params->index =3D 0; + } else { + params->pwm_type =3D EC_PWM_TYPE_GENERIC; + params->index =3D index; + } =20 return cros_ec_cmd_xfer_status(ec, msg); } =20 -static int cros_ec_pwm_get_duty(struct cros_ec_device *ec, u8 index) +static int cros_ec_pwm_get_duty(struct cros_ec_pwm_device *ec_pwm, u8 inde= x) { + struct cros_ec_device *ec =3D ec_pwm->ec; struct { struct cros_ec_command msg; union { @@ -102,8 +134,17 @@ static int cros_ec_pwm_get_duty(struct cros_ec_device = *ec, u8 index) msg->insize =3D sizeof(*resp); msg->outsize =3D sizeof(*params); =20 - params->pwm_type =3D EC_PWM_TYPE_GENERIC; - params->index =3D index; + if (ec_pwm->use_pwm_type) { + ret =3D cros_ec_dt_type_to_pwm_type(index, ¶ms->pwm_type); + if (ret) { + dev_err(ec->dev, "Invalid PWM type index: %d\n", index); + return ret; + } + params->index =3D 0; + } else { + params->pwm_type =3D EC_PWM_TYPE_GENERIC; + params->index =3D index; + } =20 ret =3D cros_ec_cmd_xfer_status(ec, msg); if (ret < 0) @@ -133,7 +174,7 @@ static int cros_ec_pwm_apply(struct pwm_chip *chip, str= uct pwm_device *pwm, */ duty_cycle =3D state->enabled ? state->duty_cycle : 0; =20 - ret =3D cros_ec_pwm_set_duty(ec_pwm->ec, pwm->hwpwm, duty_cycle); + ret =3D cros_ec_pwm_set_duty(ec_pwm, pwm->hwpwm, duty_cycle); if (ret < 0) return ret; =20 @@ -149,7 +190,7 @@ static void cros_ec_pwm_get_state(struct pwm_chip *chip= , struct pwm_device *pwm, struct cros_ec_pwm *channel =3D pwm_get_chip_data(pwm); int ret; =20 - ret =3D cros_ec_pwm_get_duty(ec_pwm->ec, pwm->hwpwm); + ret =3D cros_ec_pwm_get_duty(ec_pwm, pwm->hwpwm); if (ret < 0) { dev_err(chip->dev, "error getting initial duty: %d\n", ret); return; @@ -204,13 +245,13 @@ static const struct pwm_ops cros_ec_pwm_ops =3D { * of PWMs it supports directly, so we have to read the pwm duty cycle for * subsequent channels until we get an error. */ -static int cros_ec_num_pwms(struct cros_ec_device *ec) +static int cros_ec_num_pwms(struct cros_ec_pwm_device *ec_pwm) { int i, ret; =20 /* The index field is only 8 bits */ for (i =3D 0; i <=3D U8_MAX; i++) { - ret =3D cros_ec_pwm_get_duty(ec, i); + ret =3D cros_ec_pwm_get_duty(ec_pwm, i); /* * We look for SUCCESS, INVALID_COMMAND, or INVALID_PARAM * responses; everything else is treated as an error. @@ -236,6 +277,7 @@ static int cros_ec_pwm_probe(struct platform_device *pd= ev) { struct cros_ec_device *ec =3D dev_get_drvdata(pdev->dev.parent); struct device *dev =3D &pdev->dev; + struct device_node *np =3D pdev->dev.of_node; struct cros_ec_pwm_device *ec_pwm; struct pwm_chip *chip; int ret; @@ -251,17 +293,26 @@ static int cros_ec_pwm_probe(struct platform_device *= pdev) chip =3D &ec_pwm->chip; ec_pwm->ec =3D ec; =20 + if (of_device_is_compatible(np, "google,cros-ec-pwm-type")) + ec_pwm->use_pwm_type =3D true; + /* PWM chip */ chip->dev =3D dev; chip->ops =3D &cros_ec_pwm_ops; chip->of_xlate =3D cros_ec_pwm_xlate; chip->of_pwm_n_cells =3D 1; - ret =3D cros_ec_num_pwms(ec); - if (ret < 0) { - dev_err(dev, "Couldn't find PWMs: %d\n", ret); - return ret; + + if (ec_pwm->use_pwm_type) { + chip->npwm =3D CROS_EC_PWM_DT_COUNT; + } else { + ret =3D cros_ec_num_pwms(ec_pwm); + if (ret < 0) { + dev_err(dev, "Couldn't find PWMs: %d\n", ret); + return ret; + } + chip->npwm =3D ret; } - chip->npwm =3D ret; + dev_dbg(dev, "Probed %u PWMs\n", chip->npwm); =20 ret =3D pwmchip_add(chip); @@ -288,6 +339,7 @@ static int cros_ec_pwm_remove(struct platform_device *d= ev) #ifdef CONFIG_OF static const struct of_device_id cros_ec_pwm_of_match[] =3D { { .compatible =3D "google,cros-ec-pwm" }, + { .compatible =3D "google,cros-ec-pwm-type" }, {}, }; MODULE_DEVICE_TABLE(of, cros_ec_pwm_of_match); --=20 2.35.1.1178.g4f1659d476-goog From nobody Mon May 11 04:53:34 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C370BC433F5 for ; Thu, 14 Apr 2022 09:28:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241794AbiDNJbS (ORCPT ); Thu, 14 Apr 2022 05:31:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241752AbiDNJbB (ORCPT ); Thu, 14 Apr 2022 05:31:01 -0400 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 76F456F488 for ; Thu, 14 Apr 2022 02:28:37 -0700 (PDT) Received: by mail-wr1-x42b.google.com with SMTP id g18so6053927wrb.10 for ; Thu, 14 Apr 2022 02:28:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nO+ziw2+OwYKXZ9RD5bVom+jjKT6xZaKn0PGeE1P/J8=; b=QteKmChnkWb6oz4KhPGH8vunhcx6Vua8eilRI3R5J+5q+5LzJcdL1d3CiIenp+CYcc LFzSNQD6OaXrAJZ6kiN+C3eJwN1SfTOiFuEfkwMxrFvH5lbnSZmYkQ17wf7UCv5uFIUV pRaQMDW/nq0Z+IbluT23aHqsZCjGjoVOgmcDM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nO+ziw2+OwYKXZ9RD5bVom+jjKT6xZaKn0PGeE1P/J8=; b=D8aUMISfJc0qELPOJ4ltuoNS8qlJIM4IHba+AduuJbDQZD2ZZZHH/f+qGFylCqmvsJ 5yMNeX0uudvFv98+zMHHXlqvfpVbJL1oVsdR8YbIcsMYHWL8ksNAKl8mfpHyXyMevHQN foWNAiWXWrX2YqryZCBh4R+C19JOlXWc4yUbLVMcnhDLJ7YsEi6lIUuZjFHHXn1KyQxQ fRG0qBK9H8iRdX/EfBPMPlD0S44IqaAqcHtZ5X0VYuXbEgzTN9ONf9qbhYdlGiAJFmww W2EjeJDY7BB4WnVsmLVJt24AVmVqi9CHpdd/tkdfN3KfAmEbiM2qiXhZL+GV9HbfuXjN 44bg== X-Gm-Message-State: AOAM530DJVMWhAKvdA+cpi8PgYa+VBWC8R1a+9m3+B4F316RMScRjnF9 lMIZl98Zps98rz3/XNXOv0RDVg== X-Google-Smtp-Source: ABdhPJzaZFOkCNktJtaToekzPivMcuvQGu/MUEAC5mRmWLOWlbpLQSlFQg9jMeOJjlO0Xq/PSZoQQg== X-Received: by 2002:a05:6000:1883:b0:205:c0cb:33c6 with SMTP id a3-20020a056000188300b00205c0cb33c6mr1431223wri.39.1649928516125; Thu, 14 Apr 2022 02:28:36 -0700 (PDT) Received: from fabiobaltieri-linux.lan ([37.228.205.1]) by smtp.gmail.com with ESMTPSA id bg8-20020a05600c3c8800b0038e4c5967besm1698099wmb.3.2022.04.14.02.28.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Apr 2022 02:28:35 -0700 (PDT) From: Fabio Baltieri To: Benson Leung , Guenter Roeck Cc: Thierry Reding , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Lee Jones , Rob Herring , chrome-platform@lists.linux.dev, linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Fabio Baltieri Subject: [PATCH v4 3/4] dt-bindings: update google,cros-ec-pwm documentation Date: Thu, 14 Apr 2022 09:28:30 +0000 Message-Id: <20220414092831.3717684-4-fabiobaltieri@chromium.org> X-Mailer: git-send-email 2.36.0.rc0.470.gd361397f0d-goog In-Reply-To: <20220414092831.3717684-1-fabiobaltieri@chromium.org> References: <20220414092831.3717684-1-fabiobaltieri@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Update google,cros-ec-pwm node documentation to mention the google,cros-ec-pwm-type compatible. Signed-off-by: Fabio Baltieri --- .../devicetree/bindings/pwm/google,cros-ec-pwm.yaml | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/pwm/google,cros-ec-pwm.yaml = b/Documentation/devicetree/bindings/pwm/google,cros-ec-pwm.yaml index 7ab6912a845f..deb9e4488773 100644 --- a/Documentation/devicetree/bindings/pwm/google,cros-ec-pwm.yaml +++ b/Documentation/devicetree/bindings/pwm/google,cros-ec-pwm.yaml @@ -21,7 +21,14 @@ allOf: =20 properties: compatible: - const: google,cros-ec-pwm + oneOf: + - description: PWM controlled using EC_PWM_TYPE_GENERIC channels. + items: + - const: google,cros-ec-pwm + - description: PWM controlled using CROS_EC_PWM_DT_<...> types. + items: + - const: google,cros-ec-pwm-type + "#pwm-cells": description: The cell specifies the PWM index. const: 1 --=20 2.35.1.1178.g4f1659d476-goog From nobody Mon May 11 04:53:34 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8848C433EF for ; Thu, 14 Apr 2022 09:29:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241785AbiDNJb0 (ORCPT ); Thu, 14 Apr 2022 05:31:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241762AbiDNJbE (ORCPT ); Thu, 14 Apr 2022 05:31:04 -0400 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C4486F4B9 for ; Thu, 14 Apr 2022 02:28:38 -0700 (PDT) Received: by mail-wr1-x436.google.com with SMTP id m14so6080567wrb.6 for ; Thu, 14 Apr 2022 02:28:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=UBu9bKNpcsjBxVmcDi5TeRQJe5h4mzqRMvKt6Hs6yfk=; b=Vewj5Dz7RSg+PeiaWemyvRfbGJIw6goI02YIUIlexhdopKGfuz5QFxWlU/cRgzOEMQ xe4qzReYV1rdCqIdlEwfz8aURRc2+/ASmpJOzJV5zpHGv3JwVlzxiTjxTrcd9QzSqdv8 Zrr/R2ylnxbeTnZ3QFqDHi8umJN4S7DQCp8Io= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=UBu9bKNpcsjBxVmcDi5TeRQJe5h4mzqRMvKt6Hs6yfk=; b=ZdanKig/byIfjevp0pAzjB20pE6yjOt1vkdwIEKOMVPM5RRp1oO1ZhftKtYq4aFNVB eLsbBI5SiUbbwEzCWSg+oArXJeG6OJ7B/Jtxmf1z+zH26pIbSP7XpiPoQAqgc+8wNPHF jqIgrUrzFz0RoIk/ZqGndtWCWSm3E959JwQVrp+iuwUmaYaLCB1wYtO+AkcCJB4P4bwQ Ygox3Yl57IWSsefJvax4zu2Y/VgWTfCKfaRL9NUZyEDZhfxQl0IcCq84NgeYT8/VWPnn EKV2S8FHWw/9MhScOXT+ZjEA8iTHAyEB5HSjiDyuEZs5GGvt78O2WZWPNlRv4p8GwuhE tUSA== X-Gm-Message-State: AOAM531EEFtn0+7DLoHbyPyIBjYNqM7V88k/uYUXPA4irbCy8pUo7Vh4 kb9d+0SUxjilHO4mPlFg0MPHSA== X-Google-Smtp-Source: ABdhPJzkPWbyQ3uEjfLiHNYske8Ws1jqaNiWmEv6M26tsYDiZ4KBw96HdYn2xvcVVHlNlUsXbquqjA== X-Received: by 2002:a05:6000:1445:b0:204:1ca1:67b0 with SMTP id v5-20020a056000144500b002041ca167b0mr1376719wrx.507.1649928516912; Thu, 14 Apr 2022 02:28:36 -0700 (PDT) Received: from fabiobaltieri-linux.lan ([37.228.205.1]) by smtp.gmail.com with ESMTPSA id bg8-20020a05600c3c8800b0038e4c5967besm1698099wmb.3.2022.04.14.02.28.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Apr 2022 02:28:36 -0700 (PDT) From: Fabio Baltieri To: Benson Leung , Guenter Roeck Cc: Thierry Reding , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Lee Jones , Rob Herring , chrome-platform@lists.linux.dev, linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Fabio Baltieri Subject: [PATCH v4 4/4] arm64: dts: address cros-ec-pwm channels by type Date: Thu, 14 Apr 2022 09:28:31 +0000 Message-Id: <20220414092831.3717684-5-fabiobaltieri@chromium.org> X-Mailer: git-send-email 2.36.0.rc0.470.gd361397f0d-goog In-Reply-To: <20220414092831.3717684-1-fabiobaltieri@chromium.org> References: <20220414092831.3717684-1-fabiobaltieri@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Update various cros-ec-pwm board definitions to address the keyboard and screen backlight PWM channels by type rather than channel number. This makes the instance independent by the actual hardware configuration, relying on the EC firmware to pick the right channel, and allows dropping few dtsi overrides as a consequence. Changed the node label used to cros_ec_pwm_type to avoid ambiguity about the pwm cell meaning. Signed-off-by: Fabio Baltieri --- .../dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dts | 4 ++-- arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi | 4 ++-- arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 1 + arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi | 4 ---- arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 9 +++++---- .../boot/dts/qcom/sc7280-herobrine-herobrine-r0.dts | 7 ++++--- arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 7 ++++--- arch/arm64/boot/dts/qcom/sc7280-idp-ec-h1.dtsi | 4 ++-- arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 7 ++++--- arch/arm64/boot/dts/rockchip/rk3399-gru-bob.dts | 4 ---- arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi | 5 +++-- arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts | 4 ---- arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi | 1 + 13 files changed, 28 insertions(+), 33 deletions(-) diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.= dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dts index dec11a4eb59e..e2554a313deb 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dts +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dts @@ -15,13 +15,13 @@ pwmleds { compatible =3D "pwm-leds"; keyboard_backlight: keyboard-backlight { label =3D "cros_ec::kbd_backlight"; - pwms =3D <&cros_ec_pwm 0>; + pwms =3D <&cros_ec_pwm_type CROS_EC_PWM_DT_KB_LIGHT>; max-brightness =3D <1023>; }; }; }; =20 -&cros_ec_pwm { +&cros_ec_pwm_type { status =3D "okay"; }; =20 diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi b/arch/= arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi index 8f7bf33f607d..8474bd3af6eb 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi @@ -92,8 +92,8 @@ volume_up { }; =20 &cros_ec { - cros_ec_pwm: ec-pwm { - compatible =3D "google,cros-ec-pwm"; + cros_ec_pwm_type: ec-pwm { + compatible =3D "google,cros-ec-pwm-type"; #pwm-cells =3D <1>; status =3D "disabled"; }; diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/bo= ot/dts/mediatek/mt8183-kukui.dtsi index 0f9480f91261..ff54687ab8bf 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi @@ -7,6 +7,7 @@ =20 #include #include +#include #include "mt8183.dtsi" #include "mt6358.dtsi" =20 diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi b/arch/arm= 64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi index c81805ef2250..aea7c66d95e0 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi @@ -77,10 +77,6 @@ &ap_spi_fp { status =3D "okay"; }; =20 -&backlight { - pwms =3D <&cros_ec_pwm 0>; -}; - &camcc { status =3D "okay"; }; diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot= /dts/qcom/sc7180-trogdor.dtsi index 732e1181af48..6552e0025f84 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi @@ -8,6 +8,7 @@ #include #include #include +#include #include #include =20 @@ -316,7 +317,7 @@ backlight: backlight { num-interpolated-steps =3D <64>; default-brightness-level =3D <951>; =20 - pwms =3D <&cros_ec_pwm 1>; + pwms =3D <&cros_ec_pwm_type CROS_EC_PWM_DT_DISPLAY_LIGHT>; enable-gpios =3D <&tlmm 12 GPIO_ACTIVE_HIGH>; power-supply =3D <&ppvar_sys>; pinctrl-names =3D "default"; @@ -354,7 +355,7 @@ pwmleds { keyboard_backlight: keyboard-backlight { status =3D "disabled"; label =3D "cros_ec::kbd_backlight"; - pwms =3D <&cros_ec_pwm 0>; + pwms =3D <&cros_ec_pwm_type CROS_EC_PWM_DT_KB_LIGHT>; max-brightness =3D <1023>; }; }; @@ -637,8 +638,8 @@ cros_ec: ec@0 { pinctrl-0 =3D <&ap_ec_int_l>; spi-max-frequency =3D <3000000>; =20 - cros_ec_pwm: pwm { - compatible =3D "google,cros-ec-pwm"; + cros_ec_pwm_type: pwm { + compatible =3D "google,cros-ec-pwm-type"; #pwm-cells =3D <1>; }; =20 diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r0.dts b/a= rch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r0.dts index 1779d96c30f6..628ef990433b 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r0.dts +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r0.dts @@ -11,6 +11,7 @@ #include #include #include +#include #include #include =20 @@ -336,7 +337,7 @@ pwmleds { keyboard_backlight: keyboard-backlight { status =3D "disabled"; label =3D "cros_ec::kbd_backlight"; - pwms =3D <&cros_ec_pwm 0>; + pwms =3D <&cros_ec_pwm_type CROS_EC_PWM_DT_KB_LIGHT>; max-brightness =3D <1023>; }; }; @@ -705,8 +706,8 @@ cros_ec: ec@0 { pinctrl-0 =3D <&ap_ec_int_l>; spi-max-frequency =3D <3000000>; =20 - cros_ec_pwm: pwm { - compatible =3D "google,cros-ec-pwm"; + cros_ec_pwm_type: pwm { + compatible =3D "google,cros-ec-pwm-type"; #pwm-cells =3D <1>; }; =20 diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/bo= ot/dts/qcom/sc7280-herobrine.dtsi index dc17f2079695..eb4b0e17adec 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi @@ -15,6 +15,7 @@ =20 #include #include +#include =20 #include "sc7280-qcard.dtsi" #include "sc7280-chrome-common.dtsi" @@ -288,7 +289,7 @@ pwmleds { keyboard_backlight: keyboard-backlight { status =3D "disabled"; label =3D "cros_ec::kbd_backlight"; - pwms =3D <&cros_ec_pwm 0>; + pwms =3D <&cros_ec_pwm_type CROS_EC_PWM_DT_KB_LIGHT>; max-brightness =3D <1023>; }; }; @@ -421,8 +422,8 @@ cros_ec: ec@0 { pinctrl-0 =3D <&ap_ec_int_l>; spi-max-frequency =3D <3000000>; =20 - cros_ec_pwm: pwm { - compatible =3D "google,cros-ec-pwm"; + cros_ec_pwm_type: pwm { + compatible =3D "google,cros-ec-pwm-type"; #pwm-cells =3D <1>; }; =20 diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp-ec-h1.dtsi b/arch/arm64/bo= ot/dts/qcom/sc7280-idp-ec-h1.dtsi index a7c346aa3b02..a797f09e1328 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-idp-ec-h1.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280-idp-ec-h1.dtsi @@ -20,8 +20,8 @@ cros_ec: ec@0 { pinctrl-0 =3D <&ap_ec_int_l>; spi-max-frequency =3D <3000000>; =20 - cros_ec_pwm: pwm { - compatible =3D "google,cros-ec-pwm"; + cros_ec_pwm_type: pwm { + compatible =3D "google,cros-ec-pwm-type"; #pwm-cells =3D <1>; }; =20 diff --git a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi b/arch/arm64/boot/d= ts/qcom/sdm845-cheza.dtsi index e7e4cc5936aa..a57951a50cd6 100644 --- a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi @@ -6,6 +6,7 @@ */ =20 #include +#include #include #include "sdm845.dtsi" =20 @@ -27,7 +28,7 @@ chosen { =20 backlight: backlight { compatible =3D "pwm-backlight"; - pwms =3D <&cros_ec_pwm 0>; + pwms =3D <&cros_ec_pwm_type CROS_EC_PWM_DT_DISPLAY_LIGHT>; enable-gpios =3D <&tlmm 37 GPIO_ACTIVE_HIGH>; power-supply =3D <&ppvar_sys>; pinctrl-names =3D "default"; @@ -708,8 +709,8 @@ cros_ec: ec@0 { pinctrl-0 =3D <&ec_ap_int_l>; spi-max-frequency =3D <3000000>; =20 - cros_ec_pwm: pwm { - compatible =3D "google,cros-ec-pwm"; + cros_ec_pwm_type: pwm { + compatible =3D "google,cros-ec-pwm-type"; #pwm-cells =3D <1>; }; =20 diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru-bob.dts b/arch/arm64/b= oot/dts/rockchip/rk3399-gru-bob.dts index 31ebb4e5fd33..5a076c2564f6 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-gru-bob.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-gru-bob.dts @@ -55,10 +55,6 @@ trackpad: trackpad@15 { }; }; =20 -&backlight { - pwms =3D <&cros_ec_pwm 0>; -}; - &cpu_alert0 { temperature =3D <65000>; }; diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi b/arch= /arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi index 3355fb90fa54..28eda361dfe1 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi @@ -198,6 +198,7 @@ backlight: backlight { power-supply =3D <&pp3300_disp>; pinctrl-names =3D "default"; pinctrl-0 =3D <&bl_en>; + pwms =3D <&cros_ec_pwm_type CROS_EC_PWM_DT_DISPLAY_LIGHT>; pwm-delay-us =3D <10000>; }; =20 @@ -462,8 +463,8 @@ ap_i2c_tp: &i2c5 { }; =20 &cros_ec { - cros_ec_pwm: pwm { - compatible =3D "google,cros-ec-pwm"; + cros_ec_pwm_type: pwm { + compatible =3D "google,cros-ec-pwm-type"; #pwm-cells =3D <1>; }; =20 diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts b/arch/arm64= /boot/dts/rockchip/rk3399-gru-kevin.dts index 6863689df06f..e959a33af34b 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts @@ -84,10 +84,6 @@ thermistor_ppvar_litcpu: thermistor-ppvar-litcpu { }; }; =20 -&backlight { - pwms =3D <&cros_ec_pwm 1>; -}; - &gpio_keys { pinctrl-names =3D "default"; pinctrl-0 =3D <&bt_host_wake_l>, <&cpu1_pen_eject>; diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi b/arch/arm64/boot= /dts/rockchip/rk3399-gru.dtsi index 162f08bca0d4..181159e9982d 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi @@ -6,6 +6,7 @@ */ =20 #include +#include #include "rk3399.dtsi" #include "rk3399-op1-opp.dtsi" =20 --=20 2.35.1.1178.g4f1659d476-goog