From nobody Sun Sep 22 04:29:15 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9907C433F5 for ; Thu, 14 Apr 2022 08:11:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238475AbiDNIOJ (ORCPT ); Thu, 14 Apr 2022 04:14:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53370 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233097AbiDNIOI (ORCPT ); Thu, 14 Apr 2022 04:14:08 -0400 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09AB146658 for ; Thu, 14 Apr 2022 01:11:40 -0700 (PDT) X-UUID: cc846f08a8b14c8188298998acd3a84c-20220414 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.4,REQID:4c515ac7-047f-47eb-a159-2ab1329cdf3b,OB:0,LO B:0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:54,FILE:0,RULE:Release_Ham,ACT ION:release,TS:54 X-CID-INFO: VERSION:1.1.4,REQID:4c515ac7-047f-47eb-a159-2ab1329cdf3b,OB:0,LOB: 0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:54,FILE:0,RULE:Release_UHam,ACTI ON:release,TS:54 X-CID-META: VersionHash:faefae9,CLOUDID:197720a9-d103-4e36-82b9-b0e86991b3df,C OID:10fbb2c55067,Recheck:0,SF:13|15|28|100|16|19|48|101,TC:nil,Content:0,E DM:-3,File:nil,QS:0,BEC:nil X-UUID: cc846f08a8b14c8188298998acd3a84c-20220414 Received: from mtkcas11.mediatek.inc [(172.21.101.40)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 450445553; Thu, 14 Apr 2022 16:11:33 +0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 14 Apr 2022 16:11:32 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 14 Apr 2022 16:11:32 +0800 From: Miles Chen To: Jaroslav Kysela , Takashi Iwai , Matthias Brugger CC: Miles Chen , , , , Subject: [PATCH -next] sound/oss/dmasound: fix 'dmasound_setup' defined but not used Date: Thu, 14 Apr 2022 16:11:18 +0800 Message-ID: <20220414081119.30851-1-miles.chen@mediatek.com> X-Mailer: git-send-email 2.18.0 MIME-Version: 1.0 X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" We observed: 'dmasound_setup' defined but not used error with COMPILER=3Dgcc ARCH=3Dm68k DEFCONFIG=3Dallmodconfig build. __setup() does not work if MODULE is defined. Fix it by warpping dmasound_setup with #ifndef MODULES. Error(s): sound/oss/dmasound/dmasound_core.c:1431:12: error: 'dmasound_setup' defined= but not used [-Werror=3Dunused-function] Signed-off-by: Miles Chen --- sound/oss/dmasound/dmasound_core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/oss/dmasound/dmasound_core.c b/sound/oss/dmasound/dmasou= nd_core.c index 9c48f3a9e3d1..a1b3e71beadf 100644 --- a/sound/oss/dmasound/dmasound_core.c +++ b/sound/oss/dmasound/dmasound_core.c @@ -1428,6 +1428,7 @@ void dmasound_deinit(void) unregister_sound_dsp(sq_unit); } =20 +#ifndef MODULE static int dmasound_setup(char *str) { int ints[6], size; @@ -1470,6 +1471,7 @@ static int dmasound_setup(char *str) } =20 __setup("dmasound=3D", dmasound_setup); +#endif =20 /* * Conversion tables --=20 2.18.0