From nobody Fri Jun 19 00:57:40 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD1AEC433EF for ; Mon, 11 Apr 2022 10:52:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344943AbiDKKy1 (ORCPT ); Mon, 11 Apr 2022 06:54:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231562AbiDKKyZ (ORCPT ); Mon, 11 Apr 2022 06:54:25 -0400 Received: from mail-qt1-x831.google.com (mail-qt1-x831.google.com [IPv6:2607:f8b0:4864:20::831]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2176340A1D for ; Mon, 11 Apr 2022 03:52:12 -0700 (PDT) Received: by mail-qt1-x831.google.com with SMTP id r25so2575927qtp.8 for ; Mon, 11 Apr 2022 03:52:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=U9MFldUlI8YuKEyEgOU8kDAs+pi0T7vKsyhKnKGTjrs=; b=Ff34ICPcuZ39MIm1wSdAnTHfHMg3nEABTIupQv3gGUrKqr2aDB1qvNQlAsc4rawUvZ lbxtEmuxHeu+X9fwghaQ1VIa+rHafS+7i5hvdUHAP9omifH456HyIAyVRs+H4OZ78dyO 4VWdIdyAvMEcRK6CBtbE1dtqVaHNUg9ednhDrTRBDjqpBV4VxzaquLcP5KwhpcCz2l3M klMb2grPVD0Z5PLyBbX0PP9Gw1Xuhw+sOOAYCs9pDmq8gyLhB8ZAYvS2jZ20Fi+vg5ve uhCXNayj8WRiT0rrGWhWz796XuMSIeuwOlmYn0XUkChy87wdRwEdFQxvetImUslidHFx Zc7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=U9MFldUlI8YuKEyEgOU8kDAs+pi0T7vKsyhKnKGTjrs=; b=GTFx4jmAEqY7HZLJ2hk/pWxzHcy/KBU1ny6cDDx5hWEdU68kSgkTml5z3Nr4R6tCmh VxXUbqLPxGLA2Vp24pYn7JcRQEjLprUoClV9wMcUOqvxhFK3IGFRbMrtyALqs7aDF0Sc LwYby/dWB8s6hInWNBcau2Z6ssn71IsyYDHBQ4D40TXMVI+b33G2w9nfOlxCfKtf8c4y MkUK+3/5SsD9zetF/75LsJ+j6gn+WHpTbTRUZSNpKmChEY7NJuXNShAz0xlIvrlvrQZq cC0PDuhEUWdi/DNuJ+/w2cXw3mmNqaNKy4hSd7hhgH8iEr1czvxQHcRDL934yyadme26 IEhg== X-Gm-Message-State: AOAM5331iZuSZFJVQwDdibkI3C/vq+xQkW9ktFwf06q7zoVPX4rF1H4N 6CZaSzpvpRdWFeAsv595zRv+rouK4Ms= X-Google-Smtp-Source: ABdhPJw1RmDDrMWyFJKQ7n3xXxsChAg6SrV6I8TtssAKsFyGaB2msx9dJxTFQKSEtcp//ITLpexEpw== X-Received: by 2002:ac8:7498:0:b0:2ed:c85:c9e1 with SMTP id v24-20020ac87498000000b002ed0c85c9e1mr10360705qtq.258.1649674331346; Mon, 11 Apr 2022 03:52:11 -0700 (PDT) Received: from localhost.localdomain ([193.203.214.57]) by smtp.gmail.com with ESMTPSA id y18-20020ac85f52000000b002ed08a7dc8dsm8436561qta.13.2022.04.11.03.52.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Apr 2022 03:52:10 -0700 (PDT) From: cgel.zte@gmail.com X-Google-Original-From: lv.ruyi@zte.com.cn To: stefanr@s5r6.in-berlin.de Cc: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Lv Ruyi , Zeal Robot Subject: [PATCH] firewire: Fix using uninitialized value Date: Mon, 11 Apr 2022 10:52:05 +0000 Message-Id: <20220411105205.2520784-1-lv.ruyi@zte.com.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Lv Ruyi If data is null, request->data wouldn't be assigned value. It is random value, but we use it in handle_exclusive_region_request() and handle_fcp_region_request() later. Fix the bug by initializing it. Reported-by: Zeal Robot Signed-off-by: Lv Ruyi --- drivers/firewire/core-transaction.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firewire/core-transaction.c b/drivers/firewire/core-tr= ansaction.c index e12a0a4c33f7..16ecfa7da177 100644 --- a/drivers/firewire/core-transaction.c +++ b/drivers/firewire/core-transaction.c @@ -778,7 +778,7 @@ static struct fw_request *allocate_request(struct fw_ca= rd *card, return NULL; } =20 - request =3D kmalloc(sizeof(*request) + length, GFP_ATOMIC); + request =3D kzalloc(sizeof(*request) + length, GFP_ATOMIC); if (request =3D=3D NULL) return NULL; =20 --=20 2.25.1