From nobody Mon May 11 07:48:19 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CE30C433EF for ; Mon, 11 Apr 2022 05:48:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244791AbiDKFux (ORCPT ); Mon, 11 Apr 2022 01:50:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33038 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239132AbiDKFuv (ORCPT ); Mon, 11 Apr 2022 01:50:51 -0400 Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D59CC2CE1A for ; Sun, 10 Apr 2022 22:48:38 -0700 (PDT) Received: by mail-pj1-x1031.google.com with SMTP id md4so5925138pjb.4 for ; Sun, 10 Apr 2022 22:48:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=asidVsxyIkB3smI5tvjWUtq2ho7mLzVkVUHx4rAV13g=; b=TX4X6X/uYWWocZgV5W3leK3OmupcigwdvvTggqX3gQipGKG22EMA233dKAMFrMbnMc wfE9zwMrIjs+i/7p9Rp5QuyRmmA97ZtigFNiseX9J0GUgeSn25sUcwUk0NgfX1fLypII Hzwv+xCn2sUUy3UR6ZjQGobzrGkgSG4Kzf2WtieJvCQWYEjgzihoxCbUVlh3cIbxMI/V dpVX6hY0/46eAobG0qP2xS1r3Lpna948/bdZecvhR4pDZjiDQTxP2AjDLk+6SGlLiVOL daWyKJrsM1uEls9AWwZVH48rsx3GmNZqAJ/OZeBOUTVmps+5Ec9qN2aEx94McA/UmtpD wplQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=asidVsxyIkB3smI5tvjWUtq2ho7mLzVkVUHx4rAV13g=; b=E99MHPh/hViP/HXn8eNB6hLvaFI8hpq7Al/ANGDK4YfUhRabcaf7ZOrWf8yNGV7QI/ XZCht3c9HguTZKV3A3Zp+Cj2/skjCkH41i+EUy3YjzFcBnuZUOyVBzQZJjxtUYQOD99b OUETBpjWGCO6PYv6CXMMORskj2/8pV+ZRZBQmUgY0XUeil88c2n5c4oNO2Y+Qjebzgnc +f0sZRrWcQ3I+VCFEgH8C6vctn0R1riRa6sYGyZFkdRhRlkYVajP2X5Ixk+fPqVu1oTY P2Uo4/InzvfSqEr7yUgBd1m1G+/9mYUvLKQsDYuiV/ADE2dc+RDFlLTAGH398qE6zQss 083Q== X-Gm-Message-State: AOAM530sT+dj8CLQyfJwOdQtnJ/J1WkABerCHzWXXLzzByr5VgpVg68h 1tfJzHBk/uy6hsYFVxmZk1aq X-Google-Smtp-Source: ABdhPJwbmgBsIdc8j5+HgdEMIiEjceFzXitMX8DNRPYWXDDLDm0k+Q8F8j3z5VDeACyosEuB+rj2sg== X-Received: by 2002:a17:90a:39c3:b0:1ca:88b9:eb4a with SMTP id k3-20020a17090a39c300b001ca88b9eb4amr35334445pjf.96.1649656118376; Sun, 10 Apr 2022 22:48:38 -0700 (PDT) Received: from localhost.localdomain ([117.217.182.106]) by smtp.gmail.com with ESMTPSA id o4-20020a625a04000000b004fdf5419e41sm25961728pfb.36.2022.04.10.22.48.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Apr 2022 22:48:37 -0700 (PDT) From: Manivannan Sadhasivam To: mhi@lists.linux.dev Cc: quic_hemantk@quicinc.com, quic_bbhatt@quicinc.com, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, loic.poulain@linaro.org, Manivannan Sadhasivam Subject: [PATCH] bus: mhi: host: pci_generic: Sort mhi_pci_id_table based on the PID Date: Mon, 11 Apr 2022 11:18:31 +0530 Message-Id: <20220411054831.16344-1-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Sorting this way helps in identifying the products of vendors. There is no sorting required for VID and the new VID should be added as the last entry. Let's also add a note clarifying this. Signed-off-by: Manivannan Sadhasivam --- drivers/bus/mhi/host/pci_generic.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_= generic.c index 9527b7d63840..55e96aa15566 100644 --- a/drivers/bus/mhi/host/pci_generic.c +++ b/drivers/bus/mhi/host/pci_generic.c @@ -446,20 +446,21 @@ static const struct mhi_pci_dev_info mhi_sierra_em919= x_info =3D { .sideband_wake =3D false, }; =20 +/* Keep the list sorted based on the PID. New VID should be added as the l= ast entry */ static const struct pci_device_id mhi_pci_id_table[] =3D { + { PCI_DEVICE(PCI_VENDOR_ID_QCOM, 0x0304), + .driver_data =3D (kernel_ulong_t) &mhi_qcom_sdx24_info }, + { PCI_DEVICE(PCI_VENDOR_ID_QCOM, 0x0306), + .driver_data =3D (kernel_ulong_t) &mhi_qcom_sdx55_info }, /* EM919x (sdx55), use the same vid:pid as qcom-sdx55m */ { PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0306, 0x18d7, 0x0200), .driver_data =3D (kernel_ulong_t) &mhi_sierra_em919x_info }, - { PCI_DEVICE(PCI_VENDOR_ID_QCOM, 0x0306), - .driver_data =3D (kernel_ulong_t) &mhi_qcom_sdx55_info }, - { PCI_DEVICE(PCI_VENDOR_ID_QCOM, 0x0304), - .driver_data =3D (kernel_ulong_t) &mhi_qcom_sdx24_info }, + { PCI_DEVICE(PCI_VENDOR_ID_QCOM, 0x0308), + .driver_data =3D (kernel_ulong_t) &mhi_qcom_sdx65_info }, { PCI_DEVICE(0x1eac, 0x1001), /* EM120R-GL (sdx24) */ .driver_data =3D (kernel_ulong_t) &mhi_quectel_em1xx_info }, { PCI_DEVICE(0x1eac, 0x1002), /* EM160R-GL (sdx24) */ .driver_data =3D (kernel_ulong_t) &mhi_quectel_em1xx_info }, - { PCI_DEVICE(PCI_VENDOR_ID_QCOM, 0x0308), - .driver_data =3D (kernel_ulong_t) &mhi_qcom_sdx65_info }, /* T99W175 (sdx55), Both for eSIM and Non-eSIM */ { PCI_DEVICE(PCI_VENDOR_ID_FOXCONN, 0xe0ab), .driver_data =3D (kernel_ulong_t) &mhi_foxconn_sdx55_info }, --=20 2.25.1