From nobody Mon May 11 08:31:20 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF346C433EF for ; Sun, 10 Apr 2022 16:12:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240516AbiDJQO1 (ORCPT ); Sun, 10 Apr 2022 12:14:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243758AbiDJQMv (ORCPT ); Sun, 10 Apr 2022 12:12:51 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AACF440933 for ; Sun, 10 Apr 2022 09:10:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=B6tMKYK2Z3xVAw/QxFp/pyz5o32Ek1zRQPrPupjZolk=; b=b5/otx6cfC1w2dFSBG/HnGZhaO tknBA+fOo0Hp/JnpVoaXQPxZFNbPcnlfBt7YXqAgB5e6JJ5xJyTvEytgd4jlFTuiV0HgfJPUd/No4 kFC+8E4oe/V1+x9WZMnR3QgfrS84V5+trt+5+xRUzl3AwXEWfiTWH/3ll6LwfhmaQ6CjDbNOFG96X 0vqSicky0N46/z/NgADTbnBZLWRimS5zzrETj9HnJcSepPdZ6rKJQ4NW4bPeP96WKhk7dn12UQvOv nl7wIQD5cM9J2Y72M5RU7NPOXIWnsuGuzTfUXtReymgkKLHPe912QyVHHZDRt2F3RzATGpY4okyep 72YPKfdg==; Received: from [2601:1c0:6280:3f0::aa0b] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nda96-0056Gu-Qt; Sun, 10 Apr 2022 16:10:36 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , kernel test robot , Christophe Leroy , Benjamin Herrenschmidt , Michael Ellerman , Kees Cook , Arnd Bergmann , Finn Thain , Geert Uytterhoeven , Nathan Chancellor , Nick Desaulniers , linuxppc-dev@lists.ozlabs.org Subject: [PATCH v2] macintosh: via-pmu and via-cuda need RTC_LIB Date: Sun, 10 Apr 2022 09:10:35 -0700 Message-Id: <20220410161035.592-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Fix build when RTC_LIB is not set/enabled. Eliminates these build errors: m68k-linux-ld: drivers/macintosh/via-pmu.o: in function `pmu_set_rtc_time': drivers/macintosh/via-pmu.c:1769: undefined reference to `rtc_tm_to_time64' m68k-linux-ld: drivers/macintosh/via-cuda.o: in function `cuda_set_rtc_time= ': drivers/macintosh/via-cuda.c:797: undefined reference to `rtc_tm_to_time64' Fixes: 0792a2c8e0bb ("macintosh: Use common code to access RTC") Signed-off-by: Randy Dunlap Reported-by: kernel test robot Suggested-by: Christophe Leroy Cc: Benjamin Herrenschmidt Cc: Michael Ellerman Cc: Kees Cook Cc: Arnd Bergmann Cc: Finn Thain Cc: Geert Uytterhoeven Cc: Nathan Chancellor Cc: Nick Desaulniers Cc: linuxppc-dev@lists.ozlabs.org Acked-by: Arnd Bergmann --- v2: use RTC_LIB instead of open-coding the call to rtc_tm_to_time64() drivers/macintosh/Kconfig | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/macintosh/Kconfig +++ b/drivers/macintosh/Kconfig @@ -44,6 +44,7 @@ config ADB_IOP config ADB_CUDA bool "Support for Cuda/Egret based Macs and PowerMacs" depends on (ADB || PPC_PMAC) && !PPC_PMAC64 + select RTC_LIB help This provides support for Cuda/Egret based Macintosh and Power Macintosh systems. This includes most m68k based Macs, @@ -57,6 +58,7 @@ config ADB_CUDA config ADB_PMU bool "Support for PMU based PowerMacs and PowerBooks" depends on PPC_PMAC || MAC + select RTC_LIB help On PowerBooks, iBooks, and recent iMacs and Power Macintoshes, the PMU is an embedded microprocessor whose primary function is to