From nobody Tue Jun 9 20:01:43 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4F78C433F5 for ; Fri, 8 Apr 2022 09:28:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232989AbiDHJaJ (ORCPT ); Fri, 8 Apr 2022 05:30:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231939AbiDHJaE (ORCPT ); Fri, 8 Apr 2022 05:30:04 -0400 Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E3DE95 for ; Fri, 8 Apr 2022 02:28:01 -0700 (PDT) Received: by mail-lj1-x233.google.com with SMTP id bn33so10671320ljb.6 for ; Fri, 08 Apr 2022 02:28:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=HgPZP8og8WpumzGAAXJPVekArW+Xl/SXdvcjF73+2JQ=; b=gHyFWpI6t8tOI4tUOMMz7p3TQeEQDqT5UxoSqnTR71xyC+cPoQ8GFnBWCqBCSal1Gv orGbjTEbs5Qdnhj10PvndYzcZh0UVMaZe+wmduTGqUGHG0YhB4FCbUz4xzREn/6OgvIB RRzUbSssHiOya74amEZ+zJSMXm76gERDIhfe/FfCjCz0voIT39bcAsz6U5Myuv+Ajg70 hApiOhfPlKHR8ZQArArd+uZwWAwxZky61FDeKAfW6fAnpeth1S1BUNBM0FSSyp8gaye0 tpljYIPZAu814zQ9RtpevYuib5m+XkmRBK0Fj4nTCGordvFiVlbZiXNHMPSH0pclk/wL p6Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=HgPZP8og8WpumzGAAXJPVekArW+Xl/SXdvcjF73+2JQ=; b=aeL9R/RosZ29u7DgPjcm/+I5y6OhybJtiEzAEFeleIN+91ePPsDWiQHLnXH5gfJ7s9 c5ihmqeCB/Ov+aiA8/Yr59g+vnr83F/C339AL/P3EG7ENTq8Z8B7R45cqAQkQWWUVft8 0m403Xiv4Fu86ihtNAfqhha8wznyuZ/CDUxTXFfA23uAdZ48uxWhFT/PxnbE7WNANz6V 92uWgPUtO7RPmIPo3mtLjiHgzL4zVX39F2yczCl6oXEqWaPy+SQnIzQc3IFFyE+B1pDB lvFXE4ZrY0nXiTdyDfQhKtWpHpcKGhfJoPGzuqrBGKbucqcbX3JypfmuLsdrfqY83HNF nr/g== X-Gm-Message-State: AOAM532x/ZEZhRedHW6Qwd2wazltDGrY3lkzivS3RpZftGemIcHeHpDt bykyK0pJZRQ9myb0xbQtMzA= X-Google-Smtp-Source: ABdhPJzDmYvPgxNYX0/xkMPy8fJo6IwLGDldkvZtGq5F1xWFOwxo8a5LnYST9iSx1XiFSCkTg6ybbA== X-Received: by 2002:a05:651c:996:b0:24a:f361:1d9 with SMTP id b22-20020a05651c099600b0024af36101d9mr10971985ljq.346.1649410079474; Fri, 08 Apr 2022 02:27:59 -0700 (PDT) Received: from noname.. ([2a02:2698:8c2a:149d:6d9:f5ff:fecb:a8ab]) by smtp.googlemail.com with ESMTPSA id u12-20020a056512128c00b00446499f855dsm2412451lfs.78.2022.04.08.02.27.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Apr 2022 02:27:59 -0700 (PDT) From: Grigory Vasilyev To: Rodrigo Siqueira , Melissa Wen Cc: Grigory Vasilyev , Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , "Pan, Xinhui" , David Airlie , Daniel Vetter , =?UTF-8?q?Michel=20D=C3=A4nzer?= , Simon Ser , Evan Quan , Bas Nieuwenhuizen , Sean Paul , Qingqing Zhuo , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/amdgpu: Fix NULL pointer dereference Date: Fri, 8 Apr 2022 12:28:02 +0300 Message-Id: <20220408092803.3188-1-h0tc0d3@gmail.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The code below check for NULL, but is no check at this place, which is potentially dangerous. Signed-off-by: Grigory Vasilyev --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c b/drivers/gpu/drm/= amd/amdgpu/amdgpu_display.c index d26810e7311d..c773a92dd4e5 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c @@ -1017,8 +1017,10 @@ static int amdgpu_display_get_fb_info(const struct a= mdgpu_framebuffer *amdgpu_fb int r; =20 if (!amdgpu_fb) { - *tiling_flags =3D 0; - *tmz_surface =3D false; + if (tiling_flags) + *tiling_flags =3D 0; + if (tmz_surface) + *tmz_surface =3D false; return 0; } =20 --=20 2.35.1