From nobody Sun Dec 28 00:56:52 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8617DC433F5 for ; Thu, 7 Apr 2022 13:00:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245657AbiDGNCH (ORCPT ); Thu, 7 Apr 2022 09:02:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60060 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241951AbiDGNBz (ORCPT ); Thu, 7 Apr 2022 09:01:55 -0400 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12F261A2A23 for ; Thu, 7 Apr 2022 05:59:55 -0700 (PDT) Received: by mail-wr1-x42a.google.com with SMTP id r13so7723489wrr.9 for ; Thu, 07 Apr 2022 05:59:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=kVP0DeosChaP4vnFzIKGWwoOlpAbwuSOyH45+/mZoL0=; b=EKN2hIRsBqehxl1LPwDXn+MG5SyKoqhVpkpyr2FlER8hbxE9Ay7WNPPw4ChApC65YQ J30V9zKdRjJj8mCycqBYe6r/yZbYQ0Syua9qMK/XX+36rrCYQsATeqXHCoUQ9wc9vX4Q FSlomHsQTEMFxVm7f4qT2/pO9mm/xpdt0tgcZlCsItIrg93Wb/3T2aD77sBXVXPboyt3 LXBikbAHA50KRnYq74MsZDjdGerLMWIh4JIhh2PbGZJJDz/TUc1izmizbOFwGvt7GfZ1 smc9IZOkpFiM1D4yqyI865GU7OL7PJcOQzjADzTNCkCAPlwgZwdDXZ0OpgG9OVqBzL4i BO7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=kVP0DeosChaP4vnFzIKGWwoOlpAbwuSOyH45+/mZoL0=; b=GUQcGxtBjHvCiVqfKrYDhCx2aotp95GN8A58b2a9TObt9Ma4XohH1yO3M8RrqlGHdr XI/8rjMnvuUbmIPEfRt3oNeDgL0TYCcsoJCv/el+S0Hx5YjBD2k6azfo0Ao5cu+n3Fu5 FWk9lmkc7t2hKZo8h+xjxtnlOsJp9YUC3Q9mW+MdIcbxNcQL9YEzCu+MKcQ3/kQBwlj/ ECiXLXwCxKjJPm5+frshBttQ+0ijc1pbaSpKT/Y9drrOm89qjbrsdHvICy5b6yntWV77 UQkvZ37JooKiBmUsNFtKTTQc+x84fQOZ7ZFJSkxfaYt7d7gitx4Ifp8/jKmCNGIn0uEx OuPQ== X-Gm-Message-State: AOAM531Ik01Br0MbWDDzKdEUTQDntP4nnCDkrkoT/CYq0/1a5V6zAXRL NbL3netnYooMmca+Sidg+uk= X-Google-Smtp-Source: ABdhPJxshfU1NOlOOLmqcrimT11cLGwoDeMBpIbUyzbLG9YPscs+Pk4CihETUqSB0wB9UMgpKC6DVg== X-Received: by 2002:adf:ee08:0:b0:206:1b1e:bc20 with SMTP id y8-20020adfee08000000b002061b1ebc20mr10973407wrn.541.1649336393481; Thu, 07 Apr 2022 05:59:53 -0700 (PDT) Received: from alaa-emad ([197.57.231.245]) by smtp.gmail.com with ESMTPSA id l20-20020a05600c1d1400b0038cba2f88c0sm10704711wms.26.2022.04.07.05.59.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Apr 2022 05:59:52 -0700 (PDT) From: Alaa Mohamed To: outreachy@lists.linux.dev Cc: Larry.Finger@lwfinger.net, florian.c.schilhabel@googlemail.com, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, eng.alaamohamedsoliman.am@gmail.com Subject: [PATCH v4] staging: rtl8712: remove unnecessary parentheses Date: Thu, 7 Apr 2022 14:59:47 +0200 Message-Id: <20220407125947.8525-1-eng.alaamohamedsoliman.am@gmail.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Reported by checkpatch: Remove unnecessary parentheses around structure field references Signed-off-by: Alaa Mohamed --- Changes in v2: - Edit commit subject - Edit commit message - Fix the same check in more lines - Remove space before '.skey' in "memcpy(psta->tkiptxmickey.skey," in lines 84 and 86. --- Changes in v3: return the space before '.skey' in "memcpy(psta->tkiptxmickey.skey," in lines 84 and 86 --- Changes in v4: edit commit message to be clearer. --- drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 20 +++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/stagin= g/rtl8712/rtl871x_ioctl_linux.c index 3b6926613257..f1e352b7f83e 100644 --- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c +++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c @@ -82,9 +82,9 @@ static inline void handle_pairwise_key(struct sta_info *p= sta, (param->u.crypt. key_len > 16 ? 16 : param->u.crypt.key_len)); if (strcmp(param->u.crypt.alg, "TKIP") =3D=3D 0) { /* set mic key */ memcpy(psta->tkiptxmickey. skey, - &(param->u.crypt.key[16]), 8); + ¶m->u.crypt.key[16], 8); memcpy(psta->tkiprxmickey. skey, - &(param->u.crypt.key[24]), 8); + ¶m->u.crypt.key[24], 8); padapter->securitypriv. busetkipkey =3D false; mod_timer(&padapter->securitypriv.tkip_timer, jiffies + msecs_to_jiffies(50)); @@ -600,7 +600,7 @@ static int r8711_wx_get_name(struct net_device *dev, u32 ht_ielen =3D 0; char *p; u8 ht_cap =3D false; - struct mlme_priv *pmlmepriv =3D &(padapter->mlmepriv); + struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; struct wlan_bssid_ex *pcur_bss =3D &pmlmepriv->cur_network.network; u8 *prates; =20 @@ -1494,7 +1494,7 @@ static int r8711_wx_set_enc(struct net_device *dev, u32 keyindex_provided; struct NDIS_802_11_WEP wep; enum NDIS_802_11_AUTHENTICATION_MODE authmode; - struct iw_point *erq =3D &(wrqu->encoding); + struct iw_point *erq =3D &wrqu->encoding; struct _adapter *padapter =3D netdev_priv(dev); =20 key =3D erq->flags & IW_ENCODE_INDEX; @@ -1589,8 +1589,8 @@ static int r8711_wx_get_enc(struct net_device *dev, { uint key; struct _adapter *padapter =3D netdev_priv(dev); - struct iw_point *erq =3D &(wrqu->encoding); - struct mlme_priv *pmlmepriv =3D &(padapter->mlmepriv); + struct iw_point *erq =3D &wrqu->encoding; + struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; union Keytype *dk =3D padapter->securitypriv.DefKey; =20 if (!check_fwstate(pmlmepriv, _FW_LINKED)) { @@ -1670,7 +1670,7 @@ static int r871x_wx_set_auth(struct net_device *dev, union iwreq_data *wrqu, char *extra) { struct _adapter *padapter =3D netdev_priv(dev); - struct iw_param *param =3D (struct iw_param *)&(wrqu->param); + struct iw_param *param =3D (struct iw_param *)&wrqu->param; int paramid; int paramval; int ret =3D 0; @@ -1964,7 +1964,7 @@ static int r871x_get_ap_info(struct net_device *dev, return -EINVAL; data[32] =3D 0; =20 - spin_lock_irqsave(&(pmlmepriv->scanned_queue.lock), irqL); + spin_lock_irqsave(&pmlmepriv->scanned_queue.lock, irqL); phead =3D &queue->queue; plist =3D phead->next; while (1) { @@ -1974,7 +1974,7 @@ static int r871x_get_ap_info(struct net_device *dev, if (!mac_pton(data, bssid)) { netdev_info(dev, "r8712u: Invalid BSSID '%s'.\n", (u8 *)data); - spin_unlock_irqrestore(&(pmlmepriv->scanned_queue.lock), + spin_unlock_irqrestore(&pmlmepriv->scanned_queue.lock, irqL); return -EINVAL; } @@ -1996,7 +1996,7 @@ static int r871x_get_ap_info(struct net_device *dev, } plist =3D plist->next; } - spin_unlock_irqrestore(&(pmlmepriv->scanned_queue.lock), irqL); + spin_unlock_irqrestore(&pmlmepriv->scanned_queue.lock, irqL); if (pdata->length >=3D 34) { if (copy_to_user((u8 __user *)pdata->pointer + 32, (u8 *)&pdata->flags, 1)) --=20 2.35.1