From nobody Fri Jun 19 08:31:10 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2273FC433F5 for ; Wed, 6 Apr 2022 09:36:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1382744AbiDFJhb (ORCPT ); Wed, 6 Apr 2022 05:37:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1451058AbiDFJem (ORCPT ); Wed, 6 Apr 2022 05:34:42 -0400 Received: from mail-pj1-x1044.google.com (mail-pj1-x1044.google.com [IPv6:2607:f8b0:4864:20::1044]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4A1722521; Tue, 5 Apr 2022 23:17:27 -0700 (PDT) Received: by mail-pj1-x1044.google.com with SMTP id o5-20020a17090ad20500b001ca8a1dc47aso4878622pju.1; Tue, 05 Apr 2022 23:17:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=nVbjX3Usy314kCEmgJkih9YlvsbX+haXG81Sqj35s8g=; b=ZvKow59G7wgedgEZP1PPqH1eXcP9OiV8Kd7FM5DnYblp7q42FVsXDbPGUNkImJCupb P/ezDSEztfmEuAJEdN1i0airGh3Ffws8BQDG1ZxhQUEYJtQ5HPmWl/4hqYDSiss+hZbs RIpHnsisnZk+CnvC71UbICJpHoHvCuNUQaehT+zvC7PnrNUXWJdq7aAS2YYJnr3V1lLb xWoUdlFV0nUgnLdNlyxT4yZfgFZPKfnk5xazNAiIDj7wcuiKNLXc8OzruKZu11c79v3S RUevlVZJr1MhqMlxJ7uXqqgIaw2Df/JKCqoB3c3o5wEfll1WbG91XAEGLEdJQ87STzO7 /jNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=nVbjX3Usy314kCEmgJkih9YlvsbX+haXG81Sqj35s8g=; b=eBmXU3nzbRS1uFY6gUGlvBX3P0rQibTadcj6oqaLdwpNCUddbxBAcqxAsFcTdYUDWV 8dCczj+s9e8N15rriZ88RnvCR5nkqp8aP0vJO5qdZJmNXVX7o3A1+UeGuHCi0w1vjxiO lKGC43KRU/2XRNGtmt3T5ICw4OalKBipjOukQIMZ7Kdty1G5L3EoJgQz+sVygnQGgRgX x3Dfwgrv3RdG4a1rhYNiZZaxREeZ7vBu4lvaUJOchyquvtc6/P98Nd6ecvtrKvTjXX/V TiCXLGvmv4CZDsjKYxWJozi0/FNIUjtksx6d8N2Ji2ysZUSgXNSPdtfNiAQWZTaJ+PFD bjtw== X-Gm-Message-State: AOAM530h+67/K1Irp3JGHOkJh2Io/AGcdXvgHRd0gaf0P3CjsFVMLh+K iWXnHqf7WFT0tJn2BBqQHoY= X-Google-Smtp-Source: ABdhPJzhUsmuDt8gnYBz+cRjQzbACyW9NzlTD9u/nSS8aqaAXwzOmfveWvgCAprpGMqd1HMc4ETXJA== X-Received: by 2002:a17:902:8a95:b0:156:a40a:71e5 with SMTP id p21-20020a1709028a9500b00156a40a71e5mr7170857plo.144.1649225847168; Tue, 05 Apr 2022 23:17:27 -0700 (PDT) Received: from slim.das-security.cn ([103.84.139.53]) by smtp.gmail.com with ESMTPSA id l13-20020a056a00140d00b004e13da93eaasm17675683pfu.62.2022.04.05.23.17.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Apr 2022 23:17:26 -0700 (PDT) From: Hangyu Hua To: valentina.manea.m@gmail.com, shuah@kernel.org, gregkh@linuxfoundation.org, khoroshilov@ispras.ru Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Hangyu Hua Subject: [PATCH] usb: usbip: fix a refcount leak in stub_probe() Date: Wed, 6 Apr 2022 14:17:13 +0800 Message-Id: <20220406061713.18938-1-hbh25y@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" usb_get_dev is called in stub_device_alloc. When stub_probe fails after that, usb_put_dev needs to be used. Fix this by moving usb_put_dev to sdev_free. Fixes: 3ff67445750a ("usbip: fix error handling in stub_probe()") Signed-off-by: Hangyu Hua Reviewed-by: Shuah Khan --- drivers/usb/usbip/stub_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/usbip/stub_dev.c b/drivers/usb/usbip/stub_dev.c index d8d3892e5a69..3c6d452e3bf4 100644 --- a/drivers/usb/usbip/stub_dev.c +++ b/drivers/usb/usbip/stub_dev.c @@ -393,7 +393,6 @@ static int stub_probe(struct usb_device *udev) =20 err_port: dev_set_drvdata(&udev->dev, NULL); - usb_put_dev(udev); =20 /* we already have busid_priv, just lock busid_lock */ spin_lock(&busid_priv->busid_lock); @@ -408,6 +407,7 @@ static int stub_probe(struct usb_device *udev) put_busid_priv(busid_priv); =20 sdev_free: + usb_put_dev(udev); stub_device_free(sdev); =20 return rc; --=20 2.25.1