From nobody Fri Jun 19 09:47:48 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB5A2C433FE for ; Tue, 5 Apr 2022 23:25:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1575252AbiDEXD3 (ORCPT ); Tue, 5 Apr 2022 19:03:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1390729AbiDENnK (ORCPT ); Tue, 5 Apr 2022 09:43:10 -0400 Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7BA3B29833 for ; Tue, 5 Apr 2022 05:43:39 -0700 (PDT) Received: by mail-pl1-x62c.google.com with SMTP id n18so10799261plg.5 for ; Tue, 05 Apr 2022 05:43:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FkFtcq8jG36lKpEqQXtgVBWpO9PXs+dvDcrkyl4I1JE=; b=K3A6+NSJs8BRIGtFtREYuYGdt+I2mfbSCX/qAgVN8Llkj+IqkdCnfKCE0OmVCR0oTL ZuQ3c53uY19nlODYpvTvtL6e+pdMZJzomxMY2twipmZFpfCjtCvMDW6n91+hsCXCjO/9 SEJ4wUwiPIoumxXLjQKMitubVLWNKHTeOuDRaoprMeakAxZYyQMAULiHDXdNvPtbmOLs UXC4VhPTrG5tTZ2mzWL9Pc7C5YqeDBJ6ZKI+Hl6AESA4BgIIrbFskHFl7AOOmGuIr4Oa hbMKmf5C/jKh8/gf+IzMn5ywVlKLy0IPwvSBH8P2FO1gh+Y2a3Gxsjb63cktIDXT7UNV oCGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FkFtcq8jG36lKpEqQXtgVBWpO9PXs+dvDcrkyl4I1JE=; b=Ut3XkyU6HrSdkOnIoAF3NFbyZnIiGFnFgeltQ5h/vMidnjTzlDFBjjSsSh5l6YAjd4 XPJJFtzssqcnDAgf6WgBTmPpqYFN/7xDpu2DVIkE86XKYCIji/HYEEOhDLKqvxFne1zS osFdvlci817NkN6sGYEnYUgULT+o24q2Efe90fA72yHG+tE307Rqk2MTYr6MUK7HY4OV h9VaxoXbUaj+LF1BziYje1VCnnEylml53o2jmtnKtQ0y+WfMRhTDS13isLqovhbDue7C TKh3v5qHytTyPHJTLvJWHdf53PYRUSwTSl5teSu91C+GKE/5qpxLP5UYZsxXqtK2ELYU ynqw== X-Gm-Message-State: AOAM533kPO1La/s2dbpeW4DJxgd36m0JNStmYi9SWNvQNCGxmu0DNjEX HE2xds8HQqHnJ5LHlfLM5wc= X-Google-Smtp-Source: ABdhPJxA7BYupDalxQpTgWbwDIy06f39XbgqEQMzEvGNOezRhIRWoxVZMoYFVgURNXmPQjcaobeYZA== X-Received: by 2002:a17:902:f243:b0:156:b615:dd38 with SMTP id j3-20020a170902f24300b00156b615dd38mr3322253plc.174.1649162618681; Tue, 05 Apr 2022 05:43:38 -0700 (PDT) Received: from vihas.localhost.com ([103.85.9.59]) by smtp.gmail.com with ESMTPSA id nl17-20020a17090b385100b001c70883f6ccsm2760014pjb.36.2022.04.05.05.43.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Apr 2022 05:43:38 -0700 (PDT) From: Vihas Makwana To: Larry Finger , Phillip Potter , Greg Kroah-Hartman , Michael Straube , Dan Carpenter , Pavel Skripkin Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Vihas Makwana Subject: [PATCH 1/3] staging: r8188eu: drop redundant if check in IS_MCAST Date: Tue, 5 Apr 2022 18:12:38 +0530 Message-Id: <20220405124239.3372-2-makvihas@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220405124239.3372-1-makvihas@gmail.com> References: <20220405124239.3372-1-makvihas@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The if check is redundant. Drop it and simplify the funciton. Signed-off-by: Vihas Makwana --- drivers/staging/r8188eu/include/wifi.h | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/r8188eu/include/wifi.h b/drivers/staging/r8188= eu/include/wifi.h index e10cf17d6..88ed6b4a0 100644 --- a/drivers/staging/r8188eu/include/wifi.h +++ b/drivers/staging/r8188eu/include/wifi.h @@ -244,10 +244,7 @@ enum WIFI_REG_DOMAIN { =20 static inline bool IS_MCAST(unsigned char *da) { - if ((*da) & 0x01) - return true; - else - return false; + return (*da) & 0x01; } =20 static inline unsigned char *get_da(unsigned char *pframe) --=20 2.30.2 From nobody Fri Jun 19 09:47:48 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAF15C433FE for ; Wed, 6 Apr 2022 00:22:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1587867AbiDFAKk (ORCPT ); Tue, 5 Apr 2022 20:10:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1390735AbiDENnL (ORCPT ); Tue, 5 Apr 2022 09:43:11 -0400 Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7563653E17 for ; Tue, 5 Apr 2022 05:43:42 -0700 (PDT) Received: by mail-pf1-x432.google.com with SMTP id p8so11971167pfh.8 for ; Tue, 05 Apr 2022 05:43:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Ihb0Oo6uzrJ7i7ES6RnGudcZVN/CipVYf3jNZpUHQLI=; b=cOtTwbNQi5IfZUAxRf50Bs1HOneUA1zU2agmrl/ioAeT0pNG68hoBDlfq3E2n5c/lm v8Vz/drHW7M/EqTvitrTgJprz83zD6CN8Y5ZxNedn4ZiF7oQdLiGXSPhNe0bnbhEEFyI GLeckXj6/jek9wnvFOTbFHCwxWPEJ6PaHEZsyqCqfB9+apiJ3mJMirM9BKGgRFqs6Lav 862usk14tutu/G40euP+x93V7lpLIeWn/TYYAkaL/ScLPPhMjCh3tmbzRbivvSUTrpST /1XDrd79VUwISEPz95aoQNWKFRZxnz4QN3yFvd2ryTAUAWTeiIwv4uQU7yZMHkO0fwxm jZyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Ihb0Oo6uzrJ7i7ES6RnGudcZVN/CipVYf3jNZpUHQLI=; b=FPGeQwIje1XTtMhY5FvqLE/nSgEbtiTqs5jE3117tQqa64lnZM4gDaG92OPe6b47eJ 3TvXsud99dePpCqzhzSrPqQRfkSekHFrzy2Za3eI1o661bT1TTGrIKKjlLhdZCLw7h6i +KkE60Z59Fjw/ryy3Qo55qSdQtHjNTtTjjD28Bjr1ucWria7Ty9iwhP1KT87rvpSC6Fq B4QFCfZ9rx8cr5QT3P5+nWHPanbIDAF2vtWKKq5fQOljN6Zh88lubs+NV/RnhmF8zkG3 UXj+q6OQzIC15J7wzLjfEIyIY4ws3MH3E57FojrW9NlIsA2oDlcKrJnU1A2URvEbgbLO mRdQ== X-Gm-Message-State: AOAM531xHAyUHtxSZrdPK7wyrxZMJxkvs7O304Lpzu8LTUMnsA1eQrh0 CrLySWEkdcOD1t/6HJHXuG4sKS1Mfp+h1w== X-Google-Smtp-Source: ABdhPJxdx0qvfGREqNKAZXchciButDkbJSdfo8FktryPSKjwwRp7EPJLapSK7+0w1ZkCu7xQo4BqpA== X-Received: by 2002:a63:2d47:0:b0:399:53e3:5b4c with SMTP id t68-20020a632d47000000b0039953e35b4cmr2741835pgt.165.1649162621998; Tue, 05 Apr 2022 05:43:41 -0700 (PDT) Received: from vihas.localhost.com ([103.85.9.59]) by smtp.gmail.com with ESMTPSA id nl17-20020a17090b385100b001c70883f6ccsm2760014pjb.36.2022.04.05.05.43.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Apr 2022 05:43:41 -0700 (PDT) From: Vihas Makwana To: Larry Finger , Phillip Potter , Greg Kroah-Hartman , Michael Straube , Dan Carpenter , Pavel Skripkin Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Vihas Makwana Subject: [PATCH 2/3] staging: r8188eu: drop redundant if check in check_fwstate Date: Tue, 5 Apr 2022 18:12:39 +0530 Message-Id: <20220405124239.3372-3-makvihas@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220405124239.3372-1-makvihas@gmail.com> References: <20220405124239.3372-1-makvihas@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The if check is redundant. Drop it and simplify the funciton. Also, drop clr_fwstate(), clr_fwstate_ex(), up_scanned_network() and down_scanned_network() as they are not used anywhere. Signed-off-by: Vihas Makwana --- drivers/staging/r8188eu/include/rtw_mlme.h | 43 +--------------------- 1 file changed, 1 insertion(+), 42 deletions(-) diff --git a/drivers/staging/r8188eu/include/rtw_mlme.h b/drivers/staging/r= 8188eu/include/rtw_mlme.h index 37d217aaf..3b6f70ad8 100644 --- a/drivers/staging/r8188eu/include/rtw_mlme.h +++ b/drivers/staging/r8188eu/include/rtw_mlme.h @@ -453,15 +453,7 @@ static inline u8 *get_bssid(struct mlme_priv *pmlmepri= v) =20 static inline bool check_fwstate(struct mlme_priv *pmlmepriv, int state) { - if (pmlmepriv->fw_state & state) - return true; - - return false; -} - -static inline int get_fwstate(struct mlme_priv *pmlmepriv) -{ - return pmlmepriv->fw_state; + return pmlmepriv->fw_state & state; } =20 /* @@ -487,39 +479,6 @@ static inline void _clr_fwstate_(struct mlme_priv *pml= mepriv, int state) pmlmepriv->bScanInProcess =3D false; } =20 -/* - * No Limit on the calling context, - * therefore set it to be the critical section... - */ -static inline void clr_fwstate(struct mlme_priv *pmlmepriv, int state) -{ - spin_lock_bh(&pmlmepriv->lock); - if (check_fwstate(pmlmepriv, state)) - pmlmepriv->fw_state ^=3D state; - spin_unlock_bh(&pmlmepriv->lock); -} - -static inline void clr_fwstate_ex(struct mlme_priv *pmlmepriv, int state) -{ - spin_lock_bh(&pmlmepriv->lock); - _clr_fwstate_(pmlmepriv, state); - spin_unlock_bh(&pmlmepriv->lock); -} - -static inline void up_scanned_network(struct mlme_priv *pmlmepriv) -{ - spin_lock_bh(&pmlmepriv->lock); - pmlmepriv->num_of_scanned++; - spin_unlock_bh(&pmlmepriv->lock); -} - -static inline void down_scanned_network(struct mlme_priv *pmlmepriv) -{ - spin_lock_bh(&pmlmepriv->lock); - pmlmepriv->num_of_scanned--; - spin_unlock_bh(&pmlmepriv->lock); -} - static inline void set_scanned_network_val(struct mlme_priv *pmlmepriv, in= t val) { spin_lock_bh(&pmlmepriv->lock); --=20 2.30.2 From nobody Fri Jun 19 09:47:48 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1A35C4167E for ; Wed, 6 Apr 2022 00:09:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1445482AbiDEXpy (ORCPT ); Tue, 5 Apr 2022 19:45:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1390763AbiDENnQ (ORCPT ); Tue, 5 Apr 2022 09:43:16 -0400 Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A09A252A8 for ; Tue, 5 Apr 2022 05:43:45 -0700 (PDT) Received: by mail-pj1-x102c.google.com with SMTP id g15-20020a17090adb0f00b001caa9a230c7so2376278pjv.5 for ; Tue, 05 Apr 2022 05:43:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=32znQNcCvJk/J0LQPqfBrFopN6gveol4Y5sCPC/EtaM=; b=MZMONg6evm1b06ebf10VUy5qFruE2ufypLDORfiNPGI9Nm0V2d8NKPNfbuYFXbxynU Ew5pEiXL+/KwKou273b4JRujttgweTrjxe1fAy9x5lxWCMC0drqctxQwhyb95FPOLZgA M2GCBt9hNOFC4/fXKhg8UBwwjYM3MxkKj0saUBeRaN6TZeFpC4g51PHtvYi8xJQ6OGra eoa1gHvqGo83aGXxWV+nlgrBMVEmlWLj0Rbn48iMd00FALXO0M21yLmHguVJCwSsKS42 ySxbWr3ZrLtYfyGkDI3Ry/aerkx5NxGRDDuG+fXVHARuTb+F1Bn5hI0ft1DrvENkaJ/z XDuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=32znQNcCvJk/J0LQPqfBrFopN6gveol4Y5sCPC/EtaM=; b=Xj1eBXm/ipYgw+C+tOeRDpH8gaaVcL5NxRCeU/38b5dSKLhMM9+Ww9IQooJmN0utzF 9+OAWdzxI9ajVP0ZjQnXpZku5Neg6H8Sodx37jnIsDWAJ9z5sBeD6C/GnzLE2UIDAQVG ZOyPkK3N5ryOHFBH8oKbc8gmExF7sLqFD+4n9SigUWGwb8FDDqwNHYRCSM0eoMheEnh+ VN4yZrMpYt2+WBGrBoPy2sPwJx9yPKdi168co5c4Js0SEugcPujGwGL3P91q1cifITFk dYMsHh8WNGO3UXFBN+xD7noZqDDRRw6QurNd78Q3rzwm0RFz4NFDEqDbXdZp1GlTF2ue jbRA== X-Gm-Message-State: AOAM532SGO4CUBurhjLi5++M7+jHdu/YHxHx2pQ58yMivSADCtXTpiMc qLAyzVvIF0qsNvnV5zlrcGu7wFvYKgr9aw== X-Google-Smtp-Source: ABdhPJzr7+HkHfXYcUBAah+Burhp6afkKXykookxCMdIonn8reMbllmPBZT9DGXRbz4AgS+4r6fW0A== X-Received: by 2002:a17:90b:1994:b0:1ca:9b45:405e with SMTP id mv20-20020a17090b199400b001ca9b45405emr3861657pjb.22.1649162625300; Tue, 05 Apr 2022 05:43:45 -0700 (PDT) Received: from vihas.localhost.com ([103.85.9.59]) by smtp.gmail.com with ESMTPSA id nl17-20020a17090b385100b001c70883f6ccsm2760014pjb.36.2022.04.05.05.43.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Apr 2022 05:43:45 -0700 (PDT) From: Vihas Makwana To: Larry Finger , Phillip Potter , Greg Kroah-Hartman , Michael Straube , Dan Carpenter , Pavel Skripkin Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Vihas Makwana Subject: [PATCH 3/3] staging: r8188eu: simplify rtw_inc_and_chk_continual_urb_error Date: Tue, 5 Apr 2022 18:12:40 +0530 Message-Id: <20220405124239.3372-4-makvihas@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220405124239.3372-1-makvihas@gmail.com> References: <20220405124239.3372-1-makvihas@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The if check and variable "value" is redundant. Drop it and simplify the funciton. Signed-off-by: Vihas Makwana --- drivers/staging/r8188eu/include/usb_ops.h | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/staging/r8188eu/include/usb_ops.h b/drivers/staging/r8= 188eu/include/usb_ops.h index ddc46cb44..c5982704c 100644 --- a/drivers/staging/r8188eu/include/usb_ops.h +++ b/drivers/staging/r8188eu/include/usb_ops.h @@ -27,12 +27,7 @@ */ static inline bool rtw_inc_and_chk_continual_urb_error(struct dvobj_priv *= dvobj) { - int value =3D atomic_inc_return(&dvobj->continual_urb_error); - - if (value > MAX_CONTINUAL_URB_ERR) - return true; - - return false; + return atomic_inc_return(&dvobj->continual_urb_error) > MAX_CONTINUAL_URB= _ERR; } =20 /* --=20 2.30.2