From nobody Fri Jun 19 10:59:32 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF3E2C433EF for ; Mon, 4 Apr 2022 23:33:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231774AbiDDXfP (ORCPT ); Mon, 4 Apr 2022 19:35:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43796 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231308AbiDDXfL (ORCPT ); Mon, 4 Apr 2022 19:35:11 -0400 Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A3B952E76 for ; Mon, 4 Apr 2022 16:33:07 -0700 (PDT) Received: by mail-lj1-x22a.google.com with SMTP id bn33so14951263ljb.6 for ; Mon, 04 Apr 2022 16:33:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=DYcF2JgiKO3iyobrkCuRU5Bwnqu8GY+UYkhCntyAAkw=; b=W1gAsjOXHXd5TL2PafVBKwCAzkY5HfXPciUHtw1CalSECJqoaulG5OpfGOFU6p8NDy WyRAfCqNTNvossP5rgO2UsgamRarvNLZT5iTzFh+Yk2lgq+pO3AWFoogPTY0QXJIZht+ nWcPj56EJ/8wIcZhixgkbOh2IcPoFJDoyROWr67l5a2t1Wmqwsu4xiUbmzNr6v9k7Q1K jiL6q6HTyO+QfkeKgAUnGrUtID/t7HGLmaKMegtkckswGfLDe7qTLDDffudxsi6Y+sjD Ik3iqZXbJAAS8DSuF1v31KJmP2FzQiUS+ZJN/Otf7Tk68v0BMaGss7YgRr4x/dLdXa6p 5cdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=DYcF2JgiKO3iyobrkCuRU5Bwnqu8GY+UYkhCntyAAkw=; b=jDFF12RFgUOWTvg2SCDtinvI0ISMJ6h+E8e8zLxF+FCYu+QfHtQ5BPF/4qc5GbY014 C0LfGaTTvJYIvJQ50XcK/KWJUPrVa+Ol0zrvD+KMwc8lqEYjpa2BmerOk8bXg29tXl9S kUdViMmJAllknRs3novncoIIRfo8kSYDiO8QP6IpGfMZGaA1QSyAtaqr9aQpHNCS9rlF FQbm3AdgcRZuEz+fEjZvyfz9GlXV/isNW4eTe6OPL3pWI5sWFmZqknxazCE/ApyjLNsa ImG6w31hM0kA1Nze9WEqkAt1PDh4k/MBYaxJeXFMZ5zq2PWOnuka4tQjpMY/LDx9j/YU Hieg== X-Gm-Message-State: AOAM532DnW+foOnvMzUqZCPLtNGS89C+aV9ywyHPhOiqYeyfpPd7ynej 2owqlK+U+LuPT2Qz8+OhcY8= X-Google-Smtp-Source: ABdhPJwRP8euVP8PJVykYTC47Km7db9gS6a+mK1PxM84xFd0Qefdqyn7QAmC+Mm+J/tUMjvzOrUWvg== X-Received: by 2002:a2e:9d91:0:b0:24b:a3:d784 with SMTP id c17-20020a2e9d91000000b0024b00a3d784mr292752ljj.461.1649115185641; Mon, 04 Apr 2022 16:33:05 -0700 (PDT) Received: from noname.. ([2a02:2698:8c2a:1093:6d9:f5ff:fecb:a8ab]) by smtp.googlemail.com with ESMTPSA id e11-20020a2e984b000000b00249b8b68f61sm1196639ljj.74.2022.04.04.16.33.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Apr 2022 16:33:05 -0700 (PDT) From: Grigory Vasilyev To: Rodrigo Siqueira , Melissa Wen Cc: Grigory Vasilyev , Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , "Pan, Xinhui" , David Airlie , Daniel Vetter , Harry Wentland , Claudio Suarez , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/amdgpu: Junk code Date: Tue, 5 Apr 2022 02:33:04 +0300 Message-Id: <20220404233306.2207-1-h0tc0d3@gmail.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Variable igp_lane_info always is 0. 0 & any value =3D 0 and false. In this way, all =D1=81onditional statements will false. Therefore, it is not clear what this code does. Signed-off-by: Grigory Vasilyev --- .../gpu/drm/amd/amdgpu/atombios_encoders.c | 21 ------------------- 1 file changed, 21 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/atombios_encoders.c b/drivers/gpu/d= rm/amd/amdgpu/atombios_encoders.c index 2b0cc793291c..100bad2f5901 100644 --- a/drivers/gpu/drm/amd/amdgpu/atombios_encoders.c +++ b/drivers/gpu/drm/amd/amdgpu/atombios_encoders.c @@ -769,7 +769,6 @@ amdgpu_atombios_encoder_setup_dig_transmitter(struct dr= m_encoder *encoder, int a int dp_clock =3D 0; int dp_lane_count =3D 0; int connector_object_id =3D 0; - int igp_lane_info =3D 0; int dig_encoder =3D dig->dig_encoder; int hpd_id =3D AMDGPU_HPD_NONE; =20 @@ -852,26 +851,6 @@ amdgpu_atombios_encoder_setup_dig_transmitter(struct d= rm_encoder *encoder, int a else args.v1.ucConfig |=3D ATOM_TRANSMITTER_CONFIG_DIG1_ENCODER; =20 - if ((adev->flags & AMD_IS_APU) && - (amdgpu_encoder->encoder_id =3D=3D ENCODER_OBJECT_ID_INTERNAL_UNIPH= Y)) { - if (is_dp || - !amdgpu_dig_monitor_is_duallink(encoder, amdgpu_encoder->pixel_clo= ck)) { - if (igp_lane_info & 0x1) - args.v1.ucConfig |=3D ATOM_TRANSMITTER_CONFIG_LANE_0_3; - else if (igp_lane_info & 0x2) - args.v1.ucConfig |=3D ATOM_TRANSMITTER_CONFIG_LANE_4_7; - else if (igp_lane_info & 0x4) - args.v1.ucConfig |=3D ATOM_TRANSMITTER_CONFIG_LANE_8_11; - else if (igp_lane_info & 0x8) - args.v1.ucConfig |=3D ATOM_TRANSMITTER_CONFIG_LANE_12_15; - } else { - if (igp_lane_info & 0x3) - args.v1.ucConfig |=3D ATOM_TRANSMITTER_CONFIG_LANE_0_7; - else if (igp_lane_info & 0xc) - args.v1.ucConfig |=3D ATOM_TRANSMITTER_CONFIG_LANE_8_15; - } - } - if (dig->linkb) args.v1.ucConfig |=3D ATOM_TRANSMITTER_CONFIG_LINKB; else --=20 2.35.1