From nobody Fri Jun 19 13:36:41 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08FFFC433F5 for ; Mon, 4 Apr 2022 10:24:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357585AbiDDK0h (ORCPT ); Mon, 4 Apr 2022 06:26:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54544 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237925AbiDDK0e (ORCPT ); Mon, 4 Apr 2022 06:26:34 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 488783C71E for ; Mon, 4 Apr 2022 03:24:37 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CF55E1FB; Mon, 4 Apr 2022 03:24:36 -0700 (PDT) Received: from usa.arm.com (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id ECE1B3F718; Mon, 4 Apr 2022 03:24:35 -0700 (PDT) From: Sudeep Holla To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Sudeep Holla , Etienne Carriere , Cristian Marussi , kernel test robot Subject: [PATCH] firmware: arm_scmi: Fix sparse warnings in OPTEE transport driver Date: Mon, 4 Apr 2022 11:24:19 +0100 Message-Id: <20220404102419.1159705-1-sudeep.holla@arm.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The sparse checker complains about converting pointers between address spaces. We correctly stored an __iomem pointer in struct scmi_optee_channe= l, but discarded the __iomem when returning it from get_channel_shm, causing o= ne warning. Then we passed the non-__iomem pointer return from get_channel_shm at tow other places, where an __iomem pointer is expected, causing couple of other warnings Add the appropriate __iomem annotations at all places where it is missing. optee.c:414:20: warning: incorrect type in return expression (different add= ress spaces) optee.c:414:20: expected struct scmi_shared_mem * optee.c:414:20: got struct scmi_shared_mem [noderef] __iomem *shmem optee.c:426:26: warning: incorrect type in argument 1 (different address sp= aces) optee.c:426:26: expected struct scmi_shared_mem [noderef] __iomem *shmem optee.c:426:26: got struct scmi_shared_mem *shmem optee.c:441:30: warning: incorrect type in argument 1 (different address sp= aces) optee.c:441:30: expected struct scmi_shared_mem [noderef] __iomem *shmem optee.c:441:30: got struct scmi_shared_mem *shmem Cc: Etienne Carriere Cc: Cristian Marussi Reported-by: kernel test robot Signed-off-by: Sudeep Holla --- drivers/firmware/arm_scmi/optee.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/firmware/arm_scmi/optee.c b/drivers/firmware/arm_scmi/= optee.c index 734f1eeee161..8302a2b4aeeb 100644 --- a/drivers/firmware/arm_scmi/optee.c +++ b/drivers/firmware/arm_scmi/optee.c @@ -405,8 +405,8 @@ static int scmi_optee_chan_free(int id, void *p, void *= data) return 0; } =20 -static struct scmi_shared_mem *get_channel_shm(struct scmi_optee_channel *= chan, - struct scmi_xfer *xfer) +static struct scmi_shared_mem __iomem * +get_channel_shm(struct scmi_optee_channel *chan, struct scmi_xfer *xfer) { if (!chan) return NULL; @@ -419,7 +419,7 @@ static int scmi_optee_send_message(struct scmi_chan_inf= o *cinfo, struct scmi_xfer *xfer) { struct scmi_optee_channel *channel =3D cinfo->transport_info; - struct scmi_shared_mem *shmem =3D get_channel_shm(channel, xfer); + struct scmi_shared_mem __iomem *shmem =3D get_channel_shm(channel, xfer); int ret; =20 mutex_lock(&channel->mu); @@ -436,7 +436,7 @@ static void scmi_optee_fetch_response(struct scmi_chan_= info *cinfo, struct scmi_xfer *xfer) { struct scmi_optee_channel *channel =3D cinfo->transport_info; - struct scmi_shared_mem *shmem =3D get_channel_shm(channel, xfer); + struct scmi_shared_mem __iomem *shmem =3D get_channel_shm(channel, xfer); =20 shmem_fetch_response(shmem, xfer); } --=20 2.35.1