From nobody Fri Jun 19 13:38:22 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AF79C433F5 for ; Mon, 4 Apr 2022 10:17:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356859AbiDDKTd (ORCPT ); Mon, 4 Apr 2022 06:19:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355864AbiDDKT0 (ORCPT ); Mon, 4 Apr 2022 06:19:26 -0400 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 011833C4BE for ; Mon, 4 Apr 2022 03:17:30 -0700 (PDT) Received: by mail-wm1-x335.google.com with SMTP id m67-20020a1ca346000000b0038e6a1b218aso2798640wme.2 for ; Mon, 04 Apr 2022 03:17:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=mV7mVvkcvKrPA0nn13aopStte01CanOqiAL16eKUA4c=; b=eEiQ9s7qF5YibTbUKy/MVO17ih75uJER5OLQvBIh6WkCZ2Hx/XfTfJuH1uLw0ZeP6D e6SVJ0LOkBmnnGUY93BC+YbDeYoX0jW//xcs2LH5PmK6WbU/0lPgldozbDRNUOk2ktGb f9Am9EXbBh6lRpYkH0dEh0qlcMnw4HBoC5GnHus95ryzA5rDzBf3CfSu0cT52ZCVUWax 1o4seEMxji+2rfIxG4XnBnLTc9EObblT+Tv2n9uSMmja7Ke18Td8SHlNktbx/87JB0bH XnHHezJjr0FosaYvR1iltDwd6dOxvgXuAGVMw1pk8mhVERnxZu85g7WCA3PT5jcOYEwV lmCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=mV7mVvkcvKrPA0nn13aopStte01CanOqiAL16eKUA4c=; b=nLSGeDXlcx70GS8xybH0XMbMc6bqiChZap253+wiJ07wa5eHsPcMte/aSMaIHDQkgq jyO3Wd3W1S7hY6a3SiaabshcedxwLjOen2/oJ14+cQbOOLUuYo0jycYLvFz7kdlU/8u6 CyBnd/rgstfk0HAji225YWaBqdbIshgTOqpMsWIFvQI/HKdH3/qm0JMTLCy4WvrJjprP 5ahKIOcMY14RxpKMrQOD8aJVQDfWAYPDiv8047JSPgcu7M5do/nCKkW4MTebpIiKmvwp o/OKqIReJRjE37iaKaX3aw/4ivI7ByK/QrtDNxIrgJGaidA3KH5HSXpj/LdPrYALbg8P 413w== X-Gm-Message-State: AOAM5327z/wZ8AhIfa1/A9sNZ2oUlh2unSqgJKDB/s7jqoSK9vHWJTYa 8IUW3WcQq/OUA/8eRD/OTKgf5zoxBUwRHA== X-Google-Smtp-Source: ABdhPJw8n1n3hIBtLNlfwBGHTZN5ZaCMscFe3FPS7MSQV/nHtjlHlvBw+V2b52iPVvUrCGulTok9kw== X-Received: by 2002:a1c:3587:0:b0:381:50ff:cbd with SMTP id c129-20020a1c3587000000b0038150ff0cbdmr18745633wma.140.1649067449315; Mon, 04 Apr 2022 03:17:29 -0700 (PDT) Received: from lmecxl0524.lme.st.com ([2a04:cec0:10db:48f5:91f6:e01:f00:f0cd]) by smtp.gmail.com with ESMTPSA id q17-20020adff951000000b00205c1b97ac4sm8919255wrr.20.2022.04.04.03.17.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Apr 2022 03:17:28 -0700 (PDT) From: Etienne Carriere To: linux-kernel@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, Sudeep Holla , Cristian Marussi , Etienne Carriere Subject: [PATCH] firmware: arm_scmi: fix incorrect type in optee transport Date: Mon, 4 Apr 2022 12:17:22 +0200 Message-Id: <20220404101722.27986-1-etienne.carriere@linaro.org> X-Mailer: git-send-email 2.17.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Correct struct scmi_shared_mem references that should have __iomem attribute. The issue was reported by kernel test robot: drivers/firmware/arm_scmi/optee.c:428:20: sparse: sparse: incorrect type in= return expression (different address spaces) @@ expected struct scmi_s= hared_mem * @@ got struct scmi_shared_mem [noderef] __iomem *shmem @@ drivers/firmware/arm_scmi/optee.c:440:26: sparse: sparse: incorrect type in= argument 1 (different address spaces) @@ expected struct scmi_shared_m= em [noderef] __iomem *shmem @@ got struct scmi_shared_mem *shmem @@ Reported-by: kernel test robot Signed-off-by: Etienne Carriere --- drivers/firmware/arm_scmi/optee.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/firmware/arm_scmi/optee.c b/drivers/firmware/arm_scmi/= optee.c index 734f1eeee161..bcab9ff73103 100644 --- a/drivers/firmware/arm_scmi/optee.c +++ b/drivers/firmware/arm_scmi/optee.c @@ -405,8 +405,8 @@ static int scmi_optee_chan_free(int id, void *p, void *= data) return 0; } =20 -static struct scmi_shared_mem *get_channel_shm(struct scmi_optee_channel *= chan, - struct scmi_xfer *xfer) +static struct scmi_shared_mem __iomem *get_channel_shm(struct scmi_optee_c= hannel *chan, + struct scmi_xfer *xfer) { if (!chan) return NULL; @@ -419,7 +419,7 @@ static int scmi_optee_send_message(struct scmi_chan_inf= o *cinfo, struct scmi_xfer *xfer) { struct scmi_optee_channel *channel =3D cinfo->transport_info; - struct scmi_shared_mem *shmem =3D get_channel_shm(channel, xfer); + struct scmi_shared_mem __iomem *shmem =3D get_channel_shm(channel, xfer); int ret; =20 mutex_lock(&channel->mu); @@ -436,7 +436,7 @@ static void scmi_optee_fetch_response(struct scmi_chan_= info *cinfo, struct scmi_xfer *xfer) { struct scmi_optee_channel *channel =3D cinfo->transport_info; - struct scmi_shared_mem *shmem =3D get_channel_shm(channel, xfer); + struct scmi_shared_mem __iomem *shmem =3D get_channel_shm(channel, xfer); =20 shmem_fetch_response(shmem, xfer); } --=20 2.17.1