From nobody Fri Jun 19 13:24:31 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DC7CC433F5 for ; Mon, 4 Apr 2022 08:21:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348757AbiDDIXq (ORCPT ); Mon, 4 Apr 2022 04:23:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245400AbiDDIXo (ORCPT ); Mon, 4 Apr 2022 04:23:44 -0400 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AAFD83B3F5 for ; Mon, 4 Apr 2022 01:21:48 -0700 (PDT) Received: by mail-ej1-x62e.google.com with SMTP id r13so18230084ejd.5 for ; Mon, 04 Apr 2022 01:21:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jX6tr4s5zNKGS53pIVnQhyNOwLeKDR+GeeFQvf7Au+o=; b=mWS21PoX6y9UlgHUcVRBpDl2E5Y3z9dxssg3gEOcujRzixIiezjGZ9Kcu6rimu1ec2 UCmJ1IvrDfVhFIWgpt4tfw/8hWdnj+cXuNN4LNqcmt2hP5qqYW1xwK6dSRyEv3suiDiP OVTdWfc0ZE5+Yir8uRtCE9NqgomodNFt9HGU9K2xu2nNXMhde1QA9wKNmCE6XD3BMR3U Z9r75G3ambOkKC+8AOBDZA7ucJYjeYaQeduErtkmiir3Sf0sfkJqQKrFJ4tO+KK7uPom h848qTOUAE0Chhd7BF8sEVnU6jHMHAj4qMtMhn28Gfh5sATq+blZv4/s+P5yhklW0HVz 1BzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jX6tr4s5zNKGS53pIVnQhyNOwLeKDR+GeeFQvf7Au+o=; b=zxwNhSoDgXpZ1gd++YlDEEJIFx9bke/u91fYzy3tbscxdS158eyGF5bIqn66MeVeMZ 5/j2vPp8Z5oC/LmUhpgQycEoD3zAD2C6CiqBF8cWMKEcKkqD+OkJffHxjQgDXk/3mFvW ZBXNBNLOaH5vEyF4SjC2IFvdUAcVNTM2i9wjLVg7lFywaRo3KPlxhG+Kh0eAUFOSG7n6 zwU9/dyC1/W48WVKAVzh4+ct7qcNdwNoOXPaFaXNTQi82nHibJU2Oqep5S8Z1pG3+b/H JSGWAWwqFr4lfd3DLCyAUvZtHv5uVn8FVy8CWnTm770Ndu2eeFMZF4nqYyadym14Gsak zEzg== X-Gm-Message-State: AOAM532TeGgNKtza5bsIkdrWPRFR7KskOoLP+dG5MW/y4TGYYWhlsjnC /0O3150P9TGe8WfoYsZx4otNZ+ts56c= X-Google-Smtp-Source: ABdhPJxHJzdAUxF3gKV/nKbz79ohy+RLGfDCYPPdkrjcA5TMxYDm5niRhvzyhjI3M5flvDcnTOSGVA== X-Received: by 2002:a17:907:c16:b0:6db:682:c8c9 with SMTP id ga22-20020a1709070c1600b006db0682c8c9mr9934011ejc.153.1649060507288; Mon, 04 Apr 2022 01:21:47 -0700 (PDT) Received: from localhost.localdomain (ip5f5abb55.dynamic.kabel-deutschland.de. [95.90.187.85]) by smtp.gmail.com with ESMTPSA id n3-20020a1709061d0300b006da94efcc7esm4047336ejh.204.2022.04.04.01.21.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Apr 2022 01:21:46 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 1/5] staging: r8188eu: remove unused fields from struct pwrctrl_priv Date: Mon, 4 Apr 2022 10:21:38 +0200 Message-Id: <20220404082142.4639-2-straube.linux@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220404082142.4639-1-straube.linux@gmail.com> References: <20220404082142.4639-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" There are some unused fields in the pwrctrl_priv structure. Remove them. Signed-off-by: Michael Straube --- drivers/staging/r8188eu/include/rtw_pwrctrl.h | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/staging/r8188eu/include/rtw_pwrctrl.h b/drivers/stagin= g/r8188eu/include/rtw_pwrctrl.h index 4cc365aa3fa7..b0d48106fe56 100644 --- a/drivers/staging/r8188eu/include/rtw_pwrctrl.h +++ b/drivers/staging/r8188eu/include/rtw_pwrctrl.h @@ -47,16 +47,10 @@ struct pwrctrl_priv { u8 smart_ps; u8 bcn_ant_mode; =20 - u32 alives; - struct work_struct cpwm_event; bool bpower_saving; =20 u8 reg_rfoff; - u8 reg_pdnmode; /* powerdown mode */ =20 - /* RF OFF Level */ - u32 cur_ps_level; - u32 reg_rfps_level; uint ips_enter_cnts; uint ips_leave_cnts; =20 @@ -72,7 +66,6 @@ struct pwrctrl_priv { u8 power_mgnt; u8 bFwCurrentInPSMode; u32 DelayLPSLastTimeStamp; - s32 pnp_current_pwr_state; u8 pnp_bstop_trx; =20 u8 bInSuspend; @@ -86,7 +79,6 @@ struct pwrctrl_priv { enum rt_rf_power_state rf_pwrstate;/* cur power state */ enum rt_rf_power_state change_rfpwrstate; =20 - u8 wepkeymask; u8 bkeepfwalive; }; =20 --=20 2.35.1 From nobody Fri Jun 19 13:24:31 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCFB9C433EF for ; Mon, 4 Apr 2022 08:21:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351531AbiDDIXt (ORCPT ); Mon, 4 Apr 2022 04:23:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346885AbiDDIXo (ORCPT ); Mon, 4 Apr 2022 04:23:44 -0400 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D0AB3B3EF for ; Mon, 4 Apr 2022 01:21:49 -0700 (PDT) Received: by mail-ed1-x52b.google.com with SMTP id q26so2452066edc.7 for ; Mon, 04 Apr 2022 01:21:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rPYO2pNz1/bQYKjtDRXcH0Ioe3wPwK7iSBX0zehzbLA=; b=bW+zOzhElyJjyfZ1pCtxqO+5Rxzf71rGe6k+bvGlQw/+vog2QsXeE0jO71lEN2ZPD9 NXMw0+4wwcl1726YfkVv/yAyLNHhG6SmZlbej41yuAP4QSuktnxwZyiahDXTXfDJKnpN 3/8a8Lu1SYTahPOSi788Pw8lmFh04Nzd+IsdlQ0FzCiBW2VKSSJd6B9M/qsU3+BLzGVN BVlHSlAx5BDrd9kMN69qUdvFCNJQtWr89o05UsNrMIk6mqJvPp8sJm6E9Oaq6ThONREc kVOFnYn23Ct2nhHqqSBPQ7vUUq8OrtiGrx79Tk1iIqCV6Yu1aIEZD4kTcIR1jjemLHRn P1Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rPYO2pNz1/bQYKjtDRXcH0Ioe3wPwK7iSBX0zehzbLA=; b=r6VCbf6F61CUCfyc9bCU6FvgdWmr/DcXdSFDf5i1sIenfZV3Gtbmc4kW2f0fV97uwu RuW9+RfIO1R/aKrrTR2p5mUDbC5HurV1BZtBhvsMe89MHbDo2JFqPShCdS3SJ9bU1XuS FOHrSGRI7OqPlOcRgLXW7tqVNhv4znYy/XHkpmy9HHVDLOCmSLx8vTuYlDHGDo8Ri+8U 52lUlzCXAjiOLFcs+MIrj30Zk1M1HC6Fd1u4me1QJDC5ezuXO3rmddEJvh1Y/bdFQ+mA 2qMQ3oxRkivEKYIMNrBKdTxT+upczJJ+No0XEqXIIufSzsbds8WqlEJo4uE6YGD8KPYQ VRVg== X-Gm-Message-State: AOAM532+/1Mgd4yJOmTzCoW/bXyxT1Ru0gfEP/6LqNwrYhzod7hTtTvi ur5XXWqVDCUeIXw/Jt9hQb/v0sE+NSU= X-Google-Smtp-Source: ABdhPJxjBWCVSr/nrkBPG4q1VP7TIbF432eF+5z2b2SNwo8uaHyxyRcy8peP+Wp4Nz3NPMF2YbhVRw== X-Received: by 2002:aa7:d495:0:b0:41c:c46a:550f with SMTP id b21-20020aa7d495000000b0041cc46a550fmr4713672edr.305.1649060507963; Mon, 04 Apr 2022 01:21:47 -0700 (PDT) Received: from localhost.localdomain (ip5f5abb55.dynamic.kabel-deutschland.de. [95.90.187.85]) by smtp.gmail.com with ESMTPSA id n3-20020a1709061d0300b006da94efcc7esm4047336ejh.204.2022.04.04.01.21.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Apr 2022 01:21:47 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 2/5] staging: r8188eu: reg_rfoff is never set Date: Mon, 4 Apr 2022 10:21:39 +0200 Message-Id: <20220404082142.4639-3-straube.linux@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220404082142.4639-1-straube.linux@gmail.com> References: <20220404082142.4639-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The field reg_rfoff in struct pwrctrl_priv is never set. It stays at its default value 0. Remove it and remove related dead code. Signed-off-by: Michael Straube --- drivers/staging/r8188eu/hal/usb_halinit.c | 4 ---- drivers/staging/r8188eu/include/rtw_pwrctrl.h | 2 -- 2 files changed, 6 deletions(-) diff --git a/drivers/staging/r8188eu/hal/usb_halinit.c b/drivers/staging/r8= 188eu/hal/usb_halinit.c index 4bc6b08fb282..21ab6881796e 100644 --- a/drivers/staging/r8188eu/hal/usb_halinit.c +++ b/drivers/staging/r8188eu/hal/usb_halinit.c @@ -539,10 +539,6 @@ u32 rtl8188eu_hal_init(struct adapter *Adapter) /* Save target channel */ haldata->CurrentChannel =3D 6;/* default set to 6 */ =20 - if (pwrctrlpriv->reg_rfoff) { - pwrctrlpriv->rf_pwrstate =3D rf_off; - } - /* 2010/08/09 MH We need to check if we need to turnon or off RF after d= etecting */ /* HW GPIO pin. Before PHY_RFConfig8192C. */ /* 2010/08/26 MH If Efuse does not support sective suspend then disable = the function. */ diff --git a/drivers/staging/r8188eu/include/rtw_pwrctrl.h b/drivers/stagin= g/r8188eu/include/rtw_pwrctrl.h index b0d48106fe56..3efcc65b2f6e 100644 --- a/drivers/staging/r8188eu/include/rtw_pwrctrl.h +++ b/drivers/staging/r8188eu/include/rtw_pwrctrl.h @@ -49,8 +49,6 @@ struct pwrctrl_priv { =20 bool bpower_saving; =20 - u8 reg_rfoff; - uint ips_enter_cnts; uint ips_leave_cnts; =20 --=20 2.35.1 From nobody Fri Jun 19 13:24:31 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E64DBC433EF for ; Mon, 4 Apr 2022 08:22:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353730AbiDDIX4 (ORCPT ); Mon, 4 Apr 2022 04:23:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53846 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348387AbiDDIXp (ORCPT ); Mon, 4 Apr 2022 04:23:45 -0400 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F4AC3B3F5 for ; Mon, 4 Apr 2022 01:21:50 -0700 (PDT) Received: by mail-ej1-x62e.google.com with SMTP id yy13so18274459ejb.2 for ; Mon, 04 Apr 2022 01:21:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xwsH1XHMhYpHAHuQYTzJcbJHbl5Y3E62Se4odAiOvro=; b=hcw7OiTZegjMnjMYOc3Mf29TNrKx3WvEthqQm+u5PwM2QoI6gw3bDB7EgjauRW9bXp 5E7SGUiqsm/80TQPDyWKtMPvaO1pNHMR8j/vUADxtlbRGe8jc4X5//LEq/qL6myYrbVH vbaGsw9uKaaDGN0tM0YrXnxEFr/OdBrq9yyxVn9DgZyZGmbEyFo3SVBPHb+nFzuOdANi 1eW9yHCMqawuSShT09VcCegPYwGbkNTDxA+DcjCPY+Z0WG9CsR/RBc7uXQjM2BjW07Fp AnBJP8plRqwr8wNiXG5xnkvYtJG8jE1kqrQsIaJhXdg2XzkxZGk6v+0/08ptfdz3Qxms YUdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xwsH1XHMhYpHAHuQYTzJcbJHbl5Y3E62Se4odAiOvro=; b=DzJegehb9uefLcoYM+AG9d1Mx1qM949ba7CodNoLTx4QPrPmifinuwLE0usqlGSLZ0 FsVZTPoW0hHdkmLssAcPzZKzgmqTr2X2zgRAWdSlfRc76VA3+HtRCnRdrJk8YMQMMZHK JEB4qeqOGfSkII8NNlROoFusuc4x/43yd40mpqoqbDwxe7milqV8pwiY63UaF6YKvchc rR6zLVcrmYyfVHi3OgILq/wfr7jDU4/bTja4NNJgsSuhdKr7dNxCLQv8GFZuJLRbVPEV lybavkDfpznSYalO/XiOjVPQjPmd2TDSYeGV4vxmQfUs6eCOJBdoPSk2RqvfjNPwTGnN lbew== X-Gm-Message-State: AOAM533mzN2lVv38GK2iaM6y/o7koMfMdc5FuQE+iMimwXc3K9OSDn8M W8SM2zrl8qVMOz8IqiTqQr8= X-Google-Smtp-Source: ABdhPJwzrg6vSJfu2vqfp9sme37FQrq1ZQPDetPp5e6ytHFpurajaA91xJ/Srr+MycaqokQkem0SGg== X-Received: by 2002:a17:907:6da1:b0:6e7:efbe:d217 with SMTP id sb33-20020a1709076da100b006e7efbed217mr3381401ejc.119.1649060508614; Mon, 04 Apr 2022 01:21:48 -0700 (PDT) Received: from localhost.localdomain (ip5f5abb55.dynamic.kabel-deutschland.de. [95.90.187.85]) by smtp.gmail.com with ESMTPSA id n3-20020a1709061d0300b006da94efcc7esm4047336ejh.204.2022.04.04.01.21.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Apr 2022 01:21:48 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 3/5] staging: r8188eu: pnp_bstop_trx is never set Date: Mon, 4 Apr 2022 10:21:40 +0200 Message-Id: <20220404082142.4639-4-straube.linux@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220404082142.4639-1-straube.linux@gmail.com> References: <20220404082142.4639-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The field pnp_bstop_trx in struct pwrctrl_priv is never set. It stays at its default value 0. Remove it and remove related dead code. Signed-off-by: Michael Straube --- drivers/staging/r8188eu/hal/usb_ops_linux.c | 7 +++---- drivers/staging/r8188eu/include/rtw_pwrctrl.h | 1 - drivers/staging/r8188eu/os_dep/usb_ops_linux.c | 3 +-- 3 files changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/staging/r8188eu/hal/usb_ops_linux.c b/drivers/staging/= r8188eu/hal/usb_ops_linux.c index e5d6cd6228f2..6a65dcf57112 100644 --- a/drivers/staging/r8188eu/hal/usb_ops_linux.c +++ b/drivers/staging/r8188eu/hal/usb_ops_linux.c @@ -16,7 +16,7 @@ static int usb_read(struct intf_hdl *intf, u16 value, voi= d *data, u8 size) int status; u8 io_buf[4]; =20 - if (adapt->bSurpriseRemoved || adapt->pwrctrlpriv.pnp_bstop_trx) + if (adapt->bSurpriseRemoved) return -EPERM; =20 status =3D usb_control_msg_recv(udev, 0, REALTEK_USB_VENQT_CMD_REQ, @@ -59,7 +59,7 @@ static int usb_write(struct intf_hdl *intf, u16 value, vo= id *data, u8 size) int status; u8 io_buf[VENDOR_CMD_MAX_DATA_LEN]; =20 - if (adapt->bSurpriseRemoved || adapt->pwrctrlpriv.pnp_bstop_trx) + if (adapt->bSurpriseRemoved) return -EPERM; =20 memcpy(io_buf, data, size); @@ -414,8 +414,7 @@ u32 rtw_read_port(struct adapter *adapter, u8 *rmem) size_t alignment =3D 0; u32 ret =3D _SUCCESS; =20 - if (adapter->bDriverStopped || adapter->bSurpriseRemoved || - adapter->pwrctrlpriv.pnp_bstop_trx) + if (adapter->bDriverStopped || adapter->bSurpriseRemoved) return _FAIL; =20 if (!precvbuf) diff --git a/drivers/staging/r8188eu/include/rtw_pwrctrl.h b/drivers/stagin= g/r8188eu/include/rtw_pwrctrl.h index 3efcc65b2f6e..94a65056a77e 100644 --- a/drivers/staging/r8188eu/include/rtw_pwrctrl.h +++ b/drivers/staging/r8188eu/include/rtw_pwrctrl.h @@ -64,7 +64,6 @@ struct pwrctrl_priv { u8 power_mgnt; u8 bFwCurrentInPSMode; u32 DelayLPSLastTimeStamp; - u8 pnp_bstop_trx; =20 u8 bInSuspend; u8 bSupportRemoteWakeup; diff --git a/drivers/staging/r8188eu/os_dep/usb_ops_linux.c b/drivers/stagi= ng/r8188eu/os_dep/usb_ops_linux.c index c4b6dbc8d66d..8ca16861bfcc 100644 --- a/drivers/staging/r8188eu/os_dep/usb_ops_linux.c +++ b/drivers/staging/r8188eu/os_dep/usb_ops_linux.c @@ -106,8 +106,7 @@ u32 rtw_write_port(struct adapter *padapter, u32 addr, = u32 cnt, u8 *wmem) struct xmit_frame *pxmitframe =3D (struct xmit_frame *)pxmitbuf->priv_dat= a; struct usb_device *pusbd =3D pdvobj->pusbdev; =20 - if ((padapter->bDriverStopped) || (padapter->bSurpriseRemoved) || - (padapter->pwrctrlpriv.pnp_bstop_trx)) { + if (padapter->bDriverStopped || padapter->bSurpriseRemoved) { rtw_sctx_done_err(&pxmitbuf->sctx, RTW_SCTX_DONE_TX_DENY); goto exit; } --=20 2.35.1 From nobody Fri Jun 19 13:24:31 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32D25C433F5 for ; Mon, 4 Apr 2022 08:22:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353709AbiDDIXy (ORCPT ); Mon, 4 Apr 2022 04:23:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349065AbiDDIXq (ORCPT ); Mon, 4 Apr 2022 04:23:46 -0400 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E29C43B3FC for ; Mon, 4 Apr 2022 01:21:50 -0700 (PDT) Received: by mail-ed1-x529.google.com with SMTP id r10so4354749eda.1 for ; Mon, 04 Apr 2022 01:21:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=eYi42idZagF7+PntnhrV7u1NVJ1zH5gAAuFaLqoUChg=; b=JjsmMULs94skPzT6xphNvB4kqywkZnL72/HghLakTvfFcbUjYvX0Z4O/7mNIZGfWEw ONrgKXfIvNmc81bgyIfTtuNsLlaOHKLs/xkV7+5/yyJRRXc0Dzno3BX+au9N1Y0Vd7L1 1VHqTMV7EgKErFvvwhs532WZtJCMETyv1yJTHhxE9kx9XhOOBhBFq9Jn2C+dd0nu+h88 VhPfT4LdevaT3mqECsz+X/O0uEAimqT3tC/92w9eGHao4Nn25aO20OACQ/hiXIl8kdz2 UkF/mOr/KxuZUY7CiOlhF1CtDACs3O5qoUcDgG3cVBmBUFDj/29QoyQQQFY8GAGwxnyx bV8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=eYi42idZagF7+PntnhrV7u1NVJ1zH5gAAuFaLqoUChg=; b=T6OZz0NFZZOL//shYgSVGY/OMsSVsFdUt1ABmCm9xm/MgOiQIm63B1DWSGJzkdykI5 dKvavQbItItlAeQ8BsjT56KmlmA0wuMkzxYfAgIdRPPwH1uDwqqQo9OEeQBY8YLfHV26 Vf/dyvv0dEVsdkYf9vI1qM/cZnwdYlhOn9YoJ9nhEA97Wh7Nxt/J9/dERd63ag883pfg M2mSxk/F25EulgssS0YvHCh9If93AuTSHgTKzufZJL/vQ6M8J9lMX4TUH3ly37G95Nmu jREZn5NXt3p6CbOIiKd6aQ67guvsPffTGsvhT0yyBfbzxnc4trJT09X6lWzoy9NDk6I4 RItg== X-Gm-Message-State: AOAM532rnAZJwfh6mG2S5c05iDRYy0sI/T+5dhsDh50Acz2MITs9LP4t unDIkiOOPEkEdu8ZoLzjVYI5GdDx1oI= X-Google-Smtp-Source: ABdhPJxNjt+nCbqV1xpIeLBTsFp/FnJSPk2UM+b7LWRvSinLDRADDXWo4LlRiMDnzweqhORcZxmCgQ== X-Received: by 2002:a50:f092:0:b0:41c:b7dd:cdb5 with SMTP id v18-20020a50f092000000b0041cb7ddcdb5mr7649642edl.225.1649060509500; Mon, 04 Apr 2022 01:21:49 -0700 (PDT) Received: from localhost.localdomain (ip5f5abb55.dynamic.kabel-deutschland.de. [95.90.187.85]) by smtp.gmail.com with ESMTPSA id n3-20020a1709061d0300b006da94efcc7esm4047336ejh.204.2022.04.04.01.21.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Apr 2022 01:21:48 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 4/5] staging: r8188eu: pwr_state_check_cnts is always zero Date: Mon, 4 Apr 2022 10:21:41 +0200 Message-Id: <20220404082142.4639-5-straube.linux@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220404082142.4639-1-straube.linux@gmail.com> References: <20220404082142.4639-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The field pwr_state_check_cnts in struct pwrctrl_priv is set to 0 and never changed. Remove it and remove related dead code. Signed-off-by: Michael Straube --- drivers/staging/r8188eu/core/rtw_pwrctrl.c | 4 +--- drivers/staging/r8188eu/include/rtw_pwrctrl.h | 1 - drivers/staging/r8188eu/os_dep/os_intfs.c | 3 --- 3 files changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_pwrctrl.c b/drivers/staging/r= 8188eu/core/rtw_pwrctrl.c index 5d468e8b4920..939909e5316f 100644 --- a/drivers/staging/r8188eu/core/rtw_pwrctrl.c +++ b/drivers/staging/r8188eu/core/rtw_pwrctrl.c @@ -133,9 +133,8 @@ void rtw_ps_processor(struct adapter *padapter) if (!rtw_pwr_unassociated_idle(padapter)) goto exit; =20 - if ((pwrpriv->rf_pwrstate =3D=3D rf_on) && ((pwrpriv->pwr_state_check_cnt= s % 4) =3D=3D 0)) { + if (pwrpriv->rf_pwrstate =3D=3D rf_on) { pwrpriv->change_rfpwrstate =3D rf_off; - ips_enter(padapter); } exit: @@ -342,7 +341,6 @@ void rtw_init_pwrctrl_priv(struct adapter *padapter) pwrctrlpriv->ips_mode_req =3D padapter->registrypriv.ips_mode; =20 pwrctrlpriv->pwr_state_check_interval =3D RTW_PWR_STATE_CHK_INTERVAL; - pwrctrlpriv->pwr_state_check_cnts =3D 0; pwrctrlpriv->bInSuspend =3D false; pwrctrlpriv->bkeepfwalive =3D false; =20 diff --git a/drivers/staging/r8188eu/include/rtw_pwrctrl.h b/drivers/stagin= g/r8188eu/include/rtw_pwrctrl.h index 94a65056a77e..162792988910 100644 --- a/drivers/staging/r8188eu/include/rtw_pwrctrl.h +++ b/drivers/staging/r8188eu/include/rtw_pwrctrl.h @@ -69,7 +69,6 @@ struct pwrctrl_priv { u8 bSupportRemoteWakeup; struct timer_list pwr_state_check_timer; int pwr_state_check_interval; - u8 pwr_state_check_cnts; =20 int ps_flag; =20 diff --git a/drivers/staging/r8188eu/os_dep/os_intfs.c b/drivers/staging/r8= 188eu/os_dep/os_intfs.c index c531504acc9e..5a9374957e3a 100644 --- a/drivers/staging/r8188eu/os_dep/os_intfs.c +++ b/drivers/staging/r8188eu/os_dep/os_intfs.c @@ -441,7 +441,6 @@ static void rtw_init_default_value(struct adapter *pada= pter) u8 rtw_reset_drv_sw(struct adapter *padapter) { struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; - struct pwrctrl_priv *pwrctrlpriv =3D &padapter->pwrctrlpriv; =20 /* hal_priv */ rtl8188eu_init_default_value(padapter); @@ -457,8 +456,6 @@ u8 rtw_reset_drv_sw(struct adapter *padapter) =20 _clr_fwstate_(pmlmepriv, _FW_UNDER_SURVEY | _FW_UNDER_LINKING); =20 - pwrctrlpriv->pwr_state_check_cnts =3D 0; - /* mlmeextpriv */ padapter->mlmeextpriv.sitesurvey_res.state =3D SCAN_DISABLE; =20 --=20 2.35.1 From nobody Fri Jun 19 13:24:31 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CB0BC433EF for ; Mon, 4 Apr 2022 08:22:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354548AbiDDIYC (ORCPT ); Mon, 4 Apr 2022 04:24:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53900 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350145AbiDDIXr (ORCPT ); Mon, 4 Apr 2022 04:23:47 -0400 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F4ED3B54E for ; Mon, 4 Apr 2022 01:21:51 -0700 (PDT) Received: by mail-ej1-x62f.google.com with SMTP id p15so18202772ejc.7 for ; Mon, 04 Apr 2022 01:21:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MrgMLReyj9DEtjJrW6Fmcw5+9Z047O6Pl7Cse8bO7II=; b=oj+4MUjPCglwkn2+ftlkh1nxFR3M6fQV8y+6gZWVeQDtMldx0xHujOc0OLXqBMGHGi DqFcePhJnD+O/LFjRUtsPXxqvjrsAlFrTA/yE/HPcDXkPsjoAf470RRz/aDcQN9Orzzl cIrZxPU1TDkt9kUVzabsZFQHrcXDKdvnVZXd0U0A/a4mxFfpoYh5hfUoUqiWL2Axrgvp XzlXRruC62m3AYYL3Mzl0hRoM4qr22X1h4YD6+gzEkXzmBuyKWGC4tpyaBthSbNHGJPi vp6YY2bMs1wE2b8E8X1FIJetlBfYgRv39VX4bG1oQ/M8HJGGx6bOdIdkB637oq1o626q /uZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=MrgMLReyj9DEtjJrW6Fmcw5+9Z047O6Pl7Cse8bO7II=; b=6tDOONOBVGWDHwgEbpXHQU+n3qURexY24TNbW1oyP17FyS5sDy/7MlrWxaAtA08oQL cxeLjju9/4I47grAbiM+93iWRoLmy5zqV2QdhYtKILRS0xXWl8o9W6OlJxxWSD1JiAjj Ym04/WZ9JBwV+wCCjNsmcbNfa3DmpLI9gneFtbRzT/mwGbpaYB/7/4MojZKYK3UUTmje em0F2PQ7TbTnt5byQVF0wtLSqyUQvipxiS/9Cpn0caZdQwqWaokfDqqGmJ143QaFdo61 +jd3nu4kUed8+scnwfXgffKpHyWxmCXupZht75yMDI5fqnmbeCiBfrDWS32qk17zl5+w +1PQ== X-Gm-Message-State: AOAM531T0e7lor92toE8evS58soHcOmqTL6eymlyUgfC9GfwdMvWuIIK h4pgUB6XEd0xuaNYB4LGTEg= X-Google-Smtp-Source: ABdhPJxb9Lsvb7g5s2goW3nmb1HVqira1y4gyyfKEOObm8coZrEzPqM6DBtofIUuu9Wzgc1pQfs2pQ== X-Received: by 2002:a17:907:8a0c:b0:6df:8b04:1a65 with SMTP id sc12-20020a1709078a0c00b006df8b041a65mr9559967ejc.331.1649060510235; Mon, 04 Apr 2022 01:21:50 -0700 (PDT) Received: from localhost.localdomain (ip5f5abb55.dynamic.kabel-deutschland.de. [95.90.187.85]) by smtp.gmail.com with ESMTPSA id n3-20020a1709061d0300b006da94efcc7esm4047336ejh.204.2022.04.04.01.21.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Apr 2022 01:21:49 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 5/5] staging: r8188eu: ps_flag is never set Date: Mon, 4 Apr 2022 10:21:42 +0200 Message-Id: <20220404082142.4639-6-straube.linux@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220404082142.4639-1-straube.linux@gmail.com> References: <20220404082142.4639-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The field ps_flag in struct pwrctrl_priv is never set. It stays at its default value 0. Remove it and remove related dead code. Signed-off-by: Michael Straube --- drivers/staging/r8188eu/include/rtw_pwrctrl.h | 2 -- drivers/staging/r8188eu/os_dep/os_intfs.c | 7 ------- 2 files changed, 9 deletions(-) diff --git a/drivers/staging/r8188eu/include/rtw_pwrctrl.h b/drivers/stagin= g/r8188eu/include/rtw_pwrctrl.h index 162792988910..1d7dba853c40 100644 --- a/drivers/staging/r8188eu/include/rtw_pwrctrl.h +++ b/drivers/staging/r8188eu/include/rtw_pwrctrl.h @@ -70,8 +70,6 @@ struct pwrctrl_priv { struct timer_list pwr_state_check_timer; int pwr_state_check_interval; =20 - int ps_flag; - enum rt_rf_power_state rf_pwrstate;/* cur power state */ enum rt_rf_power_state change_rfpwrstate; =20 diff --git a/drivers/staging/r8188eu/os_dep/os_intfs.c b/drivers/staging/r8= 188eu/os_dep/os_intfs.c index 5a9374957e3a..390d1cc0ecb0 100644 --- a/drivers/staging/r8188eu/os_dep/os_intfs.c +++ b/drivers/staging/r8188eu/os_dep/os_intfs.c @@ -625,12 +625,6 @@ int _netdev_open(struct net_device *pnetdev) { uint status; struct adapter *padapter =3D (struct adapter *)rtw_netdev_priv(pnetdev); - struct pwrctrl_priv *pwrctrlpriv =3D &padapter->pwrctrlpriv; - - if (pwrctrlpriv->ps_flag) { - padapter->net_closed =3D false; - goto netdev_open_normal_process; - } =20 if (!padapter->bup) { padapter->bDriverStopped =3D false; @@ -674,7 +668,6 @@ int _netdev_open(struct net_device *pnetdev) =20 netdev_br_init(pnetdev); =20 -netdev_open_normal_process: return 0; =20 netdev_open_error: --=20 2.35.1