From nobody Fri Jun 19 14:44:34 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9884BC433EF for ; Sat, 2 Apr 2022 15:44:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357342AbiDBPqA (ORCPT ); Sat, 2 Apr 2022 11:46:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46792 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357338AbiDBPp4 (ORCPT ); Sat, 2 Apr 2022 11:45:56 -0400 Received: from 189.cn (ptr.189.cn [183.61.185.102]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 28F0A1A83F for ; Sat, 2 Apr 2022 08:44:02 -0700 (PDT) HMM_SOURCE_IP: 10.64.8.41:52718.1890659392 HMM_ATTACHE_NUM: 0000 HMM_SOURCE_TYPE: SMTP Received: from clientip-114.242.206.180 (unknown [10.64.8.41]) by 189.cn (HERMES) with SMTP id 2FF30100207; Sat, 2 Apr 2022 23:43:59 +0800 (CST) Received: from ([172.27.8.53]) by gateway-151646-dep-b7fbf7d79-9vctg with ESMTP id 2c45fadbd282437a80b064d873909b86 for l.stach@pengutronix.de; Sat, 02 Apr 2022 23:44:01 CST X-Transaction-ID: 2c45fadbd282437a80b064d873909b86 X-Real-From: 15330273260@189.cn X-Receive-IP: 172.27.8.53 X-MEDUSA-Status: 0 Sender: 15330273260@189.cn From: Sui Jingfeng <15330273260@189.cn> To: Lucas Stach , Russell King , Christian Gmeiner , David Airlie , Daniel Vetter Cc: etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/etnaviv: introduce a function to create etnaviv platform device Date: Sat, 2 Apr 2022 23:43:58 +0800 Message-Id: <20220402154358.1708299-1-15330273260@189.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" This patch make the code more clear, call of_node_put(np) only once in for_each_compatible_node(np, NULL, "vivante,gc") loop instead of three. Signed-off-by: Sui Jingfeng <15330273260@189.cn> --- drivers/gpu/drm/etnaviv/etnaviv_drv.c | 36 +++++++++++++++++---------- 1 file changed, 23 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c b/drivers/gpu/drm/etnavi= v/etnaviv_drv.c index 0b756ecb1bc2..42cb624cf1ae 100644 --- a/drivers/gpu/drm/etnaviv/etnaviv_drv.c +++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.c @@ -659,6 +659,26 @@ static struct platform_driver etnaviv_platform_driver = =3D { =20 static struct platform_device *etnaviv_drm; =20 +static int etnaviv_create_platform_device(const char *name) +{ + struct platform_device *pdev; + int ret; + + pdev =3D platform_device_alloc(name, PLATFORM_DEVID_NONE); + if (!pdev) + return -ENOMEM; + + ret =3D platform_device_add(pdev); + if (ret) { + platform_device_put(pdev); + return ret; + } + + etnaviv_drm =3D pdev; + + return 0; +} + static int __init etnaviv_init(void) { struct platform_device *pdev; @@ -683,22 +703,12 @@ static int __init etnaviv_init(void) if (!of_device_is_available(np)) continue; =20 - pdev =3D platform_device_alloc("etnaviv", PLATFORM_DEVID_NONE); - if (!pdev) { - ret =3D -ENOMEM; - of_node_put(np); - goto unregister_platform_driver; - } + of_node_put(np); =20 - ret =3D platform_device_add(pdev); - if (ret) { - platform_device_put(pdev); - of_node_put(np); + ret =3D etnaviv_create_platform_device("etnaviv"); + if (ret) goto unregister_platform_driver; - } =20 - etnaviv_drm =3D pdev; - of_node_put(np); break; } =20 --=20 2.25.1