From nobody Sun Jun 21 10:07:20 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8993AC433FE for ; Wed, 30 Mar 2022 19:48:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239062AbiC3Tty (ORCPT ); Wed, 30 Mar 2022 15:49:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231330AbiC3Ttw (ORCPT ); Wed, 30 Mar 2022 15:49:52 -0400 X-Greylist: delayed 316 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Wed, 30 Mar 2022 12:48:07 PDT Received: from postfix02.core.dcmtl.stgraber.net (postfix02.core.dcmtl.stgraber.net [IPv6:2602:fc62:a:1002:216:3eff:fe9a:b0f9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2356549FAB; Wed, 30 Mar 2022 12:48:06 -0700 (PDT) Received: from dakara.stgraber.net (unknown [IPv6:2602:fc62:b:1000:5436:5b25:64e4:d81a]) by postfix02.core.dcmtl.stgraber.net (Postfix) with ESMTP id 4D45020107; Wed, 30 Mar 2022 19:42:48 +0000 (UTC) From: =?UTF-8?q?St=C3=A9phane=20Graber?= To: netdev@vger.kernel.org Cc: Pravin B Shelar , "David S. Miller" , Jakub Kicinski , Paolo Abeni , dev@openvswitch.org, linux-kernel@vger.kernel.org, =?UTF-8?q?St=C3=A9phane=20Graber?= , Frode Nordahl Subject: [PATCH] openvswitch: Add recirc_id to recirc warning Date: Wed, 30 Mar 2022 15:42:45 -0400 Message-Id: <20220330194244.3476544-1-stgraber@ubuntu.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When hitting the recirculation limit, the kernel would currently log something like this: [ 58.586597] openvswitch: ovs-system: deferred action limit reached, drop= recirc action Which isn't all that useful to debug as we only have the interface name to go on but can't track it down to a specific flow. With this change, we now instead get: [ 58.586597] openvswitch: ovs-system: deferred action limit reached, drop= recirc action (recirc_id=3D0x9e) Which can now be correlated with the flow entries from OVS. Suggested-by: Frode Nordahl Signed-off-by: St=C3=A9phane Graber Tested-by: Stephane Graber Acked-by: Eelco Chaudron --- net/openvswitch/actions.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/openvswitch/actions.c b/net/openvswitch/actions.c index 780d9e2246f3..7056cb1b8ba0 100644 --- a/net/openvswitch/actions.c +++ b/net/openvswitch/actions.c @@ -1539,8 +1539,8 @@ static int clone_execute(struct datapath *dp, struct = sk_buff *skb, pr_warn("%s: deferred action limit reached, drop sample action\n", ovs_dp_name(dp)); } else { /* Recirc action */ - pr_warn("%s: deferred action limit reached, drop recirc action\n", - ovs_dp_name(dp)); + pr_warn("%s: deferred action limit reached, drop recirc action (recirc= _id=3D%#x)\n", + ovs_dp_name(dp), recirc_id); } } } --=20 2.34.1