From nobody Fri Jun 19 20:14:40 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D554C43217 for ; Wed, 30 Mar 2022 19:58:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231558AbiC3UA1 (ORCPT ); Wed, 30 Mar 2022 16:00:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56790 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231429AbiC3UAZ (ORCPT ); Wed, 30 Mar 2022 16:00:25 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F89D1DA77; Wed, 30 Mar 2022 12:58:40 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id CFAD1B81E41; Wed, 30 Mar 2022 19:58:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7417EC340EC; Wed, 30 Mar 2022 19:58:36 +0000 (UTC) Date: Wed, 30 Mar 2022 15:58:35 -0400 From: Steven Rostedt To: LKML Cc: Beau Belgrave , Masami Hiramatsu , linux-trace-devel , bpf , Network Development , Mathieu Desnoyers , Alexei Starovoitov , Linus Torvalds Subject: [PATCH v2] tracing: Set user_events to BROKEN Message-ID: <20220330155835.5e1f6669@gandalf.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: "Steven Rostedt (Google)" After being merged, user_events become more visible to a wider audience that have concerns with the current API. It is too late to fix this for this release, but instead of a full revert, just mark it as BROKEN (which prevents it from being selected in make config). Then we can work finding a better API. If that fails, then it will need to be completely reverted. Link: https://lore.kernel.org/all/2059213643.196683.1648499088753.JavaMail.= zimbra@efficios.com/ Signed-off-by: Steven Rostedt (Google) --- Changes since v1: https://lore.kernel.org/all/20220329222514.51af6c07@ganda= lf.local.home/ - Add depends on COMPILE_TEST too (Linus Torvalds) Hopefully, no distro is idiotic enough to enable COMPILE_TEST in their builds to get this feature. kernel/trace/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig index 16a52a71732d..f83d29adb375 100644 --- a/kernel/trace/Kconfig +++ b/kernel/trace/Kconfig @@ -741,6 +741,7 @@ config USER_EVENTS bool "User trace events" select TRACING select DYNAMIC_EVENTS + depends on BROKEN || COMPILE_TEST # API needs to be straighten out help User trace events are user-defined trace events that can be used like an existing kernel trace event. User trace --=20 2.35.1