From nobody Fri Jun 19 20:12:47 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E32EC433FE for ; Tue, 29 Mar 2022 23:25:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240242AbiC2X1c (ORCPT ); Tue, 29 Mar 2022 19:27:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58368 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234124AbiC2X13 (ORCPT ); Tue, 29 Mar 2022 19:27:29 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 6D72818596F for ; Tue, 29 Mar 2022 16:25:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648596344; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=j9WAFWoFaJCbtXRV2bAUg/ZVuSKeu2t11Zs3/Bjgv9o=; b=Rbp2lkNXab7ry0MtLn0Ycc/Wygh/1l75l5pUfJ1vkMGRXYH3Pqe9z2tZMJ7pMnXvVdwLc7 r0w/IyXp2gzDr/JghWNjaFKAgNry15a3egrlsAtixZNyq+l+4bNKmNOYeeZYZ4WdZajcU2 4ywJ5HaWeORTlxktG7L5ilHPFcpn1Cs= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-448-2tIhvgnFOXqarJ00hJy12g-1; Tue, 29 Mar 2022 19:25:43 -0400 X-MC-Unique: 2tIhvgnFOXqarJ00hJy12g-1 Received: by mail-qk1-f198.google.com with SMTP id 207-20020a3703d8000000b0067b14f0844dso11490583qkd.22 for ; Tue, 29 Mar 2022 16:25:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=j9WAFWoFaJCbtXRV2bAUg/ZVuSKeu2t11Zs3/Bjgv9o=; b=FBANm61Xa/uwZzPxxIdyUR+jj51hM2WRMAUOKEKvDkDgmyhFvaBEP+eRAT2ny1ZK/J aKNkQaqPcLO2ycUfpkgs0OB3HsEjNvtz5QrApcBTtKvEGktJAcjBTwPa5FurzorluQLl TkXRMoiX8n1MscgIyZfRajFLYyf2NI3nKmJ0/abOBn1mQDhKZbGUerZnH4Qfuf6UrXl/ DxAGZUiciJvce/uxGBads+q2YeeVfiffhxCRhiHGEt+n8f2uVQuUiTGmSSqINx8O9uz+ oto3ytlqC6dJD63DwdscUqe2GaWx6qog8DVs/nZ4S5bxax8oXCO1li5iqs1+Kf4fg7Mo Jn/A== X-Gm-Message-State: AOAM532bmiQvSDzUg29JlN2WTG5mtwlwlySmmm4dvGsWasnrCskxwSDy C6tT4aHp2OC4RrS6tHdPcIh4M6JbME/hnsBV7jj0GVDSeZWuHOU0nRBd9+iCOT7YKG8m1w1gy0t K3aIyjlCCwdUtKxKb1swO8lrp X-Received: by 2002:a05:620a:68a:b0:67b:3135:a9aa with SMTP id f10-20020a05620a068a00b0067b3135a9aamr22146762qkh.508.1648596342752; Tue, 29 Mar 2022 16:25:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzOKNeFEhOkGB2fAKKllqYm87EkU8WRMQ94OOyRzsSNA2a9eo8RNLBPMCuy0SqxE+nglW//YQ== X-Received: by 2002:a05:620a:68a:b0:67b:3135:a9aa with SMTP id f10-20020a05620a068a00b0067b3135a9aamr22146750qkh.508.1648596342537; Tue, 29 Mar 2022 16:25:42 -0700 (PDT) Received: from localhost.localdomain.com (024-205-208-113.res.spectrum.com. [24.205.208.113]) by smtp.gmail.com with ESMTPSA id f18-20020a05622a105200b002e1eb06ece3sm15856149qte.31.2022.03.29.16.25.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Mar 2022 16:25:42 -0700 (PDT) From: trix@redhat.com To: mchehab@kernel.org, sakari.ailus@linux.intel.com, gregkh@linuxfoundation.org, nathan@kernel.org, ndesaulniers@google.com, hverkuil-cisco@xs4all.nl, vrzh@vrzh.net, laurent.pinchart@ideasonboard.com, tomi.valkeinen@ideasonboard.com Cc: linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Tom Rix Subject: [RESEND PATCH] media: staging: atomisp: rework reading the id and revision values Date: Tue, 29 Mar 2022 16:25:26 -0700 Message-Id: <20220329232526.3238181-1-trix@redhat.com> X-Mailer: git-send-email 2.26.3 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Tom Rix Clang static analysis reports this representative issue atomisp-ov2722.c:920:3: warning: 3rd function call argument is an uninitialized value dev_err(&client->dev, "sensor_id_high =3D 0x%x\n", high); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ high and low are only set when ov2722_read_reg() is successful. Reporting the high value when there is an error is not meaningful. The later read for low is not checked. high and low are or-ed together and checked against a non zero value. Remove the unneeded error reporting for high. Initialize high and low to 0 and use the id check to determine if the reads were successful The later read for revision is not checked. If it fails the old high value will be used and the revision will be misreported. Since the revision is only reported and not checked or stored it is not necessary to return if the read with successful. This makes the ret variable unnecessary so remove it. Signed-off-by: Tom Rix --- .../media/atomisp/i2c/atomisp-ov2722.c | 20 ++++++++----------- 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c b/drivers/s= taging/media/atomisp/i2c/atomisp-ov2722.c index da98094d7094..d5d099ac1b70 100644 --- a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c +++ b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c @@ -906,22 +906,17 @@ static int ov2722_get_fmt(struct v4l2_subdev *sd, static int ov2722_detect(struct i2c_client *client) { struct i2c_adapter *adapter =3D client->adapter; - u16 high, low; - int ret; + u16 high =3D 0, low =3D 0; u16 id; u8 revision; =20 if (!i2c_check_functionality(adapter, I2C_FUNC_I2C)) return -ENODEV; =20 - ret =3D ov2722_read_reg(client, OV2722_8BIT, - OV2722_SC_CMMN_CHIP_ID_H, &high); - if (ret) { - dev_err(&client->dev, "sensor_id_high =3D 0x%x\n", high); - return -ENODEV; - } - ret =3D ov2722_read_reg(client, OV2722_8BIT, - OV2722_SC_CMMN_CHIP_ID_L, &low); + ov2722_read_reg(client, OV2722_8BIT, + OV2722_SC_CMMN_CHIP_ID_H, &high); + ov2722_read_reg(client, OV2722_8BIT, + OV2722_SC_CMMN_CHIP_ID_L, &low); id =3D (high << 8) | low; =20 if ((id !=3D OV2722_ID) && (id !=3D OV2720_ID)) { @@ -929,8 +924,9 @@ static int ov2722_detect(struct i2c_client *client) return -ENODEV; } =20 - ret =3D ov2722_read_reg(client, OV2722_8BIT, - OV2722_SC_CMMN_SUB_ID, &high); + high =3D 0; + ov2722_read_reg(client, OV2722_8BIT, + OV2722_SC_CMMN_SUB_ID, &high); revision =3D (u8)high & 0x0f; =20 dev_dbg(&client->dev, "sensor_revision =3D 0x%x\n", revision); --=20 2.26.3