From nobody Sun Sep 22 06:18:56 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54798C433FE for ; Mon, 28 Mar 2022 12:40:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242597AbiC1MmZ (ORCPT ); Mon, 28 Mar 2022 08:42:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240672AbiC1MmY (ORCPT ); Mon, 28 Mar 2022 08:42:24 -0400 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38D045B3F9; Mon, 28 Mar 2022 05:40:38 -0700 (PDT) X-UUID: 7c04888e22d946a2ab98aa302e160b34-20220328 X-UUID: 7c04888e22d946a2ab98aa302e160b34-20220328 Received: from mtkcas10.mediatek.inc [(172.21.101.39)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 589206584; Mon, 28 Mar 2022 20:40:31 +0800 Received: from mtkexhb02.mediatek.inc (172.21.101.103) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.15; Mon, 28 Mar 2022 20:40:30 +0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkexhb02.mediatek.inc (172.21.101.103) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 28 Mar 2022 20:40:30 +0800 Received: from mbjsdccf07.mediatek.inc (10.15.20.246) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 28 Mar 2022 20:40:29 +0800 From: Xiaobing shi To: Bjorn Andersson , Mathieu Poirier CC: Matthias Brugger , , , , , Xiaobing shi Subject: [PATCH] remoteproc: avoid array index out of bounds in debugfs file Date: Mon, 28 Mar 2022 20:34:13 +0800 Message-ID: <20220328123413.18169-1-xiaobing.shi@mediatek.com> X-Mailer: git-send-email 2.18.0 MIME-Version: 1.0 X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" There is a negative offset of an on-stack array that causes an out of bounds issue when someone called with a zero 'count' argument to syswrite(). buf[count - 1] We should add an extra check in rproc_coredump_write() to prevent the access. Signed-off-by: Xiaobing shi --- drivers/remoteproc/remoteproc_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/remoteproc/remoteproc_debugfs.c b/drivers/remoteproc/r= emoteproc_debugfs.c index b5a1e3b697d9..581930483ef8 100644 --- a/drivers/remoteproc/remoteproc_debugfs.c +++ b/drivers/remoteproc/remoteproc_debugfs.c @@ -76,7 +76,7 @@ static ssize_t rproc_coredump_write(struct file *filp, int ret, err =3D 0; char buf[20]; =20 - if (count > sizeof(buf)) + if (count < 1 || count > sizeof(buf)) return -EINVAL; =20 ret =3D copy_from_user(buf, user_buf, count); --=20 2.18.0