From nobody Sun Sep 22 09:40:31 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3F46C4332F for ; Sun, 27 Mar 2022 22:42:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237213AbiC0WoH (ORCPT ); Sun, 27 Mar 2022 18:44:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237156AbiC0Wn3 (ORCPT ); Sun, 27 Mar 2022 18:43:29 -0400 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9947E50053 for ; Sun, 27 Mar 2022 15:41:34 -0700 (PDT) Received: by mail-wr1-x430.google.com with SMTP id w21so13335778wra.2 for ; Sun, 27 Mar 2022 15:41:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7NGNU1ZiNqnfB/lQpUpav+dtnhshiIc2T9ryINKQuQo=; b=Lupz2AKwXt3lU+g4i75FMBUo3M3tvFIqglxRAW2l5j9vj36rFtIJW9ojWdmzMzfW22 hdYC0CDndjECh8xXNqQ8kZM4JroqW2wzydY3DVeUrWHCGVckPwQ21GnYR3nZLlE18hlN VJSe7dZC+vXxWQIVm1rtPP61j/ztCmXWbN/F9IZynxuKGscE1PWL3/Jc8K2uUPXzzQFk 9wDm5Gx73EormvuZaE+UB9mlgrOlP0IcB1OQ6vp0cgHM9+B2ps87hQgJS2qvJfEF74pO uRdkNNJEf/q7W9/cA43dSXSe8FtDWXYBjT+NByRojaeyG1ZL/aOg/Nu5do00cChWAZdM dnqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7NGNU1ZiNqnfB/lQpUpav+dtnhshiIc2T9ryINKQuQo=; b=h1ApijNmVxyAclI6LQGOVTVfiKYNLifneU2duLAZCJKOHxs437rLOnHuNFknGFeINW EcyzGI77XSEs8VOojOLrf/wzylu1SuE1tAgqXmw9HqGi8ZziyOQicf1LapSu0rElXMvN S6kwTxnGfFaasaKuQc6c/8570FCGDk78mGZ+ZkfQeBGMPsjVuRvxnni1jx5WiR6TIfig x6Bkbs0K4A8KHd3rL4WFO/4iqSqydga/CEvK1PCiOB4j2PttDe2V/nTUIPyX7EaQBZGz g7dnkIdNoWLTbCcR9681YrzyDsJsf5n5OLCQLESK8JrWWMZtrMTg8aAtncn7Y6MY9GX/ aDnw== X-Gm-Message-State: AOAM5337eaqHvknUMNhod0ysLfosvnBpA6IblrfNxVnMICoBQuRO9Ohp Meshc2AX0JvkZ6fpWXIjbkozcw== X-Google-Smtp-Source: ABdhPJwcnG9DzViOemEI6A/3n0FZ2hqv6pzt+OVzBIfHWjl+D3eAUChDldLbEtm4o3XchQpBULrBRw== X-Received: by 2002:adf:c188:0:b0:1e6:8ecb:ea5a with SMTP id x8-20020adfc188000000b001e68ecbea5amr18781563wre.711.1648420892888; Sun, 27 Mar 2022 15:41:32 -0700 (PDT) Received: from localhost.localdomain (2a02-8440-6341-357e-3074-96af-9642-0002.rev.sfr.net. [2a02:8440:6341:357e:3074:96af:9642:2]) by smtp.gmail.com with ESMTPSA id v5-20020adfe4c5000000b001edc1e5053esm10400867wrm.82.2022.03.27.15.41.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Mar 2022 15:41:32 -0700 (PDT) From: Guillaume Ranquet To: airlied@linux.ie, angelogioacchino.delregno@collabora.com, chunfeng.yun@mediatek.com, chunkuang.hu@kernel.org, ck.hu@mediatek.com, daniel@ffwll.ch, deller@gmx.de, jitao.shi@mediatek.com, kishon@ti.com, krzk+dt@kernel.org, maarten.lankhorst@linux.intel.com, matthias.bgg@gmail.com, mripard@kernel.org, p.zabel@pengutronix.de, robh+dt@kernel.org, tzimmermann@suse.de, vkoul@kernel.org Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, markyacoub@google.com, Rex-BC Chen Subject: [PATCH v9 20/22] drm/mediatek: add hpd debounce Date: Mon, 28 Mar 2022 00:39:25 +0200 Message-Id: <20220327223927.20848-21-granquet@baylibre.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220327223927.20848-1-granquet@baylibre.com> References: <20220327223927.20848-1-granquet@baylibre.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Jitao Shi From the DP spec 1.4a chapter 3.3, upstream devices should implement HPD signal de-bouncing on an external connection. A period of 100ms should be used to detect an HPD connect event. To cover these cases, HPD de-bounce should be implemented only after HPD low has been detected for at least 100ms. Therefore, 1. If HPD is low (which means plugging out) for longer than 100ms: we need to do de-bouncing (which means we need to wait for 100ms). 2. If HPD low is for less than 100ms: we don't need to care about the de-bouncing. In this patch, we start a 100ms timer and use a need_debounce boolean to implement the feature. Two cases when HPD is high: 1. If the timer is expired (>100ms): - need_debounce is true. - When HPD high (plugging event comes), need_debounce will be true and then we need to do de-bouncing (wait for 100ms). 2. If the timer is not expired (<100ms): - need_debounce is false. - When HPD high (plugging event comes), need_debounce will be false and no need to do de-bouncing. HPD_______ __________________ | |<- 100ms -> |____________| <- 100ms -> Without HPD de-bouncing, USB-C to HDMI Adapaters will not be detected. The change has been successfully tested with the following devices: - Dell Adapter - USB-C to HDMI - Acer 1in1 HDMI dongle - Ugreen 1in1 HDMI dongle - innowatt HDMI + USB3 hub - Acer 2in1 HDMI dongle - Apple 3in1 HDMI dongle (A2119) - J5Create 3in1 HDMI dongle (JAC379) Tested-by: Rex-BC Chen Reviewed-by: Rex-BC Chen Signed-off-by: Jitao Shi Signed-off-by: Guillaume Ranquet --- drivers/gpu/drm/mediatek/mtk_dp.c | 46 +++++++++++++++++++++++++++++++ 1 file changed, 46 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_dp.c b/drivers/gpu/drm/mediatek/m= tk_dp.c index 9e532408f12e..e099491cc6a4 100644 --- a/drivers/gpu/drm/mediatek/mtk_dp.c +++ b/drivers/gpu/drm/mediatek/mtk_dp.c @@ -174,6 +174,33 @@ struct mtk_dp { struct device *codec_dev; u8 connector_eld[MAX_ELD_BYTES]; struct drm_connector *conn; + bool need_debounce; + struct timer_list debounce_timer; +}; + +enum mtk_dp_sdp_type { + MTK_DP_SDP_NONE =3D 0x00, + MTK_DP_SDP_ACM =3D 0x01, + MTK_DP_SDP_ISRC =3D 0x02, + MTK_DP_SDP_AVI =3D 0x03, + MTK_DP_SDP_AUI =3D 0x04, + MTK_DP_SDP_SPD =3D 0x05, + MTK_DP_SDP_MPEG =3D 0x06, + MTK_DP_SDP_NTSC =3D 0x07, + MTK_DP_SDP_VSP =3D 0x08, + MTK_DP_SDP_VSC =3D 0x09, + MTK_DP_SDP_EXT =3D 0x0A, + MTK_DP_SDP_PPS0 =3D 0x0B, + MTK_DP_SDP_PPS1 =3D 0x0C, + MTK_DP_SDP_PPS2 =3D 0x0D, + MTK_DP_SDP_PPS3 =3D 0x0E, + MTK_DP_SDP_DRM =3D 0x10, + MTK_DP_SDP_MAX_NUM +}; + +struct mtk_dp_sdp_packet { + enum mtk_dp_sdp_type type; + struct dp_sdp sdp; }; =20 static bool mtk_dp_is_edp(struct mtk_dp *mtk_dp) @@ -1812,6 +1839,9 @@ static irqreturn_t mtk_dp_hpd_event_thread(int hpd, v= oid *dev) if (event < 0) return IRQ_HANDLED; =20 + if (mtk_dp->need_debounce && mtk_dp->train_info.cable_plugged_in) + msleep(100); + if (mtk_dp->drm_dev) { dev_info(mtk_dp->dev, "drm_helper_hpd_irq_event\n"); drm_helper_hpd_irq_event(mtk_dp->bridge.dev); @@ -1890,6 +1920,11 @@ static irqreturn_t mtk_dp_hpd_isr_handler(struct mtk= _dp *mtk_dp) } train_info->cable_state_change =3D true; =20 + if (!train_info->cable_plugged_in) { + mod_timer(&mtk_dp->debounce_timer, jiffies + msecs_to_jiffies(100) - 1); + mtk_dp->need_debounce =3D false; + } + return IRQ_WAKE_THREAD; } =20 @@ -2337,6 +2372,13 @@ static const struct drm_bridge_funcs mtk_dp_bridge_f= uncs =3D { .detect =3D mtk_dp_bdg_detect, }; =20 +static void mtk_dp_debounce_timer(struct timer_list *t) +{ + struct mtk_dp *mtk_dp =3D from_timer(mtk_dp, t, debounce_timer); + + mtk_dp->need_debounce =3D true; +} + static int mtk_dp_probe(struct platform_device *pdev) { struct mtk_dp *mtk_dp; @@ -2394,6 +2436,9 @@ static int mtk_dp_probe(struct platform_device *pdev) mtk_dp->bridge.of_node =3D dev->of_node; mtk_dp->bridge.type =3D DRM_MODE_CONNECTOR_eDP; =20 + mtk_dp->need_debounce =3D true; + timer_setup(&mtk_dp->debounce_timer, mtk_dp_debounce_timer, 0); + mtk_dp->bridge.ops =3D DRM_BRIDGE_OP_DETECT | DRM_BRIDGE_OP_EDID | DRM_BRIDGE_OP_HPD; drm_bridge_add(&mtk_dp->bridge); @@ -2413,6 +2458,7 @@ static int mtk_dp_remove(struct platform_device *pdev) struct mtk_dp *mtk_dp =3D platform_get_drvdata(pdev); =20 mtk_dp_video_mute(mtk_dp, true); + del_timer_sync(&mtk_dp->debounce_timer); =20 pm_runtime_disable(&pdev->dev); =20 --=20 2.34.1