From nobody Sat Jun 20 00:54:36 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3BF2C433F5 for ; Sat, 26 Mar 2022 19:42:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234793AbiCZToZ (ORCPT ); Sat, 26 Mar 2022 15:44:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232537AbiCZToW (ORCPT ); Sat, 26 Mar 2022 15:44:22 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 7821918C0FD for ; Sat, 26 Mar 2022 12:42:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648323764; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=azqELzyuB9oAQJF0V0iHBM8V3/Uqnp5/jPCm+apduZM=; b=DoEtQKvtRqfqncKmnTegJCp7piAr03r8WqWHFkQFGKHNiFmK5vkN9xq7PZBUIgPUwK9xUB PJdk+TdIr3JuwkIb7ogtGNLnqCGP80zxIIACpJQv9I3Q3UgXqeFcIKJLQADHLstBCkTURm juKDVd5aujnMfivzIkecL8sJgNAEUlA= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-116-WtXfQMbdN3q8AGPxUVelrA-1; Sat, 26 Mar 2022 15:42:43 -0400 X-MC-Unique: WtXfQMbdN3q8AGPxUVelrA-1 Received: by mail-qv1-f71.google.com with SMTP id s14-20020ad4446e000000b00440d3810126so8375866qvt.5 for ; Sat, 26 Mar 2022 12:42:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=azqELzyuB9oAQJF0V0iHBM8V3/Uqnp5/jPCm+apduZM=; b=478KUsXBziy0Eh5mXZaB2mWTZ8UpFqDRR37eU17ZhLXYFh5vSawIZSY2d65qfI83xI /BQqRLv7duq2XUfEMshdEkVMZxFrGWNloZUIL85DQ1nzeSPjARA5q9X1YTev6Tw/EC3d kOrgR6ENIo5nJqy98iPcHrDAAvy5fyVqMME1DgNYJ+Cp3n7noM7l+d55sn/CbDxIqMyN dx0I2lbKWxrThs0MUMy/OXBeLH9jYkLm0gGdtTHbwvogYh1zMS84UYK4xDrMxB8t3fum IphtCVxZAja0UF7G+z2GJTHt4MW1J9y7FZpIeOiLb4NKmOvq2sHPJx7ZPLPrM/raOGcN ca5g== X-Gm-Message-State: AOAM533OrrXOKKA3NBZ/mt0rD5RCYD6fLiFgnYdToXu/Id9fdlYZd+dm NgYYyBoFXn43TmtlLzEb4gJAIKJcDaLMwP/GdJAqa2SAx7tlkSBg3srYYDopIodEgpi0gQeUdA8 Lq25lXkWZJZw+36W1w8KaQ4fz X-Received: by 2002:a05:622a:2d5:b0:2e1:ea60:231 with SMTP id a21-20020a05622a02d500b002e1ea600231mr14957963qtx.460.1648323762249; Sat, 26 Mar 2022 12:42:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwiZjr3dpr/uR4Z7rNTTcx8g6KNr+3tArsL6c+HPu5J7FXrCb3tFzBBP0gPo+UTDziqlHWPdA== X-Received: by 2002:a05:622a:2d5:b0:2e1:ea60:231 with SMTP id a21-20020a05622a02d500b002e1ea600231mr14957948qtx.460.1648323762064; Sat, 26 Mar 2022 12:42:42 -0700 (PDT) Received: from localhost.localdomain.com (024-205-208-113.res.spectrum.com. [24.205.208.113]) by smtp.gmail.com with ESMTPSA id x19-20020a05622a001300b002e1e78062e3sm7741250qtw.84.2022.03.26.12.42.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Mar 2022 12:42:41 -0700 (PDT) From: trix@redhat.com To: a.zummo@towertech.it, alexandre.belloni@bootlin.com, nathan@kernel.org, ndesaulniers@google.com, colin.king@intel.com Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Tom Rix Subject: [PATCH] rtc: check if __rtc_read_time was successful Date: Sat, 26 Mar 2022 12:42:36 -0700 Message-Id: <20220326194236.2916310-1-trix@redhat.com> X-Mailer: git-send-email 2.26.3 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Tom Rix Clang static analysis reports this issue interface.c:810:8: warning: Passed-by-value struct argument contains uninitialized data now =3D rtc_tm_to_ktime(tm); ^~~~~~~~~~~~~~~~~~~ tm is set by a successful call to __rtc_read_time() but its return status is not checked. Check if it was successful before setting the enabled flag. Move the decl of err to function scope. Fixes: 2b2f5ff00f63 ("rtc: interface: ignore expired timers when enqueuing = new timers") Signed-off-by: Tom Rix --- drivers/rtc/interface.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/interface.c b/drivers/rtc/interface.c index d8e8357981537..9edd662c69ace 100644 --- a/drivers/rtc/interface.c +++ b/drivers/rtc/interface.c @@ -804,9 +804,13 @@ static int rtc_timer_enqueue(struct rtc_device *rtc, s= truct rtc_timer *timer) struct timerqueue_node *next =3D timerqueue_getnext(&rtc->timerqueue); struct rtc_time tm; ktime_t now; + int err; + + err =3D __rtc_read_time(rtc, &tm); + if (err) + return err; =20 timer->enabled =3D 1; - __rtc_read_time(rtc, &tm); now =3D rtc_tm_to_ktime(tm); =20 /* Skip over expired timers */ @@ -820,7 +824,6 @@ static int rtc_timer_enqueue(struct rtc_device *rtc, st= ruct rtc_timer *timer) trace_rtc_timer_enqueue(timer); if (!next || ktime_before(timer->node.expires, next->expires)) { struct rtc_wkalrm alarm; - int err; =20 alarm.time =3D rtc_ktime_to_tm(timer->node.expires); alarm.enabled =3D 1; --=20 2.26.3